From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13C39C433F5 for ; Wed, 15 Dec 2021 13:40:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 99A376B0071; Wed, 15 Dec 2021 08:40:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 921BE6B0073; Wed, 15 Dec 2021 08:40:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7C3D26B0074; Wed, 15 Dec 2021 08:40:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay025.a.hostedemail.com [64.99.140.25]) by kanga.kvack.org (Postfix) with ESMTP id 681DF6B0071 for ; Wed, 15 Dec 2021 08:40:07 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id 2664E1204BC for ; Wed, 15 Dec 2021 13:39:57 +0000 (UTC) X-FDA: 78920136834.04.D4AFD7A Received: from mail-oi1-f181.google.com (mail-oi1-f181.google.com [209.85.167.181]) by imf29.hostedemail.com (Postfix) with ESMTP id D239E120010 for ; Wed, 15 Dec 2021 13:39:54 +0000 (UTC) Received: by mail-oi1-f181.google.com with SMTP id q25so31799674oiw.0 for ; Wed, 15 Dec 2021 05:39:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=svxJfpg8jVkgXyVh9JGM5x7NaruneFPKWdsMZ9I2EiM=; b=cW48MB1IB1kQpbYVyCknBwpS9l45TSlBP232cQZlBNbg0Oh/muiXq1JbSQd9YzyZ9x sEdSY8Skr56faZwMXNEGPTHE5DYshbrQK2hGDxgM6aPhEkH+vs6UogoypduPjNmpUuWk wSvaTW382XrL8HAG6KIO/gdtAAXH8y+JFo2rFJNitbfitqVzD/ZSI1LJJ6cV/YM5g6JP xohPNT5dp8pKC3ltpmh+t/fUdk4tob6DUCN5ipiEsaSKCxkKyBubjnVDfe7wMuKTZEBh hgjTzyiLpGuvkbayjjX7UvP4rZ/O02ME50j5ZDJAQZ4A//7KIhjUh7jFDBNOJ0v1RIcl KIww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=svxJfpg8jVkgXyVh9JGM5x7NaruneFPKWdsMZ9I2EiM=; b=S77ucDUmow7m37QGNLcAOT3qZs3r7PGnllCZrp8pSw9wl8O/RDuamkIJ0TW9Afo8L/ fXzhnZKgeqclIECo3tOD+Z3hYqrSAbAMfrtIeTMFnEJoDemxoqIfsj/Jgm/OGVJ8Hrf8 aGOa+IF2kPU7gzUZIEnQTPCdHp+inMHLP1CW/Gv8t6uwJLTWB9Sk+PuQ8ohBOtHGb8H6 DpYrpzg40tjdGJpIqW9VOhEnM1PougTI3xq5/CFPb3W/k0Lqo6MTGg+47IqWmFCLmjs2 L0CTb/pnInvfSzUgfRDz2AyEel/YSZp64xPhqFgzL7qnxniFNrJCLVLKeFV1m1Iqzqb0 rylQ== X-Gm-Message-State: AOAM530tKhj8xnHJGzm4RAEFpL6OhsD0KdBLxiHZQq3pApjkJoCywaKu tGfdxQMDufktdVqdAyDeDX91Jg8cvT6LYXZ18wvXNA== X-Google-Smtp-Source: ABdhPJyhw9fV+5iWAXiiH/X/hxiW9UIqmhsUKwKcvZOrbUGfo1qIcn4wox0DtfrBc4ECp+n6hw3bCuswYLT11Fn+PL4= X-Received: by 2002:a05:6808:118c:: with SMTP id j12mr8618083oil.65.1639575595612; Wed, 15 Dec 2021 05:39:55 -0800 (PST) MIME-Version: 1.0 References: <20211214162050.660953-1-glider@google.com> <20211214162050.660953-13-glider@google.com> In-Reply-To: From: Marco Elver Date: Wed, 15 Dec 2021 14:39:43 +0100 Message-ID: Subject: Re: [PATCH 12/43] kcsan: clang: retire CONFIG_KCSAN_KCOV_BROKEN To: Mark Rutland Cc: Alexander Potapenko , Alexander Viro , Andrew Morton , Andrey Konovalov , Andy Lutomirski , Ard Biesheuvel , Arnd Bergmann , Borislav Petkov , Christoph Hellwig , Christoph Lameter , David Rientjes , Dmitry Vyukov , Eric Dumazet , Greg Kroah-Hartman , Herbert Xu , Ilya Leoshkevich , Ingo Molnar , Jens Axboe , Joonsoo Kim , Kees Cook , Matthew Wilcox , "Michael S. Tsirkin" , Pekka Enberg , Peter Zijlstra , Petr Mladek , Steven Rostedt , Thomas Gleixner , Vasily Gorbik , Vegard Nossum , Vlastimil Babka , linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=cW48MB1I; spf=pass (imf29.hostedemail.com: domain of elver@google.com designates 209.85.167.181 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspamd-Queue-Id: D239E120010 X-Stat-Signature: k7keauo946rra5m8sd1xcra86ze3hgqb X-Rspamd-Server: rspam04 X-HE-Tag: 1639575594-686872 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 15 Dec 2021 at 14:33, Mark Rutland wrote: > > On Tue, Dec 14, 2021 at 05:20:19PM +0100, Alexander Potapenko wrote: > > kcov used to be broken prior to Clang 11, but right now that version is > > already the minimum required to build with KCSAN, that is why we don't > > need KCSAN_KCOV_BROKEN anymore. > > Just to check, how is that requirement enforced? HAVE_KCSAN_COMPILER will only be true with Clang 11 or later, due to no prior compiler having "-tsan-distinguish-volatile=1". > I see the core Makefiles enforce 10.0.1+, but I couldn't spot an explicit > version dependency in Kconfig.kcsan. > > Otherwise, this looks good to me! I think 5.17 will be Clang 11 only, so we could actually revert ea91a1d45d19469001a4955583187b0d75915759: https://lkml.kernel.org/r/Yao86FeC2ybOobLO@archlinux-ax161 I should resend that to be added to the -kbuild tree.