From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0875EB64DA for ; Wed, 19 Jul 2023 15:09:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DDB93280069; Wed, 19 Jul 2023 11:09:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D8B1428004C; Wed, 19 Jul 2023 11:09:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C53AD280069; Wed, 19 Jul 2023 11:09:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B1CCA28004C for ; Wed, 19 Jul 2023 11:09:24 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 7C418C03CE for ; Wed, 19 Jul 2023 15:09:24 +0000 (UTC) X-FDA: 81028695048.28.8F36CA5 Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) by imf13.hostedemail.com (Postfix) with ESMTP id 33C8C201C3 for ; Wed, 19 Jul 2023 15:08:46 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=k6Dzz3u+; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf13.hostedemail.com: domain of elver@google.com designates 209.85.167.43 as permitted sender) smtp.mailfrom=elver@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689779327; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MFOc8wXCTX40R5n/QN5jnRi3zJ4EfVz1XUBftc9gujI=; b=YxjZmj21ExPKDIdsSPXWvXQ3uNd79EsP2sPwGHurACJsNAdA7s4c8Z+patNOSQ1wRAKTZx 9vVvjdgLEX8Oo+KEotZMz+0wZkzR35Vqnv1SIr8PnSn/6eePwAtBCg+/WYCufJFUn+KPMB pA3exsqYA+mFIDeFtQ5disidWZI5vBo= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=k6Dzz3u+; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf13.hostedemail.com: domain of elver@google.com designates 209.85.167.43 as permitted sender) smtp.mailfrom=elver@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689779327; a=rsa-sha256; cv=none; b=W0FiyJR4NkXSSlTrwr9uuVytap56uRO5unfKE93cYd06WzBO4/0b3oK/RRnVSkORmeRmgp Abp2PYOQ1q/4kFMUjaoJ1WKkWMX3MsFQISgZe2rcadKGpx4vbMlsRKY3++aPIwfvqoVC8h Eu/9qYyQBYBniXLZQ71k0PaKjUqVS7g= Received: by mail-lf1-f43.google.com with SMTP id 2adb3069b0e04-4f4b2bc1565so11840892e87.2 for ; Wed, 19 Jul 2023 08:08:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1689779325; x=1692371325; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=MFOc8wXCTX40R5n/QN5jnRi3zJ4EfVz1XUBftc9gujI=; b=k6Dzz3u+unngYvZlWXAMg/7wjM26zDJELKmq670GNyLD9qen7N5jRuhLbPJWEd8v9k wwbzSB++iejuKh2vEbBqh23UjTRMtyFfzZNzBKxizoQOAN/7rUzllO9jfx6hpm9i2LuN 9Q9Zph02XUxM+I6sy6fr7B0APwQ+FChwvqo+keI3xRxme5ol7xrRvx94cT5Kw6/sUh1N jR9f3NhPZ2LVxT0+063M+J5XrsUGkgmlkE4UoxkbrCqDuEUzhYxRjFv4M07iQOLRcZ7G NHP4vPu97B6hRzYa7RHx+CkPKzzmgTgN+6hwkuYOGYsuh/Ah3YBOL8UHxTVTWGQ5GZx1 xOiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689779325; x=1692371325; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MFOc8wXCTX40R5n/QN5jnRi3zJ4EfVz1XUBftc9gujI=; b=Uz+uKd4Ek2kO+4jObBkP/a6x3s2WKzDh9pfCOdWJh5hejJiuHjYZSaGseristckbDW gUGteZJ3KP2eH7T6uRJjFdsH9y3mrQIE3XVuugDOwcG/azLYonwnHKL29FfnWwWZgXAF KgLOW7EPKC0B4g3v6PO7AyIo1qP+dwS9yVDNMgZ1zawdBP5PK1lbcjzzJAAq4mpDoRiD tXha5abTKFM0BFYcORFWQcWwL0j2Xq0z8RCoKeKl0tbn0Fq/XoBslqrEHu18srvNSlks LcBcz+LIUS8LJZumxKG2Pm00TPw2xKQU1pdxRzAgYWc/DVUEpa5QM705q3ZCNbvTBzvD EesA== X-Gm-Message-State: ABy/qLYz5oxxOaRj8Vg+U0flTxwqec6+9j3+M+CUX9PClc/3qVp2vawv wEsqRkJaVDZaLogOl2+pdw7Ij1y7YbmUmSDoasdbSw== X-Google-Smtp-Source: APBJJlE8s+M855VZ6L+2ujTJXYs8tsRjy3wtCPDGaQRCXcBrm84s52ygjnsO9ygWffOOJq7iw34bVREN1ZqhcJhPm2A= X-Received: by 2002:a19:5f1e:0:b0:4fb:77d6:89c3 with SMTP id t30-20020a195f1e000000b004fb77d689c3mr134036lfb.12.1689779324718; Wed, 19 Jul 2023 08:08:44 -0700 (PDT) MIME-Version: 1.0 References: <20230719082732.2189747-1-lienze@kylinos.cn> <20230719082732.2189747-4-lienze@kylinos.cn> In-Reply-To: From: Marco Elver Date: Wed, 19 Jul 2023 17:08:07 +0200 Message-ID: Subject: Re: [PATCH 3/4] KFENCE: Deferring the assignment of the local variable addr To: Huacai Chen Cc: Enze Li , kernel@xen0n.name, loongarch@lists.linux.dev, glider@google.com, akpm@linux-foundation.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, zhangqing@loongson.cn, yangtiezhu@loongson.cn, dvyukov@google.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 33C8C201C3 X-Stat-Signature: qaonhqt5zaib73yqsr4t19o5j3cpqmt6 X-Rspam-User: X-HE-Tag: 1689779326-465033 X-HE-Meta: U2FsdGVkX186fFQL9vv7gxqYyfPFyciiC5sarGlZ50NCSQq2kvijFDK0fmnBvzXpUqBO7PhOAF7jfT8+4MKmv9ZRNzWdi57W15lZD2gelOP59Hz406zuyx07G6CY39p7pQ4fcS5oIg+x9q9nP0NVOyb/dTun0mHOCPtdJYPh0E+MpUwKl1up/JO3byRbWAhIM03ZFd1KUAXiXJG8GY0YaYbv50Ev+UPq4/psRlKpFuJsxf0TTboDpNQBWje8zJS1k8RyeALMIEBBlUN5wJHhhGuOXeZL2iIW+k0EtCGrxRoshVf4YYUDjMJk/Upzui82uAB6+rZh/ao4WkumsrH64WJ2QhnubdCCIDrxob0tQZcfmnbc8Hymxam0ngPk2+TNHg5uZhPJ4ySBcTYNz7oQUyqYAipk0aBD3DngubO7XA+eQPojSBPzzlKXIN5OzB4ajIpvtJ9Iz61nugJhzKjUWGfpKww8F8MiHas2NtvWEpN/1PdmmctLcNCF5tAVxyBIrhvT8QKqKH9/C0VEI/AAUEC1JiqXpjSE4r8MnLFP5ymhMIuJkVaivCygru5bwKZDeUIUWhlBa6uvBlNQUktGFjzlZNlZGEKEk19xyK1aUwRzlMbObgv26YK0rc2Hvj+hyCz/JuwBCPmddjxXNYnnMB+0elTfFJ1Um/x7ej72JuoUJQtuLA1eBazyLBVEz83W1P9EKMirk9A6rRyvXjJT9XAGNeJqux7utbqOGN4IEl4ZMSy6C8CzAHZDL/n3izSzHVwUGqQxz1XLcE6Kk3MIKPYeGPAGmkMIJ369egMzYL3dFRyVtZCAwC/DBRKr2oZN2JIexMejvV7WRKdJ7ez0aFG8R2Jx4uoKolkmRRQiF+gaQxApnTemcNw1guYzxmof2JhFqEo1OjHu6RYm4NNmbtN2MAzyPSGbJlgRotoCg2ZODsq7BP/xlMWeGhCBqb2rCWFpoH0xr3SPbvOHHhY wxi093Vl Hbky/UdEdfcbh3iG4An9TBkqkkutlPsiNpfx1045zoEhFOE2UcOQKXy7ewRHrxIVX9UAnVzlymM3jIQDhJZNv7doi3ZxV9kA260GeAkAtqKhD1xGmwDyp4Z7yTSNI3nAvwqTy6mkLbyl8txmQMChgUYhzfIouAed/t48z7U/vOZ0SXExJG8v75rZ0Y6l6pWhKqQZ3j6edjXDmBXl5LXwmI5H7WeB1kxndfqD7w1cubKbLL6NuRgS2Mm3FH9SYlUr1cOla9yyAV7cAzAQfU9i0W1znWf9vTrUJprAm7vPEjobgeNUzV6QC6VwFfQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 19 Jul 2023 at 17:06, Huacai Chen wrote: > > Hi, Marco, > > On Wed, Jul 19, 2023 at 6:55=E2=80=AFPM Marco Elver wr= ote: > > > > On Wed, 19 Jul 2023 at 10:28, Enze Li wrote: > > > > > > The LoongArch architecture is different from other architectures. > > > It needs to update __kfence_pool during arch_kfence_init_pool. > > > > > > This patch modifies the assignment location of the local variable add= r > > > in the kfence_init_pool function to support the case of updating > > > __kfence_pool in arch_kfence_init_pool. > > > > > > Signed-off-by: Enze Li > > > > I think it's fair to allow this use case. > > > > However, please make sure that when your arch_kfence_init_pool() > > fails, it is still possible to free the memblock allocated memory > > properly. > > > > Acked-by: Marco Elver > Does Acked-by means this patch can go through loongarch tree together > with other patches? If this patch should go through kfence tree, then > the others should wait for some time. It can go through loongarch tree. I don't think there are conflicts with -mm around the patch's location right now. Thanks, -- Marco