From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DC12D2E018 for ; Wed, 23 Oct 2024 06:57:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 84CFB6B0083; Wed, 23 Oct 2024 02:57:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7FB546B0085; Wed, 23 Oct 2024 02:57:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6E9446B0088; Wed, 23 Oct 2024 02:57:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 507516B0083 for ; Wed, 23 Oct 2024 02:57:45 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 3C26F1C4CED for ; Wed, 23 Oct 2024 06:57:25 +0000 (UTC) X-FDA: 82703960850.03.3AFDC0B Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) by imf20.hostedemail.com (Postfix) with ESMTP id 47F221C0009 for ; Wed, 23 Oct 2024 06:57:22 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=3d+Wyqwm; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf20.hostedemail.com: domain of elver@google.com designates 209.85.216.47 as permitted sender) smtp.mailfrom=elver@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729666551; a=rsa-sha256; cv=none; b=GrU2K7KzitMN6TrMxFA6171802ESTAkSWuLxIdwBQSfBb07VJqiVxig8+usV5x2BmPZzVL BUSE8GTh0txsgbeUuHBE+hxe39BzKb53OvbwV+vR69uQiZ+gyZmP8FJpfzaeLB51eK0fWr kpiZNgLp4VuRwxLpqgJROpKoxHn6UOc= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=3d+Wyqwm; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf20.hostedemail.com: domain of elver@google.com designates 209.85.216.47 as permitted sender) smtp.mailfrom=elver@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729666551; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aGURbA/qHkuvhmvaDTB3AAE8n+iTpH3OvqTtBmFgU3k=; b=oNj6b9RVbDXrx150ysakI9ZZGkioyDE56mrdHtL/09WLP9iKQaaB4K3y2eg9pFqN4M0eXI cOnjVRsvOFHYq3awH1WFqG79Hs5KWZ/TxoA2O7FcyJJ6IfHFV6A+wy4RDYBhYnzvgJ+MGL 8y5Dbhkj4dmc5sBu2/LzUC9hPAhroNk= Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-2e2eba31d3aso4304061a91.2 for ; Tue, 22 Oct 2024 23:57:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1729666662; x=1730271462; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=aGURbA/qHkuvhmvaDTB3AAE8n+iTpH3OvqTtBmFgU3k=; b=3d+WyqwmLMN0rYXn/gqZVZmtKMvW51aWU+AL6hrDQzZveSX/ZaQ/X+Cab/LrJThuO6 BwZnFnsVHswt7RIl6KF86+ITElS+alGmqfzpPaXR52EWIizjh4Ls0vqOGf2tEK2kfxcj /KIspmtkKjjiFwX1FLXo3csTTbJQbkW+SP4sMIT1ldBckxi5FffV8tLn2dGvwASFsEO8 vhdk5cCy4l58h529FooUp2Cdt0qvLVUowU02XTUTForfj2EYtqERxnhXTy4DmfF9detT mkyPLdBhBFa70CuLgHhs77IDOayZMukGwKfFQc7hjL2S7xh8EEFfOW5e3TcNIMWmELJV oRkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729666662; x=1730271462; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=aGURbA/qHkuvhmvaDTB3AAE8n+iTpH3OvqTtBmFgU3k=; b=SGDm8X2MCxv2bITzCv9t9a+4i4jmyc3H3ZZGlCFBCIWUU6vbrBZ/XquSdV7SUXbkCy IkwRoB88bL6FhY8z205RmBE0kq4YmZvpl/ufjFe6mBx0Ol03kpfOv077gbsEoFA8u6wX 17EclGVD0Ei43kdQZ0mugkVaIiuHc8pRde3ytFJAUBDQnajJzqa/7uYB+orU2EoSIVL+ J7pqjWU26e9M/n9l7QJUn5OWXIYHzUI8zCP2Qz7SF65bm4Y59CAiDbY3MwNSRiHFjDsP tImfVvWLAQIsp/aT+egtQl51fsDWmhNpwYFs4Uyi92BQS3Ym3s/lE0FACZGTNCMsNsUH v0DQ== X-Forwarded-Encrypted: i=1; AJvYcCWTtKsnC7qwQ7AOZTeObJlfrPAx0v1IiUbDbD/Jb3F/am+71CojLWhKEymSD1xSY/Mwp+AdJwX1ww==@kvack.org X-Gm-Message-State: AOJu0Yx4lrCSHXngY5CtUC1PcoWdK2eio2daiRNEAuxeTwkX2czsqCm4 Mtr6yDp65YujCjbg2olHR5OE4kfN4lT3rByHcumabxIp0Uc4nhbw/xVdHnGPYnY7eJOad108BL6 gpiiMC6spZ6f8+5fMKgeROlB1U/ByYRjzaWLY X-Google-Smtp-Source: AGHT+IEzIW4l3r51CWrL2LlpC9+Sdi5XdftU6GzooFfvIKhQDmOMb9aLs1JszBM7B3/dz4fbLSbHNrQjjSmV7B/tDBw= X-Received: by 2002:a17:90a:1149:b0:2e2:c406:ec8d with SMTP id 98e67ed59e1d1-2e76b6f1543mr1537207a91.31.1729666661435; Tue, 22 Oct 2024 23:57:41 -0700 (PDT) MIME-Version: 1.0 References: <20241018151112.3533820-1-arnd@kernel.org> In-Reply-To: From: Marco Elver Date: Wed, 23 Oct 2024 08:57:02 +0200 Message-ID: Subject: Re: [PATCH] mm: export copy_to_kernel_nofault To: Christoph Hellwig Cc: Arnd Bergmann , Andrew Morton , Sabyrzhan Tasbolatov , Andrey Konovalov , Arnd Bergmann , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 47F221C0009 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: jkha7gwt9zw6s8ggzq7nj6am51ezybkc X-HE-Tag: 1729666642-491704 X-HE-Meta: U2FsdGVkX1+g/rxqQA9aNsqbc4klpFqzLXwIX3d+0rOQXTHuzvtzAW1B6iTWnTf+NBG7dEuzFgEM+HbnM/o7FguNPuMaqFdtoM96uZxaAyiHgDGF7IryaknK7XJ1dnKIR5olKJiA8vh5AQrf0/73LlX71MZlH594LJqGQXHESSizctqa23A+opxuhv9vkq9k8JKZmO3MqGphlTacqE1l/IqFyD5rnn+w2qvDpXBCrft5h+Y1i1TG4TRheOqqbls9o8qhOPeoPu9SxbOt4RlpJWpEuikQ7Q1YwAsJQOJaDAB2ymRxgCmjbZDeg76i7COlUIz0fVriq6EyIhz2ob6e9z4WvX2zRYo16i9Fmm2WTlJGsuJtFkvdMxwGAp6DLq1ItFgbAIcf0gCP7bsKAZdI/86faZsNZcFJSDyBAZfX6muPZH3WPxX3lJliI0ezE/ZnfJFtlcns+hWMBeKC+yKWsbYnPcWcbD/1EeAi+JOzViwanqvk1iYiu0dhg7AkAaJDi6wIPoIa/C0bzzZ6vmTD89NkE/hPa5bV4Y9ifTC4VGFw1DzpmQfJNzzKHp4xTZE9KpibMr1KvmqwMd/XUN6LZ/Ezr9/WoPGyNbbS6rY+KLK5dx+qkaxOlgyMDw45lQSkfXUe7M8ViL9BffeFjD5fFPQPfJ5JJBGWVN5crIeNoiAVoMVxuzspfnxpoVFMyyNi0xw03sKFiMIN4we0ilHuaCU+I1fnfZOzvOQxhQZM3bz9QWenwk9cr4mbEPgRNcEPwhSJlQsgdQ41snz+2RA8rjnid0PvucdTb4gXebxllVuRAnx20/iFRNvui34gp+AeNsKtQlR/4qbRhPhKfyO+lTxZ65DqXe7hbEJuAnj8oUezVKrtS3Lk86jgkZpY2PjaUxkY7nINvqDaogWmovYJBchXJ55TGQwNKPjDA4QpkQlR+/T+KLyHUof4X2nA56/K3xOQjmkmp74gqXch1wI MNaI72ik ncTPAwc45k8ZhAoOk7TQ4LJlv53pv2i9gy1a6Pj4RLqW7fQIygd47AtC+bEKTRgvx9nKjMeiAIsg12pI5FnDgeC746JIiv3GIwGPK/XGLifN3Pd7v7u7PkI6szbAGtTWL6h6G+Y773Bb2UJ7/6huadZR+eKJRvAfxrB3NcltL7U15sSv+EIeMR6sA94QqbKDjlXzs1lprrjtjIrJulzZQ8UgYOmYKpYSxwun1nyxAjzJYo0AhwGCE/hxtLNNUy+zkb67ZI/rQEwrE71A1yJrvGyyQCxoispSs2jo5KHyUPlc1/N8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 23 Oct 2024 at 08:53, Christoph Hellwig wrote: > > On Fri, Oct 18, 2024 at 03:11:09PM +0000, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > This symbol is now used on the kasan test module, so it needs to be > > exported. > > > > ERROR: modpost: "copy_to_kernel_nofault" [mm/kasan/kasan_test.ko] undefined! > > Meh, it would be great not to export internal helpers just because > someone wants to test them. Please just mark that test built-in only > instead. We have EXPORT_SYMBOL_IF_KUNIT. See include/kunit/visibility.h - that's more appropriate, and also adjust kasan_test.c to do MODULE_IMPORT_NS(EXPORTED_FOR_KUNIT_TESTING).