From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2142DC48BF6 for ; Mon, 26 Feb 2024 10:03:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B10A76B00F2; Mon, 26 Feb 2024 05:03:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id ABFE36B00F3; Mon, 26 Feb 2024 05:03:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9AEF66B00F6; Mon, 26 Feb 2024 05:03:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 8980C6B00F2 for ; Mon, 26 Feb 2024 05:03:08 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 553D814073B for ; Mon, 26 Feb 2024 10:03:08 +0000 (UTC) X-FDA: 81833516856.18.35A94A0 Received: from mail-vs1-f54.google.com (mail-vs1-f54.google.com [209.85.217.54]) by imf20.hostedemail.com (Postfix) with ESMTP id 9758C1C0020 for ; Mon, 26 Feb 2024 10:03:06 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=i1WOKDQg; spf=pass (imf20.hostedemail.com: domain of elver@google.com designates 209.85.217.54 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708941786; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1ReaxqDHa24p0YNicQdRdk100wLLbR32pRNljWJdCTI=; b=pB2UIHLiFbtEwc1HIWjeFg0glxpNVGmDiinw0TuVFe5KWHvD4GqI9kOHMDX3HTRdgPEq/U EckzNTlYwLp0uq/OhHg7cuEkQp6wTg0dlR4w4Ps8pGxqB1TElH5L1Y16oH4+TjvX8rcjEh a8Q5+MSyab1TTcXpQRzgmUoi6bzcFr4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708941786; a=rsa-sha256; cv=none; b=fpfrSdOcomWfS8Xip7jA/Iljw30SkmiNwztzwF0qiJMY/CsFYz0hApXY5IJHJgEBm+8rRP mH09k7oc3gDUp0rt5ezGuCHtnVGM5096HBW9OtNUkfZzOyk0awDTISPeJDVUptd+1kgjLX s6/DjEjjcDz2PdV0Hmph3Dx9ulkh+WQ= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=i1WOKDQg; spf=pass (imf20.hostedemail.com: domain of elver@google.com designates 209.85.217.54 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-vs1-f54.google.com with SMTP id ada2fe7eead31-4705496ac55so257358137.3 for ; Mon, 26 Feb 2024 02:03:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1708941785; x=1709546585; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=1ReaxqDHa24p0YNicQdRdk100wLLbR32pRNljWJdCTI=; b=i1WOKDQg2U5gGRU6Z1XNpkI84gPbQi1vUdi6pUevdauV+YXBsVZx+q8dWQVfW+fkiL GDyKU6uEkM20d3jGjjzxw2WLuK7oJrBlYrRBOBZijSRkB44djZ5ceZh+Lvc9N6OSjmGY DxvCb/e8gEJdmoH5Vogn7mVPtYPTAZGCR+G2Wl9QypzAsjffgVv3d++IIAIKgUPlzd0E VqDa2r59nZbwdqtMY0sogbousc/WxltmyQC+nMz4F9UAHBU/2cwlJ4o13j1UJaheGJ5D 0pV9Di5Ly+23zt3CASzB+We2LikrzXtrOYPoM6hKWKDHa84ZqcxXTzzwgiw7lZOirHBi dBcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708941785; x=1709546585; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1ReaxqDHa24p0YNicQdRdk100wLLbR32pRNljWJdCTI=; b=aaN9OqNXiSrWWRoqV6hk7FeOOy/QVd0gFAcqIIcuUQKrCl2G5w6sVEres3IC78jqYT JQffUhbQfw/cDwlWMR4KTsKx0Lzkc48OvrqvYjLSizqCn+afAaVfTpTcQ6R25uy5uayj M60XO0wrkYF51hT1rV2IynUv2XOi5M7FuRH5g+VumiF3GNC64OGE2+dybFx8ojUseoTF L01d6wQ51xKnVpjaD0XBShe8yfp0wwJw0etkDsbTGJViduo22IIzz76EJJs/RjFEmn9w pJL7kAIYK+eLMzM3kIgvX6tNv1UL1O4qjafKO9Qjn6GvTUqJYNbl8HBRWzT/Ta6OsIpV mDMQ== X-Forwarded-Encrypted: i=1; AJvYcCXZR9Tc7xkd2x5uK5UGa1obFe0Wzh7SPp7RpSBK2cun9lPZrS3WxJWSwIqIeeCXOPUKCjxxP1qwCnd/1apgXuelT0c= X-Gm-Message-State: AOJu0YyO/0EXLPzEGhGB3/lClf92bTvWuHVNkB34HQnTv3jJuoILB9Zz I7/wux4lWGe4TPCUTNCeAzs0sq+CU0KaVLr8H4+7Ry2A+wv/zNEWBnqktfks7LW4I/WExG81MBR 60XQJ1qyOH0vBKq/YFeu1tMAjHdv1VSogVzK7 X-Google-Smtp-Source: AGHT+IHfZtFLmINWOJhHW4sjPYhxZOHsXnSSHhnF5t7uMOJOzxEdp4E8vVQzUnbrH3lNP8SN7FodNYcv/7O49cXqIu4= X-Received: by 2002:a05:6102:2a53:b0:470:501a:b992 with SMTP id gt19-20020a0561022a5300b00470501ab992mr3659537vsb.19.1708941785489; Mon, 26 Feb 2024 02:03:05 -0800 (PST) MIME-Version: 1.0 References: <20240118110216.2539519-1-elver@google.com> <20240118110216.2539519-2-elver@google.com> <17ec4ca0-db5c-47b7-ba8a-ec1d0798c977@I-love.SAKURA.ne.jp> In-Reply-To: <17ec4ca0-db5c-47b7-ba8a-ec1d0798c977@I-love.SAKURA.ne.jp> From: Marco Elver Date: Mon, 26 Feb 2024 11:02:27 +0100 Message-ID: Subject: Re: [PATCH 2/2] stackdepot: make fast paths lock-less again To: Tetsuo Handa Cc: Andrey Konovalov , Alexander Potapenko , Dmitry Vyukov , Vlastimil Babka , linux-mm@kvack.org, kasan-dev@googlegroups.com, Andi Kleen , Andrew Morton Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 9758C1C0020 X-Rspam-User: X-Stat-Signature: 7uun4ny1frt6auwu47bbk3885q38krrz X-Rspamd-Server: rspam03 X-HE-Tag: 1708941786-20966 X-HE-Meta: U2FsdGVkX1+lsls98SF43vxAKbSCnlpzbl7zQeU/Rc0kDlryOQImJ/O1N/tfBHTna2QcSWXbFleIW41HSMkTI33u+CiPbxrS1IJsQs4EOX1rZQYm6WTJB6pC4GUNFuZtG2Iq5MAzols8RWa3NdSFgISpHRyh8qTJ95wbeZdlhvjVDJ+FEnBUHYCzEzR3l/OgkVtKtQMEJ0r0WdUK0afTlGJOJa3Y7Zps7K6BLWax7SPf/gKSeDKHB44Tagu3CktBZfK2bwiozPxk4HY01NOoEChijO6RPb6hWBs1sJWOV9SiblPKBbCKC91PRnApbywJaRfdvR63JjfGssTB+BEBFtrkcn/ZGK3iYw4qxA/pQ8s2pZxL3jn/DK1nlXk3yApQu8E1Vcy+EZff2s3dWfQsrT36SBEonwSYcbUWceTVRUj/+QvFRorV4Nf1/2WVmYJyc92HzHNDw5KYQP7U1Gur53htHKdfd5Q+tf7Z4vZsUxwQrj3Hs1FbsgyBL8hFt/x1FrOSgBbiFKxozmXGftaTsqRqCasrrhNQvruWvDkIqP4b8Zigaswrtfk0rCQnoSqB/b2HRP5fDc5HRm0OpylnS8D2DYFvY9YZjPDjmbTZjtxTu8aDED/dZDZ5Mm3/j1mJDbFZ84KldF21HAvTjhkLvqW3OcPFHFeavfrs6dxZXcm8ZruJ/VKwkfjqjpa4rdum1eg/YHKajtDrgDbXXwxRvDazjAtQIEA5fUw3g62qC/BQiG3nHBW2W0pHck3iZO5WDj4F4TmJc/NN5EPaHy+0IawAIbg+6ekHZ4BfRSeUFTssL6JhEEp4N9i1p46WlP6grUykYI+gB9IahscJOT7wsvP5DRtFm4zyOSwETfb1edap0YTHaRVfWAMETe1MMEuNkuGOX9Yl//AI8tOOP24LSUnCMk6XvdhATAySkKnP0H4BU4RYK7CJfpZ2eHFwcSi09tykibwm8Us7lIeekjD BgTRWCQv 3s/LRQP4zhSoBS84eWBIC0H5KJVk8yoe7bM15CPrLpf0NXM4eZrHy8HFGo+Gn8xVYl8M5eHu9z1GpYCAlrwj3OOv9NcbswzTuq5bls5UCYFcJLKMzgSQlyYgj5kGEMcHDoitJTOZUPUEntlupqTBGjAiva40OMU5crOCuNfEwhyyaKekOSTYF3KAgV1N6Ssnk6RyJ0TMvOAXM4X+UFc1oVIbWCVNc/pwPhODU X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 26 Feb 2024 at 10:50, Tetsuo Handa wrote: > > On 2024/02/26 18:22, Marco Elver wrote: > > If we want this fixed in mainline, I propose that [1] + [2] are sent for > > 6.8-rc inclusion. > > Doing > > - alloc_flags |= __GFP_NOWARN; > + alloc_flags |= __GFP_NOWARN | __GFP_ZERO; > > in stack_depot_save_flags() solves the problem. Maybe this is easier for 6.8 cycle? But it's unnecessary and may hide future bugs once the series in -next lands. If we remember to revert this hack then I don't mind either way. I think Alex proposed something similar before we had [1] and [2], but we decided against it.