From: Marco Elver <elver@google.com>
To: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc: Andrey Konovalov <andreyknvl@gmail.com>,
Alexander Potapenko <glider@google.com>,
Dmitry Vyukov <dvyukov@google.com>,
Vlastimil Babka <vbabka@suse.cz>,
linux-mm@kvack.org, kasan-dev@googlegroups.com,
Andi Kleen <ak@linux.intel.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 2/2] stackdepot: make fast paths lock-less again
Date: Mon, 26 Feb 2024 11:02:27 +0100 [thread overview]
Message-ID: <CANpmjNNH1iQmD5F36+3Vj4vKy1oZkFuUcCq51wuc0qSRcJN=0g@mail.gmail.com> (raw)
In-Reply-To: <17ec4ca0-db5c-47b7-ba8a-ec1d0798c977@I-love.SAKURA.ne.jp>
On Mon, 26 Feb 2024 at 10:50, Tetsuo Handa
<penguin-kernel@i-love.sakura.ne.jp> wrote:
>
> On 2024/02/26 18:22, Marco Elver wrote:
> > If we want this fixed in mainline, I propose that [1] + [2] are sent for
> > 6.8-rc inclusion.
>
> Doing
>
> - alloc_flags |= __GFP_NOWARN;
> + alloc_flags |= __GFP_NOWARN | __GFP_ZERO;
>
> in stack_depot_save_flags() solves the problem. Maybe this is easier for 6.8 cycle?
But it's unnecessary and may hide future bugs once the series in -next
lands. If we remember to revert this hack then I don't mind either
way.
I think Alex proposed something similar before we had [1] and [2], but
we decided against it.
prev parent reply other threads:[~2024-02-26 10:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-18 11:01 [PATCH 1/2] stackdepot: add stats counters exported via debugfs Marco Elver
2024-01-18 11:01 ` [PATCH 2/2] stackdepot: make fast paths lock-less again Marco Elver
2024-02-24 11:38 ` Tetsuo Handa
2024-02-24 18:03 ` Marco Elver
2024-02-26 9:22 ` Marco Elver
2024-02-26 9:50 ` Tetsuo Handa
2024-02-26 10:02 ` Marco Elver [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANpmjNNH1iQmD5F36+3Vj4vKy1oZkFuUcCq51wuc0qSRcJN=0g@mail.gmail.com' \
--to=elver@google.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@gmail.com \
--cc=dvyukov@google.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-mm@kvack.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox