From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 595F1C433DB for ; Thu, 14 Jan 2021 19:56:35 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0207121D46 for ; Thu, 14 Jan 2021 19:56:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0207121D46 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 726828D011E; Thu, 14 Jan 2021 14:56:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6D57C8D00F0; Thu, 14 Jan 2021 14:56:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5EBB18D011E; Thu, 14 Jan 2021 14:56:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0155.hostedemail.com [216.40.44.155]) by kanga.kvack.org (Postfix) with ESMTP id 4B24D8D00F0 for ; Thu, 14 Jan 2021 14:56:34 -0500 (EST) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 0CA0F824556B for ; Thu, 14 Jan 2021 19:56:34 +0000 (UTC) X-FDA: 77705437908.02.ring78_100e80d27529 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin02.hostedemail.com (Postfix) with ESMTP id D93A710097AA1 for ; Thu, 14 Jan 2021 19:56:33 +0000 (UTC) X-HE-Tag: ring78_100e80d27529 X-Filterd-Recvd-Size: 4531 Received: from mail-oo1-f46.google.com (mail-oo1-f46.google.com [209.85.161.46]) by imf34.hostedemail.com (Postfix) with ESMTP for ; Thu, 14 Jan 2021 19:56:33 +0000 (UTC) Received: by mail-oo1-f46.google.com with SMTP id x203so1654382ooa.9 for ; Thu, 14 Jan 2021 11:56:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZAcc3zNp7VGprtlxhdh/3qjDl2q8+DBIOh9GzZOOC9c=; b=vmXs67opHZMsHKBRz9S4jhbrtQZYZ2sk+Iu4XwbNOhJMP2WH2LrsKhHrAzFKTliWM0 Ic/2n1TyYxSkKaJicov1ee5QzQYe6QangS0QfCGICadiwrvUxaNQdX2mD5IAIvEJ0KKu gsbgPlA2PaEpJztqi1Io7QAXMJG44t4Q/I1czERV5oIMmhaBs68dDdAKnGSS0Z+SOm5R LuHDT8sF1qDUkDNYGUGMkwh8CQIRosW41Kw4XLfZT+uEpDpB+bt3aCunI/9LwmmpLYG5 QWt23AAJb4k2kb9M6QDq0EMpYUTk5WR491MD8qMyFlXez0+1GzobQVjqlMp/SLJL1y7I +JTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZAcc3zNp7VGprtlxhdh/3qjDl2q8+DBIOh9GzZOOC9c=; b=UekwxdcqNTtBTLpUIXZ6vDAM1xOgy94PIiHFSTVKD/EfTUi9o26lC0HsHprZ8+sUoc 91ySwW8QjBzw78nYhFO8GBZ9aIiJj9TEzrnFKBZweupzP5yPx46cFCCw3nCtSxRGXw2C QiAI19TMAKY0ur4r0IIgJmTE0b4zP7XOFCMoZq+lwRvUb4hHxJmu/P5qhoI7C3EtbZFd w7wuD2lmJEPU0UBtizJxXqtyCkm3keVCeMd2oRwZA+Qfvg1BnZCrZFSMyjE7AaNUJtG9 mkIX8iTURwOifo9XBi7Lsh6er9jYPZHETogS6gkIl7LB4cGNIJ3n4/CfWPnG9c3ODbDT MpAg== X-Gm-Message-State: AOAM533VCOdkTVbESq836C3BeRkxH3pDiMydIgRMTJ0m8DVFVFcJP3UR 07tnCJN/np8ovxQU0tTd4GqHOHUqW4ESuENkb4YFrg== X-Google-Smtp-Source: ABdhPJyLa62+jHhxWdEgxjXJycNhlQSq/fBgOo4qQHvR5bY4u6pn3J9ETjhhgibepZ6UyHJfmzBm5klziTjyWZtArz0= X-Received: by 2002:a4a:e1c1:: with SMTP id n1mr5779219oot.36.1610654192707; Thu, 14 Jan 2021 11:56:32 -0800 (PST) MIME-Version: 1.0 References: <77015767eb7cfe1cc112a564d31e749d68615a0f.1610554432.git.andreyknvl@google.com> In-Reply-To: From: Marco Elver Date: Thu, 14 Jan 2021 20:56:21 +0100 Message-ID: Subject: Re: [PATCH v2 11/14] kasan: fix bug detection via ksize for HW_TAGS mode To: Andrey Konovalov Cc: Catalin Marinas , Vincenzo Frascino , Dmitry Vyukov , Alexander Potapenko , Andrew Morton , Will Deacon , Andrey Ryabinin , Peter Collingbourne , Evgenii Stepanov , Branislav Rankov , Kevin Brodsky , kasan-dev , Linux ARM , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 14 Jan 2021 at 19:01, 'Andrey Konovalov' via kasan-dev wrote: > On Wed, Jan 13, 2021 at 5:54 PM Marco Elver wrote: > > > > > +/* > > > + * Unlike kasan_check_read/write(), kasan_check_byte() is performed even for > > > + * the hardware tag-based mode that doesn't rely on compiler instrumentation. > > > + */ > > > +bool __kasan_check_byte(const void *addr, unsigned long ip); > > > +static __always_inline bool kasan_check_byte(const void *addr, unsigned long ip) > > > +{ > > > + if (kasan_enabled()) > > > + return __kasan_check_byte(addr, ip); > > > + return true; > > > +} > > > > Why was this not added to kasan-checks.h? I'd assume including all of > > kasan.h is also undesirable for tag-based modes if we just want to do > > a kasan_check_byte(). > > It requires kasan_enabled() definition. I can move both to > kasan-checks.h if you prefer. However, the only place where > kasan_check_byte() is currently used includes kasan.h anyway. Hmm, if it makes too much of a mess, let's just leave as-is. Thanks, -- Marco