From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1B1BCD11C2 for ; Wed, 10 Apr 2024 13:59:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 399066B00BD; Wed, 10 Apr 2024 09:59:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 347B66B00BE; Wed, 10 Apr 2024 09:59:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 25E9A6B00BF; Wed, 10 Apr 2024 09:59:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 022956B00BD for ; Wed, 10 Apr 2024 09:59:48 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id B702980627 for ; Wed, 10 Apr 2024 13:59:48 +0000 (UTC) X-FDA: 81993780456.16.F4ECEC7 Received: from mail-vs1-f49.google.com (mail-vs1-f49.google.com [209.85.217.49]) by imf26.hostedemail.com (Postfix) with ESMTP id F329B14001B for ; Wed, 10 Apr 2024 13:59:46 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=tPrgJYI3; spf=pass (imf26.hostedemail.com: domain of elver@google.com designates 209.85.217.49 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712757587; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5aa3hIWZtOiM9o7F/Dz6DxBBPY3BgmfWmAFxkVrBHd8=; b=IcNv/d39bDz5bGBzE3XjEJz7ERxXg/LiGOFblgF+2+feZdFzWmAm2sb7L9HlVpZl3Qhex5 LcPeO1x4REWZe4RzbrWU0DMGYDWgNsEHmlrAVEwn16ejmZ1YrHeU27bD5oUVU+KLncFwHs otaXVKJW/Ds4qOvbTW2ek6dLYH4GVoY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712757587; a=rsa-sha256; cv=none; b=2D+n0Cs32UeZFgUUKcewpmtTbRCG/V+GME6FulTg+DCqMZt7JFM3acdiP1XLbwMfGf++T0 T3srkx4VlNFicnOTXKft4FgLY6dHr1r+Si+vAWSkO71JRa4zvLi+mPMRnwZObnX2z8oVk8 gl1gYgFWQtUbWzTfolHHDlqDRCz0s5U= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=tPrgJYI3; spf=pass (imf26.hostedemail.com: domain of elver@google.com designates 209.85.217.49 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-vs1-f49.google.com with SMTP id ada2fe7eead31-479c39b78dbso2748415137.2 for ; Wed, 10 Apr 2024 06:59:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1712757586; x=1713362386; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=5aa3hIWZtOiM9o7F/Dz6DxBBPY3BgmfWmAFxkVrBHd8=; b=tPrgJYI3oRhjKN00OzxueKVF5r23e6zSS9iTz3Ozdp4mI/Cf6cTiMEKUScESrN0e8W pp0wiGbQTXxAGTEL46hGX1UXHr/DRU4x5+sQNK2/0FJt1x4pfhJGviDrTEGmVAsoycBz 8XRNxir30hjH7WM5rst9fu78cZw9VjeMC8ivx9M99JofVDOEDSEay9ABRQaoL2RZ9d6W B2V2tzYQdSNsiZgcwB16Et/v5Fv3vWaxKZ20tGZSNpvbmz5es+jVBbqOB9PdF4vEZ+go Zx+nOUtFgOUN1Z1+VYjB8t/yvHGzUpsnoCa327oSo7CSSLEJZhVFM9+pYw4mApYlyYou 0DPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712757586; x=1713362386; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5aa3hIWZtOiM9o7F/Dz6DxBBPY3BgmfWmAFxkVrBHd8=; b=rhBoRiZb9IIdKd1mzJYZ3AHF0QpPQ1GZ8MWd4zkVK65Oz7zkZ1cJxw5uC1uZBTGmBl tUV6keALbQf8ciNWH0vI8m/6fImBxcv+5dNirAMk/L2tNYYyYV/pgKZPG5dB/SlBg0YU Qtd4jumr1HFP/8XChSshFjXTgt23ym0YmyQr9Jbvy7ojc7AkDMXg+cKDadSbs7JM4A60 zi6Kzp6bRCQ5MRd6omF2S4pg8luiaNfSd+Cd5uMYVxY0gamXULxYwsg6IVUWkm4wFGYn n6loFcrJLUlbEKQlvsYnCoTNljVFsgTAzm/5u2rdkSXMbh7j7y2hpq3urboVLnzCOthx BVHw== X-Forwarded-Encrypted: i=1; AJvYcCVias+1JzAifJXR/+CJRJWN0/8cDbT2OhZJS6CoTxpMoNMvmxlkzvsi2Xoma3irQYu2G+oMZ9S+AlIDuiReJg3s5Yw= X-Gm-Message-State: AOJu0YwdwlXkRmr3prFaB6KSvOM6ipsPPLxijZWp3wYazljHLTYLP9P4 l/nFyi2e2FbChfNGjyw7sfkWrCfz7lpC7oettL8+KXImhmkG1O3j8covAcBxnrWWKJX+e4hGBtd prSp5DgpOVIVg900CQcj43jmadfEydd2Srp1O X-Google-Smtp-Source: AGHT+IEpsiKA9Ha0aSj78Js7MGsZu+xSPo2OOybBgeVcNcg20IWc+marqLN4JEtWyhh8Xzl0ENJq8kVbtbfz5TbqHoU= X-Received: by 2002:a05:6102:1593:b0:47a:248b:6846 with SMTP id g19-20020a056102159300b0047a248b6846mr2424398vsv.16.1712757585948; Wed, 10 Apr 2024 06:59:45 -0700 (PDT) MIME-Version: 1.0 References: <20240408090205.3714934-1-elver@google.com> <20240410225648.7a815ba873c8d55c44385c24@kernel.org> In-Reply-To: <20240410225648.7a815ba873c8d55c44385c24@kernel.org> From: Marco Elver Date: Wed, 10 Apr 2024 15:59:07 +0200 Message-ID: Subject: Re: [PATCH] tracing: Add new_exec tracepoint To: Masami Hiramatsu Cc: Steven Rostedt , Eric Biederman , Kees Cook , Alexander Viro , Christian Brauner , Jan Kara , Mathieu Desnoyers , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Dmitry Vyukov Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: F329B14001B X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: smr5pi9q8osjfto8eawrtmhmy8b6y5fr X-HE-Tag: 1712757586-650476 X-HE-Meta: U2FsdGVkX1/sBQp+GLGwEhNn9NRD9gdiENUA5dJtVBS3HBvJVtuS3azs264CEGqFJb9I8hFkLxWYv/OmEiDVSUipDyoriIsWuJg4/8QscJpphfDOHak3OEE2INIIScvg9D1D+ArXQwEvm4G/LCdMabY8a4XZsmh/eapCy5q4y9YOKCR5MdD/6BVrParUl1XrOWlpw7N3sM9EWQsQ05958aICpZEpfQgHcA3feGNiGqqf9t2PeHFQ+prf1qVRbPjtzdngxp+eD8ZZQwlQ8jb64F3Ss3BHRrEStmUCC8ZrLJku7vUnMygCkYI6H92AbYvJamN3mu3ty9LZ6DkbTIQPS61CoCN+ONL2P5Np8eJADmDmRXOQ6Pw//EnoCft/po+Gn1x2fSI/dnNobPV5lpFTB9Rz3Q7GWwjts1904e8s/WD1IdmvhNZ9XG7rxgqDVk3lf9ImgFWl4d3BhXso2fO1CpMazGKuAlNRisR4I8HaoCN3PTL0iq7Gj1PIZJILrWUO4UldkbZeCy5UrmZUtpmffA+4Kc30zdIek8IJLzQyRz/v7C/vjE1GfoYbtD4BtZkgKOrToh93Qm6s4qsCFgW79Y9mX0BcUwFH6FSG8T8VJg48Mr5zrsVWND7HB+DbFW9OwiqJB/QP7Of+ObO4VUuq1gi2rcFI8qgCchbTv7eNCBE6IRHTBlRtOybkOdHUwSjdsEtO5sZ7ayxJGlZEJqSJ9WVv/KiZ6Y5E0TxdcefbBel/MMQfkBvrEuSd0RygD9dVQrIlf49KJp6mD4ej4Z1QBlQU0m8LT6o8Fn3d+gasyCpm4mJzTVUSqphPA2vEpdPu28VFB0++2OCnS9mxYbsugRtWDigLmsQ6aHbfnJlmg3OLlLU2gl9064+z6rs+kK/ZObZCthxl+JnCzH20oUVpzHDwt8BRIhzIYgpJbD0iG8BhHVvgagOfAdaf0UrYi+PT2LwzRMcZVt5z+bflDWI sUOBkJws dkIvvs3OHoMzsEt/vL2zfMv7mU4n7+67C7gnTPFsx3iaNI6Vq0RHmFoImQV07ECtuI9pWKygT+tL3O4j26/491HfdVfXHhtZQCC52M+d8ng1D0TeN/kC915xLl3kGdIVzeYgLlBMf8oOTLD3a/v3JWruoDF8GKYpaiwoVgYBWCP6nUUJ2BGimKqXfzn89jitrYmX7exgFY3EOYZs+i2Ed4KIKsuKuF/VNr4eTW2nfPQCTUiWXQ9yVS7JH4/Mi95DQgpisoqVZGehh0yepWaTAcZCDX6SdQKjAtpMcyOCSbr5o58OVubCOdhjWxy0blNCQP+0Qy8NXruRkkbl+mXMgYbmYiVNoeRrjCn2u X-Bogosity: Ham, tests=bogofilter, spamicity=0.000016, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 10 Apr 2024 at 15:56, Masami Hiramatsu wrote: > > On Mon, 8 Apr 2024 11:01:54 +0200 > Marco Elver wrote: > > > Add "new_exec" tracepoint, which is run right after the point of no > > return but before the current task assumes its new exec identity. > > > > Unlike the tracepoint "sched_process_exec", the "new_exec" tracepoint > > runs before flushing the old exec, i.e. while the task still has the > > original state (such as original MM), but when the new exec either > > succeeds or crashes (but never returns to the original exec). > > > > Being able to trace this event can be helpful in a number of use cases: > > > > * allowing tracing eBPF programs access to the original MM on exec, > > before current->mm is replaced; > > * counting exec in the original task (via perf event); > > * profiling flush time ("new_exec" to "sched_process_exec"). > > > > Example of tracing output ("new_exec" and "sched_process_exec"): > > nit: "new_exec" name a bit stands out compared to other events, and hard to > expect it comes before or after "sched_process_exec". Since "begin_new_exec" > is internal implementation name, IMHO, it should not exposed to user. > What do you think about calling this "sched_prepare_exec" ? I like it, I'll rename it to sched_prepare_exec. Thanks!