From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2C19D591A5 for ; Tue, 19 Nov 2024 16:38:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5A62F6B0099; Tue, 19 Nov 2024 11:38:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 555A56B009A; Tue, 19 Nov 2024 11:38:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 41DE36B009B; Tue, 19 Nov 2024 11:38:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 27C6A6B0099 for ; Tue, 19 Nov 2024 11:38:13 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id BF6B6160145 for ; Tue, 19 Nov 2024 16:38:12 +0000 (UTC) X-FDA: 82803400470.10.49356CE Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) by imf08.hostedemail.com (Postfix) with ESMTP id 5EA2F160003 for ; Tue, 19 Nov 2024 16:37:37 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=RbylM5Xq; spf=pass (imf08.hostedemail.com: domain of elver@google.com designates 209.85.210.177 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732034199; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tsi76Pj99/LFVNHPqhU6HGDCzJfL0N7wlXitIphx0zw=; b=vnKwuHB6T6+ZsFLsXGdIMIThxR+XvUe8bwh34R+xzH7VK5VlMc9NmfXAWvL6hL2igWNHzK a6rL3j+ixVMluCHEAbLXCVxTOIl6tk66LhOI8+bbvX241sNsf0o7s01Kbso2l3aW+azmAH 7mdAfVd/hoQR6vtU4kjvmyYLdKWJDhw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732034199; a=rsa-sha256; cv=none; b=zhrH5L3NOVC4p+hB8VpPS9CxYvAQEC0wQmo9it4riOZsps+KE3llkW4WureBoHWAa41r0h yL7w1rv28z76OJyhGVALcilO21oG6hyrhiCGB9nP2nPrw3CHoyy/oe2MMTSZDbt1bqbK6b iEWX/XuGHqxINSNXn0jEMmc0sNcAPUI= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=RbylM5Xq; spf=pass (imf08.hostedemail.com: domain of elver@google.com designates 209.85.210.177 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-7248c1849bdso2947971b3a.3 for ; Tue, 19 Nov 2024 08:38:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1732034290; x=1732639090; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=tsi76Pj99/LFVNHPqhU6HGDCzJfL0N7wlXitIphx0zw=; b=RbylM5XqcvtbrfYiH4KjfWr6eeSdKbyW23qrW1Xj45AZcfXXurW1zAxGE3VVHPQpI/ 3Z2p15HXIooRDcbwNpBud6R6DKfTYgyUh77G4wCgThtNYhfYIhXIXu7+MfQfk5JDGA43 reRpVFSr5EOVp2tUXUwvU84lfKNZ4kSXGQibm4rI/4m3E5IeoZAIu3lzQ9a5rRCuVrzm ewHx+FsvvWbbz6rOCx/adQELAnAQkuXkFLrvSTwWRBOQ27PWzjBbh9ANGBDd9GiUM2RC sLRj5ZgPjjJ1BmFZBcyxzhb6g2IX8Bn0p0aEibtUxEvkWJs1QC/zaDXNqpbXe3KnwX8e ybtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732034290; x=1732639090; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=tsi76Pj99/LFVNHPqhU6HGDCzJfL0N7wlXitIphx0zw=; b=v8jZIkeOz/W/T0ToTauxxnxqaTcBmE/wgc6SkSoxKH6J03RcgIz/aSKCGI76dUmLuT sN9Bgd8TPlVP5EnqrCBIRRwjQkvGuTTa/8P3lX+RDFz0tSB8K15gOxF/qW05656aDVNR fCc9zyEHpoyElVbzWUbUNZxS6m3FT+IklCgtTUDoPMcwJiW00AX94sPhVNKtaYf/EjKh mr6VbJGDCTD51WpqwwXFcWy/kzX8Ic1DmRMnnPHV7g8SZ5Wgf7HA51REtGDqSsYg2/Yy DRDwwsIRV/HyXcgdoOBrI/DDmWxjp+3hxRw7c+yXJaGUFy7mN3ANXbSCJHN+r1jI58Qk DoRA== X-Forwarded-Encrypted: i=1; AJvYcCX2xC1nZ8YgZcmDVIhMxNDzRPgGnOKsDqyjm0n1gyF3HPjlSyhXW90jU2cR/HfSeeAI3Xc+p9Y7sw==@kvack.org X-Gm-Message-State: AOJu0YxgXXSNendshgtSf6QT/5HW5q4bE/3ZzHE149Ip6LKCtPCiZRUT HQExTK0GASGv6kKgSnHEj7S19TMNa1mt8JsMdl+ZBObS3cZItzwPfyzWAHx8z/OfJ7aCEj/6To8 pn8NvjQHNA5LbS/QFdKVKs/TCxrNoqdExbWBM X-Google-Smtp-Source: AGHT+IHQA7XqdVsvATXbGsRCW6vobj0rSX84VvhPHoBIjp4qi1gk3ZaGfQ5C7h7OzzD9KSSUyMm+r/Mcm1I7aPg7hZg= X-Received: by 2002:a05:6a00:1390:b0:724:592d:aa5f with SMTP id d2e1a72fcca58-72476c4c25amr21755898b3a.19.1732034289334; Tue, 19 Nov 2024 08:38:09 -0800 (PST) MIME-Version: 1.0 References: <67275485.050a0220.3c8d68.0a37.GAE@google.com> <20241104114506.GC24862@noisy.programming.kicks-ass.net> <20241119155701.GYennzPF@linutronix.de> In-Reply-To: <20241119155701.GYennzPF@linutronix.de> From: Marco Elver Date: Tue, 19 Nov 2024 17:37:33 +0100 Message-ID: Subject: Re: [PATCH] kasan: Remove kasan_record_aux_stack_noalloc(). To: Sebastian Andrzej Siewior Cc: Peter Zijlstra , Vlastimil Babka , syzbot , Liam.Howlett@oracle.com, akpm@linux-foundation.org, jannh@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, lorenzo.stoakes@oracle.com, syzkaller-bugs@googlegroups.com, Andrey Konovalov , kasan-dev , Andrey Ryabinin , Alexander Potapenko , Waiman Long , dvyukov@google.com, vincenzo.frascino@arm.com, paulmck@kernel.org, frederic@kernel.org, neeraj.upadhyay@kernel.org, joel@joelfernandes.org, josh@joshtriplett.org, boqun.feng@gmail.com, urezki@gmail.com, rostedt@goodmis.org, mathieu.desnoyers@efficios.com, jiangshanlai@gmail.com, qiang.zhang1211@gmail.com, mingo@redhat.com, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com, tj@kernel.org, cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, Thomas Gleixner , roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, rcu@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam10 X-Stat-Signature: exgmuzyibk5p6tfaid1nprtgie8xw7ia X-Rspamd-Queue-Id: 5EA2F160003 X-Rspam-User: X-HE-Tag: 1732034257-781017 X-HE-Meta: U2FsdGVkX18LwEehHBSsnCkiyORVfurK7rplKlt7/EoJWboytYu9Kb0kLedWKGAdkOyNCzo9KUOQrl1O5Q/sKaIVQ5wuy36IpT4jOmDzJVAycFS/dKl3hviWFTroXRfCgoAMiy/cAfVA0U8FAcJkHJdi8st7JsQrF4GcGZSF2iR2ah3Xap1YUw7Zc6yKCaXiuuHQgrpAR2TZk6OjoOeKUKB7Py12Hssu56JiBLOfLmCKLEVCLdYjeunHxeYX60L6OiCuIuyunamQLX+Ri2QRWQwWwW5sxPYDnNFKoxxliFNSQRr9KFQsM8Uc/UI5TiOyThEIYv6Utw23K7WoiNctg6psfi8CMu7Tte28V3lRpel3geafqg1vSLcOX8fsVIpJiO8UGbvpoYf04QPwTx6iDUcMtiFCGzwM9oKKs5p8W2YcX99WU6NO9nzdAxpgWa3jENRv7VLHKcBuOOzgg9ZNSkQnVkQ62EjnpsMXVYefpshYqexRpZDIC1Y3Au3j9o8z5KhHzhZYA8DPcuRn3eKVPtcUJAlqNSOy0xhiMs7Nu33mY7ScM9aN0mWfHdHXvNUcDsqTiqpeHpaU37VLDywdbuRcTWfowLZWFN/BghBF5kV99lIKlgLfKHusfRbnCIsbc5NJ/8aUrTwZwCkISxLqspUm1oLcXYsEtcI5S3LwotMkgt6DQHlkOpW/DA3v94+FG44ZMNVesFGNumQg3n/H3m4Pzgel+ut2DSfdseaBWTJzAffb0HW55WSlCGgPiQop/SgOgd9vYo5zfz/W/F7aBDoL/fF8/obDLvhVUam71D1NXMRJDmWBf9C9mV4iH4fqu4m0Q1w85+uzFo32J+/mqrf/cqjIm92PKNGaU4KhDtNnSusvh4pZwmreofj23AUsM3JEivB/nbUllUfy9frS/Pr1ZyvKpirXUD+5uW++K9Q5/qlMXZcAOGGzitK3wjCvR1xhzYQQ97hPXmV/+mH BjcdJnD4 1WKmvb6Fr0bL/YK+4nQKr2Fj4AcvsCiHfxCWeF6yjzX/Yf20D4IuMzUSo1vVS3V+7nSJQoro9xhndaRYwXcGRaB+tRNilbGdNHNtAEI5txSsrhB9zBAz1x6tcoRPTn80KTlldo+cBT00jsBOM6tV8ExzdCb+CUCRYCICeNnYWyqt+gfm2g42vuH2+3mB5VGQubH6m6J1h8ZWbs1Pwx4beCoYmY5J6TZSMk7dgCc1ufbIyHzOGlBdHrE39wFcpLAriOq3Z31j/DsEaAgJqo6GjZlAzIeLq6KRhqHJqAI7tI5s5v+YepYoQVj38utUYPd/wb+hs9frOtIIbusdRK7lBbAaziROaUsXaHrnnOq3bqfG+koeisJOHdriDMyfpH3MEG2p2/inZaMRpnwrilCL733602pDlYuzXIk8qzur1a3Vpxz8CpxpU+7EE6Cz4X8wKqTUVae6VTax8yZzgGqYb/gxR1VMngJaq+DAF5DYQRReYhEF5rD3DU5sgZf7sj9K6RJka7ysY/jYdI5ro1zFuf3lPxQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 19 Nov 2024 at 16:57, Sebastian Andrzej Siewior wrote: > > From: Peter Zijlstra The patch title is misleading - it might suggest the opposite of what it's doing. I think this might be clearer: "kasan: Make kasan_record_aux_stack_noalloc() the default behaviour" Which is also more or less what you say below. > kasan_record_aux_stack_noalloc() was introduced to record a stack trace > without allocating memory in the process. It has been added to callers > which were invoked while a raw_spinlock_t was held. > More and more callers were identified and changed over time. Is it a > good thing to have this while functions try their best to do a > locklessly setup? The only downside of having kasan_record_aux_stack() > not allocate any memory is that we end up without a stacktrace if > stackdepot runs out of memory and at the same stacktrace was not > recorded before. Marco Elver said in > https://lore.kernel.org/all/20210913112609.2651084-1-elver@google.com/ > that this is rare. > > Make the kasan_record_aux_stack_noalloc() behaviour default as > kasan_record_aux_stack(). > > [bigeasy: Dressed the diff as patch. ] > > Reported-by: syzbot+39f85d612b7c20d8db48@syzkaller.appspotmail.com > Closes: https://lore.kernel.org/all/67275485.050a0220.3c8d68.0a37.GAE@google.com > Signed-off-by: Peter Zijlstra (Intel) > Signed-off-by: Sebastian Andrzej Siewior Reviewed-by: Marco Elver As I wrote in https://lore.kernel.org/all/CANpmjNPmQYJ7pv1N3cuU8cP18u7PP_uoZD8YxwZd4jtbof9nVQ@mail.gmail.com/: > I'd be in favor, it simplifies things. And stack depot should be > able to replenish its pool sufficiently in the "non-aux" cases > i.e. regular allocations. Worst case we fail to record some > aux stacks, but I think that's only really bad if there's a bug > around one of these allocations. In general the probabilities > of this being a regression are extremely small [...] Good riddance. Thanks, -- Marco > --- > > Didn't add a Fixes tag, didn't want to put > 7cb3007ce2da2 ("kasan: generic: introduce kasan_record_aux_stack_noalloc()") > > there. > > include/linux/kasan.h | 2 -- > include/linux/task_work.h | 3 --- > kernel/irq_work.c | 2 +- > kernel/rcu/tiny.c | 2 +- > kernel/rcu/tree.c | 4 ++-- > kernel/sched/core.c | 2 +- > kernel/task_work.c | 14 +------------- > kernel/workqueue.c | 2 +- > mm/kasan/generic.c | 14 ++------------ > mm/slub.c | 2 +- > 10 files changed, 10 insertions(+), 37 deletions(-) > > diff --git a/include/linux/kasan.h b/include/linux/kasan.h > index 00a3bf7c0d8f0..1a623818e8b39 100644 > --- a/include/linux/kasan.h > +++ b/include/linux/kasan.h > @@ -488,7 +488,6 @@ void kasan_cache_create(struct kmem_cache *cache, unsigned int *size, > void kasan_cache_shrink(struct kmem_cache *cache); > void kasan_cache_shutdown(struct kmem_cache *cache); > void kasan_record_aux_stack(void *ptr); > -void kasan_record_aux_stack_noalloc(void *ptr); > > #else /* CONFIG_KASAN_GENERIC */ > > @@ -506,7 +505,6 @@ static inline void kasan_cache_create(struct kmem_cache *cache, > static inline void kasan_cache_shrink(struct kmem_cache *cache) {} > static inline void kasan_cache_shutdown(struct kmem_cache *cache) {} > static inline void kasan_record_aux_stack(void *ptr) {} > -static inline void kasan_record_aux_stack_noalloc(void *ptr) {} > > #endif /* CONFIG_KASAN_GENERIC */ > > diff --git a/include/linux/task_work.h b/include/linux/task_work.h > index 2964171856e00..0646804860ff1 100644 > --- a/include/linux/task_work.h > +++ b/include/linux/task_work.h > @@ -19,9 +19,6 @@ enum task_work_notify_mode { > TWA_SIGNAL, > TWA_SIGNAL_NO_IPI, > TWA_NMI_CURRENT, > - > - TWA_FLAGS = 0xff00, > - TWAF_NO_ALLOC = 0x0100, > }; > > static inline bool task_work_pending(struct task_struct *task) > diff --git a/kernel/irq_work.c b/kernel/irq_work.c > index 2f4fb336dda17..73f7e1fd4ab4d 100644 > --- a/kernel/irq_work.c > +++ b/kernel/irq_work.c > @@ -147,7 +147,7 @@ bool irq_work_queue_on(struct irq_work *work, int cpu) > if (!irq_work_claim(work)) > return false; > > - kasan_record_aux_stack_noalloc(work); > + kasan_record_aux_stack(work); > > preempt_disable(); > if (cpu != smp_processor_id()) { > diff --git a/kernel/rcu/tiny.c b/kernel/rcu/tiny.c > index b3b3ce34df631..4b3f319114650 100644 > --- a/kernel/rcu/tiny.c > +++ b/kernel/rcu/tiny.c > @@ -250,7 +250,7 @@ EXPORT_SYMBOL_GPL(poll_state_synchronize_rcu); > void kvfree_call_rcu(struct rcu_head *head, void *ptr) > { > if (head) > - kasan_record_aux_stack_noalloc(ptr); > + kasan_record_aux_stack(ptr); > > __kvfree_call_rcu(head, ptr); > } > diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c > index b1f883fcd9185..7eae9bd818a90 100644 > --- a/kernel/rcu/tree.c > +++ b/kernel/rcu/tree.c > @@ -3083,7 +3083,7 @@ __call_rcu_common(struct rcu_head *head, rcu_callback_t func, bool lazy_in) > } > head->func = func; > head->next = NULL; > - kasan_record_aux_stack_noalloc(head); > + kasan_record_aux_stack(head); > local_irq_save(flags); > rdp = this_cpu_ptr(&rcu_data); > lazy = lazy_in && !rcu_async_should_hurry(); > @@ -3807,7 +3807,7 @@ void kvfree_call_rcu(struct rcu_head *head, void *ptr) > return; > } > > - kasan_record_aux_stack_noalloc(ptr); > + kasan_record_aux_stack(ptr); > success = add_ptr_to_bulk_krc_lock(&krcp, &flags, ptr, !head); > if (!success) { > run_page_cache_worker(krcp); > diff --git a/kernel/sched/core.c b/kernel/sched/core.c > index a1c353a62c568..3717360a940d2 100644 > --- a/kernel/sched/core.c > +++ b/kernel/sched/core.c > @@ -10485,7 +10485,7 @@ void task_tick_mm_cid(struct rq *rq, struct task_struct *curr) > return; > > /* No page allocation under rq lock */ > - task_work_add(curr, work, TWA_RESUME | TWAF_NO_ALLOC); > + task_work_add(curr, work, TWA_RESUME); > } > > void sched_mm_cid_exit_signals(struct task_struct *t) > diff --git a/kernel/task_work.c b/kernel/task_work.c > index c969f1f26be58..d1efec571a4a4 100644 > --- a/kernel/task_work.c > +++ b/kernel/task_work.c > @@ -55,26 +55,14 @@ int task_work_add(struct task_struct *task, struct callback_head *work, > enum task_work_notify_mode notify) > { > struct callback_head *head; > - int flags = notify & TWA_FLAGS; > > - notify &= ~TWA_FLAGS; > if (notify == TWA_NMI_CURRENT) { > if (WARN_ON_ONCE(task != current)) > return -EINVAL; > if (!IS_ENABLED(CONFIG_IRQ_WORK)) > return -EINVAL; > } else { > - /* > - * Record the work call stack in order to print it in KASAN > - * reports. > - * > - * Note that stack allocation can fail if TWAF_NO_ALLOC flag > - * is set and new page is needed to expand the stack buffer. > - */ > - if (flags & TWAF_NO_ALLOC) > - kasan_record_aux_stack_noalloc(work); > - else > - kasan_record_aux_stack(work); > + kasan_record_aux_stack(work); > } > > head = READ_ONCE(task->task_works); > diff --git a/kernel/workqueue.c b/kernel/workqueue.c > index 9949ffad8df09..65b8314b2d538 100644 > --- a/kernel/workqueue.c > +++ b/kernel/workqueue.c > @@ -2180,7 +2180,7 @@ static void insert_work(struct pool_workqueue *pwq, struct work_struct *work, > debug_work_activate(work); > > /* record the work call stack in order to print it in KASAN reports */ > - kasan_record_aux_stack_noalloc(work); > + kasan_record_aux_stack(work); > > /* we own @work, set data and link */ > set_work_pwq(work, pwq, extra_flags); > diff --git a/mm/kasan/generic.c b/mm/kasan/generic.c > index 6310a180278b6..b18b5944997f8 100644 > --- a/mm/kasan/generic.c > +++ b/mm/kasan/generic.c > @@ -521,7 +521,7 @@ size_t kasan_metadata_size(struct kmem_cache *cache, bool in_object) > sizeof(struct kasan_free_meta) : 0); > } > > -static void __kasan_record_aux_stack(void *addr, depot_flags_t depot_flags) > +void kasan_record_aux_stack(void *addr) > { > struct slab *slab = kasan_addr_to_slab(addr); > struct kmem_cache *cache; > @@ -538,17 +538,7 @@ static void __kasan_record_aux_stack(void *addr, depot_flags_t depot_flags) > return; > > alloc_meta->aux_stack[1] = alloc_meta->aux_stack[0]; > - alloc_meta->aux_stack[0] = kasan_save_stack(0, depot_flags); > -} > - > -void kasan_record_aux_stack(void *addr) > -{ > - return __kasan_record_aux_stack(addr, STACK_DEPOT_FLAG_CAN_ALLOC); > -} > - > -void kasan_record_aux_stack_noalloc(void *addr) > -{ > - return __kasan_record_aux_stack(addr, 0); > + alloc_meta->aux_stack[0] = kasan_save_stack(0, 0); > } > > void kasan_save_alloc_info(struct kmem_cache *cache, void *object, gfp_t flags) > diff --git a/mm/slub.c b/mm/slub.c > index 5b832512044e3..b8c4bf3fe0d07 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -2300,7 +2300,7 @@ bool slab_free_hook(struct kmem_cache *s, void *x, bool init, > * We have to do this manually because the rcu_head is > * not located inside the object. > */ > - kasan_record_aux_stack_noalloc(x); > + kasan_record_aux_stack(x); > > delayed_free->object = x; > call_rcu(&delayed_free->head, slab_free_after_rcu_debug); > -- > 2.45.2 >