From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 452F0C432C3 for ; Thu, 28 Nov 2019 13:44:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EFA9021789 for ; Thu, 28 Nov 2019 13:44:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="F4KgNdc8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EFA9021789 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 89B136B052D; Thu, 28 Nov 2019 08:44:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 824906B052E; Thu, 28 Nov 2019 08:44:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6EBAB6B052F; Thu, 28 Nov 2019 08:44:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0022.hostedemail.com [216.40.44.22]) by kanga.kvack.org (Postfix) with ESMTP id 56CA56B052D for ; Thu, 28 Nov 2019 08:44:53 -0500 (EST) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id 1D70C246E for ; Thu, 28 Nov 2019 13:44:53 +0000 (UTC) X-FDA: 76205806866.10.goat41_64cbd6627991b X-HE-Tag: goat41_64cbd6627991b X-Filterd-Recvd-Size: 6470 Received: from mail-oi1-f194.google.com (mail-oi1-f194.google.com [209.85.167.194]) by imf27.hostedemail.com (Postfix) with ESMTP for ; Thu, 28 Nov 2019 13:44:52 +0000 (UTC) Received: by mail-oi1-f194.google.com with SMTP id e9so23359421oif.8 for ; Thu, 28 Nov 2019 05:44:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Al/TthukP0WD7gRqj0XMop50I5kzb6OxLRnwHk14qyU=; b=F4KgNdc8CjNbL/CjyUqUqRSfFW5D2hLvcTnhh2L+RzkyRwJVL8OnvXF+C3gI9eJm0J q+r/49CmE71pn8ad4cS7erk8paRns0ibprhe025lhpoU/sq0Sd+3wsm9e+Kl9eY2JC/M +vuVwyU1DTdNS0dWWGhTtNnteBahaLzNvOEsGBEKaGjIxrMR2HFnYVD46rN6N14Dmw3u 6mdZpwXfdjosFxEzHhd+pgbTJnO/dXwKTqJIP2Q7Iusw1CCFmm6d6IR9YWaqiaCAqRuf YFsM/32awY0ANJlXJ/Vo7fio0ld/TcSLDK35f/JsCMof5DljH/mw86aXnNvlNcrLxQBo bc2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Al/TthukP0WD7gRqj0XMop50I5kzb6OxLRnwHk14qyU=; b=Jc0gLECkvOPPh6rTRBBFycrR70Oh0jYtLgq7A1f1q1Y3LKWaHUpGGJNqj3qlyFc+eC rZS0gQNDhy7IECnUBOfCvIzKAnzH00IC9jzyAlXgucK1IlaZ17hiX8w1IYD7ORpejbPb HI0rP4zQq7gnhaJYWawzwxsG6mToeFgGAC09uR1+8sEG52AjYAI1djbEYrrNwsoSOZxL YnAffS+zaWixYBatdGr8sTROLRnigMb9KWUQesAeJBcsPyKHJNrNvmlZ1Uj0izGl/rR0 o9qL9YZ4P/ZbmAV8cA6CwmTRFSbXyU5jKdcaQz+MHKDqzkgSUNePhv0G2NzY6Utf/f0t iyNg== X-Gm-Message-State: APjAAAXNqzI/z+vm8LofEX/oUcfIkppY5R9vbs7bGKHgKezT92gVVQAE GVKCmP5BLTzG5kqTS2M92GlnzCTEqeXz1PCDWGR6HQ== X-Google-Smtp-Source: APXvYqwGvVkxbHSTaECwzHUB9Yvd15deceZ9rXQj9PDSnZFleYrPM60nBE9YF49E+fqFhel7MYyJylzCRWM8AEsDRjM= X-Received: by 2002:aca:bf06:: with SMTP id p6mr5392737oif.121.1574948691381; Thu, 28 Nov 2019 05:44:51 -0800 (PST) MIME-Version: 1.0 References: <20191122112621.204798-1-glider@google.com> <20191122112621.204798-10-glider@google.com> In-Reply-To: <20191122112621.204798-10-glider@google.com> From: Marco Elver Date: Thu, 28 Nov 2019 14:44:40 +0100 Message-ID: Subject: Re: [PATCH RFC v3 09/36] kmsan: add KMSAN bits to struct page and struct task_struct To: Alexander Potapenko Cc: Jens Axboe , Andy Lutomirski , Vegard Nossum , Dmitry Vyukov , Christoph Hellwig , Linux Memory Management List , Al Viro , adilger.kernel@dilger.ca, Andrew Morton , Andrey Konovalov , Andrey Ryabinin , Ard Biesheuvel , Arnd Bergmann , hch@infradead.org, darrick.wong@oracle.com, davem@davemloft.net, dmitry.torokhov@gmail.com, Eric Biggers , Eric Dumazet , ericvh@gmail.com, gregkh@linuxfoundation.org, harry.wentland@amd.com, herbert@gondor.apana.org.au, iii@linux.ibm.com, mingo@elte.hu, jasowang@redhat.com, m.szyprowski@samsung.com, Mark Rutland , martin.petersen@oracle.com, schwidefsky@de.ibm.com, Matthew Wilcox , mst@redhat.com, Michal Simek , pmladek@suse.com, Qian Cai , Randy Dunlap , robin.murphy@arm.com, Sergey Senozhatsky , Steven Rostedt , tiwai@suse.com, tytso@mit.edu, Thomas Gleixner , gor@linux.ibm.com, wsa@the-dreams.de Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 22 Nov 2019 at 12:26, wrote: > > Each struct page now contains pointers to two struct pages holding KMSAN > metadata (shadow and origins) for the original struct page. > > Each task_struct contains a struct kmsan_task_state used to track the > metadata of function parameters and return values for that task. > > Signed-off-by: Alexander Potapenko > Cc: Jens Axboe > Cc: Andy Lutomirski > Cc: Vegard Nossum > Cc: Dmitry Vyukov > Cc: Christoph Hellwig > Cc: linux-mm@kvack.org > --- > > Change-Id: Ie329527e558dd60307fb88b2da151f7f4db951ac > --- > include/linux/mm_types.h | 9 +++++++++ > include/linux/sched.h | 5 +++++ > 2 files changed, 14 insertions(+) > > diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h > index 2222fa795284..c87c5416a802 100644 > --- a/include/linux/mm_types.h > +++ b/include/linux/mm_types.h > @@ -216,6 +216,15 @@ struct page { > not kmapped, ie. highmem) */ > #endif /* WANT_PAGE_VIRTUAL */ > > +#ifdef CONFIG_KMSAN > + /* > + * Bits in struct page are scarce, so the LSB in *shadow is used to > + * indicate whether the page should be ignored by KMSAN or not. > + */ > + struct page *shadow; > + struct page *origin; > +#endif > + > #ifdef LAST_CPUPID_NOT_IN_PAGE_FLAGS > int _last_cpupid; > #endif > diff --git a/include/linux/sched.h b/include/linux/sched.h > index 72b20f33c56e..ba705f66f78c 100644 > --- a/include/linux/sched.h > +++ b/include/linux/sched.h > @@ -15,6 +15,7 @@ > #include > #include > #include > +#include This file does not exist at this point in the series, and the build would fail for all configs. This can cause problems for 'git bisect' users etc. I would just merge this patch with patch 10. Thanks, -- Marco > #include > #include > #include > @@ -1173,6 +1174,10 @@ struct task_struct { > unsigned int kasan_depth; > #endif > > +#ifdef CONFIG_KMSAN > + struct kmsan_task_state kmsan; > +#endif > + > #ifdef CONFIG_FUNCTION_GRAPH_TRACER > /* Index of current stored address in ret_stack: */ > int curr_ret_stack; > -- > 2.24.0.432.g9d3f5f5b63-goog >