From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01EF8C433E0 for ; Wed, 13 Jan 2021 16:38:13 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 610A9235FA for ; Wed, 13 Jan 2021 16:38:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 610A9235FA Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7BB376B0164; Wed, 13 Jan 2021 11:38:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 76D1A8D006C; Wed, 13 Jan 2021 11:38:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 65A0B8D006A; Wed, 13 Jan 2021 11:38:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0161.hostedemail.com [216.40.44.161]) by kanga.kvack.org (Postfix) with ESMTP id 4843D6B0164 for ; Wed, 13 Jan 2021 11:38:12 -0500 (EST) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 067821EF1 for ; Wed, 13 Jan 2021 16:38:12 +0000 (UTC) X-FDA: 77701309224.16.mark67_35096672751f Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin16.hostedemail.com (Postfix) with ESMTP id CA65C100E6917 for ; Wed, 13 Jan 2021 16:38:11 +0000 (UTC) X-HE-Tag: mark67_35096672751f X-Filterd-Recvd-Size: 6588 Received: from mail-ot1-f44.google.com (mail-ot1-f44.google.com [209.85.210.44]) by imf31.hostedemail.com (Postfix) with ESMTP for ; Wed, 13 Jan 2021 16:38:11 +0000 (UTC) Received: by mail-ot1-f44.google.com with SMTP id x13so2454690oto.8 for ; Wed, 13 Jan 2021 08:38:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oHd/Kicf/hoH6eKoo5AC7GFnFGH61vMiUslEm8Z70PU=; b=Ezx3nAz4GFftYjCL/OWE0LNcnj3O/YpHc3uyjRkNy7pFQY24u8im6eAlP2bXOZTKUV uGmkoiiluZaE+w6gbmEf3EFHK2lJ6xqrnd+BCLL8RBaDEYZJTUv7HpEoXaCxjlnTOz8l NhYlz4mrmLSMuERImCeoMkWdn4zFpgxlbaxPiRJGUB5d+BKqfv781f7QXWUOMmZbC2Yc 5XpPbeCQTbJUKsjhohIeVMOiCaGgQ2Nl1eNrabb3sxNtgtuDF+2Y3HYPdeovHTu/REvG /Qp7q61QVO/UaNErP4h4Vi0foutnzdXW1qEELcBuOUfVnxUa/sbOf5l/j5q334nD2ZQT M2RA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oHd/Kicf/hoH6eKoo5AC7GFnFGH61vMiUslEm8Z70PU=; b=CpugGDOT63e5qy9pauNlitL7baa4obgPZh4jmRZUZ62d7Az3T1jUCjeBMU0QHE6yn4 qTuzAX+Wvd7ASd0RM2vKMA1mWoT8NBZwE1jT3iiRa6l5tnkJsCswVAnFG/zO+U4N26AX ORYxUrbRF1+tcX8GPyLnpU7YixDieAajaBoOtmORBC3o1NnG/1rOcx+pR+eSd6v8OgCK jtZUb16t/3Pt/ErSJS7xO8SkYv8n7734DDIDppgvvVAht4vpf/Q/EhwDh2v4DGTf6fxS eFKUD3N1KnxODELZOVY+L5HfV3nUvU1UaCwRkDf+OImMzScKT7Mpa1UFQyvcWBpvKvMS afrA== X-Gm-Message-State: AOAM532cnGUYD6ESe8OW8Q+A0tS25/GzP+Fsi1UXVvOGYS3pubZcRbiI aAooxGNc8R42PTyY2+Ds8H/9pf0RZOGuayA0UpLR+Q== X-Google-Smtp-Source: ABdhPJxrXHSavVkk4MhbxgsayCG8kXDnZrYMNzthFK9pismXNnoj6IT/K7Bk+lsQOwYAzgqMXlJ+EOZ/90qErfrlG4k= X-Received: by 2002:a05:6830:2413:: with SMTP id j19mr1858158ots.251.1610555890417; Wed, 13 Jan 2021 08:38:10 -0800 (PST) MIME-Version: 1.0 References: <0e994d67a05cbf23b3c6186a862b5d22cad2ca7b.1610554432.git.andreyknvl@google.com> In-Reply-To: <0e994d67a05cbf23b3c6186a862b5d22cad2ca7b.1610554432.git.andreyknvl@google.com> From: Marco Elver Date: Wed, 13 Jan 2021 17:37:58 +0100 Message-ID: Subject: Re: [PATCH v2 13/14] kasan: add a test for kmem_cache_alloc/free_bulk To: Andrey Konovalov Cc: Catalin Marinas , Vincenzo Frascino , Dmitry Vyukov , Alexander Potapenko , Andrew Morton , Will Deacon , Andrey Ryabinin , Peter Collingbourne , Evgenii Stepanov , Branislav Rankov , Kevin Brodsky , kasan-dev , Linux ARM , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 13 Jan 2021 at 17:22, Andrey Konovalov wrote: > > Add a test for kmem_cache_alloc/free_bulk to make sure there are now > false-positives when these functions are used. s/now/no/ (but by itself doesn't necessarily demand a v3) > Link: https://linux-review.googlesource.com/id/I2a8bf797aecf81baeac61380c567308f319e263d > Signed-off-by: Andrey Konovalov > --- > lib/test_kasan.c | 39 ++++++++++++++++++++++++++++++++++----- > 1 file changed, 34 insertions(+), 5 deletions(-) > > diff --git a/lib/test_kasan.c b/lib/test_kasan.c > index 5e3d054e5b8c..d9f9a93922d5 100644 > --- a/lib/test_kasan.c > +++ b/lib/test_kasan.c > @@ -479,10 +479,11 @@ static void kmem_cache_oob(struct kunit *test) > { > char *p; > size_t size = 200; > - struct kmem_cache *cache = kmem_cache_create("test_cache", > - size, 0, > - 0, NULL); > + struct kmem_cache *cache; > + > + cache = kmem_cache_create("test_cache", size, 0, 0, NULL); > KUNIT_ASSERT_NOT_ERR_OR_NULL(test, cache); > + > p = kmem_cache_alloc(cache, GFP_KERNEL); > if (!p) { > kunit_err(test, "Allocation failed: %s\n", __func__); > @@ -491,11 +492,12 @@ static void kmem_cache_oob(struct kunit *test) > } > > KUNIT_EXPECT_KASAN_FAIL(test, *p = p[size + OOB_TAG_OFF]); > + > kmem_cache_free(cache, p); > kmem_cache_destroy(cache); > } > > -static void memcg_accounted_kmem_cache(struct kunit *test) > +static void kmem_cache_accounted(struct kunit *test) > { > int i; > char *p; > @@ -522,6 +524,32 @@ static void memcg_accounted_kmem_cache(struct kunit *test) > kmem_cache_destroy(cache); > } > > +static void kmem_cache_bulk(struct kunit *test) > +{ > + struct kmem_cache *cache; > + size_t size = 200; > + size_t p_size = 10; s/p_size/ARRAY_SIZE(p)/ ? > + char *p[10]; > + bool ret; > + int i; > + > + cache = kmem_cache_create("test_cache", size, 0, 0, NULL); > + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, cache); > + > + ret = kmem_cache_alloc_bulk(cache, GFP_KERNEL, p_size, (void **)&p); > + if (!ret) { > + kunit_err(test, "Allocation failed: %s\n", __func__); > + kmem_cache_destroy(cache); > + return; > + } > + > + for (i = 0; i < p_size; i++) > + p[i][0] = p[i][size - 1] = 42; > + > + kmem_cache_free_bulk(cache, p_size, (void **)&p); > + kmem_cache_destroy(cache); > +} > + > static char global_array[10]; > > static void kasan_global_oob(struct kunit *test) > @@ -961,7 +989,8 @@ static struct kunit_case kasan_kunit_test_cases[] = { > KUNIT_CASE(kfree_via_page), > KUNIT_CASE(kfree_via_phys), > KUNIT_CASE(kmem_cache_oob), > - KUNIT_CASE(memcg_accounted_kmem_cache), > + KUNIT_CASE(kmem_cache_accounted), > + KUNIT_CASE(kmem_cache_bulk), > KUNIT_CASE(kasan_global_oob), > KUNIT_CASE(kasan_stack_oob), > KUNIT_CASE(kasan_alloca_oob_left), > -- > 2.30.0.284.gd98b1dd5eaa7-goog >