From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0971C4167D for ; Tue, 12 Dec 2023 09:33:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 39D2F6B02A5; Tue, 12 Dec 2023 04:33:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 34C2A6B02A7; Tue, 12 Dec 2023 04:33:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 215B16B02A8; Tue, 12 Dec 2023 04:33:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 0E6816B02A5 for ; Tue, 12 Dec 2023 04:33:27 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D29F98089E for ; Tue, 12 Dec 2023 09:33:26 +0000 (UTC) X-FDA: 81557653212.17.8ED1CA4 Received: from mail-ua1-f46.google.com (mail-ua1-f46.google.com [209.85.222.46]) by imf10.hostedemail.com (Postfix) with ESMTP id 1D94EC001B for ; Tue, 12 Dec 2023 09:33:24 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=UcdujHfZ; spf=pass (imf10.hostedemail.com: domain of elver@google.com designates 209.85.222.46 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702373605; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gsXSrEFfFqnsLGyUGm1rzVcPU2A/TTzMQTc9kn2e+Kg=; b=5vcRgSj2jb1g/wpoeCSKcbDESbHs4d3o0TSwzyDW4dCoI9JERpBXGFGAOEadz7R8G9HJ1s dI1amkmEGJj/5UUPWPbwuurXp5aUwyRb42vP8WuB0CmR8dbmUDErJ8QGk14rO4MJQIO3ca YSpBm+29Oh2U6h/x52a06kUN1Xzx+oc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702373605; a=rsa-sha256; cv=none; b=qm9UXeeLPHuGmGVzg2EwR8fqLk6+f6fJ/WxED6AeWA6OIZeAMotgzd3LG++IOkKxqWVfHE x1Hcu2f/U0rfk+jbU8dQOWlVuvf6ydZDvBpqCiyXbh9JR2daqb7WbP2koay9102KtHtpd0 zdwSYpBxlgMvqSlHCcGvhyrpxESdOK8= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=UcdujHfZ; spf=pass (imf10.hostedemail.com: domain of elver@google.com designates 209.85.222.46 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-ua1-f46.google.com with SMTP id a1e0cc1a2514c-7c8431b3d34so1312569241.3 for ; Tue, 12 Dec 2023 01:33:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1702373604; x=1702978404; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=gsXSrEFfFqnsLGyUGm1rzVcPU2A/TTzMQTc9kn2e+Kg=; b=UcdujHfZANa4Ql44XE5RT9X7sPv4VxOEhQJdjbDiEkckq4Gz+wD/6Tm+zf28z9GZak EStb8lJyPwhK7+HRdGHiCAdUr2rljaCtLUSr7NLT8RNHkiAK6HBeZXBiJlvjq/QZmWU/ RFmJsK2VYg8NRSzQXHiMaQ7Mxy8VlCwfxzAVOyzzlKQnjW9kyMJzd0mJCFBib55RFCpz jXiAYlAdfb23jjCtVxRdIAOQm3Kj1XkNMnI2+8bKHw+Qr5iY4puHJkqC/uB5lkqGmVpE k48XsrMBYiZaxKuOOe6063BtCTATePxNO8wjSOlEtJvimNIblxlsTzT011tTOlZeIg92 VFqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702373604; x=1702978404; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gsXSrEFfFqnsLGyUGm1rzVcPU2A/TTzMQTc9kn2e+Kg=; b=YCHrcItL5nLSQD0n1qEjsH4Bt94reELHrkgmH4iI1trwIwX+uYDDDrFg3iZKgGeB/g QyogVwSylwfjPF9LW0eMr95lSkyztR9tfc6t8xADQu0tp8l2r+6M2r5OiUhQkITnNCaV Ddn33DAJAOZA8zSmQ9kugFnrk08kY7OzZ9xzAIfPqgqWy2IyNUK7tWGHQrSOb3Gehxhb 7zENAAPT0pMJmnCKjs/thrgDt08Na6d9B1H4jQHvqBOpnuAKyxwNsJe7oUxVNMMe+io6 32nuWy3/N35ALzcZ5Hn3I533BrfRqERqr75uzfhlrAClk9YiIJkFQqsguSZQ/DMUdJ3I 7DOw== X-Gm-Message-State: AOJu0YxKa3xe3wmcWEvR6QIon75Ya2YPCEcD8YSzGJH/AzOPz55k55Rp FrZTHl9x2NAaIXUdx6hDEhJtjJRtuiu7uaL83e8g6Q== X-Google-Smtp-Source: AGHT+IHlXf7ufoX8iXosJ2Nva+E8Qq+/po5/QAYPJ2Cb40hg+ICo+pQLEugoyr6S8RABxkMFeoJMyIrjbdahPjoIXoc= X-Received: by 2002:a05:6102:e13:b0:464:6008:72cf with SMTP id o19-20020a0561020e1300b00464600872cfmr4421711vst.20.1702373603951; Tue, 12 Dec 2023 01:33:23 -0800 (PST) MIME-Version: 1.0 References: <20230505095805.759153de@gandalf.local.home> In-Reply-To: From: Marco Elver Date: Tue, 12 Dec 2023 10:32:45 +0100 Message-ID: Subject: Re: [PATCH v3 1/3] kasan: switch kunit tests to console tracepoints To: =?UTF-8?Q?Paul_Heidekr=C3=BCger?= Cc: Andrey Konovalov , Steven Rostedt , Peter Collingbourne , andrey.konovalov@linux.dev, Andrew Morton , Alexander Potapenko , Dmitry Vyukov , Andrey Ryabinin , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov , Masami Hiramatsu , linux-trace-kernel@vger.kernel.org, Nick Desaulniers Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: eo9bzp91cdep53ygbf1eiy467nxxx586 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 1D94EC001B X-Rspam-User: X-HE-Tag: 1702373604-473443 X-HE-Meta: U2FsdGVkX18pwgY7DnytHq/uwG2IxJR8f0M9wMovCxiIGywVmPiehrPkMV65MNEDrZ86vam86lqhbNHeHRZ1yr1e6AFFFrdCIiab2OrM19wLDjeQndlf51LCacNujzU0wEOgGRox9RSCuDHmdfI3CiD11rkIMEaTqPnbMCkc87OX+hfv+cUk8lAqjl/Mp4N8qdokeomGI5d2jtryupSoEavsccNvJWqz/KnieJNJZimH9mFsQ4tPDoJQMf6jPuNCDLmI04JgTXtllheGfQtEpRAL85eYTG1Ccf79GImCA63LOSkDHDwsFhAprcNQMshQdqjyJq0hwl9BM5y9maPzQ0QJJwKDhwyDhoAiwYp+fLlO5lthpX3DcVxEaw/V7/fUMRlKPFnBeGSfbTAAoUQ/DtsnpkndWEeo+HnuHfeC7zH2a16AihPsMyVkgREarpcXD/Zzv4oQMo9LsJHkUNvVX6PPu1DxOZFRCClHGN/NbL+jQuBIK+m96E2jN1FC05nojC/Hfol5/r8Rke8wic26RVdUha81vn/kCIgToxe6WBV8xFu3A/dQ8gbrUeo9U6udxPBL3yk2VpL8yYgfg9VsIJ3v1Z6MFf1OevGMe1rhXF+WlhFYValxxVGubrf24FmrGtmMOzEokNWB1EGyhE9o1xkStOGJKk/G7wO/DwoPXNyv7Gn49tTC1fdH0gcP5xkVG9yiFpiWV1sL8x4616lTos4vfpUVocATOZ1siWhHECWSxY0zW1hdyW0yTTlQCrs34IA9/IPll9hTH3fAxKF2P9ePqfeI7bX4Pn/qjXsP4CVPIT5ek/SoYTURRFVmpArM05BQD9wE31JuE+zNhushUVFUuJwkNtgJIQC1dggvCAp6vv+kfk7sMZlS7UVE+o7RWqHiWeV3XVar/vjgGoyT3SXJj6reIDh8eMwgKWTwgPdyzk7woOqaX162ySXQB79iF/deScxNQoVvSMyJZt9 FpT6rPZF izrVKLrC5yC2fWrufVDSTd0i5kDLQ817xiedNRwrtt23sRNgYdm44BXAmhUNoB2YLIHrXMF/J0JuLLshVAU1lhnY7cbX7ykdK4uqh8vuWcP2fnOFEr0tua7UFhUmzRPBkh6/VYDZfa1DYXebufxDwq0oH5vFqXYjkWTHy7FVkL4c+MdjL1ZtznpB+79e2Gb7RwkcaThjMdaxpR0MUfQY3ub/mqOxZ0lIG+qBmsXzbsx1XMi/twOhBr5GAw0Y1K7meIump95PfWxi75sluEZPVF7QgHoW2JJUDBPj/IaR1cCs1C98= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 12 Dec 2023 at 10:19, Paul Heidekr=C3=BCger wrote: > > On 12.12.2023 00:37, Andrey Konovalov wrote: > > On Tue, Dec 12, 2023 at 12:35=E2=80=AFAM Paul Heidekr=C3=BCger > > wrote: > > > > > > Using CONFIG_FTRACE=3Dy instead of CONFIG_TRACEPOINTS=3Dy produces th= e same error > > > for me. > > > > > > So > > > > > > CONFIG_KUNIT=3Dy > > > CONFIG_KUNIT_ALL_TESTS=3Dn > > > CONFIG_FTRACE=3Dy > > > CONFIG_KASAN=3Dy > > > CONFIG_KASAN_GENERIC=3Dy > > > CONFIG_KASAN_KUNIT_TEST=3Dy > > > > > > produces > > > > > > =E2=9E=9C ./tools/testing/kunit/kunit.py run --kunitconfig= =3Dmm/kasan/.kunitconfig --arch=3Darm64 > > > Configuring KUnit Kernel ... > > > Regenerating .config ... > > > Populating config with: > > > $ make ARCH=3Darm64 O=3D.kunit olddefconfig CC=3Dclang > > > ERROR:root:Not all Kconfig options selected in kunitconfig we= re in the generated .config. > > > This is probably due to unsatisfied dependencies. > > > Missing: CONFIG_KASAN_KUNIT_TEST=3Dy > > > > > > By that error message, CONFIG_FTRACE appears to be present in the gen= erated > > > config, but CONFIG_KASAN_KUNIT_TEST still isn't. Presumably, > > > CONFIG_KASAN_KUNIT_TEST is missing because of an unsatisfied dependen= cy, which > > > must be CONFIG_TRACEPOINTS, unless I'm missing something ... > > > > > > If I just generate an arm64 defconfig and select CONFIG_FTRACE=3Dy, > > > CONFIG_TRACEPOINTS=3Dy shows up in my .config. So, maybe this is kuni= t.py-related > > > then? > > > > > > Andrey, you said that the tests have been working for you; are you ru= nning them > > > with kunit.py? > > > > No, I just run the kernel built with a config file that I put together > > based on defconfig. > > Ah. I believe I've figured it out. > > When I add CONFIG_STACK_TRACER=3Dy in addition to CONFIG_FTRACE=3Dy, it w= orks. CONFIG_FTRACE should be enough - maybe also check x86 vs. arm64 to debug mo= re. > CONFIG_STACK_TRACER selects CONFIG_FUNCTION_TRACER, CONFIG_FUNCTION_TRACE= R > selects CONFIG_GENERIC_TRACER, CONFIG_GENERIC_TRACER selects CONFIG_TRACI= NG, and > CONFIG_TRACING selects CONFIG_TRACEPOINTS. > > CONFIG_BLK_DEV_IO_TRACE=3Dy also works instead of CONFIG_STACK_TRACER=3Dy= , as it > directly selects CONFIG_TRACEPOINTS. > > CONFIG_FTRACE=3Dy on its own does not appear suffice for kunit.py on arm6= 4. When you build manually with just CONFIG_FTRACE, is CONFIG_TRACEPOINTS enab= led? > I believe the reason my .kunitconfig as well as the existing > mm/kfence/.kunitconfig work on X86 is because CONFIG_TRACEPOINTS=3Dy is p= resent in > an X86 defconfig. > > Does this make sense? > > Would you welcome a patch addressing this for the existing > mm/kfence/.kunitconfig? > > I would also like to submit a patch for an mm/kasan/.kunitconfig. Do you = think > that would be helpful too? > > FWICT, kernel/kcsan/.kunitconfig might also be affected since > CONFIG_KCSAN_KUNIT_TEST also depends on CONFIG_TRACEPOITNS, but I would h= ave to > test that. That could be a third patch. I'd support figuring out the minimal config (CONFIG_FTRACE or something else?) that satisfies the TRACEPOINTS dependency. I always thought CONFIG_FTRACE ought to be the one config option, but maybe something changed. Also maybe one of the tracing maintainers can help untangle what's going on here. Thanks, -- Marco