From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0F81C6FA82 for ; Tue, 20 Sep 2022 19:10:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5C43C6B0072; Tue, 20 Sep 2022 15:10:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 573126B0073; Tue, 20 Sep 2022 15:10:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 41339940007; Tue, 20 Sep 2022 15:10:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 30AF46B0072 for ; Tue, 20 Sep 2022 15:10:21 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 0293D1401FF for ; Tue, 20 Sep 2022 19:10:20 +0000 (UTC) X-FDA: 79933404642.18.1DDF04B Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) by imf12.hostedemail.com (Postfix) with ESMTP id 94BE34001B for ; Tue, 20 Sep 2022 19:10:20 +0000 (UTC) Received: by mail-wm1-f45.google.com with SMTP id o20-20020a05600c4fd400b003b4a516c479so2374234wmq.1 for ; Tue, 20 Sep 2022 12:10:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=vhcZzgEgF161dV3JAs/7wiPgpLh5ucK8PQ1AhMND7Wk=; b=rY1HK3uJjfj2GdveigAJaHAIvNjngvON3srR39Y7URQ5VrSPuVK2+OL+P1leo7oifp 8mH6IEmU5/pSmHl3+nIG5/NKAbpvbMEKvahuQd7kzY8kOJFuZXzydRIUbp01/FXOXmTO v09Ja0htbn82UV8KqclijMQgPcAcOpgzEldfL1tFIhnjXR8TKuROgz/ylILhEOi9m4dU 6jyrbSOR0xR+JdlkjhSqouRZQUHs18haHauvkJbxDZPTu52OPy2+KcmgA9AcMRvOTo13 guJqDVErDp+7aWIsht+9yYFtlir2/WGbzfB6GHiJc7tY3ztIEyoQ1mc6mCLkp5cPf+DW nKkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=vhcZzgEgF161dV3JAs/7wiPgpLh5ucK8PQ1AhMND7Wk=; b=evZJMCwmbpiuBSmdgXHTenq7orPKQAMvq9orUOGtZAWdjRB0EympyACUBw0TW0XD0n JSux2Nr8ZEUyrpVcyHDXiKw+qywRVvIvSL0PfApITnf5/z9solO3Ye5yizAv+A4d5xdI 5qqfWG9FRZVWIDVuW1QEJBqbe/EXN968rNS6K7cvCGddAziccNjJU+Ga6pLlzDeJVae2 4i2dsKcd9tbzt1Ote/Tc5UyVK5iEexldIY55uMP7GwgjZiN/etNuW+p2CANSzaplnYAy jbZZ1VvAebGCrU6FLr2xHfLwaltXk5CjOB78CpB5FXhHeefTuuum/R+mSTSF5pIL/NTk EtVQ== X-Gm-Message-State: ACrzQf0mgTkhvdThN33oWKE28IcZ1lStQ42QoSsEJu78Yts/BoNAjc01 pVaNJuEd4IS5REXQLrBpdI+K15qMI9lB+XwhwiLCZQ== X-Google-Smtp-Source: AMsMyM5YLrNDLjj0aYNlMedK7bBKZqr8J7Gn+pvWfSVryamv7O2e1K7CVasBgn1HC6XCXWrFAL4K1mPXOWGK107wSBs= X-Received: by 2002:a05:600c:1d11:b0:3b4:7644:b788 with SMTP id l17-20020a05600c1d1100b003b47644b788mr3742800wms.114.1663701019260; Tue, 20 Sep 2022 12:10:19 -0700 (PDT) MIME-Version: 1.0 References: <576182d194e27531e8090bad809e4136953895f4.1663700262.git.andreyknvl@google.com> In-Reply-To: <576182d194e27531e8090bad809e4136953895f4.1663700262.git.andreyknvl@google.com> From: Marco Elver Date: Tue, 20 Sep 2022 21:09:42 +0200 Message-ID: Subject: Re: [PATCH mm] kasan: initialize read-write lock in stack ring To: andrey.konovalov@linux.dev Cc: Andrew Morton , Andrey Konovalov , Alexander Potapenko , Dmitry Vyukov , Andrey Ryabinin , kasan-dev@googlegroups.com, linux-mm@kvack.org, Yu Zhao , linux-kernel@vger.kernel.org, Andrey Konovalov Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663701020; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vhcZzgEgF161dV3JAs/7wiPgpLh5ucK8PQ1AhMND7Wk=; b=YcqpUJbtgcLwkrfXtRh1++qTQJgmKQR48uYKWGgcvdnSuj3yPQ9oP6/sdZBoSO0GXFctmH RTfBwcAQN5OVshf05y9Tk5B4O7rN1Og1J8W4F4u3ns4Dp8kAYrmYzArwgX3YdDvaOBeao8 Xjt40oN2oLXbNJR6Od9GJuaCgYoak7o= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=rY1HK3uJ; spf=pass (imf12.hostedemail.com: domain of elver@google.com designates 209.85.128.45 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663701020; a=rsa-sha256; cv=none; b=ewm3cbB7nVqkrN43iEm3SFnuQcJO9bm2llO9RLWAlnwN0sU8ZcMQF4L7TAuPRXuV92v0qN EMDdAndzP1yEf1YUPyIV0/pNP2WN/B+9w4qgEfknQC0x+L3FFrcEdxPKY3KVWG9viraUWZ AzMhA5zZ4ZY69w0dMAIt3pc/rA5AmiI= X-Rspam-User: Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=rY1HK3uJ; spf=pass (imf12.hostedemail.com: domain of elver@google.com designates 209.85.128.45 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspamd-Server: rspam04 X-Stat-Signature: yzendfwj31ijqq6p1kdxacj66npj8rit X-Rspamd-Queue-Id: 94BE34001B X-HE-Tag: 1663701020-15890 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 20 Sept 2022 at 20:58, wrote: > > From: Andrey Konovalov > > Use __RW_LOCK_UNLOCKED to initialize stack_ring.lock. > > Reported-by: Yu Zhao > Signed-off-by: Andrey Konovalov > > --- > > Andrew, could you please fold this patch into: > "kasan: implement stack ring for tag-based modes". > --- > mm/kasan/tags.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/mm/kasan/tags.c b/mm/kasan/tags.c > index 9d867cae1b7b..67a222586846 100644 > --- a/mm/kasan/tags.c > +++ b/mm/kasan/tags.c > @@ -36,7 +36,9 @@ DEFINE_STATIC_KEY_TRUE(kasan_flag_stacktrace); > /* Non-zero, as initial pointer values are 0. */ > #define STACK_RING_BUSY_PTR ((void *)1) > > -struct kasan_stack_ring stack_ring; > +struct kasan_stack_ring stack_ring = { > + .lock = __RW_LOCK_UNLOCKED(stack_ring.lock) > +}; Reviewed-by: Marco Elver > /* kasan.stacktrace=off/on */ > static int __init early_kasan_flag_stacktrace(char *arg) > -- > 2.25.1 >