From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 332B0C54EBD for ; Thu, 12 Jan 2023 11:35:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9DEA88E0003; Thu, 12 Jan 2023 06:35:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 98E708E0001; Thu, 12 Jan 2023 06:35:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 857C28E0003; Thu, 12 Jan 2023 06:35:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 73A418E0001 for ; Thu, 12 Jan 2023 06:35:16 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 534B2A05E2 for ; Thu, 12 Jan 2023 11:35:16 +0000 (UTC) X-FDA: 80345941032.19.A5106C7 Received: from mail-yb1-f174.google.com (mail-yb1-f174.google.com [209.85.219.174]) by imf16.hostedemail.com (Postfix) with ESMTP id B7729180014 for ; Thu, 12 Jan 2023 11:35:14 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=SmA+oCE6; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf16.hostedemail.com: domain of elver@google.com designates 209.85.219.174 as permitted sender) smtp.mailfrom=elver@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673523314; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sZdRy8QTItnLRyny4d2jEHrecgEcHxwrD4J8NtmTL7Y=; b=TVCvxL0hL2zZ6pn2QGaudtOb8ncdU3VHllHBEvpuNT3Xig/7n+MMVlizXD0u/qg+GX5JXM xu3BvbFAj6oGiVA/zzdm2puC0HrYQaqWsRQ7/n/PsPVKbFLHIkKpBxVS9u/AmhR5QGJPrH BTwJu5+FOai8r6NG70GvNcKh0EhYUdA= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=SmA+oCE6; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf16.hostedemail.com: domain of elver@google.com designates 209.85.219.174 as permitted sender) smtp.mailfrom=elver@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673523314; a=rsa-sha256; cv=none; b=5LjRJJMe6dzXi2rXDTRRaVuvg46oimjumEPgFmm6XtaYq4SIU91NufDlPgJHjBd56CSnEq JwG4PbzaGBgQiwPZ9jV/TqwrU+6T+cJxHI8MHNdCMnH9nSsRot3muLXQgGc6lb4hIV98gO yaHW4xkhh4TpsmY6LTLv/UPgbpn3cLo= Received: by mail-yb1-f174.google.com with SMTP id 16so18343283ybc.0 for ; Thu, 12 Jan 2023 03:35:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=sZdRy8QTItnLRyny4d2jEHrecgEcHxwrD4J8NtmTL7Y=; b=SmA+oCE6TuGwbe2Xxh1HHB85rLlmPcddh1Tg8ni226DuXlH4RYgHFgwTNjWnK+hIys wbwhICrZRvoXjfR3033PKcTsF5+Zb9yl2OcZDq6+Vu20nsMUgERxpMHaz9DsCCSsKds9 pKwALp0zEfZxMQRvR/NRnF8fYZRMmvKnPtuGfg2soZ4w4iSPkWisa0K2npbmQn0k0Dww Pil4sA0iEjKKxQE8Qa6pry2EJGIG2nXl/ag3OsJUo7wv/n5QfE8M7N4Sf+FFR2rZ2Dq5 l5jY0BDLbd1+KDAtPtTqIxjgWji5tWY6t307XezHRSS5amR7ZG7eMLg/9nnEv2/OpiJ6 9kAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=sZdRy8QTItnLRyny4d2jEHrecgEcHxwrD4J8NtmTL7Y=; b=IiKeJrN7OA6TaU22yyJiw73VqtOHGzyUNxJtL+opuhx3UNZtjFCJv39dc2tW45TpYL g9MHeKr/4gtH6cDrvmNgd9NXsrWghxcIP3/a2S4tm7w5nOB9YfYNZ5sZrPj2c+jveI+B nl+l1A136pfmMsoI7gDEMKCb+nMiBNr2b4XhewjRt9t+0i5zeYriMXSAAyQhli/7I5zA Ji+BDpA+KpVgvdeYIZwZhIacpwTNReFCGw7Rr9R0ky7sq/37OsPRmargj1SnXgV+RqSW KBr/eaRh1Y8c4TkR2dSi9/5R+MiLasqZbNi6zPcR/iPS4pWC/Qa6k7EiQZsXqq95RBEL RY/w== X-Gm-Message-State: AFqh2krsAPVgZTGELASHBjm29RXZ92WQqAaQb1MmgaPVi+j5llTFAr1B kEC+YpuzrVNTcm5/ud1i9g7jSUBiWDDJ04Nfi0cbRQ== X-Google-Smtp-Source: AMrXdXsKOjoo2EXnu3Tqsyki97VXA+55QinQw21cvlQPMGCjj8pLnIr5qWtWkgNPBXQn0krLQs14d6T11dXADaRCx4E= X-Received: by 2002:a5b:a90:0:b0:70b:87d5:4a73 with SMTP id h16-20020a5b0a90000000b0070b87d54a73mr5919340ybq.584.1673523313774; Thu, 12 Jan 2023 03:35:13 -0800 (PST) MIME-Version: 1.0 References: <20230112103147.382416-1-glider@google.com> In-Reply-To: <20230112103147.382416-1-glider@google.com> From: Marco Elver Date: Thu, 12 Jan 2023 12:34:37 +0100 Message-ID: Subject: Re: [PATCH] kmsan: silence -Wmissing-prototypes warnings To: Alexander Potapenko Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, peterz@infradead.org, mingo@redhat.com, dvyukov@google.com, linux-mm@kvack.org, kasan-dev@googlegroups.com, kernel test robot , Vlastimil Babka Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: B7729180014 X-Stat-Signature: bnja5eb43qcsrbubxpp8m1dme6jswpjo X-HE-Tag: 1673523314-56500 X-HE-Meta: U2FsdGVkX1+XiFFltQSSdW2nE39pbM/TlfvDNWw2UQMXdlYh3NAccAj92VbUOUYS/ADFdiV1hxanO0eZEGXKo4VYih2lKcblhFiunF/cgBu/Lo7qnGhnBGzLnDmbTVtV7aphdaMgmwsfnOJ7Q9WwSuKK6g8J6EXov0ofKJuBeTnv8jVq+2fLQO7z7PsVyPD69MYwX0NqNGVDqDAKFem5HMILaR+Ta9YjDUKqhv3WYSQVkV3Ive83ahDAM3dZV/P0S/1yKy1L1Wndw97vA7v8tG3A5BJpYAfNSX1QTQsquUSqCjTJNs7DSHu8eMUR4coo2eQPYhT8oPfQuNh5O42P2PzpCfcSx7EMhiZyz/40dVLKN2f3HVFQXXuWjKYm4Dsu/ucyG9v+vG91H+DwMJN5fJB/CxNuSTcRmeNR6eu1p854t6EEOBR15/c6Bc7Q1tNxqh0DXErEfSUb5N6ahdkTrSjq6khi5luf29cNut6R1i+dnEpLiOMC0tWF0I42MgXxbnjzAFaKdTQDJKO/I+5tKUPcSPSSkjSY0fOmyCQOjWofQM4of66vwUF3tV653WolxVr147ntIuwLmbKuaxZW3N4/WZHNc35XQ6bFK0aDw8PgZ4DjhYpawQfhf+w41xeaU8qbrqFo5nm1Cul/2n/E8on2m6UybRC1zfXf4KjCnJWxHIcIdnSWgqPlQYl0alAQ2WDKPhN7rUFybb1zGXOYqsV6mRPv4FdLZRRW16CcyjKZnuGtIWcrvR7Bs4+6LSC1XAlEGk92xJ06IhgyjEJMPtUuV1Mj1+/+Go5mnWPLyDruLExGwK83TFCHw2Q3rEsrcSFfkSqHScRjJmskvO8pSU5sVMJgKv0U1WpFBjpMNUZLFkSf6GUDk0iUeaqGGc7hUXQPw1GIAkI9xV3maEmBxTds4iP5M0a2SDAZPJStaxmPcAb36qde5RC6cJaoTW3rZBugc5YB7qAe3qZTlUG 2Sm+dIun 97NvCKYW82/YoLv0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 12 Jan 2023 at 11:31, Alexander Potapenko wrote: > > When building the kernel with W=1, the compiler reports numerous > warnings about the missing prototypes for KMSAN instrumentation hooks. > > Because these functions are not supposed to be called explicitly by the > kernel code (calls to them are emitted by the compiler), they do not > have to be declared in the headers. Instead, we add forward declarations > right before the definitions to silence the warnings produced by > -Wmissing-prototypes. > > Reported-by: kernel test robot > Link: https://lore.kernel.org/lkml/202301020356.dFruA4I5-lkp@intel.com/T/ > Reported-by: Vlastimil Babka > Suggested-by: Marco Elver > Signed-off-by: Alexander Potapenko Reviewed-by: Marco Elver > --- > mm/kmsan/instrumentation.c | 23 +++++++++++++++++++++++ > 1 file changed, 23 insertions(+) > > diff --git a/mm/kmsan/instrumentation.c b/mm/kmsan/instrumentation.c > index 770fe02904f36..cf12e9616b243 100644 > --- a/mm/kmsan/instrumentation.c > +++ b/mm/kmsan/instrumentation.c > @@ -38,7 +38,15 @@ get_shadow_origin_ptr(void *addr, u64 size, bool store) > return ret; > } > > +/* > + * KMSAN instrumentation functions follow. They are not declared elsewhere in > + * the kernel code, so they are preceded by prototypes, to silence > + * -Wmissing-prototypes warnings. > + */ > + > /* Get shadow and origin pointers for a memory load with non-standard size. */ > +struct shadow_origin_ptr __msan_metadata_ptr_for_load_n(void *addr, > + uintptr_t size); > struct shadow_origin_ptr __msan_metadata_ptr_for_load_n(void *addr, > uintptr_t size) > { > @@ -47,6 +55,8 @@ struct shadow_origin_ptr __msan_metadata_ptr_for_load_n(void *addr, > EXPORT_SYMBOL(__msan_metadata_ptr_for_load_n); > > /* Get shadow and origin pointers for a memory store with non-standard size. */ > +struct shadow_origin_ptr __msan_metadata_ptr_for_store_n(void *addr, > + uintptr_t size); > struct shadow_origin_ptr __msan_metadata_ptr_for_store_n(void *addr, > uintptr_t size) > { > @@ -59,12 +69,16 @@ EXPORT_SYMBOL(__msan_metadata_ptr_for_store_n); > * with fixed size. > */ > #define DECLARE_METADATA_PTR_GETTER(size) \ > + struct shadow_origin_ptr __msan_metadata_ptr_for_load_##size( \ > + void *addr); \ > struct shadow_origin_ptr __msan_metadata_ptr_for_load_##size( \ > void *addr) \ > { \ > return get_shadow_origin_ptr(addr, size, /*store*/ false); \ > } \ > EXPORT_SYMBOL(__msan_metadata_ptr_for_load_##size); \ > + struct shadow_origin_ptr __msan_metadata_ptr_for_store_##size( \ > + void *addr); \ > struct shadow_origin_ptr __msan_metadata_ptr_for_store_##size( \ > void *addr) \ > { \ > @@ -86,6 +100,7 @@ DECLARE_METADATA_PTR_GETTER(8); > * entering or leaving IRQ. We omit the check for kmsan_in_runtime() to ensure > * the memory written to in these cases is also marked as initialized. > */ > +void __msan_instrument_asm_store(void *addr, uintptr_t size); > void __msan_instrument_asm_store(void *addr, uintptr_t size) > { > unsigned long ua_flags; > @@ -138,6 +153,7 @@ static inline void set_retval_metadata(u64 shadow, depot_stack_handle_t origin) > } > > /* Handle llvm.memmove intrinsic. */ > +void *__msan_memmove(void *dst, const void *src, uintptr_t n); > void *__msan_memmove(void *dst, const void *src, uintptr_t n) > { > depot_stack_handle_t origin; > @@ -162,6 +178,7 @@ void *__msan_memmove(void *dst, const void *src, uintptr_t n) > EXPORT_SYMBOL(__msan_memmove); > > /* Handle llvm.memcpy intrinsic. */ > +void *__msan_memcpy(void *dst, const void *src, uintptr_t n); > void *__msan_memcpy(void *dst, const void *src, uintptr_t n) > { > depot_stack_handle_t origin; > @@ -188,6 +205,7 @@ void *__msan_memcpy(void *dst, const void *src, uintptr_t n) > EXPORT_SYMBOL(__msan_memcpy); > > /* Handle llvm.memset intrinsic. */ > +void *__msan_memset(void *dst, int c, uintptr_t n); > void *__msan_memset(void *dst, int c, uintptr_t n) > { > depot_stack_handle_t origin; > @@ -217,6 +235,7 @@ EXPORT_SYMBOL(__msan_memset); > * uninitialized value to memory. When reporting an error, KMSAN unrolls and > * prints the whole chain of stores that preceded the use of this value. > */ > +depot_stack_handle_t __msan_chain_origin(depot_stack_handle_t origin); > depot_stack_handle_t __msan_chain_origin(depot_stack_handle_t origin) > { > depot_stack_handle_t ret = 0; > @@ -237,6 +256,7 @@ depot_stack_handle_t __msan_chain_origin(depot_stack_handle_t origin) > EXPORT_SYMBOL(__msan_chain_origin); > > /* Poison a local variable when entering a function. */ > +void __msan_poison_alloca(void *address, uintptr_t size, char *descr); > void __msan_poison_alloca(void *address, uintptr_t size, char *descr) > { > depot_stack_handle_t handle; > @@ -272,6 +292,7 @@ void __msan_poison_alloca(void *address, uintptr_t size, char *descr) > EXPORT_SYMBOL(__msan_poison_alloca); > > /* Unpoison a local variable. */ > +void __msan_unpoison_alloca(void *address, uintptr_t size); > void __msan_unpoison_alloca(void *address, uintptr_t size) > { > if (!kmsan_enabled || kmsan_in_runtime()) > @@ -287,6 +308,7 @@ EXPORT_SYMBOL(__msan_unpoison_alloca); > * Report that an uninitialized value with the given origin was used in a way > * that constituted undefined behavior. > */ > +void __msan_warning(u32 origin); > void __msan_warning(u32 origin) > { > if (!kmsan_enabled || kmsan_in_runtime()) > @@ -303,6 +325,7 @@ EXPORT_SYMBOL(__msan_warning); > * At the beginning of an instrumented function, obtain the pointer to > * `struct kmsan_context_state` holding the metadata for function parameters. > */ > +struct kmsan_context_state *__msan_get_context_state(void); > struct kmsan_context_state *__msan_get_context_state(void) > { > return &kmsan_get_context()->cstate; > -- > 2.39.0.314.g84b9a713c41-goog >