From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44569C433FE for ; Wed, 23 Feb 2022 23:35:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C53048D0003; Wed, 23 Feb 2022 18:35:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C29088D0001; Wed, 23 Feb 2022 18:35:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ACA478D0003; Wed, 23 Feb 2022 18:35:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0216.hostedemail.com [216.40.44.216]) by kanga.kvack.org (Postfix) with ESMTP id 845218D0001 for ; Wed, 23 Feb 2022 18:35:45 -0500 (EST) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 1C622181951DE for ; Wed, 23 Feb 2022 23:35:45 +0000 (UTC) X-FDA: 79175654250.24.17816F5 Received: from mail-yw1-f181.google.com (mail-yw1-f181.google.com [209.85.128.181]) by imf30.hostedemail.com (Postfix) with ESMTP id 939F980002 for ; Wed, 23 Feb 2022 23:35:44 +0000 (UTC) Received: by mail-yw1-f181.google.com with SMTP id 00721157ae682-2d07c4a0d06so6661927b3.13 for ; Wed, 23 Feb 2022 15:35:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=thOSbRDXMSWEe7zpjS3HEOJEuojyPix5lNBQyOalrFA=; b=kXBeL+3UeKaErZtrfUujSN7sJ2H6imMH32gDw3JIIT7a6J2nKg52sY05pBNozH2tcH jNQc5H3uZVqcxtdZ6S9aLrlGiB0O5WsBJaiyU5DBHUE1zk4LxcBaY1Pw11zdheqK1tnK rQ4wSRtNvn7DdrOW/O6iUOTTXxFkkNelw9GlQ+gMRlVUoFw28/dNbpSVwVo4spgp7K6c PcoKUTacLMbjSWCm6QUn2l4FtyNj9Bc3sacWKkKiCdn/kHe6numf+Kc5XkqtpJTxGZHs WWCRQTZ42wnejb6xmmebnXq4J+4LXI5ieknHlzxVzLJ+ieJPtq7m7m1IDAGDyK6LwSrz QJ7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=thOSbRDXMSWEe7zpjS3HEOJEuojyPix5lNBQyOalrFA=; b=M+WvcSkpWj/1kuEiFycS/OaR73UgudRthpzXrGZF72E+m4F9gwUtEB+objKEy/nWdo JVrT1nci8+4zooE4EX5GVZ64qhXviEun18t2+aF3MzHCj//3mnERTOn8tAXJcHMNNUfM 6FOTvyM9ShOG2rbKtEK54ug941xHRgu57U80cdlyzwy+rkqT4BLqYLQX5GYWiupJ33Yq zKqcOAG/WkFtPhLCIvkar2vpj8xmyHfAf0SvFRhBuuTj/aW0atHLH81wnT2S7f0PzYjN 7ODtqRHC7MTk2j6nRDFA5Dzx/o2P2Q2RGE7kP9ayiEnpWeLMOwclLRPLgvUo7IY7wUlr 418w== X-Gm-Message-State: AOAM5318l+TdbhclS5w9euSxf2/K4aU62269c8AgkiiDwXNHwyKoohOy NDj7ZQEChyHgNsBzRy4r3N5M836tr/4kubzQoyM2kw== X-Google-Smtp-Source: ABdhPJwbVPd7qT77NHlk8V4oWlEXIgmOyfJu7gQ03AREf4rQdIni83XRcufA5aZlf62+GYl8OF6Af0CHpB+Ne4lTEg0= X-Received: by 2002:a81:1a49:0:b0:2d7:fc73:dab2 with SMTP id a70-20020a811a49000000b002d7fc73dab2mr9323ywa.316.1645659343393; Wed, 23 Feb 2022 15:35:43 -0800 (PST) MIME-Version: 1.0 References: <20220219012433.890941-1-pcc@google.com> <7a6afd53-a5c8-1be3-83cc-832596702401@huawei.com> In-Reply-To: From: Marco Elver Date: Thu, 24 Feb 2022 00:35:32 +0100 Message-ID: Subject: Re: [PATCH] kasan: update function name in comments To: Peter Collingbourne Cc: Miaohe Lin , Andrew Morton , Linux Memory Management List , Andrey Konovalov , kasan-dev , LKML , Sasha Levin Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 939F980002 X-Rspam-User: Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=kXBeL+3U; spf=pass (imf30.hostedemail.com: domain of elver@google.com designates 209.85.128.181 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com X-Stat-Signature: 1tf4qynzgzo3oogz5dsngnbn66pnumer X-HE-Tag: 1645659344-824418 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 23 Feb 2022 at 23:31, Peter Collingbourne wrote: [...] > > > > Link: https://linux-review.googlesource.com/id/I20faa90126937bbee77d9d44709556c3dd4b40be > > > > Signed-off-by: Peter Collingbourne > > > > Fixes: e5f4728767d2 ("kasan: test: add globals left-out-of-bounds test") > > > > > > This Fixes tag is unneeded. > > > > > > Except the above nit, this patch looks good to me. Thanks. > > > > > > Reviewed-by: Miaohe Lin > > > > Reviewed-by: Marco Elver > > > > And yes, the Fixes tag should be removed to not have stable teams do > > unnecessary work. > > I thought that Cc: stable@vger.kernel.org controlled whether the patch > is to be taken to the stable kernel and Fixes: was more of an > informational tag. At least that's what this seems to say: > https://www.kernel.org/doc/html/latest/process/submitting-patches.html#reviewer-s-statement-of-oversight These days patches that just have a Fixes tag (and no Cc: stable) will be auto-picked in many (most?) cases (by empirical observation). I think there were also tree-specific variances of this policy, but am not sure anymore. What is the latest policy? > > +Cc'ing missing mailing lists (use get_maintainers.pl - in particular, > > LKML is missing, which should always be Cc'd for archival purposes so > > that things like b4 can work properly). > > get_maintainers.pl tends to list a lot of reviewers so I try to filter > it to only the most important recipients or only use it for > "important" patches (like the uaccess logging patch). It's also a bit > broken in my workflow -- > https://lore.kernel.org/all/20210913233435.24585-1-pcc@google.com/ > fixes one of the problems but there are others. That's fair. It just seemed that something went wrong given kasan-dev@googlegroups.com wasn't Cc'd. FWIW, syzbot uses 'get_maintainer.pl --git-min-percent=20' which is a bit less aggressive with Cc'ing folks not mentioned explicitly in MAINTAINERS. > Doesn't b4 scan all the mailing lists? So I'd have imagined it > wouldn't matter which one you send it to. Those under lore.kernel.org or lists.linux.dev. Seems linux-mm does get redirected to lore: https://lore.kernel.org/linux-mm/ -- It's not entirely obvious which are lore managed and which aren't (obviously things like kasan-dev@googlegroups.com aren't).