From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB4DEC2B9F4 for ; Mon, 28 Jun 2021 06:01:26 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4E224610E5 for ; Mon, 28 Jun 2021 06:01:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4E224610E5 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8BC1F8D001E; Mon, 28 Jun 2021 02:01:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 86CAB8D0016; Mon, 28 Jun 2021 02:01:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6C05D8D001E; Mon, 28 Jun 2021 02:01:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0032.hostedemail.com [216.40.44.32]) by kanga.kvack.org (Postfix) with ESMTP id 38C508D0016 for ; Mon, 28 Jun 2021 02:01:25 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 2CAF214551 for ; Mon, 28 Jun 2021 06:01:25 +0000 (UTC) X-FDA: 78302085330.06.D0E4823 Received: from mail-oi1-f175.google.com (mail-oi1-f175.google.com [209.85.167.175]) by imf02.hostedemail.com (Postfix) with ESMTP id D87C54202A23 for ; Mon, 28 Jun 2021 06:01:24 +0000 (UTC) Received: by mail-oi1-f175.google.com with SMTP id w127so20767700oig.12 for ; Sun, 27 Jun 2021 23:01:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3eoMbUJoUpBqjeLK9yBay7/GW88cz7V1P5CryiYnRUc=; b=J8O8csduHCymdY8XfO0RVZLJRr4hRLUgwxNepl6Atq+rB0+W5XLcelj4QYEBXC1n9d GF0w2QcynCMaGY+VzxfLV4K8Uu/SqweIeov3c3s9iHIyee7wiZ0WDSJrpYUax6SDiQg+ kLj+6ijATACxk6+1ulRD0hZL3G5VwYOGVQ07Mh19QqyolZpf/QwRj9FwW2cyqc+K2Nu9 7x9TPZtuoivyd/9GsmW3q5uCut1l8StFHe5oHgix4JKmZsnOsFBaWIzkFccKukwiGi8U GNrLydbyjRXaBaIgo5GzNDp7lSxj2245oVXqbgmyNlXAq5qO7Zy+MUz7S3JbLdic6Vp7 065Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3eoMbUJoUpBqjeLK9yBay7/GW88cz7V1P5CryiYnRUc=; b=BFtYlDWzp+i/thOdy60jrZPJHkgkHawmdIlVxlCd/Rs3rdAEeMhIu7wHJkiHfNjXjF OjM6aVguKdSoHwoBOfqcb0uXBobOyEKIPNEue5GuOFNQZ8KrWVjQSAZCe01kJxUmLqSS uKijF3/ZbQWxLdkpX6XZKUVr00LcnxkdzhHOWgtfAo/RUTMUbT/JHBwhADAlqylXt6GJ FFfL8+c6+zLRRSRUq20gv03DmKXqcBR/Uj9f/2T8/zIZALCjcFCDjaNt3q2ntpQkJ4OM Nix9MW7kGBrDFxor9dUbnS+QxUKi9gC/N/rb+WWnJO9epmNjvlJYi8mmgQm7qGLxwFrG Ow4A== X-Gm-Message-State: AOAM5338FYg5jnoDL4s1Fl9GQDzs6k0Y8V+nDkKPjEpqqRSEwgOkzxws wLJjfXmQqfIGPMYNjsKL1ttr+kBLWEOFiA0+R/N//Q== X-Google-Smtp-Source: ABdhPJzsU3jCobviaf98Fdqeq3OWjtnCAdAy7cMWzNILO5gKNRlbIaIlW8OeNQH7gdmWmGmtmuZWOcB52mJfeobr3Cs= X-Received: by 2002:aca:ba06:: with SMTP id k6mr16233354oif.70.1624860084112; Sun, 27 Jun 2021 23:01:24 -0700 (PDT) MIME-Version: 1.0 References: <20210626100931.22794-1-Kuan-Ying.Lee@mediatek.com> <20210626100931.22794-4-Kuan-Ying.Lee@mediatek.com> In-Reply-To: <20210626100931.22794-4-Kuan-Ying.Lee@mediatek.com> From: Marco Elver Date: Mon, 28 Jun 2021 08:00:00 +0200 Message-ID: Subject: Re: [PATCH v4 3/3] kasan: add memory corruption identification support for hardware tag-based mode To: Kuan-Ying Lee Cc: Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Andrew Morton , Matthias Brugger , kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, wsd_upstream@mediatek.com, chinwen.chang@mediatek.com, nicholas.tang@mediatek.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: D87C54202A23 X-Stat-Signature: fj64wfc5pachprwyurin9xbqhkuo6kic Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20161025 header.b=J8O8csdu; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf02.hostedemail.com: domain of elver@google.com designates 209.85.167.175 as permitted sender) smtp.mailfrom=elver@google.com X-HE-Tag: 1624860084-243239 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, 26 Jun 2021 at 12:09, Kuan-Ying Lee wrote: > > Add memory corruption identification support for hardware tag-based > mode. We store one old free pointer tag and free backtrace instead > of five because hardware tag-based kasan only has 16 different tags. > > If we store as many stacks as SW tag-based kasan does(5 stacks), > there is high probability to find the same tag in the stacks when > out-of-bound issues happened and we will mistake out-of-bound > issue for use-after-free. > > Signed-off-by: Kuan-Ying Lee > Suggested-by: Marco Elver > Reviewed-by: Alexander Potapenko > Reviewed-by: Andrey Konovalov > Cc: Andrey Ryabinin > Cc: Dmitry Vyukov > Cc: Andrew Morton Reviewed-by: Marco Elver > --- > lib/Kconfig.kasan | 2 +- > mm/kasan/kasan.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/Kconfig.kasan b/lib/Kconfig.kasan > index fdb4a08dba83..1e2d10f86011 100644 > --- a/lib/Kconfig.kasan > +++ b/lib/Kconfig.kasan > @@ -169,7 +169,7 @@ config KASAN_STACK > > config KASAN_TAGS_IDENTIFY > bool "Enable memory corruption identification" > - depends on KASAN_SW_TAGS > + depends on KASAN_SW_TAGS || KASAN_HW_TAGS > help > This option enables best-effort identification of bug type > (use-after-free or out-of-bounds) at the cost of increased > diff --git a/mm/kasan/kasan.h b/mm/kasan/kasan.h > index 952df2db7fdd..f58672f6029a 100644 > --- a/mm/kasan/kasan.h > +++ b/mm/kasan/kasan.h > @@ -153,7 +153,7 @@ struct kasan_track { > depot_stack_handle_t stack; > }; > > -#ifdef CONFIG_KASAN_TAGS_IDENTIFY > +#if defined(CONFIG_KASAN_TAGS_IDENTIFY) && defined(CONFIG_KASAN_SW_TAGS) > #define KASAN_NR_FREE_STACKS 5 > #else > #define KASAN_NR_FREE_STACKS 1 > -- > 2.18.0