From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BD11C4332F for ; Mon, 11 Dec 2023 22:57:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BFE8F6B0250; Mon, 11 Dec 2023 17:57:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B86546B0252; Mon, 11 Dec 2023 17:57:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A4DD76B0253; Mon, 11 Dec 2023 17:57:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 92DE66B0250 for ; Mon, 11 Dec 2023 17:57:19 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 624431A0809 for ; Mon, 11 Dec 2023 22:57:19 +0000 (UTC) X-FDA: 81556050198.19.B205B15 Received: from mail-ua1-f48.google.com (mail-ua1-f48.google.com [209.85.222.48]) by imf09.hostedemail.com (Postfix) with ESMTP id 999A014000F for ; Mon, 11 Dec 2023 22:57:17 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=gRWoqYw0; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf09.hostedemail.com: domain of elver@google.com designates 209.85.222.48 as permitted sender) smtp.mailfrom=elver@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702335437; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VkXKnEfT8eKc5Yh5rOydAPt9sQ7NUY597Q2G+9UH8MI=; b=rTXieJ/pnqrMhYO2uR48N37pph7XGJ206lVqWiwTkQQHS3ctqZ5rBrBHwqQkrbGdMYgiOP CbdacjgRh/uYdQaeQaNQ2NRyAiqjjsS99IR+Q3PbqIY961+UD7756DRByapkeG7RKxOFsp fV8RiF5GKcEwdiZxToZ9t5cROuRkLGs= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=gRWoqYw0; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf09.hostedemail.com: domain of elver@google.com designates 209.85.222.48 as permitted sender) smtp.mailfrom=elver@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702335437; a=rsa-sha256; cv=none; b=aAut5yLFwk6y+nn5OKEE7fAYQVByyeRuYe1htOrT9SUDPcZdhBoJo4RisDIjr7pLa4DTus AK7JX8xYd70JyfvzpB3OxhNOb4JRhkJEzu8C9NcSNsRrgBtcpR8pQ9n9eh5fezAs6igqyK xt8abOVECb1I/kQV9SsRj+vjUqNzmFw= Received: by mail-ua1-f48.google.com with SMTP id a1e0cc1a2514c-7c5639267ebso1145973241.0 for ; Mon, 11 Dec 2023 14:57:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1702335436; x=1702940236; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=VkXKnEfT8eKc5Yh5rOydAPt9sQ7NUY597Q2G+9UH8MI=; b=gRWoqYw0CBWJp4CCDfJgMTNePQETamsSaaGkAQdq12ue3mOllhutHrfy9zoVbS6oLh JMDLJ5FNK52yFEzkAkKpYXqcJZQEaVGThQNl4dzi9PF90sNfJ+txhNc1TPHQJiYEBNZY m9hz/p20n82lFuGi+MNh77v93RLz9q/BY1ZtTwCpydaGaRWTZd0wJ7k0oB74D059ClDk 8yVd11T0hOLz2kwGu5u3RmhLgN3Ug6rxXvP+EY8tjrNb3a6tx6otDbxdNs+Z9W/yiUfM xEXwzhrntbyZsmkGCMuxxml8rlrmJ/LmzY1u+CPGDLt7iC3ko6gY0U5T3DmfLYNwqkls Lm+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702335436; x=1702940236; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VkXKnEfT8eKc5Yh5rOydAPt9sQ7NUY597Q2G+9UH8MI=; b=UX8kUWtaTub+bBgrg94JcLt4BExBEl6mR31EpS+5LgrnBAZD6yptRuPgc5xQvryyGq NTGFYDbbmj9+W9S1ApmWcNI8zXTDTLip0Zar6LljpnC9Yu52HOnGnLMZS7qRAofGxqLZ qLG3UF4iky+lq721Q+QCnmviBfh+sHrPNNos9cqWEAOW1i/7WejsHBc0n+GfRNWpLgZW PiquwcPEnwIVJyelHL2+22YBkUpTqos3g8Mh1hZcveQrpLt65EVDU6A6wR28JnAWoExC iVdtYEEvDo/w11nU0MFsdcIb8fAtZsA1EjfVMEkWuLbtxabji1pMJRpB5szs55Fc2rZ0 sjIA== X-Gm-Message-State: AOJu0YzEF7a3emxyCiwzf45qQv5EFcKTFOo7XwlpYURoQEGhcGhbPq/x b5ceuf9P7C6oaTsxIOWJTwVkcV7PrZeu41an4WfOfg== X-Google-Smtp-Source: AGHT+IE2xtn4pdHDL5Lsao1xivD+gQkdLWb1Ukglk33Rvsu/8sJpEoK/GIG0VTF0ZL+Ihg0qHAqGLharR2cgxinzA7Q= X-Received: by 2002:a05:6102:38cd:b0:464:811a:9ef9 with SMTP id k13-20020a05610238cd00b00464811a9ef9mr3502893vst.17.1702335436511; Mon, 11 Dec 2023 14:57:16 -0800 (PST) MIME-Version: 1.0 References: <20230215143306.2d563215@rorschach.local.home> <20230505095805.759153de@gandalf.local.home> In-Reply-To: From: Marco Elver Date: Mon, 11 Dec 2023 23:56:37 +0100 Message-ID: Subject: Re: [PATCH v3 1/3] kasan: switch kunit tests to console tracepoints To: =?UTF-8?Q?Paul_Heidekr=C3=BCger?= Cc: Andrey Konovalov , Steven Rostedt , Peter Collingbourne , andrey.konovalov@linux.dev, Andrew Morton , Alexander Potapenko , Dmitry Vyukov , Andrey Ryabinin , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov , Masami Hiramatsu , linux-trace-kernel@vger.kernel.org, Nick Desaulniers Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: tjbgxwehfbiqqps9d1oqhczwst6wzmxs X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 999A014000F X-HE-Tag: 1702335437-911941 X-HE-Meta: U2FsdGVkX1+31xsHeAwO9s1tHsqnWyKb5CgTmqjBbaPJSISQ9k0nNb7tP/X23eJEJFNDspSnB8N6oRmB8e8/MNIZooGVzm2m4nOAFBt2D6vdBIUL98PbsGHbKo+K2FC3gFIw4hruc3t4ONdTjSN1nwdsvIuCZGBKDtF7TE7EJAYbLfrcu4W/a2nk/Du6QLiqvjGeaoUOWQQ20keM79c1X1ccpgicWd3p9zUWVlwSoNh1kKJD6OE8Os/Zgggxuf/8RUFSitaEFx88K4TcXADjKK4Fwsv94f6EtAzqBKfgN16KLwm21Rt9BQlYQ7B4pVWSXPVaQ5swSo2O61OvhalFqDFfaBAF2l5dhZ+Y+v8JqffkkFMKsL5raHLN2IAZP4vp+YQY5y5ojL0/mb13cMN0WNG/KyoG4CgNhZBqmdMmjeyHIkiXcBz05/nsNn7yeVbdglqf6n2bFIncVKFYpXsINz278t/n4zM8uU7kXV8n+8dLgHbMRBczDpBksxusYw0CNPOkloh3wZ6/a1KssSexBWh4OhcdIjYAX2AhtjHPbJtH4nTQATY1AsH5gfJxVmHHdeVZFuGInXubgfDUUhcfzxMgfmTWI+AjHEMGo1tUkl0WS1qnsHiWUJsdDxP0eFni+0cMH1pyLIFmweGzHsvZ0dVwFKK0MvQe8GGm/JU8yj+ie9xMswhLXmIyrDcHpctubFAF+IwDray8sKtA1uwfmQy5ZW0xOVdhDNT4C3x+DA++9C6UozZjApSNedoSzoW5jb8s/umOujaIy5otGbYMePFq75ZHyuZm+Fzy9i/ecrnvdZfbydYTnBskc4Uon85L+CWdYDosmhB49RQYVdALMXrOrtr1R5/uj1cnNoGH8TVpwKVg/dvueDxXu3AiBgBn5dKaxBT9TCucAVhH8qaEAMHeGkcnzrJ07GoTFQd2nktsc0lOC82pkt12ne74RQV0iZ2UzR38WN1i0SGkSQB 2SC1ZvtS zhX+45bLdb1MhzUbu9NFhxl3H97cxyCGOlg5Krqumpr3bBn68qEdxuvkcyReYvz9RIUlz8GJmgLbNDWUatXYCwv8qL1E1qn5I80Wn5mcMKrtdREHWobG29ZmlGMlVgzNwi6uve+hdt5njVhw7H7DBgIfyhUUsmHGVNTIBKTcQNhSXheiWHhnKSuqxMrCKbbpoKAx3y2lt22WBhvA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.010447, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 11 Dec 2023 at 23:48, Paul Heidekr=C3=BCger wrote: > > On 11.12.2023 21:51, Andrey Konovalov wrote: > > On Mon, Dec 11, 2023 at 7:59=E2=80=AFPM Paul Heidekr=C3=BCger > > wrote: > > > > > > > Hi Paul, > > > > > > > > I've been successfully running KASAN tests with CONFIG_TRACEPOINTS > > > > enabled on arm64 since this patch landed. > > > > > > Interesting ... > > > > > > > What happens when you try running the tests with .kunitconfig? Does > > > > CONFIG_TRACEPOINTS or CONFIG_KASAN_KUNIT_TEST get disabled during > > > > kernel building? > > > > > > Yes, exactly, that's what's happening. > > > > > > Here's the output kunit.py is giving me. I replaced CONFIG_DEBUG_KERN= EL with > > > CONFIG_TRACEPOINTS in my .kunitconfig. Otherwise, it's identical with= the one I > > > posted above. > > > > > > =E2=9E=9C ./tools/testing/kunit/kunit.py run --kunitconfig= =3Dmm/kasan/.kunitconfig --arch=3Darm64 > > > Configuring KUnit Kernel ... > > > Regenerating .config ... > > > Populating config with: > > > $ make ARCH=3Darm64 O=3D.kunit olddefconfig > > > ERROR:root:Not all Kconfig options selected in kunitconfig we= re in the generated .config. > > > This is probably due to unsatisfied dependencies. > > > Missing: CONFIG_KASAN_KUNIT_TEST=3Dy, CONFIG_TRACEPOINTS=3Dy > > > > > > Does CONFIG_TRACEPOINTS have some dependency I'm not seeing? I couldn= 't find a > > > reason why it would get disabled, but I could definitely be wrong. > > > > Does your .kunitconfig include CONFIG_TRACEPOINTS=3Dy? I don't see it i= n > > the listing that you sent earlier. > > Yes. For the kunit.py output from my previous email, I replaced > CONFIG_DEBUG_KERNEL=3Dy with CONFIG_TRACEPOINTS=3Dy. So, the .kunitconfig= I used to > produce the output above was: > > CONFIG_KUNIT=3Dy > CONFIG_KUNIT_ALL_TESTS=3Dn > CONFIG_TRACEPOINTS=3Dy > CONFIG_KASAN=3Dy > CONFIG_KASAN_GENERIC=3Dy > CONFIG_KASAN_KUNIT_TEST=3Dy > > This more or less mirrors what mm/kfence/.kunitconfig is doing, which als= o isn't > working on my side; kunit.py reports the same error. mm/kfence/.kunitconfig does CONFIG_FTRACE=3Dy. TRACEPOINTS is not user selectable. I don't think any of this has changed since the initial discussion above, so CONFIG_FTRACE=3Dy is still needed.