From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BD21C41513 for ; Thu, 12 Oct 2023 12:14:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C8E7580009; Thu, 12 Oct 2023 08:14:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C3E068D0002; Thu, 12 Oct 2023 08:14:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B069D80009; Thu, 12 Oct 2023 08:14:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 9DA008D0002 for ; Thu, 12 Oct 2023 08:14:23 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 76DD812043A for ; Thu, 12 Oct 2023 12:14:23 +0000 (UTC) X-FDA: 81336702006.08.5B67A06 Received: from mail-vs1-f46.google.com (mail-vs1-f46.google.com [209.85.217.46]) by imf06.hostedemail.com (Postfix) with ESMTP id B444E180025 for ; Thu, 12 Oct 2023 12:14:21 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="zc/EhuLV"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf06.hostedemail.com: domain of elver@google.com designates 209.85.217.46 as permitted sender) smtp.mailfrom=elver@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697112861; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uIVKgMbPrdbBiBUZkSG3/934vJNvcwEmUkQTpoFMZCk=; b=ZNCbdmR3VgdPSEQDg4ZCMw141Tg1mkC1YBd6iCZQHg+e+iEkGFzt6k8gVulpbcw6HNsObw 2lXVTNXQ1PbU13vRdYKgB5s/aUSEa3slOCuYDXf0UpYIVxODo+YItywxaLTptGU1IsjTVg jVgAvHvQ1LG9EIkfyJpLcsRg57BITiY= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="zc/EhuLV"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf06.hostedemail.com: domain of elver@google.com designates 209.85.217.46 as permitted sender) smtp.mailfrom=elver@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697112861; a=rsa-sha256; cv=none; b=OE1hnF5nHHVXa6UKgolnePl8nWf2GqQF//2I/YgwDXoCkslw2nHtVfBY1KVSdbfHyXPYTI xjcWSA+yGW+obCqJbtrK3Idk745CQf520R0hjrLN98hlv92w8rhBAa0DLSqvHS+2qfJwSC yv2ZgH0IvuPXd9wZnCXdvMEz1O369A8= Received: by mail-vs1-f46.google.com with SMTP id ada2fe7eead31-457ae239ff3so283411137.2 for ; Thu, 12 Oct 2023 05:14:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1697112860; x=1697717660; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=uIVKgMbPrdbBiBUZkSG3/934vJNvcwEmUkQTpoFMZCk=; b=zc/EhuLVu9SRi/qF5Fz8XnN7Y+DMkmao83wad057iPRvr2HfgX9sMwZ4OgAs2gJh8x 8R1TTkRtwRFaMayiQHco/flg8/xUTU7NiC+lSpsafRVX61QqqzVDW8WvLbw7RLiwseKI eEp5Xlb5Q5lb7D1bV4hgPnnA6s1en6LM0T2trnA5JjpphT2hpHLK9NhiaKPx496/LVlV 00LGWjEvMWJ9u3QQveqqlKB/qZqQFouwQEuRCCvZgl5X2wPxqYSMlxHSLx4NcCEY3/0E PmqchWq8uBZ/8zICsMaoJkS2uWiRSiN3k6EOw0W/5xcW/4Jr9qRlLPV/CtutFZPj5eIp PxtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697112860; x=1697717660; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=uIVKgMbPrdbBiBUZkSG3/934vJNvcwEmUkQTpoFMZCk=; b=cMhSQF6tp2SI+785tK31XXDb1A++r+Gy8BLck3TligZR/IjyoS5zMA2mUGrwhkgQfp lpMhCTd+s+ZUyh1uPcUcr+FrcyMz+8nR+ETyD0vOt5hmXBrYUA9BLY9162nPGNK+y5zd Jy1yIeFQIuaq20lZMZsodUAF3FBNqkqxuLLsduDWveXchPMjdI+80V/O/V251A2rynep 6O3K0IHlJyiekeHE+lsOh858qUXwtJerXo6+ZEWJvMMfaPIqzWS5AxKmo7FC/uXdWrrU mr3W+8zq4U3AeGF3GeitPVbuNSQQ5UrdUUOKbH+eOAmS5DgNe5ukV34+ijsL5mqVPFVP MdaA== X-Gm-Message-State: AOJu0YwEKUq/FtpYkINJNt4cQaMuOYNiEDJhKJthIXhs4UGbdtoOH8u+ yPs/Ru0yUoSdH5Dri5w5QSgUqNLpA4yEhZ/k5MA+ow== X-Google-Smtp-Source: AGHT+IGSoIb8uQABAFJTeUJgo2RfYY4jfayfwcYkHHdPEVjq+eBHhrTPQ/7URUajOd/zOEzWZ81EtKRuSQPLeMl9XzI= X-Received: by 2002:a05:6102:54a2:b0:457:a8fb:3251 with SMTP id bk34-20020a05610254a200b00457a8fb3251mr3718012vsb.0.1697112860491; Thu, 12 Oct 2023 05:14:20 -0700 (PDT) MIME-Version: 1.0 References: <20231002151031.110551-1-alexghiti@rivosinc.com> <20231002151031.110551-5-alexghiti@rivosinc.com> In-Reply-To: <20231002151031.110551-5-alexghiti@rivosinc.com> From: Marco Elver Date: Thu, 12 Oct 2023 14:13:44 +0200 Message-ID: Subject: Re: [PATCH 4/5] riscv: Suffix all page table entry pointers with 'p' To: Alexandre Ghiti Cc: Ryan Roberts , Alexander Potapenko , Dmitry Vyukov , Paul Walmsley , Palmer Dabbelt , Albert Ou , Anup Patel , Atish Patra , Ard Biesheuvel , Andrey Ryabinin , Andrey Konovalov , Vincenzo Frascino , kasan-dev@googlegroups.com, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-efi@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: B444E180025 X-Stat-Signature: obuunysza5561c6weeshxt4a79554b7p X-Rspam-User: X-HE-Tag: 1697112861-908900 X-HE-Meta: U2FsdGVkX1/+hxwMwfFwe4HH50CQ/A9vAIR5rn8y+ZzeFgq06m9O90eCG7pvtC2wH9B/Y81ybedQQ0EvLJXw2ird4Pnd9q6OS2tIeDzbFZD7Y9nGdbwPNG7ZxLSJbRIM6S0z1lHpmZr6PPl6aQDMzEoyZtZq9b3b1mgazf6VN4RMV3Nb2uenLTdB3kHohomoZRgTx6aBg4g3oO4zZzMgbS7Td/9tCUd7CrKjap9phZ663jyZ6b7F4QyGyA5S+1V68tILyrnAGql7NvXZH4dSmr9hz8E3WpRHZRtQ0RXehzoOluZ6tzUpCXMSic9XLDqPTf8E0MXwNTslqralaaVWWxwj0SfWlUiWotEObSjp2kJ94DDBDF6rTF6mT6wUaX9CscE7+mjfBwcHi7BXjCmxCgmBBUJV9avnEBvDO4e4u5om3ATqU1V+gPwy0QMo88NcN2V6xPObqoLe+yS1v0NEg94N6hc0eludPcZQov2gFvBpxslELTXBwGqKCWh3uy8taaNPQD7lDTjAa3MRs7hh0vcXzM3XSt0CeaTwrZChMs5D/Esy6wYI8hjcfOE3fwkZbij/YnzbMIcR1r1TO2lTDzYvrZzU1067+niTrBbOpCYQpgpsqaHgxPF6K1HjYsDb42S+Pgjlf5nXyXfFjTeKj38qIa+cZxP39w2REB3vFpe/SHswcyyn/tZRdHKoFx67hqjNpnxAlTCPSTR1Mck+P8o5iBCcvlkoz6lzfqKLFGCgTb79uYMpLMa3zViBOv9EDMYX0Mg3I2Md2Zgx1bBHap1KC3DPU2zhkNBdFeC+ox/LPtE4Qief0GHlTOmXhl78LZj0HMBI4k93S/tz5QRyIDRU62YcM5FTTyDAjS/6kIvkGIMrJWqv7bC/ggraLJY2a9PRPIG92ZmgzTEVoqdJ6osb180K+wElXpdw+jkw2tBbgY6SK5yPLEiVhiVo1ljnY8oQV0/5RyCDsS0TAyZ yPtWeyhb mcenZ/c1iIVU88B8ybbOEgieXWDgNTjEkqt41fOmOtDb1WsXYA9FGazIMKe5I/UInzu3igTnyKp+eMWtj/OZ+g8RcdHHE5NzIkv1x8iFx0UX6mIsVraMSKXrPO6+ZbZRUFcpZiutoGuWALpZ4olcfWQRND97V3NfMX7LcHMnNRW4YpA9g3SbHpzbmnMWNJ06mp3iNGmKmK8WaRaOWsS4PG7WGe2TJ8DYs72g+2wCHMKC0EBO1NoVvh70AD/+ueIaLbM7Ie/q0BCfVh2Ec2bY1byFMykx+ii+EjYbfllgvD3KlhLuRBn7mqOHtAIWK4P7WqZ/ipwVkflTRq5YpmCs9tpXQ7Hz8ubEkn00qzA683SYMuew= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 2 Oct 2023 at 17:14, Alexandre Ghiti wrote: > > That makes it more clear what the underlying type is, no functional > changes intended. > > Signed-off-by: Alexandre Ghiti > --- > arch/riscv/include/asm/kfence.h | 6 +- > arch/riscv/include/asm/kvm_host.h | 2 +- > arch/riscv/include/asm/pgalloc.h | 86 +++++++++++++------------- > arch/riscv/include/asm/pgtable-64.h | 20 +++--- > arch/riscv/kvm/mmu.c | 22 +++---- > arch/riscv/mm/fault.c | 38 ++++++------ > arch/riscv/mm/hugetlbpage.c | 78 +++++++++++------------ > arch/riscv/mm/init.c | 30 ++++----- > arch/riscv/mm/kasan_init.c | 96 ++++++++++++++--------------- > arch/riscv/mm/pageattr.c | 74 +++++++++++----------- > arch/riscv/mm/pgtable.c | 46 +++++++------- > 11 files changed, 251 insertions(+), 247 deletions(-) > > diff --git a/arch/riscv/include/asm/kfence.h b/arch/riscv/include/asm/kfence.h > index 0bbffd528096..3b482d0a4633 100644 > --- a/arch/riscv/include/asm/kfence.h > +++ b/arch/riscv/include/asm/kfence.h > @@ -15,12 +15,12 @@ static inline bool arch_kfence_init_pool(void) > > static inline bool kfence_protect_page(unsigned long addr, bool protect) > { > - pte_t *pte = virt_to_kpte(addr); > + pte_t *ptep = virt_to_kpte(addr); > > if (protect) > - set_pte(pte, __pte(pte_val(*pte) & ~_PAGE_PRESENT)); > + set_pte(ptep, __pte(pte_val(*ptep) & ~_PAGE_PRESENT)); > else > - set_pte(pte, __pte(pte_val(*pte) | _PAGE_PRESENT)); > + set_pte(ptep, __pte(pte_val(*ptep) | _PAGE_PRESENT)); > > flush_tlb_kernel_range(addr, addr + PAGE_SIZE); As others expressed, this seems unnecessary. It doesn't make the code any clearer to me. However, for your subsystem you make the rules. I would just suggest to keep things consistent with other kernel code, although there are already stylistic deviations between subsystems (e.g. comment style in net and rcu vs rest), I'd simply vote for fewer deviations between subsystems. Real downsides of stylistic changes that have unclear benefit: 1. stable backports become more difficult. 2. chasing a change with git blame becomes harder.