From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61D32C433EF for ; Mon, 28 Mar 2022 18:58:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A14098D0002; Mon, 28 Mar 2022 14:58:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9C2818D0001; Mon, 28 Mar 2022 14:58:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8B1B08D0002; Mon, 28 Mar 2022 14:58:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0060.hostedemail.com [216.40.44.60]) by kanga.kvack.org (Postfix) with ESMTP id 7C5FD8D0001 for ; Mon, 28 Mar 2022 14:58:10 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 23DA28249980 for ; Mon, 28 Mar 2022 18:58:10 +0000 (UTC) X-FDA: 79294705140.21.D1C7F69 Received: from mail-yb1-f174.google.com (mail-yb1-f174.google.com [209.85.219.174]) by imf25.hostedemail.com (Postfix) with ESMTP id B4D0CA0040 for ; Mon, 28 Mar 2022 18:58:09 +0000 (UTC) Received: by mail-yb1-f174.google.com with SMTP id u103so27667408ybi.9 for ; Mon, 28 Mar 2022 11:58:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8612p/69znHIDRySiH+8dA+VUWRJM0II/moWC9PgDh0=; b=R0RSG/eD45vxAB8C5huZwsNn3GSeO3CeFOpFkhEwACU4cYjU/qDHeJ9dRU/s8iPWkR MkZHry9neauW9HYX8gXxgzjaqkX2mpcav9D0nXygYspjw6/qDToneyjZcOTBPNrq53yY nkBuN1SaZSzlXWjtN+gOY40RVYATiLKCRctlk5ci0unOxkcEx6JuTvZCItXjBp8QYbB3 cXCQ0phWilxKLZc1KrUHJB7xFLYl9pFmrgGZwLiW3wfmofX2/LAFA74UEDDkPcl4f/BO MBQq7nWEcsK7zH3LuUO/lIgSlBmR5GgZAgOjW8+GlMDjlS4XRGDFjKBSgPib3uyzEw80 dCcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8612p/69znHIDRySiH+8dA+VUWRJM0II/moWC9PgDh0=; b=y3UVptoJyzeucp+kEpWSBj4Cv771GOm9ITUN/9cFScoaYoCL7ND4h8KU9sYRZLo2Z3 oBr5HQKwnM+s4pcPjWGWI9AzTCAr1Iac0lM+R3ftEZmb3eC3WmwwVBkDLIQC7P+vYaPc DBP85AEMAPsNRkao3JWh9e+82jNnEQ/C3CxLhn/g3vwmj57MOn+qeUYwwFol9v+mVlRL jvfi4GwEuU0fu8kQfCmo+nPYCM49JDoosjDB/p06fdJ7Kp3a2XmW/0A3r6FF2ZGtZWRs VtVdYeM2FXLdfAx9R4lCeWQTQnomQ6MB+8GjIgl0iFi4fWaDadecy7i0JQsHLINTA73A nlpA== X-Gm-Message-State: AOAM531gLZm071/qtrNqq0mM9lCWLl2vLH3SbpBYZKgUFp/lmbaaP/qr X+iq2OpSFXpL3oF0uPst78VFzAk+zB8lyMduSVtHIA== X-Google-Smtp-Source: ABdhPJwt+RoOnL37cR1r2A91NZ3Rlf28H9zAzoMDrsg1szQFpW4MvObpLTmFzcIGyJ6XEm4sTQgFMRKRui/r76+UYwE= X-Received: by 2002:a05:6902:241:b0:633:d3e1:ff5e with SMTP id k1-20020a056902024100b00633d3e1ff5emr24158708ybs.625.1648493888782; Mon, 28 Mar 2022 11:58:08 -0700 (PDT) MIME-Version: 1.0 References: <20220328132843.16624-1-songmuchun@bytedance.com> In-Reply-To: From: Marco Elver Date: Mon, 28 Mar 2022 20:57:32 +0200 Message-ID: Subject: Re: [PATCH v2] mm: kfence: fix objcgs vector allocation To: Muchun Song Cc: Alexander Potapenko , Dmitry Vyukov , Andrew Morton , kasan-dev , Linux Memory Management List , LKML , Xiongchun duan Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Stat-Signature: ixh47hnmyg69oz46eoix3k3xipca9moz Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="R0RSG/eD"; spf=pass (imf25.hostedemail.com: domain of elver@google.com designates 209.85.219.174 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: B4D0CA0040 X-HE-Tag: 1648493889-829190 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 28 Mar 2022 at 17:54, Muchun Song wrote: [...] > > > > > > Btw, how did you test this? > > > > > I have tested it with syzkaller with the following configs. > And I didn't find any issues. > > CONFIG_KFENCE=y > CONFIG_KFENCE_SAMPLE_INTERVAL=10 > CONFIG_KFENCE_NUM_OBJECTS=2550 > CONFIG_KFENCE_DEFERRABLE=n > CONFIG_KFENCE_STATIC_KEYS=y > CONFIG_KFENCE_STRESS_TEST_FAULTS=0 Hmm, I would have expected that you have some definitive test case that shows the issue, and with the patch the issue is gone. Were there issues triggered by syzkaller w/o this patch? Thanks, -- Marco