From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14ACFC48260 for ; Tue, 13 Feb 2024 08:26:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A20158D0001; Tue, 13 Feb 2024 03:26:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9D0C36B008C; Tue, 13 Feb 2024 03:26:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8982F8D0001; Tue, 13 Feb 2024 03:26:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 792376B008A for ; Tue, 13 Feb 2024 03:26:50 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 21537A03B4 for ; Tue, 13 Feb 2024 08:26:50 +0000 (UTC) X-FDA: 81786099780.12.1B1C601 Received: from mail-vk1-f170.google.com (mail-vk1-f170.google.com [209.85.221.170]) by imf22.hostedemail.com (Postfix) with ESMTP id 99655C000A for ; Tue, 13 Feb 2024 08:26:48 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=AsnXYNyg; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf22.hostedemail.com: domain of elver@google.com designates 209.85.221.170 as permitted sender) smtp.mailfrom=elver@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707812808; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sxi4daiMjo969D0hS7+XvRJwRmcr6gtaf2stlPB/TO4=; b=BpGReahkpXtGqOtv29wsqxyUaCmTa94rQ+gr+WAdTNfhj8PZZrc7cKdDgLAPD0bWj6w8LA dSnOUE7T5dw1YwGA6AJarRibTtIjU8DBRxrxvco0rI+wa63nE101dKt0gwl6szCa1jG2sq LtXZVid5/4tq0Q6tr+XACwJtQz34dB4= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=AsnXYNyg; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf22.hostedemail.com: domain of elver@google.com designates 209.85.221.170 as permitted sender) smtp.mailfrom=elver@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707812808; a=rsa-sha256; cv=none; b=blyaNPMTffU8wb2/BLaiHXRBYTzb6UeaTHZlZsVnPUujBX0Q4vOrXOfelhyCrJA7Jj6KsL ht6NO+CCz9lf06SNbkZzSsHny41K9nzrAYTMy3OLKFIty9WL1mMBGRtiNwdPB2izZMB1O7 N3qB7vBHhADsKC18fkzW7u+QTYix0V8= Received: by mail-vk1-f170.google.com with SMTP id 71dfb90a1353d-4c021a73febso804726e0c.2 for ; Tue, 13 Feb 2024 00:26:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1707812808; x=1708417608; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=sxi4daiMjo969D0hS7+XvRJwRmcr6gtaf2stlPB/TO4=; b=AsnXYNygGkBe3wfjPUrqj5Albuw6yAQbxnccyK1XaLcrSk9KQUH7/59TaUBuHcmubK MEsAa11fiEYekxp/i2bYEQFQ8tIV88ztYd7VzwlKDOFaWZ/er88k53jrvBZ5vwoF9p5z tzpHvEQzAEmiIHxaw+hdO7ffHu6x8sKBJYlPIv0G793M5U5alPmqKO03BlchxSY4jTXw 8SUk8WoKGL8lhSOIQ2a3p2x11MnotCPSsg4HmrTiamoz4UDKVu2WJIrH1C8jAIjOJNQm 7NOZ0s0hjgS2jlV7TWk2XPip69OzjfMUf32Gg7zL9QCq80VKuTVSjgx4P+obQ/aqzOa4 Natg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707812808; x=1708417608; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=sxi4daiMjo969D0hS7+XvRJwRmcr6gtaf2stlPB/TO4=; b=SZVIZcWY+BNASMBZr8TxIfwDld0gXf7fZR9rOWiKS1WUsjoIWn7sxUOLhQl3DaFzke 4WkgMdi1DQO+2YjfNvJGXrcDA2niIq2LnHlskAFJMqY2MHE3g36MXnhmbrQVe2xG/xrr UbBKPVtrxaIsG0P9NOmn38pvB6DfFtayWPc2/H4eoRJK0bleoNIOxhuGfZq6LMw8KVwb Y+tUbDYovnDn6gGTSOyKtVmyPo89Sewgw1AozQi/T+WiTxVGpmhedIPBF11lIy5nG/j5 l/rPjkXHkg5lZjI5crZX8mPWkDpJHLzjKttySQ7JpBVPWmEBTnENDr2W/+ZacrsIDgJH 4XDg== X-Gm-Message-State: AOJu0YyYamxnu+Pt10E10wHPP6U2esTdlCbKA8BuRy+/Y9KM4swuveQO k+D99nTE2Lt5Dkh5GNuHpqjR6nzIMsXttlXuqAs+mgm3KsCo5notEt/R4DCAaoqX1euCtW9dTfF CPqG+3PdZBemMnDWj838t8ZdyssyzcGe1GzMYyBhVJpkhap0mcQ== X-Google-Smtp-Source: AGHT+IGNTtXt2kUxA+0n34KgEgcHDIJnieHa2LH69jAMYeuLQqAzXKRYR4SbtE8rXY9uLIH5xG5rW/ZnsEHPjyOOGQ0= X-Received: by 2002:a1f:6744:0:b0:4c0:7d26:58da with SMTP id m4-20020a1f6744000000b004c07d2658damr4139220vki.2.1707812807507; Tue, 13 Feb 2024 00:26:47 -0800 (PST) MIME-Version: 1.0 References: <20240212223029.30769-1-osalvador@suse.de> <20240212223029.30769-2-osalvador@suse.de> In-Reply-To: <20240212223029.30769-2-osalvador@suse.de> From: Marco Elver Date: Tue, 13 Feb 2024 09:26:09 +0100 Message-ID: Subject: Re: [PATCH v8 1/5] lib/stackdepot: Move stack_record struct definition into the header To: Oscar Salvador Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko , Vlastimil Babka , Andrey Konovalov , Alexander Potapenko Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 99655C000A X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: yjhpw4czdezno6a8qniuq4w353eo4a4y X-HE-Tag: 1707812808-871971 X-HE-Meta: U2FsdGVkX19dH68beruInRGuv2nGA3khyTy5EMyLl4gauLFwYTL1n1kmas95vDzEA9+CAZ9u+iyLuk/MHSwS1K00tR9b7DisFQ1oqdk2jXlp+bcVLiDUsyt2KUW3yMtW6vf7KjB7hxJ+ZVLCcrd9DDsviOrf+YDYmfQqOoQyOMR7iF72xZ4zb4q/qurmFrW7ARMEcsIxNqL7usnI2o7vLPovLotlriUr87uNY2f2bxmNwLa+ztA1jCCeiS11pIOCplIBG5zdL7tx90TrOmky7dk4NHttS18sgl1cSPCRWk6oinQRDTRFTR33vHmBRnpuZTCmX1ysgOzmhOIrM+Hv5isTQ1t7AxbUg5NpLoOcOtN6Mz7ZhFI8tqHgpkxptbkhEFVYtmF7a8tMyB4VkQfDbvIojZDUXKfG7E+8WlliL9wogey2bvmv8uIdBsKPNeOR/lAenCSYQGZDxtSRh0xH7gLAxjgpFH8cALn9LaFy0YDuVXfD3nBLHPl4dtouf9YX73kqW5yY6qjutS3IKuYP0PTOAdDXlJ8ZL2X9itYVPzK98DL3ZOcEwXuqmh2ICHDKt5etW/xOqPdvTZi4NmckO4l1A2y2Rt7Sn7vJlUFBsGkwMw5NQkEcgZHv/uAr7LtVP0gYA/eTSOpNqCWQzDSRFlgm+h87lTsFE1cvB1atAyhkZyogYtQxCGpF/jW5qWoLgkqEWiSGJHVeF04cVyXoBveNhuPNKwo9WbOaD519CEXMO7taSSsy/P4YLqGy+YsT+96pWb1HNi5RWxUG2vtMf2r5TzbXxaIdI+F6akgrOAXOS38kldV0U1lNwLdBuMPVwQkU0pf2AklHymarGnUbyBIyxggbFoqEW2BMbRx54YX4ZOLZSUsJgMXwtE9mGi7lwd+0g7LuKj1Yt2EYe4tyQgTUZB5bWlyW4QKBYCA4E330+phmSahNBHiiRTAOQFk8sijSe+5LCqzNSUqLj4i CxP00sm2 g0DhjG51+TxkhWKSNJHPgESLoHzHnkQAWwM5o9FkV4vd/XwQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 12 Feb 2024 at 23:29, Oscar Salvador wrote: > > In order to move the heavy lifting into page_owner code, this one > needs to have access to the stack_record structure, which right now > sits in lib/stackdepot.c. > Move it to the stackdepot.h header so page_owner can access > stack_record's struct fields. > > Signed-off-by: Oscar Salvador Reviewed-by: Marco Elver > --- > include/linux/stackdepot.h | 44 ++++++++++++++++++++++++++++++++++++++ > lib/stackdepot.c | 43 ------------------------------------- > 2 files changed, 44 insertions(+), 43 deletions(-) > > diff --git a/include/linux/stackdepot.h b/include/linux/stackdepot.h > index adcbb8f23600..90274860fd8e 100644 > --- a/include/linux/stackdepot.h > +++ b/include/linux/stackdepot.h > @@ -30,6 +30,50 @@ typedef u32 depot_stack_handle_t; > */ > #define STACK_DEPOT_EXTRA_BITS 5 > > +#define DEPOT_HANDLE_BITS (sizeof(depot_stack_handle_t) * 8) > + > +#define DEPOT_POOL_ORDER 2 /* Pool size order, 4 pages */ > +#define DEPOT_POOL_SIZE (1LL << (PAGE_SHIFT + DEPOT_POOL_ORDER)) > +#define DEPOT_STACK_ALIGN 4 > +#define DEPOT_OFFSET_BITS (DEPOT_POOL_ORDER + PAGE_SHIFT - DEPOT_STACK_ALIGN) > +#define DEPOT_POOL_INDEX_BITS (DEPOT_HANDLE_BITS - DEPOT_OFFSET_BITS - \ > + STACK_DEPOT_EXTRA_BITS) > + > +/* Compact structure that stores a reference to a stack. */ > +union handle_parts { > + depot_stack_handle_t handle; > + struct { > + u32 pool_index : DEPOT_POOL_INDEX_BITS; > + u32 offset : DEPOT_OFFSET_BITS; > + u32 extra : STACK_DEPOT_EXTRA_BITS; > + }; > +}; > + > +struct stack_record { > + struct list_head hash_list; /* Links in the hash table */ > + u32 hash; /* Hash in hash table */ > + u32 size; /* Number of stored frames */ > + union handle_parts handle; /* Constant after initialization */ > + refcount_t count; > + union { > + unsigned long entries[CONFIG_STACKDEPOT_MAX_FRAMES]; /* Frames */ > + struct { > + /* > + * An important invariant of the implementation is to > + * only place a stack record onto the freelist iff its > + * refcount is zero. Because stack records with a zero > + * refcount are never considered as valid, it is safe to > + * union @entries and freelist management state below. > + * Conversely, as soon as an entry is off the freelist > + * and its refcount becomes non-zero, the below must not > + * be accessed until being placed back on the freelist. > + */ > + struct list_head free_list; /* Links in the freelist */ > + unsigned long rcu_state; /* RCU cookie */ > + }; > + }; > +}; > + > typedef u32 depot_flags_t; > > /* > diff --git a/lib/stackdepot.c b/lib/stackdepot.c > index 4a7055a63d9f..6f9095374847 100644 > --- a/lib/stackdepot.c > +++ b/lib/stackdepot.c > @@ -36,54 +36,11 @@ > #include > #include > > -#define DEPOT_HANDLE_BITS (sizeof(depot_stack_handle_t) * 8) > - > -#define DEPOT_POOL_ORDER 2 /* Pool size order, 4 pages */ > -#define DEPOT_POOL_SIZE (1LL << (PAGE_SHIFT + DEPOT_POOL_ORDER)) > -#define DEPOT_STACK_ALIGN 4 > -#define DEPOT_OFFSET_BITS (DEPOT_POOL_ORDER + PAGE_SHIFT - DEPOT_STACK_ALIGN) > -#define DEPOT_POOL_INDEX_BITS (DEPOT_HANDLE_BITS - DEPOT_OFFSET_BITS - \ > - STACK_DEPOT_EXTRA_BITS) > #define DEPOT_POOLS_CAP 8192 > #define DEPOT_MAX_POOLS \ > (((1LL << (DEPOT_POOL_INDEX_BITS)) < DEPOT_POOLS_CAP) ? \ > (1LL << (DEPOT_POOL_INDEX_BITS)) : DEPOT_POOLS_CAP) > > -/* Compact structure that stores a reference to a stack. */ > -union handle_parts { > - depot_stack_handle_t handle; > - struct { > - u32 pool_index : DEPOT_POOL_INDEX_BITS; > - u32 offset : DEPOT_OFFSET_BITS; > - u32 extra : STACK_DEPOT_EXTRA_BITS; > - }; > -}; > - > -struct stack_record { > - struct list_head hash_list; /* Links in the hash table */ > - u32 hash; /* Hash in hash table */ > - u32 size; /* Number of stored frames */ > - union handle_parts handle; /* Constant after initialization */ > - refcount_t count; > - union { > - unsigned long entries[CONFIG_STACKDEPOT_MAX_FRAMES]; /* Frames */ > - struct { > - /* > - * An important invariant of the implementation is to > - * only place a stack record onto the freelist iff its > - * refcount is zero. Because stack records with a zero > - * refcount are never considered as valid, it is safe to > - * union @entries and freelist management state below. > - * Conversely, as soon as an entry is off the freelist > - * and its refcount becomes non-zero, the below must not > - * be accessed until being placed back on the freelist. > - */ > - struct list_head free_list; /* Links in the freelist */ > - unsigned long rcu_state; /* RCU cookie */ > - }; > - }; > -}; > - > static bool stack_depot_disabled; > static bool __stack_depot_early_init_requested __initdata = IS_ENABLED(CONFIG_STACKDEPOT_ALWAYS_INIT); > static bool __stack_depot_early_init_passed __initdata; > -- > 2.43.0 >