From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CBC7C43334 for ; Tue, 12 Jul 2022 11:55:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CCCFF940062; Tue, 12 Jul 2022 07:55:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C7CA6940060; Tue, 12 Jul 2022 07:55:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B4581940062; Tue, 12 Jul 2022 07:55:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A61F9940060 for ; Tue, 12 Jul 2022 07:55:00 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 77FD380761 for ; Tue, 12 Jul 2022 11:55:00 +0000 (UTC) X-FDA: 79678291560.15.04B2A77 Received: from mail-yb1-f176.google.com (mail-yb1-f176.google.com [209.85.219.176]) by imf23.hostedemail.com (Postfix) with ESMTP id 06C7E140074 for ; Tue, 12 Jul 2022 11:54:59 +0000 (UTC) Received: by mail-yb1-f176.google.com with SMTP id 6so13514694ybc.8 for ; Tue, 12 Jul 2022 04:54:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=OUm36JXbn2cFfASaBApIenl9AkY8jJt+kU3h2jjV/Do=; b=mlIxG6kQ1nJjyT6pnefCQ3hYABDyxXfo8vj7QqVR4W0A7RKYEtOLZa9MbrvvnIeMWR dfsXALkc0WEOD7PXmqQLiwLJ9xEBAysuby6yJKxj6646dvxPucmvvsZeyGqyiHsjL/GL /wqk0M7810Tm+4Nl/pBaBDlgMG3r6FU/a8y7b8hFbCrk8MOi8ARKr2IZ+H4FK9kdgidm o1sBcXYQMiH7/P2fq0YEUeWiPFgmGDtd/4ONHw7keEK/SPKD6yLtwB38/r44hQur7j9n zibhzt/o3QqDmHI8n+D5RAyIxVzPcB2S7X6hhOZi6r94M7FaOv56m0+LfqlZv8xH8OQO bNJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OUm36JXbn2cFfASaBApIenl9AkY8jJt+kU3h2jjV/Do=; b=yr5pnlBSaDPbby8QZgp5V9skGC1aOsgqb64Yx3w13nuYDlMOMjbxSCtMzoz031NLGs VVkS4RBZnMMp+CPQYGOWJpj5AxL0x7FRGKtWu7iG50JxyrsCndZme0jZ87JKbU2FMpVm AuI3d8kyqq4vQdPmCEaam+w7DPCLqeYf5I73lK4lqZR+kM9+ihtn07kLQ+/NBnIvabD1 QekC2cpyGNjr5r9U/9vhyaYFvUiC9TCXLSAMEs1rbzAqmrL6F9tRx6TT10zRoiMbLbZd sVXyVU22EAzGwmzFXrO69a/fI9JvCWpL6X1PG1sD3kEqZw9jYULCDTvwPkwSPy/Y4+0Y vTjQ== X-Gm-Message-State: AJIora/WXUpbZH4FxQhvwFv6lsodTHW3Af2t4fKHzy20IllwynlSVfPC GydCV/kShrg+18AMz+R8BVITmMuOTr+6aHzv5Rqqbg== X-Google-Smtp-Source: AGRyM1ubexV4ZZio45G9VEs9ZwCCiwvszuvc+5DyA79Fo6d49h5TUMvqOxyRyX7e7kpx2hjZfwJJQpUJOqnmCD99wfo= X-Received: by 2002:a25:2d59:0:b0:66e:32d3:7653 with SMTP id s25-20020a252d59000000b0066e32d37653mr21902834ybe.625.1657626899153; Tue, 12 Jul 2022 04:54:59 -0700 (PDT) MIME-Version: 1.0 References: <20220701142310.2188015-1-glider@google.com> <20220701142310.2188015-13-glider@google.com> In-Reply-To: <20220701142310.2188015-13-glider@google.com> From: Marco Elver Date: Tue, 12 Jul 2022 13:54:23 +0200 Message-ID: Subject: Re: [PATCH v4 12/45] kmsan: disable instrumentation of unsupported common kernel code To: Alexander Potapenko Cc: Alexander Viro , Alexei Starovoitov , Andrew Morton , Andrey Konovalov , Andy Lutomirski , Arnd Bergmann , Borislav Petkov , Christoph Hellwig , Christoph Lameter , David Rientjes , Dmitry Vyukov , Eric Dumazet , Greg Kroah-Hartman , Herbert Xu , Ilya Leoshkevich , Ingo Molnar , Jens Axboe , Joonsoo Kim , Kees Cook , Mark Rutland , Matthew Wilcox , "Michael S. Tsirkin" , Pekka Enberg , Peter Zijlstra , Petr Mladek , Steven Rostedt , Thomas Gleixner , Vasily Gorbik , Vegard Nossum , Vlastimil Babka , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657626900; a=rsa-sha256; cv=none; b=y8iReWlgdQRmYq1XcFJxVAAb26ARqktMAbOWpCNg0yTn6q4AS/9R5uGrztfGvVzaSKlA2g FpfZVotf90OHCfVTIXM+X10wQNJf3zVEuGNM3Cd1bkV4YjYa/EdKYMn8vyY1PR67tLa4dQ 73z+THlUGhQq8tLmEaoJ2LncMbKPBXw= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=mlIxG6kQ; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf23.hostedemail.com: domain of elver@google.com designates 209.85.219.176 as permitted sender) smtp.mailfrom=elver@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657626900; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OUm36JXbn2cFfASaBApIenl9AkY8jJt+kU3h2jjV/Do=; b=VS50/Wa0B4v5byB+Bl2puH4Ztx7Xty6pJsQoWd2zc3Hd//okp2NByx7MZzuxvB1O79c8DK jW46ueXw56d8/P/8E6mO85STE2nfCnPQD4hOCb4zxn98J/knAkuoFdtf/xtbZ/lfOSFJ3Q A/mzVItrLZ30RNZ5ixjs6SZhGW0GqyA= Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=mlIxG6kQ; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf23.hostedemail.com: domain of elver@google.com designates 209.85.219.176 as permitted sender) smtp.mailfrom=elver@google.com X-Stat-Signature: 79rborr1memi5jhfdwx1yrs8ggmq4urb X-Rspamd-Queue-Id: 06C7E140074 X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1657626899-564005 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 1 Jul 2022 at 16:23, Alexander Potapenko wrote: > > EFI stub cannot be linked with KMSAN runtime, so we disable > instrumentation for it. > > Instrumenting kcov, stackdepot or lockdep leads to infinite recursion > caused by instrumentation hooks calling instrumented code again. > > This patch was previously part of "kmsan: disable KMSAN instrumentation > for certain kernel parts", but was split away per Mark Rutland's > request. The "This patch..." paragraph feels out of place, and feels like it should be part of a v4 changelog below ---. > Signed-off-by: Alexander Potapenko Otherwise, Reviewed-by: Marco Elver > --- > Link: https://linux-review.googlesource.com/id/I41ae706bd3474f074f6a870bfc3f0f90e9c720f7 > --- > drivers/firmware/efi/libstub/Makefile | 1 + > kernel/Makefile | 1 + > kernel/locking/Makefile | 3 ++- > lib/Makefile | 1 + > 4 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/firmware/efi/libstub/Makefile b/drivers/firmware/efi/libstub/Makefile > index d0537573501e9..81432d0c904b1 100644 > --- a/drivers/firmware/efi/libstub/Makefile > +++ b/drivers/firmware/efi/libstub/Makefile > @@ -46,6 +46,7 @@ GCOV_PROFILE := n > # Sanitizer runtimes are unavailable and cannot be linked here. > KASAN_SANITIZE := n > KCSAN_SANITIZE := n > +KMSAN_SANITIZE := n > UBSAN_SANITIZE := n > OBJECT_FILES_NON_STANDARD := y > > diff --git a/kernel/Makefile b/kernel/Makefile > index a7e1f49ab2b3b..e47f0526c987f 100644 > --- a/kernel/Makefile > +++ b/kernel/Makefile > @@ -38,6 +38,7 @@ KCOV_INSTRUMENT_kcov.o := n > KASAN_SANITIZE_kcov.o := n > KCSAN_SANITIZE_kcov.o := n > UBSAN_SANITIZE_kcov.o := n > +KMSAN_SANITIZE_kcov.o := n > CFLAGS_kcov.o := $(call cc-option, -fno-conserve-stack) -fno-stack-protector > > # Don't instrument error handlers > diff --git a/kernel/locking/Makefile b/kernel/locking/Makefile > index d51cabf28f382..ea925731fa40f 100644 > --- a/kernel/locking/Makefile > +++ b/kernel/locking/Makefile > @@ -5,8 +5,9 @@ KCOV_INSTRUMENT := n > > obj-y += mutex.o semaphore.o rwsem.o percpu-rwsem.o > > -# Avoid recursion lockdep -> KCSAN -> ... -> lockdep. > +# Avoid recursion lockdep -> sanitizer -> ... -> lockdep. > KCSAN_SANITIZE_lockdep.o := n > +KMSAN_SANITIZE_lockdep.o := n > > ifdef CONFIG_FUNCTION_TRACER > CFLAGS_REMOVE_lockdep.o = $(CC_FLAGS_FTRACE) > diff --git a/lib/Makefile b/lib/Makefile > index f99bf61f8bbc6..5056769d00bb6 100644 > --- a/lib/Makefile > +++ b/lib/Makefile > @@ -272,6 +272,7 @@ obj-$(CONFIG_POLYNOMIAL) += polynomial.o > CFLAGS_stackdepot.o += -fno-builtin > obj-$(CONFIG_STACKDEPOT) += stackdepot.o > KASAN_SANITIZE_stackdepot.o := n > +KMSAN_SANITIZE_stackdepot.o := n > KCOV_INSTRUMENT_stackdepot.o := n > > obj-$(CONFIG_REF_TRACKER) += ref_tracker.o > -- > 2.37.0.rc0.161.g10f37bed90-goog >