From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5A67C678D4 for ; Thu, 2 Mar 2023 11:19:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 756BD6B0073; Thu, 2 Mar 2023 06:19:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 707456B0074; Thu, 2 Mar 2023 06:19:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5CFFC6B0075; Thu, 2 Mar 2023 06:19:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 5073A6B0073 for ; Thu, 2 Mar 2023 06:19:39 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 2875F80ED6 for ; Thu, 2 Mar 2023 11:19:39 +0000 (UTC) X-FDA: 80523712878.13.8B23363 Received: from mail-ua1-f44.google.com (mail-ua1-f44.google.com [209.85.222.44]) by imf06.hostedemail.com (Postfix) with ESMTP id EF29418001A for ; Thu, 2 Mar 2023 11:19:35 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=LwDWn5Nt; spf=pass (imf06.hostedemail.com: domain of elver@google.com designates 209.85.222.44 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677755976; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UpoYsX/wcX1BKUpmOF97rT/5TG0r4tQZUsDLiVIcjh4=; b=gLiqpVB8+tWoEfs2NiBFQywmJzD523FJSfBjxhOIuPzRvdrt72s2hEyRd+cIebjtOLJrWb 5JcShGWmRmkXlp9GPH3vE/P+BI9F/mFKTSnE/4VW2qIhKxifmbzg3rgz6kIjBBU/Kk9WGE V1D3/Gtoj/3S/SmKefqPQFf6H5ZIJ68= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=LwDWn5Nt; spf=pass (imf06.hostedemail.com: domain of elver@google.com designates 209.85.222.44 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677755976; a=rsa-sha256; cv=none; b=lKUas+tZPeoDD5ks9FFY9chC4eDim7xDJiwARQ1oBoZyKdBZHBOlG5WCkE0UM5yzkDDu7W sIg4UDrEx/Fs4k2zlmm2tUmd2LqgiFDkkOVnr1U+XVSzR3z1KGTSd7vsf0dakdG70MzsK/ PtpW5V46yFUPrj/0Z8mtmIow8+/y+6w= Received: by mail-ua1-f44.google.com with SMTP id l24so5894448uac.12 for ; Thu, 02 Mar 2023 03:19:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=UpoYsX/wcX1BKUpmOF97rT/5TG0r4tQZUsDLiVIcjh4=; b=LwDWn5Nt2IAkaWo9dUqFcLRfElg1ai2BCo3iFdJM2sQzjBPx5HoxsBdhTxg5hf3+Px j+97E+e944Mu+PJyA3RQ6Q/4HGim2Y+YeK3eHnvDVk4Hgkt8RME7t9LIg28bhB7jnSPF gHIcw59Hshb2Iv2LyESKJ7ecGjqVx+ExSRlr3uSiF1y2nJcjk/Om9YU8yJX/bRMxpga2 lI8FBBSMt67hGup0AJFqcFoQKSO6FXZQhxDCvPqKjhx8sthvfzYQAcUiZK2AO9Mr5mjR dJclpeSLZSi5JnWEFzROHXVSECWixlvpFJaOq8iAJ372Tx3MB4nTaHaxD/dI2KIiMGoU NDNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UpoYsX/wcX1BKUpmOF97rT/5TG0r4tQZUsDLiVIcjh4=; b=snBt6zR1M+JiqvOPPFZ2j3Qf6AD672ji3xzBG7BcZSM93FUx4ZGSZJ49valIa+Q6iW N0gDkHg3cmjS+RJpZtWV2h5hjrGSE4zy6KBg3EStSSnUBmvJzpWPDFpatk47iVlDDqdb naUrkzHGy3S9sKGJLls6GYbdZzDRuinDS4+8udex3hiTNA79mzMie44ifymmlddb9lwl 1PC/zlwRNCCRQbGvAIcxYSXj+UojSFjFRc9I3ShQxI/23OxWvH13NORMNeX6sUOLcaKX nvlYF5fczBuijb+AlJGg/KWrz9Ts6GnH5jtEUTw0Ojjw0QPQV1aRZRzGciFwqApHQA1N W1Qg== X-Gm-Message-State: AO0yUKVN3y7lMJTxKA8qQcnTY1ybIxbFofdJKL+EmIxDw6Y5kRAshJf6 0LzYNLLUv3aDzI+Rjw+3tJGSy1RHnpFs3BEOSZCtOA== X-Google-Smtp-Source: AK7set8pAGt3Pxj8EsVzgstq7VhTF8idjtE4IBSBO5saiDwLhWLaq6tv1oezXFrOWflpsWeWrNLIhpFj41mJrk5HIVA= X-Received: by 2002:a05:6122:e0f:b0:406:8403:4e64 with SMTP id bk15-20020a0561220e0f00b0040684034e64mr5028140vkb.2.1677755975009; Thu, 02 Mar 2023 03:19:35 -0800 (PST) MIME-Version: 1.0 References: <20230301143933.2374658-1-glider@google.com> <20230301143933.2374658-3-glider@google.com> In-Reply-To: <20230301143933.2374658-3-glider@google.com> From: Marco Elver Date: Thu, 2 Mar 2023 12:18:59 +0100 Message-ID: Subject: Re: [PATCH 3/4] x86: kmsan: use C versions of memset16/memset32/memset64 To: Alexander Potapenko Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, x86@kernel.org, dave.hansen@linux.intel.com, hpa@zytor.com, akpm@linux-foundation.org, dvyukov@google.com, nathan@kernel.org, ndesaulniers@google.com, kasan-dev@googlegroups.com, Geert Uytterhoeven , Daniel Vetter , Helge Deller , Tetsuo Handa Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: EF29418001A X-Rspam-User: X-Stat-Signature: n3uxk57cz8gzqxh6oieeubtu7eg3zgbt X-HE-Tag: 1677755975-525884 X-HE-Meta: U2FsdGVkX19KcD5uPtNR6u7TjHJcT6UKoamjDwEI6QYvNPPWnYOP4ezvceeiPa3FF0LUDI15Pc84FWPYolv+GX1oEY3FoDWhW9JDYniy/YqV5VWXlmKMjQrE89nDVCV+19cXjO6v1f05+I0By2WUC1YKpDSiL9vSsMtQ7lH4FQwokGbDd1KdPB6T/XohrGRPp65+KjdpmrmhooTHVz2gkxLsDQZaAEXq6DghfwW8q+Ow36ua5d2e6kS4eFc4fZmWnS90j5Gd/spaXoawjbRZllN2E4eHufZ36eYU+kcajx/hhygJLzxcG9ebA0mz0/QGYjWYdLznAsXoRALwSQYj62gKfsz6/5Vr3sTDVwzDsXHG8tkgyU0EborBNkBe+HDqXMEunKbQ72LUreYmBguqHqsdyY0cB5IkeN+h/b+k4VQ+8YzPEfi/DwPW8uRH934+Kip2Ve+noL+d6HyQKrnuFhJu/cD0dpK7pTuhsTZRoWzE6XHy5DCfDZ3U/BCSESW2HbKMCowVF5+ZKPi4K/bYKYvre7Nn5r+59PyZSIGu1+NJaJlP4SoF73IdLWTvLjjXn39hrju4Qn7H9QsPtng9QtRj+3A7s/q5D0A+bCM6RMbTMVBq2KYaQL7osNA3dfBGqMIE07hapkDC6JHAfIRp/CMdTlC7zPo7egTnWYYxdBI+4UuzZlRYwZZTTk0OZGriqfNDL9VJOJb3acc9u5YcrjbDs/r9U1w4fvQDCgeSRtTXdqf65XLRdlZplKXhL4x6ebw7588/3PcUdn0WIEnPqqe2lQwr4PDTdvUwG1/IaLXmH24AKFwbFklUWGXnellLQnrlRpDrmBqRsmbbdKHxmYLgJFuqXVm3qAhSnEPpQMgiyv+AdOemqrKwJp/6N5CW1ln1wQ7pkb0zncwaMT6EZXePZQzguIRllinKvCCjiz+PcbJ/vau0K/I3iNcaBP6AbqE9JdiLCSm3GfB82Mw VUZzE7Ol NPyLYSpa4mTYmhlT5f5C5HR9zlxrPkQ0iZYRV2aasED3w1cH6dVYF5NG4uYWlXycXD4cY7D5B12xJ2sLroMuoHe2JvNROsxsDOwITnZ3f06WYqcE4vdp8FEKw7lBrMEnNspyWVejJ9z3jYR+GiUsZ1xQwEsR/bC0rFKWrHQ9ImRHPuhRsdUXfjriN4BUgdDAba+BsAW0iaJ2RaDjgUXdVcAceHVLBVolp4YqmwBhVSLVDE3tfV55H+wJVT4d6b5jQvqOz9mBALu1tsb9NMr4z2utC77bwGYu4ddzIZmYKl/LG8RPqOxfnUZAE7wzyM7cPrjKlUAUOGKeCQR1XMZTC3JHVF58qGgjN5R5ewqNW5uxBwAMQ6K5Z4yHCspKYQtfe4WgEGLhs5cBHImmgZDlY1Nypb8Ve+NNZALMX4x1TIGgJxNyCm9ptxcXY+w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 1 Mar 2023 at 15:39, 'Alexander Potapenko' via kasan-dev wrote: > > KMSAN must see as many memory accesses as possible to prevent false > positive reports. Fall back to versions of > memset16()/memset32()/memset64() implemented in lib/string.c instead of > those written in assembly. > > Cc: Geert Uytterhoeven > Cc: Daniel Vetter > Cc: Helge Deller > Suggested-by: Tetsuo Handa > Signed-off-by: Alexander Potapenko Reviewed-by: Marco Elver > --- > arch/x86/include/asm/string_64.h | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/x86/include/asm/string_64.h b/arch/x86/include/asm/string_64.h > index 9be401d971a99..e9c736f4686f5 100644 > --- a/arch/x86/include/asm/string_64.h > +++ b/arch/x86/include/asm/string_64.h > @@ -22,6 +22,11 @@ extern void *__memcpy(void *to, const void *from, size_t len); > void *memset(void *s, int c, size_t n); > void *__memset(void *s, int c, size_t n); > > +/* > + * KMSAN needs to instrument as much code as possible. Use C versions of > + * memsetXX() from lib/string.c under KMSAN. > + */ > +#if !defined(CONFIG_KMSAN) > #define __HAVE_ARCH_MEMSET16 > static inline void *memset16(uint16_t *s, uint16_t v, size_t n) > { > @@ -57,6 +62,7 @@ static inline void *memset64(uint64_t *s, uint64_t v, size_t n) > : "memory"); > return s; > } > +#endif > > #define __HAVE_ARCH_MEMMOVE > void *memmove(void *dest, const void *src, size_t count); > -- > 2.39.2.722.g9855ee24e9-goog > > -- > You received this message because you are subscribed to the Google Groups "kasan-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an email to kasan-dev+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/kasan-dev/20230301143933.2374658-3-glider%40google.com.