From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE1CFC02180 for ; Wed, 15 Jan 2025 16:21:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 760206B007B; Wed, 15 Jan 2025 11:21:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 70FE06B0082; Wed, 15 Jan 2025 11:21:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5D7586B0085; Wed, 15 Jan 2025 11:21:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 3FEC36B007B for ; Wed, 15 Jan 2025 11:21:08 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id ED69381475 for ; Wed, 15 Jan 2025 16:21:07 +0000 (UTC) X-FDA: 83010200574.01.E15EF18 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by imf19.hostedemail.com (Postfix) with ESMTP id 069031A0005 for ; Wed, 15 Jan 2025 16:21:05 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=MC7Rn60t; spf=pass (imf19.hostedemail.com: domain of elver@google.com designates 209.85.214.170 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736958066; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Z0swpJpnqngIgl9tsMO0EehO0BF6GXb/S4Vl2pslhD0=; b=aBaPWz/kpWgVD6pRy6MrzZ02am4JYkYrXRolMN2cVjyts/yw/EghmCjzjyf4K1ggf0F/e6 gPnOrK/ct/HwhLJQVwb/c9tFrvKbWzQK6Rs//SB1yqKZO6tsGogPnZdet+07J/Xe/hiR/A OLuMynwUwxUyYhtzFx22UjAozaOv2DA= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=MC7Rn60t; spf=pass (imf19.hostedemail.com: domain of elver@google.com designates 209.85.214.170 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736958066; a=rsa-sha256; cv=none; b=0ccShdntsYvnpLLFoIQ9cB+Yn7iusP7l9C1XBUa7mElFWEGQVIXYC2Q3Y0hnfJHizv/6Us GZL1SB3Br+jVpeA4xsIKf+y2yC8NAZ1hZsyFYW1JrrTA7Mfm3EkXiXwU7qKKndwEkvjwJm e/XfmNss65+KftlAVl+/SqPWbHMnFDc= Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-21669fd5c7cso128802995ad.3 for ; Wed, 15 Jan 2025 08:21:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1736958065; x=1737562865; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Z0swpJpnqngIgl9tsMO0EehO0BF6GXb/S4Vl2pslhD0=; b=MC7Rn60tRdEUUUr3r6LTgLsqbV4+qyGQb/oI+JUdUvpf/mBt91uQAY9AWPr4c0pXUn sFpXyFDo88hlZM41Oadyi3rZASkT5GvVhMM7HEmtK05Uw4JsKGWWjOVgfCHk6JJaHFbo gJSk8fuOt3ZPkIHYACPdwAKjNYp6g0u0yXN/YEBl3VojKpG2c9ROpsTT+iuxO7F1DJq/ Mzr73fhZbG9xi1rt9bqFc4v1hVfah5LD+FOCY6KgORlQY+NZbOJ73YmdcluKoGk1liOK GeDm3Pir/Db1VFFWvA5WR3YHJssDlrB5OYaQd4iV086VI6G1SEHyi3O4D/P0zp9hTxBM faew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736958065; x=1737562865; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Z0swpJpnqngIgl9tsMO0EehO0BF6GXb/S4Vl2pslhD0=; b=W8NkX4NNaokoKx5mH3mhoT4X1bOGLh/ks/oohrapvl3eouxJLLzhMQJZOrACVt91pP uT1V1dxEpaQZSWeNYHd27lncrYY4tIoBkEBLHmjn8H2LJnx2v33O/uW1GrLZ6GPg8CUE +V7XCa9inYh0VReMZ1jyjUctYYgxdjg/uxtInCeqcIHMKxpGjLxZ+qRxNeY3GZbeZOha Cbtpy9tIZ0bsgHgYOf2Un7aCgDYd6jHxOqQfLjR6KH4XdAew7vdPstPtdiHEQuSkHewn uYL/Ff2jrKcaZadrj0UPFhQj8SKCV8zLmENOB80YYTCJ6tdrQO4m8VR5OhYf5aaGv4hM /lCw== X-Forwarded-Encrypted: i=1; AJvYcCUSwlXizQIKb5iIorjip/0YRhOFhlAaqxszuMNnpqEZzMThmO7QO5pxpKEJOUZvTg2IIs1oPGsgjQ==@kvack.org X-Gm-Message-State: AOJu0YxJSIlvfLJ1xZTtHoYBHGknbq3slinpwT1G3oUOEG3p+TFhXchK kPDD5nPJzJ6bjBPlmqiNWBAHut9DRc/86w/eSwoiZZ+X6Fg6EC9DacT1Kf/x8eVCPEdmQEleKks EUy825vZ1y89xBWuMLlP1NgORFouAAkE4PUovY7sdPSD5DrQHvw== X-Gm-Gg: ASbGnctYipXZzgcFpyDsfp5H5U9ztF9N/oiVsQjTGgSCuT5L0D63OwojM1h3T0XSZK9 4y92gv+oVOsKs/RZWjdSAo4gUVMu6+4v3k8Ufqx+BOsxPHVk3YzeOmiKFwexfWK6IszSR X-Google-Smtp-Source: AGHT+IGCjKssIwxo1/dDYEhQyNIhTrmldNpuFZYFBudr7mSytivI9A1tpuI8TlPO/QuKCwj4/J1ZHZh/I+y6HOj094g= X-Received: by 2002:a17:90b:2f4e:b0:2ee:f550:3848 with SMTP id 98e67ed59e1d1-2f548e98ea9mr39134653a91.5.1736958064515; Wed, 15 Jan 2025 08:21:04 -0800 (PST) MIME-Version: 1.0 References: <20250115155511.954535-2-thorsten.blum@linux.dev> In-Reply-To: <20250115155511.954535-2-thorsten.blum@linux.dev> From: Marco Elver Date: Wed, 15 Jan 2025 17:20:28 +0100 X-Gm-Features: AbW1kva0IzuJXTuUluEZw7TyyHnuEPZQASxfInZXM9pB4COpApVcMzBsRaYzxzs Message-ID: Subject: Re: [PATCH v2] mm/kfence: Use str_write_read() helper in get_access_type() To: Thorsten Blum Cc: Alexander Potapenko , Dmitry Vyukov , Andrew Morton , Anshuman Khandual , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 069031A0005 X-Stat-Signature: wcsixs1h5jwb94dn4ac3i4781e7ycs1b X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1736958065-267565 X-HE-Meta: U2FsdGVkX19ilpOkh8h8DhTeWd1tvJ6b81c/TrdzcBGO3444RWAVsu2X2vanphHNV1O0Vt6cs8MzYEeI+3StbRKqt7rwpTSTA2N2Ka2zkGy27v0JekXmmp4+1hxU0ltWEI1EvxYaED3JMx/mlb8erKmJRJ0CxLU8XlpkXs1PJ1WKTRr2/8U68wnhREDu5wwCUnmH1TnyO4Folmim5/MeoZshRzNC3BaV5KwzeH10Bt47lpq7FaM4RxFNIJpg1q3fPnfhsnwaFZYxa3SCCmZm9frXbdYaSMNU3TcWrYiic7RVvupbgsxAvgMsVUHNk8o/6qeS1yrd3sFj/Qqu4uahtQWVXjlHBszdrUMz1eXhZRFstD3h0IsboxbttN4i9GtcOEhiWvE/fDTmVtE6CXSzeYIrvjrkOUUrSzu2dVf0nLmuzdvKa50Os/VL9cc6hGFwV/C2RKXZOfw3Tz/w10fW1NhzJ+YfMqxhYFAiNd5OhUcCeY5duKIBuzmtHh6eIBtBGsxIjdapIKOzHwxJlcAzgyY3Hbv4vqY9RTDwh6XYrcXl+/tBLQU3PGIYSg6W23r1eTJwp/mNPcIWdGSAdbGh6BLR5uGhFZFpLscaCwxTPdBOqLH99Xc0rwAlryBahPCr5FliwmrIumLMIKelL69Mn6L45DyDKBwMM0T5WzmkSF6eF8D8mbQICeo6+FJOgupPqKt9PGviXy9gnTx+YAEhqjPMRLQkaul3kXldJd0OF4SXSDzw2WbOWABYKeGWHSTY1DxGwD0PAukr4q68Itw0aqSND3BEPyh4VpU7NJf9mqsHNZO8ZIvymF/iMhXWHyAJrjuQc+ek5Fa7J+v7hlep7yXrVMRvtbMzKKAkrfy3tYJnfBstx1rKTeG9zcuAx9rZEGqqbuzJkOthspIWA5EiXa5Hn2596Qytyc+l8Ligrt6k1mNcmnF/fnEmwgcrHXshbEvDHsO7lvZeP4k4Wgd AiZd9yPn aPWz322Vgv/egnzC59cG0lR/xS5UD39JxWpbDLfOVDVf1ESE9QHg4+14QDecsMXOb/ZtvXiu6VJ/JJ4WdHzXhvpdkPKRhJbu54XpVSVm/kR3PXtJnZJok2xIeJH6IsrSO0aneGIDqfg0Q+h/BSJsHuvCWUEgCXgtZ5MEx9vw4Ep/379LJMlTOpbtYiiee9Mm54ErlBnYIavdJx3pYQEshb5VQ8la3HWlX95LXgopW0uamPCFQ/Rv31lemRsNr2PDm54YSoAsFAMekymgoPoLC/6LY/pm7bmPNWY+HSlYrReaS+n/smYjFgopEYkmbaFuGsfpOkJUNXsrKgJfh6WGneDSEoQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 15 Jan 2025 at 16:56, Thorsten Blum wrote: > > Remove hard-coded strings by using the str_write_read() helper function. > > Suggested-by: Anshuman Khandual > Signed-off-by: Thorsten Blum > --- > Changes in v2: > - Use str_write_read() in report.c as suggested by Marco Elver (thanks!) > - Link to v1: https://lore.kernel.org/r/20250115090303.918192-2-thorsten.blum@linux.dev/ Reviewed-by: Marco Elver > --- > mm/kfence/kfence_test.c | 3 ++- > mm/kfence/report.c | 3 ++- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/mm/kfence/kfence_test.c b/mm/kfence/kfence_test.c > index f65fb182466d..00034e37bc9f 100644 > --- a/mm/kfence/kfence_test.c > +++ b/mm/kfence/kfence_test.c > @@ -20,6 +20,7 @@ > #include > #include > #include > +#include > #include > #include > > @@ -88,7 +89,7 @@ struct expect_report { > > static const char *get_access_type(const struct expect_report *r) > { > - return r->is_write ? "write" : "read"; > + return str_write_read(r->is_write); > } > > /* Check observed report matches information in @r. */ > diff --git a/mm/kfence/report.c b/mm/kfence/report.c > index 6370c5207d1a..10e6802a2edf 100644 > --- a/mm/kfence/report.c > +++ b/mm/kfence/report.c > @@ -16,6 +16,7 @@ > #include > #include > #include > +#include > #include > #include > > @@ -184,7 +185,7 @@ static void print_diff_canary(unsigned long address, size_t bytes_to_show, > > static const char *get_access_type(bool is_write) > { > - return is_write ? "write" : "read"; > + return str_write_read(is_write); > } > > void kfence_report_error(unsigned long address, bool is_write, struct pt_regs *regs, > -- > 2.47.1 >