From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E1C0C07E98 for ; Mon, 5 Jul 2021 09:01:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B38AA61260 for ; Mon, 5 Jul 2021 09:01:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B38AA61260 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 64BD16B0011; Mon, 5 Jul 2021 05:01:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5FBEF6B0036; Mon, 5 Jul 2021 05:01:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 49CF56B005D; Mon, 5 Jul 2021 05:01:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0205.hostedemail.com [216.40.44.205]) by kanga.kvack.org (Postfix) with ESMTP id 297306B0011 for ; Mon, 5 Jul 2021 05:01:57 -0400 (EDT) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id A07161842ACD0 for ; Mon, 5 Jul 2021 09:01:56 +0000 (UTC) X-FDA: 78327941832.27.B8E957F Received: from mail-ot1-f41.google.com (mail-ot1-f41.google.com [209.85.210.41]) by imf19.hostedemail.com (Postfix) with ESMTP id 64F6CB0000A3 for ; Mon, 5 Jul 2021 09:01:56 +0000 (UTC) Received: by mail-ot1-f41.google.com with SMTP id o17-20020a9d76510000b02903eabfc221a9so17719390otl.0 for ; Mon, 05 Jul 2021 02:01:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pi5VhRb63QYKLkBHNkU2ZBerPCcgeUsVkfNp8aUI108=; b=EScxNMFd9uw0mfB5IMHJEQ7Vh+bzQe/gdYLsmhyz37yTL3xZJyjL0ZL1i9UY1Ig8dg HOcx3WmLqKYJCAUHCoLewkUm4f52YDNAtUB60dkDTeYcO8a20M8hWaOUNfBOfNRLZpTI /dzQzzulNCoJPxvU/j6IFVM2I4393glUrJspiO9ZRL/O0/+kTJe1kuIS3znCT1JaktA6 nvH1RTRfCCCI3KsjknUQI0bE8/vDkd1mRA+tO5qTv5z8iMf96ztPwpHlu4QUKXBg0+3j EfWkEMgIfQVU2mzF0OVkP5xoanSUpF7kXIEbIrNtbTZtlo7VImybLsRh4dVQvh/55oWS J4mQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pi5VhRb63QYKLkBHNkU2ZBerPCcgeUsVkfNp8aUI108=; b=G2y2H7Zm2DaR7Rh+ELSmtuS5KXJ+RhSxADA2hMIaGN+nfqbAUSFc4aM1EhHwwI+5Xy cDkFm9cGVZmGy5cC996NpmDgthsa0B9NvpWjmupHtqjtkcq54+yBblyBtfo1Kr0Jg+VK g3RP25yzYzNvUoHpsFFgiqjHXk34ppETL2sU/ddUYiB9N4gj6k/kW2piQvvdPLW9PDkG BAftbSFeXNB072eTopuzqKLrdBQKXbV7HemrNxNkXWXW/RFFdtjbFBC4VV56yD/HvJKI 2+2vZhOPkayob4hhs7255UFQx6Av2F3TG6coe6Aw47UTRCZLjG1lQVYVLWEaoaulD7i0 P9HA== X-Gm-Message-State: AOAM530xZcwiSiHFuERbzLhGHH+D6Xjnp0mEwkkHb6fPXNIcitwk0qG2 NZA96ixrErYvR5TRQqouqu7K8LqFGsWmAv8HhyKvbg== X-Google-Smtp-Source: ABdhPJxLPFb6DtseNVjohvKekq8AGDXIypTgO51hjfWHG6OWJnjESD2yylsiZfBR4iUP7DLazpIAk2fl2E4+RaDiEiM= X-Received: by 2002:a9d:d04:: with SMTP id 4mr10450183oti.251.1625475715433; Mon, 05 Jul 2021 02:01:55 -0700 (PDT) MIME-Version: 1.0 References: <20210705072716.2125074-1-elver@google.com> In-Reply-To: From: Marco Elver Date: Mon, 5 Jul 2021 11:01:44 +0200 Message-ID: Subject: Re: [PATCH] kasan: fix build by including kernel.h To: Andy Shevchenko Cc: Andrew Morton , Alexander Potapenko , Dmitry Vyukov , pcc@google.com, Catalin Marinas , Vincenzo Frascino , Linux Kernel Mailing List , linux-mm , kasan-dev , Andrey Ryabinin , Andrey Konovalov , Andy Shevchenko Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20161025 header.b=EScxNMFd; spf=pass (imf19.hostedemail.com: domain of elver@google.com designates 209.85.210.41 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com X-Stat-Signature: fhitzzgn3oa5ncch7yoewjppqy39app8 X-Rspamd-Queue-Id: 64F6CB0000A3 X-Rspamd-Server: rspam06 X-HE-Tag: 1625475716-507822 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 5 Jul 2021 at 10:50, Andy Shevchenko wrote: > On Mon, Jul 5, 2021 at 10:28 AM Marco Elver wrote: > > The header relies on _RET_IP_ being defined, and had > > been receiving that definition via inclusion of bug.h which includes > > kernel.h. However, since f39650de687e that is no longer the case and get > > the following build error when building CONFIG_KASAN_HW_TAGS on arm64: > > > > In file included from arch/arm64/mm/kasan_init.c:10: > > ./include/linux/kasan.h: In function 'kasan_slab_free': > > ./include/linux/kasan.h:230:39: error: '_RET_IP_' undeclared (first use in this function) > > 230 | return __kasan_slab_free(s, object, _RET_IP_, init); > > > > Fix it by including kernel.h from kasan.h. > > ...which I would like to avoid in the long term, but for now it's > probably the best quick fix, otherwise it will require the real split > of _RET_IP or at least rethinking its location. > > Reviewed-by: Andy Shevchenko > Thanks! Thanks! > > Fixes: f39650de687e ("kernel.h: split out panic and oops helpers") > > P.S. I have tested the initial patch against full build of x86_64, and > it was long time available for different CIs/build bots, none > complained so far. It only manifests on arm64 when using CONFIG_KASAN_HW_TAGS mode (requires Arm64 MTE extensions). The other 2 modes include in kasan.h, and that seems to include kernel.h somewhere. The HW_TAGS mode, however, doesn't receive -next testing by a CI system AFAIK, so this was missed because it's not yet used by many (I'd expect that to change when CPUs with MTE are more widespread). Thanks, -- Marco