From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDE14C433EF for ; Thu, 30 Jun 2022 09:24:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3BEA36B0072; Thu, 30 Jun 2022 05:24:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 36DF86B0073; Thu, 30 Jun 2022 05:24:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 23FD38E0001; Thu, 30 Jun 2022 05:24:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 0F8E66B0072 for ; Thu, 30 Jun 2022 05:24:12 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id AED0D13CD for ; Thu, 30 Jun 2022 09:24:11 +0000 (UTC) X-FDA: 79634365902.04.2E8D5BB Received: from mail-yb1-f179.google.com (mail-yb1-f179.google.com [209.85.219.179]) by imf11.hostedemail.com (Postfix) with ESMTP id 5BB194003C for ; Thu, 30 Jun 2022 09:24:11 +0000 (UTC) Received: by mail-yb1-f179.google.com with SMTP id v185so23162223ybe.8 for ; Thu, 30 Jun 2022 02:24:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BiBmHGa2ClhXtCQ51AGcLtCso1fCDbCqVOHmA5sybi8=; b=Okonep8oIJyQnI/ZbxkKvw0SC4lkiyxfehKi0jKa0C6rkA8OGWjPVqqpWrG8XVlJMu vzFUC5Ggp4qVhEgihT9rdzI5jfWVcvRBopujM1h508cmf6gsxDIeEVz+LUC+21FnJFct A0ZlbT6s64qjzwZj8jQbU7MK06wFcIy18+QQ1KNrM/jah3BGgKtb3grG5ejymxvLPbFY CIBzkpg+iaOpWKrwQkGxVY8kA145Tq90FoOyaPTA6W+l7x/t/W1xuSD0Wnx+7WUFXDmx xleedD+alhmgRz2Ps76c5eVV6GJcidFuFk6F/ZaGpVWEb1POquU7UZw1NQ3XC4+BA8g6 CQlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BiBmHGa2ClhXtCQ51AGcLtCso1fCDbCqVOHmA5sybi8=; b=N+TFbDMU3o4up/H05fFO0A8k/gSfd+d1SWYp/ZnWkLYbRTmzKaTs4pq5XsPLbfbaGC CkPmmcWZA0R8XCTpWOaflyislLxkwg0/NiXspAaDNUkfFgGTVGw3L8ANMldcElLJZ0uh bXfo63nCEFSo4mwCYb6MY4lii1YD+9xSYJjxa6s69KRoXt3Csde5AQHPpibZ9x64nLOc 4duscLYNM2XXI+DIrMuIhkRzSUSi504i8Gv52/E5Iw+Apmw+NvzBRFS8gebQ/2aYaSfR pdja4BzrC4KrcmNDlbahZoWM8C0qbvHo9dMW+GncllwyEbNVrjbDO87ClgCoRTF/9oyZ RpdA== X-Gm-Message-State: AJIora+11WsDlYMzKxVxv8VN7HZJh83UvDd7ILfwv8YCqK60Xi8TL7WZ kJGgHMUp99qAZ2R2NKTcTNLXXCAUiE4+lqN4yQKKjg== X-Google-Smtp-Source: AGRyM1t9qyOwcSuQX9fPqfb3ZvEOzBYTM4AOckFsWrKACD6+EwN0rMbK1kv76oi4z34jcvd9wR68R0VWvAkRhMUhRto= X-Received: by 2002:a25:3497:0:b0:66c:c013:4bea with SMTP id b145-20020a253497000000b0066cc0134beamr8274918yba.625.1656581050492; Thu, 30 Jun 2022 02:24:10 -0700 (PDT) MIME-Version: 1.0 References: <20220630084124.691207-1-linus.walleij@linaro.org> <20220630084124.691207-4-linus.walleij@linaro.org> In-Reply-To: <20220630084124.691207-4-linus.walleij@linaro.org> From: Marco Elver Date: Thu, 30 Jun 2022 11:23:34 +0200 Message-ID: Subject: Re: [PATCH 3/5] mm: kfence: Pass a pointer to virt_to_page() To: Linus Walleij Cc: Andrew Morton , linux-mm@kvack.org, Alexander Potapenko , Dmitry Vyukov , kasan-dev@googlegroups.com Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656581051; a=rsa-sha256; cv=none; b=O21Vbmy1fVhvCDzy6CWrgQA2Sn8HqwlfunLTtrMEifbPeqGIzt9v2qmdjt4mfbFn/pFHqB 09nO5mIxwsVutmEdkuwVGAhkhtG6WO1DwmWL4nA4GEka3GgG0lYWIOEI00OFi/2+qSskit BHbImN1zFVW8IvvyypLKg9ZygvfKA/Q= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=Okonep8o; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf11.hostedemail.com: domain of elver@google.com designates 209.85.219.179 as permitted sender) smtp.mailfrom=elver@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656581051; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BiBmHGa2ClhXtCQ51AGcLtCso1fCDbCqVOHmA5sybi8=; b=ZJGgmmDlpy42264xTevIeXbkWj9+6OasDt2dT8fkrWB+69Qtkc/j/jWaeBaoRd2iSnqNAV j5DIs+0iu48AZ5WUrHxkEWJfAie7j9q0ySksgXMaz59w6IEmh7eNDjNoe472NmY87o3BjB Ep/t0OzwO7LX5bym0/sZbrFqGZAjCX0= Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=Okonep8o; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf11.hostedemail.com: domain of elver@google.com designates 209.85.219.179 as permitted sender) smtp.mailfrom=elver@google.com X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 5BB194003C X-Stat-Signature: 1z1zzzjbsfgdmk9rnsg1xr9is9ir4wx4 X-Rspam-User: X-HE-Tag: 1656581051-33480 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 30 Jun 2022 at 10:43, Linus Walleij wrote: > > Functions that work on a pointer to virtual memory such as > virt_to_pfn() and users of that function such as > virt_to_page() are supposed to pass a pointer to virtual > memory, ideally a (void *) or other pointer. However since > many architectures implement virt_to_pfn() as a macro, > this function becomes polymorphic and accepts both a > (unsigned long) and a (void *). > > If we instead implement a proper virt_to_pfn(void *addr) > function the following happens (occurred on arch/arm): > > mm/kfence/core.c:558:30: warning: passing argument 1 > of 'virt_to_pfn' makes pointer from integer without a > cast [-Wint-conversion] > > In one case we can refer to __kfence_pool directly (and > that is a proper (char *) pointer) and in the other call > site we use an explicit cast. > > Cc: Andrew Morton > Cc: Alexander Potapenko > Cc: Marco Elver > Cc: Dmitry Vyukov > Cc: kasan-dev@googlegroups.com > Cc: linux-mm@kvack.org > Signed-off-by: Linus Walleij Reviewed-by: Marco Elver > --- > mm/kfence/core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/kfence/core.c b/mm/kfence/core.c > index 4e7cd4c8e687..153cde62ad72 100644 > --- a/mm/kfence/core.c > +++ b/mm/kfence/core.c > @@ -543,7 +543,7 @@ static unsigned long kfence_init_pool(void) > if (!arch_kfence_init_pool()) > return addr; > > - pages = virt_to_page(addr); > + pages = virt_to_page(__kfence_pool); > > /* > * Set up object pages: they must have PG_slab set, to avoid freeing > @@ -657,7 +657,7 @@ static bool kfence_init_pool_late(void) > /* Same as above. */ > free_size = KFENCE_POOL_SIZE - (addr - (unsigned long)__kfence_pool); > #ifdef CONFIG_CONTIG_ALLOC > - free_contig_range(page_to_pfn(virt_to_page(addr)), free_size / PAGE_SIZE); > + free_contig_range(page_to_pfn(virt_to_page((void *)addr)), free_size / PAGE_SIZE); > #else > free_pages_exact((void *)addr, free_size); > #endif > -- > 2.36.1 >