From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDE6AC77B71 for ; Tue, 18 Apr 2023 10:11:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 396196B0074; Tue, 18 Apr 2023 06:11:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3467B8E0002; Tue, 18 Apr 2023 06:11:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 20DDB8E0001; Tue, 18 Apr 2023 06:11:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 1098D6B0074 for ; Tue, 18 Apr 2023 06:11:37 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id DC79C120128 for ; Tue, 18 Apr 2023 10:11:36 +0000 (UTC) X-FDA: 80694094992.08.7CD35E5 Received: from mail-il1-f173.google.com (mail-il1-f173.google.com [209.85.166.173]) by imf30.hostedemail.com (Postfix) with ESMTP id 0914180019 for ; Tue, 18 Apr 2023 10:11:34 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b="Cv2mPKC/"; spf=pass (imf30.hostedemail.com: domain of elver@google.com designates 209.85.166.173 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681812695; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=t7oNbt6UHUojCngKOJ0DxqaobdP4aHKdK/uVGrFOX4A=; b=lrVlcxxV9M2TM1EVly/Ti4UPQXumrAV5hxBHZh41E6OzTDF2SOtFKvp0dvzPK8DCtMdJSb OnLmhJrj8YYb/R4gmP12fv8zfXBw2a+KTZR2eWWcwvyioQ58+B5JrlhsqYZW3OI3XeQJAG K9iuqX9bzAC2lrQi4Uz+mLDrC//OpGg= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b="Cv2mPKC/"; spf=pass (imf30.hostedemail.com: domain of elver@google.com designates 209.85.166.173 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681812695; a=rsa-sha256; cv=none; b=5mN9U7HIGNNNsca4G3qmcI8qQoYvE0tIY2I4Pcp0REe2zqc2RoXf9uzyt8p9Q0zf+0wyOu M+5phC3MiJZvP07gVgkzHCMeO41DsLE8hRr0IwdlkkCpTP1B44Ft1Jd65z5Bm//jhinSxy zpGaplyrp5hj44Zbp6v4C578W49khW4= Received: by mail-il1-f173.google.com with SMTP id e9e14a558f8ab-32a7770f7d1so30638105ab.1 for ; Tue, 18 Apr 2023 03:11:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1681812694; x=1684404694; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=t7oNbt6UHUojCngKOJ0DxqaobdP4aHKdK/uVGrFOX4A=; b=Cv2mPKC/vP9dBafytcdnqHnkxMtJ7odBspcC7EBjxQaZbbGa51BPAqJCODkF/BFlzo KYjeYx0Dm3UD0AEQ10KK81Oe/kqzQWv7g/TGJ7bNJ/FOu4NgKsB1b5w7bCecNWhrpnkk cplxOnpGBy939dBcB97TDYLR6bVrOJIihIiHyWQzPciROwz/YGEL4SIU/eWk6/uOHHY+ eTanoBMfME1C8b4Lt0IjFi4C29mb0aVTqQHX+Ggchm+mki797ql/KaG2qFZXKpac7ZTK o32CId0UaQoUvPs2/6HLK92TFLgv3rxo1NUzoRpI9S5SFrbVfompKGBr2Jwv3yaBWyeH ij4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681812694; x=1684404694; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=t7oNbt6UHUojCngKOJ0DxqaobdP4aHKdK/uVGrFOX4A=; b=HJ2fkfpcw+YKt24ZzAOdzP99I+dtCModz1XdtUJVV6brDGxSM71eJR23nHqhaYesrL 9pzeEG2eIGWMs0EK1uI2lpTv6EWY/0vmvLLhspcfvdUPINArahvUD3GrMesqJb1D12Kz T1Ixw2z9+jMj4NmcjKGPaLxcxrcbUZV0skTjJg4eAemIUvTZ1KZxCicvePPvqp1bfwJ1 cUjkFfpoxQaM3hVVsgzHLtc6ql0vNrpo3RT0mQbWii6W5KSS6RIMJ+QkosRpwyR+TAvk El1fqpmUIrnq2vyKXNxbj3T610K3QJZsBx/grtoA3ozEZmp8kQUuz6dZDvpg/7jEyPki SKtA== X-Gm-Message-State: AAQBX9cYVAmJQ8IdObEOsHDzVrKnrkSWiKaFuYNYtX0F7bRD7BxFT3D6 MhsF6AHcZGl6+59AFi6Xty6pPegn7lU3+CNEl6c36A== X-Google-Smtp-Source: AKy350YNZVWkwrsSvj08CvK+g3B+QBOhbLyfSq9683Wfe1DivlOxIMokDWKxZHy0H6PZp5kSqAIU8GYD3d/gzR/ZzI4= X-Received: by 2002:a5e:8607:0:b0:753:989:ebb5 with SMTP id z7-20020a5e8607000000b007530989ebb5mr1447879ioj.7.1681812694096; Tue, 18 Apr 2023 03:11:34 -0700 (PDT) MIME-Version: 1.0 References: <20230413131223.4135168-1-glider@google.com> <20230413131223.4135168-4-glider@google.com> In-Reply-To: <20230413131223.4135168-4-glider@google.com> From: Marco Elver Date: Tue, 18 Apr 2023 12:10:57 +0200 Message-ID: Subject: Re: [PATCH v2 4/4] mm: apply __must_check to vmap_pages_range_noflush() To: Alexander Potapenko Cc: urezki@gmail.com, hch@infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, dvyukov@google.com, kasan-dev@googlegroups.com, Dipanjan Das Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 0914180019 X-Stat-Signature: 47d7sook4xiwtqejaez9tkrh4icnpqi9 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1681812694-54931 X-HE-Meta: U2FsdGVkX1+zhaqJSfPCkZ5m5vcueldzhiDS+7H+Sk2xXE97wOvL1ZxiY0JXMcRD0nGLNAKyHcEWaLs3l3N6EFA7vW3uwvc2Act1TIf+ciGETeDILQTcY6zvKBX0SUXTWnvbjvBpjpDA1zYGDHde4XmWpVTXyE8Q+mXCuZGiytQ42dkJ+nqsUjVzZhuCJaSSw7BfBwBNW1W//vkLz+dKBpGKBd8HrWK0jEON20jnclbnYo9bpz7RO0p1KTkMXfY6nh3D5MG/Rb6YYIdfCW/qx0WSrY6kzThukTHZ0DDzExQdRb0JQ3uMn1xWF5uFOl4vBblQmLSFcv/HqwpToE9l9haOYznWHIntkZFaYVtBij4ATO75VtSyGGzJ1pUEnyum5BEfEqsKRmRdPNQA2fz5+LHJhjTYMWZnk0J8vnj3uWB8V9rQhV/AXNK/dSNIDrQT1HT9Rv5xNXrISTUSmg3l0ST1DLp+AKiaYbAOFmNg4BHMgrdGHdomiRa8DowCzGPTQJvQCk8VXNgaKswu209OOzDC2UUnLrST0zDS35tPYUoQAt+T1wiOQvJF1H9Ragnjqao3YavXxcKSvV0aiHHUE6d4ynG/auL0Yf+Q2PLCZrDhMDiGCq3YbMIiJXskXQxngpx5y+4Gk9QkF0/rANslxj++fjtRyoH9AJWlBYQEUoIDul2/6+JSK9k5ZyuboMTtu5W2eQHyVVUsaNG9NRrfc0DwWT+aRfOixYYd4IHtI5aCdCjGXy7l/LOIXuZcQDrRI/o+A+ynvpH92nXNyOSEEoUCrOBYQXZEGT21o2otBJ7wucyyQ6uWm63gK/Obqq4Lz1JZUGkdlCpWclip0SU7wGKyecdi76li3/s2XlcG3Ee2RRGkhJynX9xwhMP/Or1xXGCBwLLlCLOxkr+3HMtYdikdjRnf55U/oJFy1HAQRukr1XD/hGg9k0SpEAQPlIxGkd/wsubxYrv81elDE22 oNBjAy/Z R1+tUOqf9n/UDBuMXld2BRnveiIGCL+1bzryWXzDsKJVFq8KN9IH4DiICBKMGj/xaRE6ec4u0wBnvvuNG05f1d8PGvS3J/ct1ZhtF4/P9k46aDxvBSPFAoF3maEDGFuyUgAQ2uecsQ0h7MS1JVmAI3BG8IjS80hzoFw/zThcwIkF44k02INGYy43A0J8adCEBw2oPgWv6OWPsk3VS0WVUdKpS43H55bNfxPNnhjhGQ46R0tjQLejby7B9IPwJblj2z12pEIpOzCnbEbQYBgfdZcYV2RGcvyeelyawFq6K7DQYbtx2goiMTb1MB3h78g/esKpyzEfzZ+45jUtXSnJ2onfpJ8Ko9ze0r4GT/nvt5p1rMDhJg79XRIzi4jjysBHbNrKySkVsTp7i1Yw0DqsUQyUu7KCLXXg0hi9hkb6KyZ0Mbis0t8nU3hkwwN1pLg5TchEh9hNdzmsWUXeGNwW5c/8y1w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 13 Apr 2023 at 15:12, Alexander Potapenko wrote: > > To prevent errors when vmap_pages_range_noflush() or > __vmap_pages_range_noflush() silently fail (see the link below for an > example), annotate them with __must_check so that the callers do not > unconditionally assume the mapping succeeded. > > Reported-by: Dipanjan Das > Link: https://lore.kernel.org/linux-mm/CANX2M5ZRrRA64k0hOif02TjmY9kbbO2aCBPyq79es34RXZ=cAw@mail.gmail.com/ > Signed-off-by: Alexander Potapenko Reviewed-by: Marco Elver > --- > mm/internal.h | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/mm/internal.h b/mm/internal.h > index 7920a8b7982ec..a646cf7c41e8a 100644 > --- a/mm/internal.h > +++ b/mm/internal.h > @@ -833,20 +833,20 @@ size_t splice_folio_into_pipe(struct pipe_inode_info *pipe, > * mm/vmalloc.c > */ > #ifdef CONFIG_MMU > -int vmap_pages_range_noflush(unsigned long addr, unsigned long end, > - pgprot_t prot, struct page **pages, unsigned int page_shift); > +int __must_check vmap_pages_range_noflush(unsigned long addr, unsigned long end, > + pgprot_t prot, struct page **pages, unsigned int page_shift); > #else > static inline > -int vmap_pages_range_noflush(unsigned long addr, unsigned long end, > - pgprot_t prot, struct page **pages, unsigned int page_shift) > +int __must_check vmap_pages_range_noflush(unsigned long addr, unsigned long end, > + pgprot_t prot, struct page **pages, unsigned int page_shift) > { > return -EINVAL; > } > #endif > > -int __vmap_pages_range_noflush(unsigned long addr, unsigned long end, > - pgprot_t prot, struct page **pages, > - unsigned int page_shift); > +int __must_check __vmap_pages_range_noflush( > + unsigned long addr, unsigned long end, pgprot_t prot, > + struct page **pages, unsigned int page_shift); > > void vunmap_range_noflush(unsigned long start, unsigned long end); > > -- > 2.40.0.577.gac1e443424-goog >