From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85E5AC43334 for ; Fri, 17 Jun 2022 11:35:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 002AC6B0074; Fri, 17 Jun 2022 07:35:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EF4E86B0075; Fri, 17 Jun 2022 07:35:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DBC556B0078; Fri, 17 Jun 2022 07:35:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C94BD6B0074 for ; Fri, 17 Jun 2022 07:35:27 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 847F520A03 for ; Fri, 17 Jun 2022 11:35:27 +0000 (UTC) X-FDA: 79587522294.20.C427E9B Received: from mail-yw1-f179.google.com (mail-yw1-f179.google.com [209.85.128.179]) by imf14.hostedemail.com (Postfix) with ESMTP id 2528F100072 for ; Fri, 17 Jun 2022 11:35:26 +0000 (UTC) Received: by mail-yw1-f179.google.com with SMTP id 00721157ae682-317803b61e5so14159597b3.1 for ; Fri, 17 Jun 2022 04:35:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=x5bwvKPWoiAdNfsl0rpPiOJbLUCKa6eFsFkR7Dl/GBw=; b=PENmBcxuKfoFRDHda84GkCq+WJODrnGWd1BRRAYSLp6UWmG1E5r4fVQr3JlCQYWR2z Qergd8Q6YnMXN+pMYTsBxlrOigKyDtcdwAkd6Fu22A9ts3hO0XNAJA6xPzya4pYHDrUP 2j04UJ1lxfaS/nfX9aIIcWdVfQqb+t5HJ9a0tRlgtD7WGdewEjwEB/mxpuAP5Cz5Euh7 KwJ25dhBw8FvfWESdwfhtqZWRSvXLdaCek5fo8yrPOBi+uuAD+JUiTov9IONiWiwMl5j sBZgKiR/22QfjoIbF0VcBhHwo21dUvctTQ9K/3xAPyBfKfNXqf0FMg2lK4whTouF4FEB qBHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=x5bwvKPWoiAdNfsl0rpPiOJbLUCKa6eFsFkR7Dl/GBw=; b=f9OIInw7SyxzBLfHTmuxADtBOONlOFrlB/tBuXpxC6FELRe5iWDhGBNXnd656wXMPR kFxaof7qta6sHnKFA+DAEBJdWItynrpyOEcdQ9eufzCbhr1i4xAAgvrNorufWyvF3mGM NUkFQVmI6VybUFmaGixla66Gwt7kqFYDaYsNX2jQ98SNA+plZnuiMaGANWJ2m2GTedjl q83ZrzuBy8+CnaRbezhGQZydG/54JTgG1o9qRvoA4c+vLrPsCn+Iy/Iap9fXY7TnAkHp GTSbcKEKI8WWm/4xkQQgQCifuFSIbNUYGYseVWGyaPnx5WPZ/90jMOO+xqHX0ZNAAttG mdLQ== X-Gm-Message-State: AJIora+WrmvHgLBucrHteurzC1ZAUq+UX9USS58M+JqGXDPNtPG3pAsR joerG6GGT8m9e+USQ61RJT2Ap/uU5VmiL68VuPd8hw== X-Google-Smtp-Source: AGRyM1sPWp60NI6GDHzc4UkssfaxItU18eWBZCQxcAan3JOuUbMEgrM9UAlZ3+93QWh1rqFj6ljJADuu4vENZMP6q78= X-Received: by 2002:a81:18c1:0:b0:317:648e:eec8 with SMTP id 184-20020a8118c1000000b00317648eeec8mr10552299ywy.327.1655465725193; Fri, 17 Jun 2022 04:35:25 -0700 (PDT) MIME-Version: 1.0 References: <11a7bfb5ed5de141b50db8c08e9c6ad37ef3febc.1655150842.git.andreyknvl@google.com> In-Reply-To: <11a7bfb5ed5de141b50db8c08e9c6ad37ef3febc.1655150842.git.andreyknvl@google.com> From: Marco Elver Date: Fri, 17 Jun 2022 13:34:49 +0200 Message-ID: Subject: Re: [PATCH 06/32] kasan: introduce kasan_print_aux_stacks To: andrey.konovalov@linux.dev Cc: Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Andrey Ryabinin , kasan-dev@googlegroups.com, Peter Collingbourne , Evgenii Stepanov , Florian Mayer , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655465726; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=x5bwvKPWoiAdNfsl0rpPiOJbLUCKa6eFsFkR7Dl/GBw=; b=rHDWYladVin7jTmnGN6ZO3Yt+u5C1c9gU2KCKkOurQr5glSj7TNWeQ0XbYxLpFb/SVJL2k Me1EfjpIjBF3LI/d/2NmovlX9XQ4CKIpK1kEPWPKiG0GNJExyKEbwJLELcFMgKioz4EF/c LuneL9SnGkrJJ/ALnqOwIY6tm90zNkY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655465726; a=rsa-sha256; cv=none; b=SCdYcnfOCv3WMvFQTM2E+T3GZCvMP2wpeCEP3PRKIbzJyxE60SMXYS4xMh8N6xH1aduiN4 uiTDutDxUqOwAD+zVbWfo2P62igxKTc8WJ1YxhwtHHIqk7+KUoe1uu3OtSDrkNLHaHA5Gm P1p4W0x0b5qUyacPWcEboU721t4Y3kc= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=PENmBcxu; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf14.hostedemail.com: domain of elver@google.com designates 209.85.128.179 as permitted sender) smtp.mailfrom=elver@google.com Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=PENmBcxu; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf14.hostedemail.com: domain of elver@google.com designates 209.85.128.179 as permitted sender) smtp.mailfrom=elver@google.com X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 2528F100072 X-Stat-Signature: pky5hhcbw8snugycbya7tpwcwsyrzyry X-HE-Tag: 1655465726-859387 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 13 Jun 2022 at 22:16, wrote: > > From: Andrey Konovalov > > Add a kasan_print_aux_stacks() helper that prints the auxiliary stack > traces for the Generic mode. > > This change hides references to alloc_meta from the common reporting code. > This is desired as only the Generic mode will be using per-object metadata > after this series. > > Signed-off-by: Andrey Konovalov > --- > mm/kasan/kasan.h | 6 ++++++ > mm/kasan/report.c | 15 +-------------- > mm/kasan/report_generic.c | 20 ++++++++++++++++++++ > 3 files changed, 27 insertions(+), 14 deletions(-) > > diff --git a/mm/kasan/kasan.h b/mm/kasan/kasan.h > index aa6b43936f8d..bcea5ed15631 100644 > --- a/mm/kasan/kasan.h > +++ b/mm/kasan/kasan.h > @@ -265,6 +265,12 @@ void kasan_print_address_stack_frame(const void *addr); > static inline void kasan_print_address_stack_frame(const void *addr) { } > #endif > > +#ifdef CONFIG_KASAN_GENERIC > +void kasan_print_aux_stacks(struct kmem_cache *cache, const void *object); > +#else > +static inline void kasan_print_aux_stacks(struct kmem_cache *cache, const void *object) { } > +#endif Why not put this into one of the existing "#ifdef CONFIG_KASAN_GENERIC" blocks? There are several; probably the one 10 lines down might be ok?