From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.2 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B381C4338F for ; Thu, 12 Aug 2021 08:56:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D937E6103E for ; Thu, 12 Aug 2021 08:56:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D937E6103E Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 7083B6B0082; Thu, 12 Aug 2021 04:56:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6B7CD8D0009; Thu, 12 Aug 2021 04:56:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 57F076B0085; Thu, 12 Aug 2021 04:56:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0220.hostedemail.com [216.40.44.220]) by kanga.kvack.org (Postfix) with ESMTP id 3D8BB6B0082 for ; Thu, 12 Aug 2021 04:56:57 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id D477F141FF for ; Thu, 12 Aug 2021 08:56:56 +0000 (UTC) X-FDA: 78465823632.13.E30B7FB Received: from mail-oi1-f171.google.com (mail-oi1-f171.google.com [209.85.167.171]) by imf07.hostedemail.com (Postfix) with ESMTP id 86C8110081F0 for ; Thu, 12 Aug 2021 08:56:56 +0000 (UTC) Received: by mail-oi1-f171.google.com with SMTP id r5so9228757oiw.7 for ; Thu, 12 Aug 2021 01:56:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CpNbFyXnXHPCTrfQK9jrNKENE4zlP3yIY6h8yYZAoL0=; b=XKyvMwXf6ld2suQ7v4o10/Mwzba2BnazQYjm/Mnva9F/4jx4nj2FjysWxq3ZQpPKs+ qcqWHbHCGNka/QHgern7puGDE0EdMCRkOYmgJw2oiPLTFMOwCXZtIiHVYjevSP70wb3y oZDKnKBtwE6F9K6DHixs8ztsAOx5w5UHCUNsVjxjqxjdp8qPp/jsqj1PDMn/oYFRpeAV I1iDgtnM1M4z7JMqs6Mio86xRD6mtDWHiAB8HVwxv5hUWbnG91XD+UOQ1NeEFqj43dJB BG46n7EmY3Zm/dbe4i4iOELegT/bA3SVUCpIYpsdvwTxQeaNb8EkPWnpLigVaQNHK713 IfGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CpNbFyXnXHPCTrfQK9jrNKENE4zlP3yIY6h8yYZAoL0=; b=MEabXvJ7ct5Zr0gGC74eNJyXWlOvhKl0ZcAT2j6qlp5BrJqjfq/20PaoeFeF2If5TL nd5ZHQitKFFVvbqnB93u8A+ntnWvScHS2UKbB6kEJMRIzsyxs+PGXzCjBdtpwbT4gRzk DfJHtTakD4W4fEbEeCBXFSkndVT0C4LIDBlQx7qXfp+9mDXPj3p0HfXx9mDZkuBrgzAA CqlRfyTxUuGJxCEe8mvmP1XvHR1dQRvsum+VgefUzV3Ab2Xofbg6SGp4H+mRVQ5F00mZ bbLdUqmKwXQUOHGaMNkD6z6RhA4YTa7CpRjsloXBiqHTrEdku9IyyanNpttzDY5jqt4S 6tJA== X-Gm-Message-State: AOAM531zX5GDZimzhAdFpBJ3JoasnwVl4yhp2Zr5AzB+SjgoejL33WDb MAd8QMJGGEF8vcD4/rqZmfTbXB60Ny75wcgnsjM10A== X-Google-Smtp-Source: ABdhPJymXxOTmk35yp+1Yawr5fY7uG03snHwzVDeA1bE4jw7jms1BHO34si+giJK72JgJCcEloICZoJ0dCiPPSlgzyw= X-Received: by 2002:aca:2316:: with SMTP id e22mr2503665oie.172.1628758615724; Thu, 12 Aug 2021 01:56:55 -0700 (PDT) MIME-Version: 1.0 References: <6e0ddf32ce140b9e8aaf127e9e40cbfff4430995.1628709663.git.andreyknvl@gmail.com> In-Reply-To: <6e0ddf32ce140b9e8aaf127e9e40cbfff4430995.1628709663.git.andreyknvl@gmail.com> From: Marco Elver Date: Thu, 12 Aug 2021 10:56:43 +0200 Message-ID: Subject: Re: [PATCH 5/8] kasan: test: only do kmalloc_uaf_memset for generic mode To: andrey.konovalov@linux.dev Cc: Andrew Morton , Andrey Konovalov , Andrey Ryabinin , Dmitry Vyukov , Alexander Potapenko , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20161025 header.b=XKyvMwXf; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf07.hostedemail.com: domain of elver@google.com designates 209.85.167.171 as permitted sender) smtp.mailfrom=elver@google.com X-Stat-Signature: ttag3tad9hrhijciq81cktnrsumuhqdn X-Rspamd-Queue-Id: 86C8110081F0 X-Rspamd-Server: rspam05 X-HE-Tag: 1628758616-273453 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 11 Aug 2021 at 21:21, wrote: > From: Andrey Konovalov > > kmalloc_uaf_memset() writes to freed memory, which is only safe with the > GENERIC mode (as it uses quarantine). For other modes, this test corrupts > kernel memory, which might result in a crash. > > Only enable kmalloc_uaf_memset() for the GENERIC mode. > > Signed-off-by: Andrey Konovalov Acked-by: Marco Elver > --- > lib/test_kasan.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/lib/test_kasan.c b/lib/test_kasan.c > index 0b5698cd7d1d..efd0da5c750f 100644 > --- a/lib/test_kasan.c > +++ b/lib/test_kasan.c > @@ -528,6 +528,12 @@ static void kmalloc_uaf_memset(struct kunit *test) > char *ptr; > size_t size = 33; > > + /* > + * Only generic KASAN uses quarantine, which is required to avoid a > + * kernel memory corruption this test causes. > + */ > + KASAN_TEST_NEEDS_CONFIG_ON(test, CONFIG_KASAN_GENERIC); > + > ptr = kmalloc(size, GFP_KERNEL); > KUNIT_ASSERT_NOT_ERR_OR_NULL(test, ptr); > > -- > 2.25.1