From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4798AC433F5 for ; Wed, 29 Sep 2021 12:45:33 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BA8DC61503 for ; Wed, 29 Sep 2021 12:45:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org BA8DC61503 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 4DA92940025; Wed, 29 Sep 2021 08:45:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 488D2940020; Wed, 29 Sep 2021 08:45:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 350BA940025; Wed, 29 Sep 2021 08:45:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0003.hostedemail.com [216.40.44.3]) by kanga.kvack.org (Postfix) with ESMTP id 26FF0940020 for ; Wed, 29 Sep 2021 08:45:32 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id E562231E6A for ; Wed, 29 Sep 2021 12:45:31 +0000 (UTC) X-FDA: 78640582062.09.6E6CD14 Received: from mail-ot1-f51.google.com (mail-ot1-f51.google.com [209.85.210.51]) by imf25.hostedemail.com (Postfix) with ESMTP id A906EB00018B for ; Wed, 29 Sep 2021 12:45:31 +0000 (UTC) Received: by mail-ot1-f51.google.com with SMTP id 77-20020a9d0ed3000000b00546e10e6699so2693653otj.2 for ; Wed, 29 Sep 2021 05:45:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TDNN1kFSC/fnkpvN4FxxnnuhSeRYTwee8Iq2doyYjYU=; b=lRVpwkBQh6MN54FQXDSwODst7PksnyRxoo3AuIwVLjbqgOY6zkMEC7tIvZ4nPu87eg NsMfUigEplVKq+C2Zpo4TGMX3NFjrYnSLLdUXxTNY4YueLhMG/cV/lkIIsahUeovR0Cp +nk8fOXCC7Qr6a1/Eecx6qcXR6yLWymoPzAXLaEr+O1A1Td1YW3bovQT2u9lZ4UN+jv8 OR+I6MIaCc/Q/fS5zcQ2C3zltW23lk61GLw0vW3QMgLMQNoymjNMhCDCvStcmHcPH/IJ 8GAD+hk+UnxAkSnmwmaa7UdIwoNOqKffb/sJ7Qmx7/rAo0jB5cL4eBp9IxTyfi3/JuAf CltQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TDNN1kFSC/fnkpvN4FxxnnuhSeRYTwee8Iq2doyYjYU=; b=5CUPiklZIuBGf1hYzMhC5fmuAdoua6M36C0W82774CHrulJ+0AD9250BQMeq0+rTlR VTr/Q331XUdYOJGKW5d3Kw5yx8326uEBXem26HWWF9gCEqpI2c+ieSkaSdCC4Ei4Cviw 6Em2OO7udWSz9ZazZzfJQC6meqVngW4D418wZfOW8HVqxFnXRbjnhkoVaE54X1rgggiI 1gAuXh5hYACuHVRh6H2c6COG6Fl6f+FV9CJk9brfbObHLQMfOTcsnbEwAvsmwIjbIYxG n3EfZW9sFLV8pnOYhBLlnPKqsiTtWQZ7j82WjjgdmnAqplaBqRavH1SxvAO5BtUCKqVA T2qg== X-Gm-Message-State: AOAM531Zi/rOVee1gvIjkfNAGhxEytwF2jiv4fjloZFcHBbRM41nPE6I s8AvwfIEQjuqEuBQQUibSrqjkOhQHfkPQ2qtxaqLsw== X-Google-Smtp-Source: ABdhPJwshPfU0u8Rmc/ls+CfHNk4a27/G3l5is5qWJ66RcP/VzHI6aqi6vGFU1tJFet2kE9xp8w+KwHScTENqo6xYhU= X-Received: by 2002:a9d:135:: with SMTP id 50mr9862599otu.295.1632919530692; Wed, 29 Sep 2021 05:45:30 -0700 (PDT) MIME-Version: 1.0 References: <20210929234929.857611-1-yanjun.zhu@linux.dev> In-Reply-To: From: Marco Elver Date: Wed, 29 Sep 2021 14:45:19 +0200 Message-ID: Subject: Re: [PATCH 1/1] mm/kasan: avoid export __kasan_kmalloc To: yanjun.zhu@linux.dev Cc: ryabinin.a.a@gmail.com, akpm@linux-foundation.org, kasan-dev@googlegroups.com, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: A906EB00018B X-Stat-Signature: 4mowonbu487xbnfhf59y1tz7m8tc84si Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=lRVpwkBQ; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf25.hostedemail.com: domain of elver@google.com designates 209.85.210.51 as permitted sender) smtp.mailfrom=elver@google.com X-HE-Tag: 1632919531-843930 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000014, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 29 Sept 2021 at 14:42, Marco Elver wrote: > > On Wed, Sep 29, 2021 at 07:49PM -0400, yanjun.zhu@linux.dev wrote: > > From: Zhu Yanjun > > > > Since the function __kasan_kmalloc is only used in kasan module, > > remove EXPORT_SYMBOL to this function. > > This is incorrect, see below. > > > @@ -521,7 +521,6 @@ void * __must_check __kasan_kmalloc(struct kmem_cache *cache, const void *object > > { > > return ____kasan_kmalloc(cache, object, size, flags); > > } > > -EXPORT_SYMBOL(__kasan_kmalloc); > > Sorry, but this will break all users of kmalloc() with KASAN on if > !TRACING: *module users. An allmodconfig but with CONFIG_TRACING=n will probably show you the problem. > __always_inline kmalloc() include/linux/slab.h > -> __always_inline kmem_cache_alloc_trace() include/linux/slab.h > -> __always_inline kasan_kmalloc() include/linux/kasan.h > -> __kasan_kmalloc() mm/kasan/common.c