From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89F16C35274 for ; Thu, 21 Dec 2023 20:14:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2C19F6B00AD; Thu, 21 Dec 2023 15:14:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 271756B00AE; Thu, 21 Dec 2023 15:14:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 160C16B00AF; Thu, 21 Dec 2023 15:14:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 06CC46B00AD for ; Thu, 21 Dec 2023 15:14:26 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id DC65F1A05E3 for ; Thu, 21 Dec 2023 20:14:25 +0000 (UTC) X-FDA: 81591927690.10.4625578 Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) by imf15.hostedemail.com (Postfix) with ESMTP id E9C07A001D for ; Thu, 21 Dec 2023 20:14:23 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="XEaM/CM+"; spf=pass (imf15.hostedemail.com: domain of elver@google.com designates 209.85.167.46 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703189664; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ijpi7yL8jJKP/LTHTn6tiHQRczMxthGLWkutDiKOvB4=; b=SzVwnANvkWOMwWovpu99EWL44KZJTo623F2ySYIDrODjJQiVLhrsfyF7tmEuhubauyJPzl 0uUKs8o2v3+Y716F7ChHQHDzl+TZRPGJPQi8wzpvf4z6k2Qc+CEEVfQ7g5pls3B3FI55gM IjlvbGKNQRXJWNsbfvOTB4AJ7HYOcMo= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="XEaM/CM+"; spf=pass (imf15.hostedemail.com: domain of elver@google.com designates 209.85.167.46 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703189664; a=rsa-sha256; cv=none; b=v2YQwr99VG7PwARl3YJArnFBBrURZo8zJjEJvy16Q2oCy0m9jeXmeUhwGQ+COTyshxKdYt 74f/1FL8nDvhucvw9wnCLwVaqp44z+ZUV8yYPMGzAkRsySia94tVMsteGYchF+c1Mk4ZK2 SK+FCICERzRXERV5/adJ6aCLgIBeytw= Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-50e3901c2e2so1535116e87.0 for ; Thu, 21 Dec 2023 12:14:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1703189662; x=1703794462; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=ijpi7yL8jJKP/LTHTn6tiHQRczMxthGLWkutDiKOvB4=; b=XEaM/CM+7fhx0oBxHUQRcaPIDqkCv0ith4kM48PSvYMeG9d71DApl9KB6UyAK8U49F moUshe+wgIIZIpA6zJvjdp4dHC19s+Ad3ozaXYmuMV0yMB1OIqk2CFA94nh9tGmm4KKZ 0FMTDdlr303PIt1bJDg6jbrF/c8dxA4p1eJZpTgsfypT+LyWpmw61Nyzo27YM8pinvEf Jsn655hMR8hy4gBjZKVKFFtAp7msUgZCw1jSpqP9EmxjLn2x5cnIK6Es2mJKnkozQ3nZ r6hZCJ05Y+CVs8JgLBZ6LH17jQ87COf6qR8+3iNASTbDKp6I0IDexhtiMrWq6KW4ZS03 cHvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703189662; x=1703794462; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ijpi7yL8jJKP/LTHTn6tiHQRczMxthGLWkutDiKOvB4=; b=ML3yffLkFkDc+91XfS38jcIJLGyEdTv5qlzC6yLf5roaBsbFbXRnWSfXpwzQSzJYZH ayjus4ozZxSCPDbp+j/rAEpTeVvOnabZsl8WV/HW4yBKlrlS0YvzDQwXOPgxQsiJNoNo NvwM2ekUguGx75yYI2xY/8qh4nreVq3wLpzaT3SpurgM7Rl0nPoJfR5kRSdhyvoPjR59 TcySMpVMdJKSPAelRSc934fG2W+nYswskuxvDC6nQ0WnsXIYfHqxCsf+gAHTgDvUyDHa VjWZ7GHBVk5QnyhE/ZlW0PMsc5a8pZ64klguHDJx89Z1eri5LRND20ZvDvLsu1dTIbpo /Z/g== X-Gm-Message-State: AOJu0Yxd+xTHaRzy9p8Hucx8l8xd+iFeda5/ABHMQ4ah7Ez0z12zxnbR EgBh/RmHWmMjRFFBAGuLF5h9p7WYIYXJoR6iC+pARbBMEciepFZc1w1mCMlJ8Kl9 X-Google-Smtp-Source: AGHT+IHBnrac0FEpnHGgr+WUxPanK1JDmNnibxTtSW5ojDg1dk13bRfTTGEW38UxwbiZtW29eD+v3LwcFyB1OtSnzHw= X-Received: by 2002:a05:6512:3767:b0:50e:644a:d384 with SMTP id z7-20020a056512376700b0050e644ad384mr83656lft.129.1703189662207; Thu, 21 Dec 2023 12:14:22 -0800 (PST) MIME-Version: 1.0 References: <20231221183540.168428-1-andrey.konovalov@linux.dev> <20231221183540.168428-4-andrey.konovalov@linux.dev> In-Reply-To: <20231221183540.168428-4-andrey.konovalov@linux.dev> From: Marco Elver Date: Thu, 21 Dec 2023 21:13:44 +0100 Message-ID: Subject: Re: [PATCH mm 4/4] kasan: simplify kasan_complete_mode_report_info for tag-based modes To: andrey.konovalov@linux.dev Cc: Andrew Morton , Juntong Deng , Andrey Konovalov , Alexander Potapenko , Dmitry Vyukov , Andrey Ryabinin , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: E9C07A001D X-Rspam-User: X-Stat-Signature: 7r8aq6588r6wd86e8pq4ymzmshcwqsa1 X-Rspamd-Server: rspam01 X-HE-Tag: 1703189663-695879 X-HE-Meta: U2FsdGVkX1/uhubDbl4ARoKFuMR3FVhOeWP+3aa4zqtIssX+ZNRYKVSgaEUCLmpbZG85AxFlotp+iwojdOFHscUyQy3mDQAVVDnRDYJZyM9SfUeSHbU5q4MnoJROuWB7B+qQfIJYAGl05jU/47ZcI0Ny1qzoYwFm0ebNahbUB2UcB7YmVel55UFZEulhFDHwHS764tgpya+tbEAM3LGNNpKbFEaWWc5BHHUqkZxFZ7RwxjHgVXzLuMT3cqXuS29mvqhd8uqbrXthRSmu4BGePgmxEsjk9NUSiwezcOppqXjIpCMteT/OfkT1xXS5ZEl5dqgK4voE19fGgF50OYb2sbb7vnMR5mBLBDaHLzgm3ltFz6+T/CFqoeVI9TEPv1DHS22XVjFuPQm6mG5bbir3jE5cjGFSGMyNkHH8fXCb7QPqICr5bx5Cg1n6LftmUr7leir0WUB76ysJwuGVYR/kZ8q4rZNaf2bP8r4AX6/uqRyPpq+CdjYVLbyyIP2eEFrAz5g9uN5UNWGYLEhUVfueI8E01eQvYC6yYSg1Zj13ZuFFafzkM2zy14jUqv9chkNkT+NNOUcR+vtEefIspipvLFyW2eDP+nnrV+2l7xz4kq35mCrFHz+Xzp6Clu3rZvnb+tHZuWbHLwnIkST1HF8Q7OsbB+g9VD4MCuwzc5+SxOII+YgWUGA0Iz6ZPXk2oV+T8zfGKFfGdFJixEahnR8dcOZxRmKG6gJ4uBAcHeNc2All9tyV9orCTPPJ88O3poTKr4fWxtLEU3QJbrVlKv234HD4nbNveTDrL9L7XY/vJWRMMth3gO8tfl42jP6J0vbS5eRl9NQEUIpVc56PNnpilQWrZihIG99ZH2D7HlI/FIQoh+YlCMXB9muLs4vdu3ozas7A3J8HhH9th9Q16h4vw5jT5pObU/WAZLg06NTzq83xmpgkum3moEmrV0GnSASMxS8VlCfbp8ad8fHQD/D EE+rEOKq tu1CQxFn6OvijuUxS1cImvPYmsfRk8AdvbEv2v1cSJOgOW4hrenHju9Ghn6qJe4nOEsyQRLGM5yIYDZZcjyEcU1YpG3TcVyGL+NYQyDpmGq7TIM130cbdWSFMmMIW6Ofi76f1uK9dWKeGcA8EfQJ8ebhTBHnppBs5LUWJiJjqk+ALggdBZx4+AAbuoeMn81p4zraTYI9sBJwEoXuwEZ4kZ7yZgV90jMMw6XrXHC4mp8wmesgy/9OOHdbojBQwW3GEOZ0dO1uZTagxTUK2oDyhO/R4+weWbAH9enLGQ18aAw1824MytQeHt3rhKeDhvIZ7dSw5IAJPjMsA2zs8Hz8KKdk/P5om9T8vjzwnLzxvvmjtpv+O1CLyMKjdZyvhWzIc0OuFtXkTYJ5SR8srP7C3JL08lw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 21 Dec 2023 at 19:35, wrote: > > From: Andrey Konovalov > > memcpy the alloc/free tracks when collecting the information about a bad > access instead of copying fields one by one. > > Fixes: 5d4c6ac94694 ("kasan: record and report more information") > Signed-off-by: Andrey Konovalov Reviewed-by: Marco Elver > --- > mm/kasan/report_tags.c | 23 ++++------------------- > 1 file changed, 4 insertions(+), 19 deletions(-) > > diff --git a/mm/kasan/report_tags.c b/mm/kasan/report_tags.c > index 688b9d70b04a..d15f8f580e2c 100644 > --- a/mm/kasan/report_tags.c > +++ b/mm/kasan/report_tags.c > @@ -27,15 +27,6 @@ static const char *get_common_bug_type(struct kasan_report_info *info) > return "invalid-access"; > } > > -#ifdef CONFIG_KASAN_EXTRA_INFO > -static void kasan_complete_extra_report_info(struct kasan_track *track, > - struct kasan_stack_ring_entry *entry) > -{ > - track->cpu = entry->track.cpu; > - track->timestamp = entry->track.timestamp; > -} > -#endif /* CONFIG_KASAN_EXTRA_INFO */ > - > void kasan_complete_mode_report_info(struct kasan_report_info *info) > { > unsigned long flags; > @@ -80,11 +71,8 @@ void kasan_complete_mode_report_info(struct kasan_report_info *info) > if (free_found) > break; > > - info->free_track.pid = entry->track.pid; > - info->free_track.stack = entry->track.stack; > -#ifdef CONFIG_KASAN_EXTRA_INFO > - kasan_complete_extra_report_info(&info->free_track, entry); > -#endif /* CONFIG_KASAN_EXTRA_INFO */ > + memcpy(&info->free_track, &entry->track, > + sizeof(info->free_track)); Not sure why the line break is necessary. > free_found = true; > > /* > @@ -98,11 +86,8 @@ void kasan_complete_mode_report_info(struct kasan_report_info *info) > if (alloc_found) > break; > > - info->alloc_track.pid = entry->track.pid; > - info->alloc_track.stack = entry->track.stack; > -#ifdef CONFIG_KASAN_EXTRA_INFO > - kasan_complete_extra_report_info(&info->alloc_track, entry); > -#endif /* CONFIG_KASAN_EXTRA_INFO */ > + memcpy(&info->alloc_track, &entry->track, > + sizeof(info->alloc_track)); > alloc_found = true; > > /* > -- > 2.25.1 >