linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Marco Elver <elver@google.com>
To: Hyeonggon Yoo <42.hyeyoo@gmail.com>
Cc: Feng Tang <feng.tang@intel.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	 Alexander Potapenko <glider@google.com>,
	Dmitry Vyukov <dvyukov@google.com>,
	Vlastimil Babka <vbabka@suse.cz>,
	 kasan-dev@googlegroups.com, linux-mm@kvack.org
Subject: Re: [PATCH -next] mm: kence: add __kmem_cache_free to function skip list
Date: Wed, 31 Aug 2022 16:21:38 +0200	[thread overview]
Message-ID: <CANpmjNMFOmtu3B5NCgrbrbkXk=FVfxSKGOEQvBhELSXRSv_1uQ@mail.gmail.com> (raw)
In-Reply-To: <Yw9qeSyrdhnLOA8s@hyeyoo>

On Wed, 31 Aug 2022 at 16:04, Hyeonggon Yoo <42.hyeyoo@gmail.com> wrote:

> Maybe you can include those functions too?
>
> - __kmem_cache_alloc_node
> - kmalloc_[node_]trace, kmalloc_large[_node]

This is only required if they are allocator "root" functions when
entering allocator code (or may be tail called by a allocator "root"
function). Because get_stack_skipnr() looks for one of the listed
function prefixes in the whole stack trace.

The reason __kmem_cache_free() is now required is because it is tail
called by kfree() which disappears from the stack trace if the
compiler does tail-call-optimization.


  reply	other threads:[~2022-08-31 14:22 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-31  7:30 Feng Tang
2022-08-31  7:35 ` Marco Elver
2022-08-31 11:37   ` Vlastimil Babka
2022-08-31 14:04 ` Hyeonggon Yoo
2022-08-31 14:21   ` Marco Elver [this message]
2022-08-31 16:16     ` Vlastimil Babka
2022-09-01  1:26       ` Feng Tang
2022-09-01  8:47         ` Vlastimil Babka
2022-09-01 12:41           ` Feng Tang
2022-08-31 14:44   ` Feng Tang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANpmjNMFOmtu3B5NCgrbrbkXk=FVfxSKGOEQvBhELSXRSv_1uQ@mail.gmail.com' \
    --to=elver@google.com \
    --cc=42.hyeyoo@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=dvyukov@google.com \
    --cc=feng.tang@intel.com \
    --cc=glider@google.com \
    --cc=kasan-dev@googlegroups.com \
    --cc=linux-mm@kvack.org \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox