From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED176CCA481 for ; Mon, 20 Jun 2022 13:40:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 685B96B0071; Mon, 20 Jun 2022 09:40:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 632B38E0002; Mon, 20 Jun 2022 09:40:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 523FD8E0001; Mon, 20 Jun 2022 09:40:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 42C1A6B0071 for ; Mon, 20 Jun 2022 09:40:03 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id 2507C6023F for ; Mon, 20 Jun 2022 13:40:03 +0000 (UTC) X-FDA: 79598722686.14.46FD840 Received: from mail-yb1-f177.google.com (mail-yb1-f177.google.com [209.85.219.177]) by imf01.hostedemail.com (Postfix) with ESMTP id AF454400B9 for ; Mon, 20 Jun 2022 13:40:02 +0000 (UTC) Received: by mail-yb1-f177.google.com with SMTP id x38so19009276ybd.9 for ; Mon, 20 Jun 2022 06:40:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WS4VFRwLCNQ3Gv6onv6Grnwt8jHHc1O3704ajv1HwX8=; b=oe3RFUCFtQsf2C6GbVuLT4H9zsB2uSOBU8ynW0d58tLz9eliKUvPOnd7yGRq8ujcgj bQEYRUlPrSOo51iJQlpJvSxpxQ3NW5hhBldbwTnE/1cHebxP6baEdZoUlcfKnPC7hA+D ItrLiJO0KmnQCCN4GpecieYlpdTU5X+JyGAdi06uXyJA68eQnMEtAPDwqXeC7qw7x9CL DH7/GUHyMf2n/Okv3gqxzoJ8M9p35Lk+Nvyj1OYHvn3XtR8EJ3EVwIlh93wnrX0ufJjy dSx7vAqQTl7KhADa5j36BnlSMSoazoQtyrN1iTgjB6TAXwv2f/IVdtHQwUDhiXtB/OpE xQ0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WS4VFRwLCNQ3Gv6onv6Grnwt8jHHc1O3704ajv1HwX8=; b=LGjhbFXHjcdVg2+PbbpH9uW3TfRbXSncyxIXYFCpmdAmOQN8L2zLMZsiIVMJ68idHY Qot7UvkjDtg/O+DoAYOtUh9lwOWgTvVNtveKRxvFHGXoO7vN4vFFz028albZZbyMObNQ DP25MqgoACVUF7/FE9LVD/GfLZweJtW7hfK6SqhN44yujpXH+RixMwF4X++QmbFa5bME gx0a+VTVNOmuKV85PrTQW6P/jPUfA4cd17uX3phB3Cwn4IyaR292GT6lZ1D1ARQ1BbPQ AFkyboVMsa/dPHYj39SzjN4W3KRJJK9rib9d+Ma9NSpdRaMfpbLy2WwkNPjCDKo8WGnc rYtg== X-Gm-Message-State: AJIora+Odo/XpulgeHAZ2bJHLsRzsdAI1+qzqmHvaHFCyG4/TPyakuUH yqZd+zQLsI7mN2JrTw+Yc++ZOBDaKxvCGf0NZlxzdg== X-Google-Smtp-Source: AGRyM1vRcYVHrLrEyrWcPlNUihQGx+K0o4UAIjdcz+oIlc3j+a6xk8wSBx8O7GIO95PC80xMSGoFy4rwkBtYrU3IeMI= X-Received: by 2002:a25:94a:0:b0:668:df94:fdf4 with SMTP id u10-20020a25094a000000b00668df94fdf4mr10943765ybm.425.1655732401678; Mon, 20 Jun 2022 06:40:01 -0700 (PDT) MIME-Version: 1.0 References: <91406e5f2a1c0a1fddfc4e7f17df22fda852591c.1655150842.git.andreyknvl@google.com> In-Reply-To: <91406e5f2a1c0a1fddfc4e7f17df22fda852591c.1655150842.git.andreyknvl@google.com> From: Marco Elver Date: Mon, 20 Jun 2022 15:39:25 +0200 Message-ID: Subject: Re: [PATCH 01/32] kasan: check KASAN_NO_FREE_META in __kasan_metadata_size To: andrey.konovalov@linux.dev Cc: Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Andrey Ryabinin , kasan-dev@googlegroups.com, Peter Collingbourne , Evgenii Stepanov , Florian Mayer , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655732402; a=rsa-sha256; cv=none; b=8Zszl0zmIWPPzFXJV4C8sayJC22vb7f3eQ6CxJCiiw+xF5fulHxr6SAow0O9vlVHv7zq+Z LC30v+DlbtB38LeelZ/CYMI5NJuRcoT69uKdmY36b8O41RNy6GIgA0VKfgbJ++tUQYqEAZ /QKtHJK83R10ealax5Xg5YT9BOUdig0= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=oe3RFUCF; spf=pass (imf01.hostedemail.com: domain of elver@google.com designates 209.85.219.177 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655732402; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WS4VFRwLCNQ3Gv6onv6Grnwt8jHHc1O3704ajv1HwX8=; b=INuwi1iLDRmMct3eoL97P0gcCbMfjOWX+hSgfW/WKxs8VG0+jDuS4Ev5aKXdvGMOTgFmll l7jQjM03tcqXDsqz+u0/rJSEvQ1UTyUFGUxiQcaGOM9kHgJepzzsmfsYjILDUdUMneXey1 uUVrnxHED30GH/m0DadHzrvFsE10E0g= X-Stat-Signature: gghwd3xyj4owjhwnqxe3pjbo47jsb3ob X-Rspamd-Queue-Id: AF454400B9 Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=oe3RFUCF; spf=pass (imf01.hostedemail.com: domain of elver@google.com designates 209.85.219.177 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspamd-Server: rspam07 X-Rspam-User: X-HE-Tag: 1655732402-24828 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 13 Jun 2022 at 22:15, wrote: > > From: Andrey Konovalov > > __kasan_metadata_size() calculates the size of the redzone for objects > in a slab cache. > > When accounting for presence of kasan_free_meta in the redzone, this > function only compares free_meta_offset with 0. But free_meta_offset could > also be equal to KASAN_NO_FREE_META, which indicates that kasan_free_meta > is not present at all. > > Add a comparison with KASAN_NO_FREE_META into __kasan_metadata_size(). > > Signed-off-by: Andrey Konovalov Reviewed-by: Marco Elver > --- > > This is a minor fix that only affects slub_debug runs, so it is probably > not worth backporting. > --- > mm/kasan/common.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/mm/kasan/common.c b/mm/kasan/common.c > index c40c0e7b3b5f..968d2365d8c1 100644 > --- a/mm/kasan/common.c > +++ b/mm/kasan/common.c > @@ -223,8 +223,9 @@ size_t __kasan_metadata_size(struct kmem_cache *cache) > return 0; > return (cache->kasan_info.alloc_meta_offset ? > sizeof(struct kasan_alloc_meta) : 0) + > - (cache->kasan_info.free_meta_offset ? > - sizeof(struct kasan_free_meta) : 0); > + ((cache->kasan_info.free_meta_offset && > + cache->kasan_info.free_meta_offset != KASAN_NO_FREE_META) ? > + sizeof(struct kasan_free_meta) : 0); > } > > struct kasan_alloc_meta *kasan_get_alloc_meta(struct kmem_cache *cache, > -- > 2.25.1 > > -- > You received this message because you are subscribed to the Google Groups "kasan-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an email to kasan-dev+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/kasan-dev/91406e5f2a1c0a1fddfc4e7f17df22fda852591c.1655150842.git.andreyknvl%40google.com.