From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D02F7C4725D for ; Fri, 19 Jan 2024 11:00:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 65F856B007E; Fri, 19 Jan 2024 06:00:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 60FAA6B0080; Fri, 19 Jan 2024 06:00:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4D7A16B0081; Fri, 19 Jan 2024 06:00:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 3CA2F6B007E for ; Fri, 19 Jan 2024 06:00:33 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id F07E380A52 for ; Fri, 19 Jan 2024 11:00:32 +0000 (UTC) X-FDA: 81695767104.23.1A43C95 Received: from mail-yb1-f178.google.com (mail-yb1-f178.google.com [209.85.219.178]) by imf27.hostedemail.com (Postfix) with ESMTP id 4611B40010 for ; Fri, 19 Jan 2024 11:00:31 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=eU2qhiWZ; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf27.hostedemail.com: domain of elver@google.com designates 209.85.219.178 as permitted sender) smtp.mailfrom=elver@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705662031; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kW4AZyeA4bljp7x9nTqzteku8F1VnnufDy0bi8JpooQ=; b=llEDSEIIVFuqfmjn6zqfm8DtVdCY9+qYVuEIcRoNw1DbrEoqio7a3i61bfo7RKslBtR71v +lrAgMVvKKcSeSIHhRieo+c/8c5/6cUh7D52Y7pfwY3nGgpCP6WA1oQUpuco29inuJmVTf j/yjzGQKUSlU35DRVF/dELXdZj/8+Qs= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=eU2qhiWZ; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf27.hostedemail.com: domain of elver@google.com designates 209.85.219.178 as permitted sender) smtp.mailfrom=elver@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705662031; a=rsa-sha256; cv=none; b=wHasrovvXgMutRvXZhomzsHEipYax8g3Pl5s2sNnL/S1ekQ1hf6CK1RKtQxNmeNlM8HcX1 gfnIR8vAQbkERxlVw0CypC3peWTQnXtPFJQuUwECECZEYfGfo+y0DhGVaSHWbhnkWKOUIh iLYDeyE5arBoV4qgNBxOGB3DkGORVWU= Received: by mail-yb1-f178.google.com with SMTP id 3f1490d57ef6-db4364ecd6aso552256276.2 for ; Fri, 19 Jan 2024 03:00:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1705662030; x=1706266830; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=kW4AZyeA4bljp7x9nTqzteku8F1VnnufDy0bi8JpooQ=; b=eU2qhiWZ86tXgYsqeu0n9Adv0NVzlfLkHLedaOegyoYbQKnbdPXeiWbJ8w23gHG2NS hV+sgMMzS7LYwJRXTkbLY5wWdVdymqHflUkWTmW5ts9I+dqa7UJ59aEVAIhMX0od8KJ5 ns3qgDScRSV4E5M0FQx4bBE9L+2xUC2LtkgGKMVlIl3fznOKUnBEp1z0Ix+7cyXLYMWE tNi7vaBgD2voqix/Vg0llwoTR6ma4iLe2V7gQZ6xUxrS+Jdxx1nuNV4DVc7WZWqi/SiT mfNjiFULcsxKxpXBTLd8sE8KkGOtTg0Ar089mBc9ly7bsgRbHqABeyybH6DLBFhgyTSc ltmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705662030; x=1706266830; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kW4AZyeA4bljp7x9nTqzteku8F1VnnufDy0bi8JpooQ=; b=X+OASMVU8QO6MVkr29QtQM/C0SSdXe9o/BH7G8MvAGuZDc8eG1knIPmK1Mg7ugk3d+ T2CI0KkcvDN3G3fRDo9gXZiojdDpKD5hfQYbCHN6VimhJysZAEVDak0R+R+uuYnZUFQT tIPxrYBUhjJ3piShDVwo/ufjF0pK5fKRInkn7eu97n2gmMox7SDW2n9a7Fo2fKqwe8l6 gA+U6y3YkaK03borTn7hUpwlMDSfdLvFR2BUizwh+00LEQpTg5XL/b9vNoGfvN4+jFDz LVTkY+yOzQAG7kpUBMgALUmn0gTyDqmseBGz7XR62L9GYoYbKsjLW9J7qiA/FW2Z20pv jwEA== X-Gm-Message-State: AOJu0YyWv0VWS+RrCcf7rK0ft8Kagx+ewLsqHhAdwi0W5ZeUzzDg0Xjz NZPFNoKZgXP+iggIuXkC2W1e1c5pgQWs8V3JGeo1QNyC+GDUly6F7+Qi01c2hHIdQA67v73LLa9 A4DaUJwukfg1381uHWguW7GJ7wcO3ovTfOx03 X-Google-Smtp-Source: AGHT+IH43KcVJy94YdV7VaeLq8V0TGB/qMQbBhYYFRL9gVy1PzmmQ0UZASDTafAYC5KFNDONbReJLFfeSMjgeji5Mjk= X-Received: by 2002:a25:8686:0:b0:dc2:5515:6f64 with SMTP id z6-20020a258686000000b00dc255156f64mr1546205ybk.93.1705662030096; Fri, 19 Jan 2024 03:00:30 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Marco Elver Date: Fri, 19 Jan 2024 11:59:54 +0100 Message-ID: Subject: Re: regression/bisected commit 773688a6cb24b0b3c2ba40354d883348a2befa38 make my system completely unusable under high load To: Mikhail Gavrilov Cc: glider@google.com, dvyukov@google.com, eugenis@google.com, Oscar Salvador , Vlastimil Babka , Andrew Morton , Linux List Kernel Mailing , Linux Memory Management List , Andrey Konovalov Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Stat-Signature: rquspc4156984gqbgcy5fu1i1ie8si8j X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 4611B40010 X-HE-Tag: 1705662031-260553 X-HE-Meta: U2FsdGVkX18q146/Vr4PgdqNRkfwmbIH1tCJxvesZe7zO01SGOJiw4NjR/sIvSpzJDJm9mQBejhTkyMQYmDz+DKvOtXqOGaICDi2OchUfMp8OxUDF6oY0QgV6NauM/E5m+COqcgPt44VS3x52JBgCERul2wPl/Ao86JB1xIJ23JyWgYb+ktbKAeTRWb2HN91AvsiZKPJcQkY2Ij3pFNBXq6LUHu2uUhnaMlen1Wju/zYm5xbVezUQJWC1LTly3KV+xDDJKLJGwPzKRCg3AaoiUDLBk9jlKuCI8Guq1etDJrNNqOwnVNVglVcfrOn0D/s5blWG7B2lTlYmMmGYyLhItSmkd3X1xL8ffSZNLo26hGR+sg1E1rV13FEzkl0m+wyB986D3727oQ52vfAW+eHb0Z8TzX1Zm81pWRdFg0HYulWgftbJ4K9Qz3rIQulzdT1Zpq/ycZ85T1pa2XtuRZpnlBgkrOSyB7CUmhg8dk7wex1jXnwpV2OPKDGo4WvkM+OCYwQyWZVDKczGpAQO92Ebq7WVbfjizoGZFY/7P4xVFfO7Uk2oZYtMD4zc7PDxuQVQd7VdHQjCc0xE71qcMr6OQQUMZVvyYIy1f2hUp3yhZ/oPW9fchwPb4Cr0COJOLsavWbT8RlaOKDiLznNqmy1yqn5q4SZKE2FyQgMrmZYr4Hn/XTVx4jBQaZYMxLpGJJLKap9C5M5VcLDYYmnio9qxT9KiOWvmFl8eZVVr6XdxSYFalPTjO8j8d1VQXhtCWPwE0pj2DxSgn90x415412FvUFqf1qZT93Ouid5N41T2RzzwcDpwRPDeNAlYy+RZT03xNlvMqZZQNBHxbCsnx9KHnzG8aQ5PQ1yplK2BqIhTuCfhApGtolcvYZ/i1mv49+83iFtbmC7YLN+dwHw9udSiKUhifrGk9Uktsk5voLIq6nSJlMgpt4Frk81T16RsuAtQK3VW6+vzvGGzIUq9xT L87oDkTo BTI8jEpofCnentHe8EUdOOAnZxg2Xyj2l4V9uvn/k+wuvZpIDnocak7a+en65BQoQlTpzoiK3dpUozHvNJcBgOL3DofEKMjyKCvJECKb/ge/2r5UbENTx7yYUuIxkUWKXMDQ1jzeEy12F/pswyFHjJ7ErZAoQkYYG7BapZjrZNjYx7SnR1WMZKPxH9N0Du6GvI7BcGXYGVx0oayBdpH9p9LFKiMuZxLsTAGes/KsAMhkcRfb/kvA5FRS5CxFr3c3CO+CgfFcauFKX/FyT5iKAwuV/QIdkvz7W6uCp39hzO3WdhAW3n564+I4KRJPwl/V7Fc3sCJXfm/ZM0mJq6SCXugrQNAR7LV5Sy1bP1KGqCS3lfaS1TnTQfXJdo0Zh29Tn0YJRTq3nlSJMAsBXi3n7jQXl6A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.045287, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 19 Jan 2024 at 11:54, Marco Elver wrote: > > On Fri, 19 Jan 2024 at 11:46, Mikhail Gavrilov > wrote: > > > > Hi, > > I use a system with KASAN sanitizer everyday. > > Because I want to catch difficult-to-repeat bugs. > > And all worked fine until commit 773688a6cb24b0b3c2ba40354d883348a2befa38. > > After commit 773688a6cb24b0b3c2ba40354d883348a2befa38 all working > > jerky when I compile something. > > The sound is interrupted, the cursor moves jerkily if I try to do > > anything when all the cores are loaded. > > > > > git bisect bad > > 773688a6cb24b0b3c2ba40354d883348a2befa38 is the first bad commit > > commit 773688a6cb24b0b3c2ba40354d883348a2befa38 > > Author: Andrey Konovalov > > Date: Mon Nov 20 18:47:19 2023 +0100 > > > > kasan: use stack_depot_put for Generic mode > [...] > > mm/kasan/common.c | 3 ++- > > mm/kasan/generic.c | 22 ++++++++++++++++++---- > > mm/kasan/quarantine.c | 26 ++++++++++++++++++++------ > > 3 files changed, 40 insertions(+), 11 deletions(-) > > > > I attached here my build .config and kernel log. > > Who could dig into it, please? > > I was afraid this would happen - could you try this patch series: > https://lore.kernel.org/all/20240118110216.2539519-2-elver@google.com/ [1] In addition, could you give some additional details about the number of CPUs in your system? And if possible, do you have a way to measure performance besides the obvious lagging of the system? It would be interesting to know if the fix in [1] regains performance fully. One major difference is still that an atomic RMW is in the fast paths. This could be fixed by reverting 773688a6cb24b0b3c2ba40354d883348a2befa38 on top of everything else, but we're not sure yet that's necessary because the cost of an atomic RMW really depends on the system you're working with.