From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D1E7C388F9 for ; Wed, 11 Nov 2020 08:29:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D5AB32074B for ; Wed, 11 Nov 2020 08:29:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="fY5gjnlc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D5AB32074B Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 497706B0036; Wed, 11 Nov 2020 03:29:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 46E736B005D; Wed, 11 Nov 2020 03:29:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3873F6B0068; Wed, 11 Nov 2020 03:29:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0062.hostedemail.com [216.40.44.62]) by kanga.kvack.org (Postfix) with ESMTP id 0E3C36B0036 for ; Wed, 11 Nov 2020 03:29:57 -0500 (EST) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id AC5691EE6 for ; Wed, 11 Nov 2020 08:29:56 +0000 (UTC) X-FDA: 77471464392.18.tub19_130939f272fc Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin18.hostedemail.com (Postfix) with ESMTP id 8EC29100ED9DF for ; Wed, 11 Nov 2020 08:29:56 +0000 (UTC) X-HE-Tag: tub19_130939f272fc X-Filterd-Recvd-Size: 5877 Received: from mail-oi1-f179.google.com (mail-oi1-f179.google.com [209.85.167.179]) by imf03.hostedemail.com (Postfix) with ESMTP for ; Wed, 11 Nov 2020 08:29:56 +0000 (UTC) Received: by mail-oi1-f179.google.com with SMTP id c80so1344615oib.2 for ; Wed, 11 Nov 2020 00:29:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pfSE5/lXKDKWvupd66vFeefPVzfzS3PVTtaZxopqHn0=; b=fY5gjnlcVshqGSRA6q6KUAXv/ADS/nDaZZEyYRq0zzOlqIBhd8YeaznY6x2LonMMEp +kkAI7SHlgNaXz8mMj5c4GYchnXQH1qFHxKneGweu9V6EHXVaNk7NYehPvYga6Dveujn q/bc+0hMvDzb80sshZeUn0EZr7bir5H7LXoXI5VwKMQ8M/mz5lGOmue1AuHbSj+NLbFB co9evogF7/JXWpyLdV+31dm4BJHr52+12hPBXtoUHOF3a5Q4p6Fu+0QYAFodijk3BUmg pkywXX9HE60D3PCTBgBIUqJrKCMJRgiO98visg0AVt6QArGrRCua17+swFdxRoyOGZvD vu6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pfSE5/lXKDKWvupd66vFeefPVzfzS3PVTtaZxopqHn0=; b=Lih6/P9nzP+VnXwY/AMYP0gdfdB8Hoj9Vw9m8fE2EeHMpQE5K72J2H4Ukbpcm0pHJ1 PSx4XMT7z9yqJFBmJd1u54whyGc4b7kTvCnzUGjzEqTUGEfTvcHcSUiYgPWqrimNNWdl c+Yw5jaKRqvBqKrbVKsQlnoRYwMsxuyi2zg2aPobczzSMe9Syz9It4nNxAHKty9LOQCl zP4GwZmkg/GXgwqDPEqpREsQzu4IP92ZNQyFVOhJsn+EM5OJOrMG3l4CdxsC0z4NtpZZ nIxbmr2mMMKgKF7+tsGI5J7dAJVKzReYens+m6kA1i3cMN/SdUWZEzApjZC6/1NmEa6I 8Wrw== X-Gm-Message-State: AOAM532SDRN3ctfwrM/aQ2hFdWeNS09+MaT1GlX+yz3K3Se8z18y9Y4h lQ26OOGnWp3kjyPtioGbgLVl9D1VfPhahs0M9yQb9g== X-Google-Smtp-Source: ABdhPJzSacpvGvWxh02TIAEIeTJX7iTjjyCW2uU9tYSTviNQgaMkp7c83J1N3CAcupo238JycrG45gFh4n4SmI6HuL8= X-Received: by 2002:a05:6808:5ca:: with SMTP id d10mr1524759oij.70.1605083395264; Wed, 11 Nov 2020 00:29:55 -0800 (PST) MIME-Version: 1.0 References: <20201110135320.3309507-1-elver@google.com> In-Reply-To: From: Marco Elver Date: Wed, 11 Nov 2020 09:29:43 +0100 Message-ID: Subject: Re: [PATCH] kfence: Avoid stalling work queue task without allocations To: Anders Roxell Cc: Andrew Morton , Alexander Potapenko , Dmitry Vyukov , Jann Horn , Mark Rutland , Linux Kernel Mailing List , Linux-MM , kasan-dev Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 11 Nov 2020 at 00:23, Anders Roxell wrote: [...] > > I gave them a spin on next-20201105 [1] and on next-20201110 [2]. > > I eventually got to a prompt on next-20201105. > However, I got to this kernel panic on the next-20201110: > > [...] > [ 1514.089966][ T1] Testing event system initcall: OK > [ 1514.806232][ T1] Running tests on all trace events: > [ 1514.857835][ T1] Testing all events: > [ 1525.503262][ C0] hrtimer: interrupt took 10902600 ns > [ 1623.861452][ C0] BUG: workqueue lockup - pool cpus=0 node=0 > flags=0x0 nice=0 stuck for 65s! > [...] > [ 7823.104349][ T28] Tainted: G W > 5.10.0-rc3-next-20201110-00008-g8dc06700529d #3 > [ 7833.206491][ T28] "echo 0 > > /proc/sys/kernel/hung_task_timeout_secs" disables this message. > [ 7840.750700][ T28] task:kworker/0:1 state:D stack:26640 pid: > 1872 ppid: 2 flags:0x00000428 > [ 7875.642531][ T28] Workqueue: events toggle_allocation_gate > [ 7889.178334][ T28] Call trace: > [ 7897.066649][ T28] __switch_to+0x1cc/0x1e0 > [ 7905.326856][ T28] 0xffff00000f7077b0 > [ 7928.354644][ T28] INFO: lockdep is turned off. > [ 7934.022572][ T28] Kernel panic - not syncing: hung_task: blocked tasks > [ 7934.032039][ T28] CPU: 0 PID: 28 Comm: khungtaskd Tainted: G > W 5.10.0-rc3-next-20201110-00008-g8dc06700529d #3 > [ 7934.045586][ T28] Hardware name: linux,dummy-virt (DT) > [ 7934.053677][ T28] Call trace: > [ 7934.060276][ T28] dump_backtrace+0x0/0x420 > [ 7934.067635][ T28] show_stack+0x38/0xa0 > [ 7934.091277][ T28] dump_stack+0x1d4/0x278 > [ 7934.098878][ T28] panic+0x304/0x5d8 > [ 7934.114923][ T28] check_hung_uninterruptible_tasks+0x5e4/0x640 > [ 7934.123823][ T28] watchdog+0x138/0x160 > [ 7934.131561][ T28] kthread+0x23c/0x260 > [ 7934.138590][ T28] ret_from_fork+0x10/0x18 > [ 7934.146631][ T28] Kernel Offset: disabled > [ 7934.153749][ T28] CPU features: 0x0240002,20002004 > [ 7934.161476][ T28] Memory Limit: none > [ 7934.171272][ T28] ---[ end Kernel panic - not syncing: hung_task: > blocked tasks ]--- > > Cheers, > Anders > [1] https://people.linaro.org/~anders.roxell/output-next-20201105-test.log > [2] https://people.linaro.org/~anders.roxell/output-next-20201110-test.log Thanks for testing. The fact that it passes on next-20201105 but not on 20201110 is strange. If you boot with KFENCE disabled (boot param kfence.sample_interval=0), does it boot? In your log [2] I see a number of "BUG: workqueue lockup ..." but that doesn't make sense, at least I don't think the KFENCE work item is causing this. It'd be interesting to bisect what changed between 20201105 and 20201110, but I have a suspicion that might take too long. Short of that, let me see if there are any changes between the 2 that look like it might be causing this. Thanks, -- Marco