From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B3F8C433EF for ; Fri, 3 Dec 2021 23:42:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E5A886B0073; Fri, 3 Dec 2021 18:42:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E0A2B6B0074; Fri, 3 Dec 2021 18:42:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CD1AE6B0075; Fri, 3 Dec 2021 18:42:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0009.hostedemail.com [216.40.44.9]) by kanga.kvack.org (Postfix) with ESMTP id BE1006B0073 for ; Fri, 3 Dec 2021 18:42:25 -0500 (EST) Received: from smtpin31.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 861BF18432CDE for ; Fri, 3 Dec 2021 23:42:15 +0000 (UTC) X-FDA: 78878109030.31.3A61B60 Received: from mail-ot1-f47.google.com (mail-ot1-f47.google.com [209.85.210.47]) by imf18.hostedemail.com (Postfix) with ESMTP id 274834002088 for ; Fri, 3 Dec 2021 23:42:15 +0000 (UTC) Received: by mail-ot1-f47.google.com with SMTP id x43-20020a056830246b00b00570d09d34ebso5444238otr.2 for ; Fri, 03 Dec 2021 15:42:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4JwQlDJ0eW7f9hYvr2thOhENg/qO/ZaZzGs6+sDFshM=; b=AJ/TTnwyVYSX6l2dbIpeBUSjXxXc1p865vm+D2RhGu04FOd1dojH/S075xAjkHvREE CX63gNQpg8eFmDqxN/+1Qwah0kEZdrJU5IZLuEmukgMBSbGT8ZVsX87ACdVvxTvnXDBK mZYWElg8rD4PTchWPB7nykjdZkyxRmpHBGGNR8kqpq8vCZXDfxbqez7uIQ5NdV7hMoCV Lf3SWZgqQW1MzTH/UOTBSje7705REt9thTaNdYmeUjFBEC9AlYqm2gHhrWgfoy3hsGkp iLaT99dRzBy0QEyguUM6y79ZuC6inrGFlSDfBARE+En7rgXRrfkwyxOXfrRn2Ukcdd0x ZlTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4JwQlDJ0eW7f9hYvr2thOhENg/qO/ZaZzGs6+sDFshM=; b=pusaZ0sq7SCcTP9lB1r2LcwhFi6BKCbxvbkrlY2a80nIF0iN8HCRRQgwuIpMVipuy3 Xv5exBgocAf/EZqIcUO+CPKnF2+M0f2i29qsVMuqFCaKrpUnHiTiIX3LnVB2J2QwQMzC 62aPe/9l/EbLsf8yrrdTGQICidFHAdqC1Gz5GmdeAq00pKHjPpyMrX4ObSpgPTxJShCn yO5ok1vhJi0+hVXAUBbgc8ISw6rkgxfIIUEKJQ6VGNRMFj7Y4ru7eFlr38Ej1cr6IHxm QeqIiJDGbOmheLwLr0hxCoN6NhH+L0eyamGLwA7B+vAzi70rXc5mQVPY7vcUDhQA33oO tnTw== X-Gm-Message-State: AOAM532uUKFbq/aveZrZLuUmUZLFRU5axmqO5DUNfXcwvgByDt1zjzwL YBg3+VBaQ8kh2tYuP4suj8/a8MF4kK2IIsJvawLAgg== X-Google-Smtp-Source: ABdhPJzmeHxYPCJX3eYijPp8C1oQT6JTRLMS+qeYs0OAMS77tBDynJpAjMPOmqpeKVSmDxkzBYLKtTfkIQWBc6uaOn0= X-Received: by 2002:a9d:7548:: with SMTP id b8mr18387018otl.92.1638574934196; Fri, 03 Dec 2021 15:42:14 -0800 (PST) MIME-Version: 1.0 References: <20211130114433.2580590-1-elver@google.com> <20211130114433.2580590-5-elver@google.com> <20211203165020.GR641268@paulmck-ThinkPad-P17-Gen-1> <20211203210856.GA712591@paulmck-ThinkPad-P17-Gen-1> In-Reply-To: <20211203210856.GA712591@paulmck-ThinkPad-P17-Gen-1> From: Marco Elver Date: Sat, 4 Dec 2021 00:42:02 +0100 Message-ID: Subject: Re: [PATCH v3 04/25] kcsan: Add core support for a subset of weak memory modeling To: paulmck@kernel.org Cc: Alexander Potapenko , Boqun Feng , Borislav Petkov , Dmitry Vyukov , Ingo Molnar , Mark Rutland , Peter Zijlstra , Thomas Gleixner , Waiman Long , Will Deacon , kasan-dev@googlegroups.com, linux-arch@vger.kernel.org, linux-doc@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, llvm@lists.linux.dev, x86@kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 274834002088 X-Stat-Signature: 4dmcyqj64ouqde5azmqrs9ca6y7t8p8h Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="AJ/TTnwy"; spf=pass (imf18.hostedemail.com: domain of elver@google.com designates 209.85.210.47 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com X-HE-Tag: 1638574935-395524 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 3 Dec 2021 at 22:09, Paul E. McKenney wrote: [...] > A few quick tests located the following: > > [ 0.635383] INFO: trying to register non-static key. > [ 0.635804] The code is fine but needs lockdep annotation, or maybe > [ 0.636194] you didn't initialize this object before use? > [ 0.636194] turning off the locking correctness validator. > [ 0.636194] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5.16.0-rc1+ #3208 [...] > When running without the new patch series, this splat does not appear. > > Do I need a toolchain upgrade? I see the Clang 14.0 in the cover letter, > but that seems to apply only to non-x86 architectures. > > $ clang-11 -v > Ubuntu clang version 11.1.0-++20210805102428+1fdec59bffc1-1~exp1~20210805203044.169 Good catch! That would be lockdep telling me off for putting test locks on the stack. :-/ I thought I had tested this with lockdep, but it seems the set of semi-automated tests I run didn't (yet) generate a config with KCSAN_WEAK_MEMORY + LOCKDEP. This should be fixed by: https://lkml.kernel.org/r/20211203233817.2815340-1-elver@google.com Thanks, -- Marco