From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1BAEECAAD4 for ; Wed, 31 Aug 2022 09:41:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 21A476B0071; Wed, 31 Aug 2022 05:41:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1CA6C6B0072; Wed, 31 Aug 2022 05:41:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 091D48D0001; Wed, 31 Aug 2022 05:41:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id EDCB56B0071 for ; Wed, 31 Aug 2022 05:41:07 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 2233B1404EC for ; Wed, 31 Aug 2022 09:41:07 +0000 (UTC) X-FDA: 79859394174.20.D07039F Received: from mail-vk1-f169.google.com (mail-vk1-f169.google.com [209.85.221.169]) by imf10.hostedemail.com (Postfix) with ESMTP id C458FC002E for ; Wed, 31 Aug 2022 09:41:06 +0000 (UTC) Received: by mail-vk1-f169.google.com with SMTP id j11so4505725vkl.12 for ; Wed, 31 Aug 2022 02:41:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=H8I52gPNPVJrjSXFrBrthY/mEoKoCdNI9xLIW6uiQAo=; b=RmqVJSYxWksJR/0krMxdP2/erN7GsGomo+62ATiUwnPwroCqeWj+mwmS95PgcKwEDF jPTc+WqR4L3WEIJJceFutF4ZvV7VIFh/te3peDR4XY+7NTDYFoVuWAYWwpfgssqCVj2w ew1uMTMT11WW7eCobbZgpv+0DBiOuriBz9v6j9/As1TDEACv5+eAIb8m31avfgoAAKPY IGYUZFF4zK2gEfyD7yeHzDl6rkDXp5E9ePEfgzzR32vOu5PJUF8p0jq5QrfiIIjAmfS4 1zJScAHU4QQ8ZtNvvGOSt6zuZW8/dznOw4cBDpIrTdcueCvYqFzpucqfzmZwftCDOVAS 9dxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=H8I52gPNPVJrjSXFrBrthY/mEoKoCdNI9xLIW6uiQAo=; b=4oLwVZEcMGV+Ni1ZiP5PBAmuGAczWJaY29KPXVl4Gl2/HP4Qy7hOd+t+n411UONdts +mqz+h6h6mrWyN8JWeTrYDFPJSte9i/nBWZmA7tYSKUJavDhYYW/OTSb/T3MjqV2QA4m 09fVpvhEQ084v/SfToAunAUPlLqfmvCp2WnQQ7P8KiQfrwT3lmEY6pH10UmgtCCZ5Cy6 hXeK379BYPYYA1mjAVZ+ZMJtCffs3oVpiHPukJVC6pgobN0+0JGui0w9odusm025Ly1f hySOJKoVMCjTJ3tLVHrt7Ds5i1dLRbX6w4mFNr4e5O/CA4nQP/gh9ZDgi6tigS7mlLRC bjmA== X-Gm-Message-State: ACgBeo3LDZgLRhv7K5hViKEJpUxGqNa1vEmC93GSy7hNtf7x25bTKc4e Rk0/DBTnrSe55we03Q2pMCLuvPltaV29vmvPW+PKPA== X-Google-Smtp-Source: AA6agR7m2IqkYQg1r6P55MJEV7W9yiHksf53dzKw1v+1lTnKHiAD3I7MJmnyzMzHPLO4TIaqD27aT11ApVx6ZFD+ZyA= X-Received: by 2002:a1f:bd0e:0:b0:394:9da0:2449 with SMTP id n14-20020a1fbd0e000000b003949da02449mr2239474vkf.4.1661938865760; Wed, 31 Aug 2022 02:41:05 -0700 (PDT) MIME-Version: 1.0 References: <0000000000002c73fd05e6ba3e0b@google.com> <20220821013246.a706fa7c2d8cb494efdba02e@linux-foundation.org> <0004c00e-e50f-5dcf-20f9-1b8da0822bfd@nvidia.com> <20220821163120.df7d936c9f47b6dc875ab763@linux-foundation.org> <761793f4-cd16-fcc1-8777-f7e032604e1e@nvidia.com> In-Reply-To: <761793f4-cd16-fcc1-8777-f7e032604e1e@nvidia.com> From: Aleksandr Nogikh Date: Wed, 31 Aug 2022 11:40:54 +0200 Message-ID: Subject: Re: [syzbot] general protection fault in vma_is_shmem To: John Hubbard Cc: Andrew Morton , syzbot , hughd@google.com, LKML , linux-mm@kvack.org, "'Aleksandr Nogikh' via syzkaller-bugs" , Alistair Popple , David Hildenbrand , Jason Gunthorpe Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661938866; a=rsa-sha256; cv=none; b=r6N7UtGW4DQcJq0eX0uGw6za698+JciZfUeRgecflU2lO89Lfld14drQ00R7WBRCm67V2Z 4B+81bTiXVd0cVCeGIESStCZQQ8dnJ/YLKAYifEXN/qaBIznD5YT4czUAFcUShesaE271G 235leD4bkJYi2Y+wTAdmGDeiNi00I2g= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=RmqVJSYx; spf=pass (imf10.hostedemail.com: domain of nogikh@google.com designates 209.85.221.169 as permitted sender) smtp.mailfrom=nogikh@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661938866; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=H8I52gPNPVJrjSXFrBrthY/mEoKoCdNI9xLIW6uiQAo=; b=Qoh4DRDwmqyO6ADmCmGiEZeBnYL3TLLB3fzZAiCQv7apcWaTXGscA3ehsI2zoIuHwWTZuJ oUn2w16wnsgHUaZ7LhnoP9x3dq535wewNHtubHob3imQLd3JfqtKhqH9UcNMrpfnwwvXc5 pn9bhA4dSEQMqG4KXAwc+DY63/xm+tY= X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: C458FC002E X-Rspam-User: Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=RmqVJSYx; spf=pass (imf10.hostedemail.com: domain of nogikh@google.com designates 209.85.221.169 as permitted sender) smtp.mailfrom=nogikh@google.com; dmarc=pass (policy=reject) header.from=google.com X-Stat-Signature: 7mnn81hugn53djc7xqquabezjz6jxw6q X-HE-Tag: 1661938866-231022 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Let's tell syzbot about the fix #syz fix: mm/gup.c: Fix return value for __gup_longterm_locked() On Mon, Aug 22, 2022 at 2:10 AM 'John Hubbard' via syzkaller-bugs wrote: > > On 8/21/22 16:31, Andrew Morton wrote: > > On Sun, 21 Aug 2022 16:18:48 -0700 John Hubbard wrote: > > > >>> vmas[] array. We haven't messed with gup.c much this time around - > >>> just one patch from Alistair ("mm/gup.c: simplify and fix > >>> check_and_migrate_movable_pages() return codes"). It does touch this > >>> area, but I can't immediately see how it could newly cause this. > >>> > >> > >> Neither can I, even after looking at both of these recent commits to > >> gup.c in this branch: > >> > >> commit 4d1225cd5560 ("mm/gup.c: simplify and fix > >> check_and_migrate_movable_pages() return codes") > >> > >> commit 0e5d6dac6b65 ("mm/gup: fix FOLL_FORCE COW security issue and > >> remove FOLL_COW") > >> > >> As you say, a bisection would really help here. > > > > Might > > https://lkml.kernel.org/r/20220821183547.950370-1-syoshida@redhat.com > > save us? > > > > > > aha yes, that looks right. > > > thanks, > -- > John Hubbard > NVIDIA > > -- > You received this message because you are subscribed to the Google Groups "syzkaller-bugs" group. > To unsubscribe from this group and stop receiving emails from it, send an email to syzkaller-bugs+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/syzkaller-bugs/761793f4-cd16-fcc1-8777-f7e032604e1e%40nvidia.com.