From: Aleksandr Nogikh <nogikh@google.com>
To: John Hubbard <jhubbard@nvidia.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
syzbot <syzbot+681bbbb80445ead3c040@syzkaller.appspotmail.com>,
hughd@google.com, LKML <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org,
"'Aleksandr Nogikh' via syzkaller-bugs"
<syzkaller-bugs@googlegroups.com>,
Alistair Popple <apopple@nvidia.com>,
David Hildenbrand <david@redhat.com>,
Jason Gunthorpe <jgg@nvidia.com>
Subject: Re: [syzbot] general protection fault in vma_is_shmem
Date: Wed, 31 Aug 2022 11:40:54 +0200 [thread overview]
Message-ID: <CANp29Y6Wk21aqLjJ2ygTykZgqZ+3=1kQks6cTYrB_=TVRQqghw@mail.gmail.com> (raw)
In-Reply-To: <761793f4-cd16-fcc1-8777-f7e032604e1e@nvidia.com>
Let's tell syzbot about the fix
#syz fix: mm/gup.c: Fix return value for __gup_longterm_locked()
On Mon, Aug 22, 2022 at 2:10 AM 'John Hubbard' via syzkaller-bugs
<syzkaller-bugs@googlegroups.com> wrote:
>
> On 8/21/22 16:31, Andrew Morton wrote:
> > On Sun, 21 Aug 2022 16:18:48 -0700 John Hubbard <jhubbard@nvidia.com> wrote:
> >
> >>> vmas[] array. We haven't messed with gup.c much this time around -
> >>> just one patch from Alistair ("mm/gup.c: simplify and fix
> >>> check_and_migrate_movable_pages() return codes"). It does touch this
> >>> area, but I can't immediately see how it could newly cause this.
> >>>
> >>
> >> Neither can I, even after looking at both of these recent commits to
> >> gup.c in this branch:
> >>
> >> commit 4d1225cd5560 ("mm/gup.c: simplify and fix
> >> check_and_migrate_movable_pages() return codes")
> >>
> >> commit 0e5d6dac6b65 ("mm/gup: fix FOLL_FORCE COW security issue and
> >> remove FOLL_COW")
> >>
> >> As you say, a bisection would really help here.
> >
> > Might
> > https://lkml.kernel.org/r/20220821183547.950370-1-syoshida@redhat.com
> > save us?
> >
> >
>
> aha yes, that looks right.
>
>
> thanks,
> --
> John Hubbard
> NVIDIA
>
> --
> You received this message because you are subscribed to the Google Groups "syzkaller-bugs" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to syzkaller-bugs+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/syzkaller-bugs/761793f4-cd16-fcc1-8777-f7e032604e1e%40nvidia.com.
prev parent reply other threads:[~2022-08-31 9:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-21 6:14 syzbot
[not found] ` <20220821013246.a706fa7c2d8cb494efdba02e@linux-foundation.org>
2022-08-21 23:18 ` John Hubbard
2022-08-21 23:31 ` Andrew Morton
2022-08-22 0:10 ` John Hubbard
2022-08-31 9:40 ` Aleksandr Nogikh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANp29Y6Wk21aqLjJ2ygTykZgqZ+3=1kQks6cTYrB_=TVRQqghw@mail.gmail.com' \
--to=nogikh@google.com \
--cc=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=david@redhat.com \
--cc=hughd@google.com \
--cc=jgg@nvidia.com \
--cc=jhubbard@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=syzbot+681bbbb80445ead3c040@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox