linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Aleksandr Nogikh <nogikh@google.com>
To: kernel test robot <lkp@intel.com>
Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
	 Andrew Morton <akpm@linux-foundation.org>,
	 Linux Memory Management List <linux-mm@kvack.org>,
	Dmitry Vyukov <dvyukov@google.com>,
	 Andrey Konovalov <andreyknvl@gmail.com>
Subject: Re: kernel/kcov.c:635:32: error: 'KCOV_MODE_REMOTE' undeclared
Date: Fri, 21 Jun 2024 12:18:44 +0200	[thread overview]
Message-ID: <CANp29Y5Nz_nf1HPfr_dY4Nrg=S6w0gJgWe0uS1d90GLDZsd0ZA@mail.gmail.com> (raw)
In-Reply-To: <202406201538.SMBucNWT-lkp@intel.com>

On Thu, Jun 20, 2024 at 9:53 AM kernel test robot <lkp@intel.com> wrote:
>
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   e5b3efbe1ab1793bb49ae07d56d0973267e65112
> commit: 01c8f9806bde438ca1c8cbbc439f0a14a6694f6c kcov: don't lose track of remote references during softirqs
> date:   5 days ago
> config: x86_64-randconfig-014-20240202 (https://download.01.org/0day-ci/archive/20240620/202406201538.SMBucNWT-lkp@intel.com/config)
> compiler: gcc-13 (Ubuntu 13.2.0-4ubuntu3) 13.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240620/202406201538.SMBucNWT-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202406201538.SMBucNWT-lkp@intel.com/
>

I was unable to reproduce the problem with the attached config/script.

> All errors (new ones prefixed by >>):
>
>          |                     ^~
>    include/asm-generic/rwonce.h:55:27: note: in definition of macro '__WRITE_ONCE'
>       55 |         *(volatile typeof(x) *)&(x) = (val);                            \
>          |                           ^
>    kernel/kcov.c:363:9: note: in expansion of macro 'WRITE_ONCE'
>      363 |         WRITE_ONCE(t->kcov_mode, KCOV_MODE_DISABLED);
>          |         ^~~~~~~~~~
>    kernel/kcov.c:363:21: error: 'struct task_struct' has no member named 'kcov_mode'
>      363 |         WRITE_ONCE(t->kcov_mode, KCOV_MODE_DISABLED);

It looks as if CONFIG_KCOV is not enabled, but
1) It is enabled in the attached config file.
2) If it's not enabled, the kernel/kcov.c file should not have been
compiled in the first place.

>          |                     ^~
>    include/asm-generic/rwonce.h:55:34: note: in definition of macro '__WRITE_ONCE'
>       55 |         *(volatile typeof(x) *)&(x) = (val);                            \
>          |                                  ^
>    kernel/kcov.c:363:9: note: in expansion of macro 'WRITE_ONCE'
>      363 |         WRITE_ONCE(t->kcov_mode, KCOV_MODE_DISABLED);
>          |         ^~~~~~~~~~
>    kernel/kcov.c:363:34: error: 'KCOV_MODE_DISABLED' undeclared (first use in this function); did you mean 'KCOV_DISABLE'?
>      363 |         WRITE_ONCE(t->kcov_mode, KCOV_MODE_DISABLED);

This looks again as if CONFIG_KCOV is not set (and there follow the
same two conclusions).

-- 
Aleksandr


  reply	other threads:[~2024-06-21 10:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-20  7:53 kernel test robot
2024-06-21 10:18 ` Aleksandr Nogikh [this message]
2024-06-21 12:35   ` Philip Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANp29Y5Nz_nf1HPfr_dY4Nrg=S6w0gJgWe0uS1d90GLDZsd0ZA@mail.gmail.com' \
    --to=nogikh@google.com \
    --cc=akpm@linux-foundation.org \
    --cc=andreyknvl@gmail.com \
    --cc=dvyukov@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lkp@intel.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox