From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FC53C6FD1D for ; Tue, 4 Apr 2023 16:17:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 55D936B0071; Tue, 4 Apr 2023 12:17:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 50DE86B0072; Tue, 4 Apr 2023 12:17:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3D5BE6B0074; Tue, 4 Apr 2023 12:17:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 2D68B6B0071 for ; Tue, 4 Apr 2023 12:17:21 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id CB4BF12110C for ; Tue, 4 Apr 2023 16:17:20 +0000 (UTC) X-FDA: 80644213440.08.E369453 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) by imf07.hostedemail.com (Postfix) with ESMTP id ABBCF4000C for ; Tue, 4 Apr 2023 16:17:17 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=UsJlJtgl; spf=pass (imf07.hostedemail.com: domain of edumazet@google.com designates 209.85.128.43 as permitted sender) smtp.mailfrom=edumazet@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680625037; a=rsa-sha256; cv=none; b=RZDmA9hErgw5kXyOmzSEnsJidt8MBH1wOovl7js3wpw/G3kMZ9VrO8VYRnpMzJ+IohgwKp xnSL0vFaPpFKoVdw6I6khlcvM2vXHVyW7i6c8nwSc4vuDaoy9L9CKsaNQ7kNjSHziKvlgg Dqx0lWdUtfRzSx6XEJKMMy75rmLYe5I= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=UsJlJtgl; spf=pass (imf07.hostedemail.com: domain of edumazet@google.com designates 209.85.128.43 as permitted sender) smtp.mailfrom=edumazet@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680625037; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AeoTfM9IE31WpQAHtBZQ6P4u+SGWj42bFgZh9//cw64=; b=ZfBHQGDZFLGfET/z/sF8k0ZyuGXFU+VmBQ+Uo7Wc3RJbCKHZxr5wFmf08/bDeyB4x73j8A 8zy1ZALvNDl9YbTIPOty/8WWB1T8hSAPEa75o+FpoG83b6TFp4mde7ZjUwX84w2CJGxXOh lEBbnspw8FNqUR8ZvRRQjo+au2j1XiM= Received: by mail-wm1-f43.google.com with SMTP id o32so19366194wms.1 for ; Tue, 04 Apr 2023 09:17:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1680625036; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=AeoTfM9IE31WpQAHtBZQ6P4u+SGWj42bFgZh9//cw64=; b=UsJlJtglwVTL79cS4mjCtYkKJjqudOec+JGHg061L3CdSYYXu6+qAd0ezddFaqxDZy MpgWomkVyp0DB+YW7TijroJcRpSKWBLbcmYTg+7wZznCFH4/o9ZY98ER5Yjd8wGpr+J5 rlmZMo4XnnwIswhtbZzenXBOaZq8qOpIph1t5/BaGQ2ln4ceb2Zd2VPIZF+z6Hb+prGR 9RAPK8Hs992Dm8kGXbWIByDcO7XJz6iq+ooWSWG5vFO252ojZY7MA8Mq+PJy8mEOsASu 39S98YHSrUFnMPzbaOiLzcAiVgyngDml4dX3xfo6gm8ZWAQgmwWb6relSNl7AyhydvBZ W2Hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680625036; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AeoTfM9IE31WpQAHtBZQ6P4u+SGWj42bFgZh9//cw64=; b=pQNB9gewhvdpWI6Y6vDUOWbdL+/agvc20ipMh7EzljUI8ebBMemJ8JNv6X44sMBvrN TljqPM0nTMMY1LMoxlgJzXXqU0eqYBsr6QHAQ9IW7umsKzuTBKHxXyC2UWRdqU89fHfe QfedH4zdmxp/DDEn26jecxGn+dFnYopHt8Kjqj0z3AN+dq0bgsZKmNdWha01O64Y97Im OpyOWdZ5+ndxYqEU3Ul7q3g4k8anNYH2eCdWGxbPyJ7C5HVDYeUjpzCTg48vrBNYGYaR 7L6OFBM9r5uTUajlwNmP2GLRCJa+dXVtAPBx7wCfRq1XfJffS7eAFMOw9PtTquibaHWy uwsg== X-Gm-Message-State: AAQBX9enoIMqejpT8YC6DgfoR2YK34b2WAk72iWOYnQ5W6kgUylQEFhv WW7C0+Lr2RoznHJGqZ+igspRbHuCLUyJqPf1zfMdOw== X-Google-Smtp-Source: AKy350Y2XCaAKou1W/+qWYHFfYr04Nbc2BgboeZyVoBHZKNLVUoSVpuBAPQsXO5iDjiO8H16/GXdQgp0JA3P8qo1hO4= X-Received: by 2002:a7b:ca4f:0:b0:3ed:d6cb:d025 with SMTP id m15-20020a7bca4f000000b003edd6cbd025mr905141wml.0.1680625036072; Tue, 04 Apr 2023 09:17:16 -0700 (PDT) MIME-Version: 1.0 References: <202304042104.UFIuevBp-lkp@intel.com> In-Reply-To: <202304042104.UFIuevBp-lkp@intel.com> From: Eric Dumazet Date: Tue, 4 Apr 2023 18:17:04 +0200 Message-ID: Subject: Re: [linux-next:master 5025/9010] tcp_mmap.c:211:61: warning: 'lu' may be used uninitialized in this function To: kernel test robot Cc: Xiaoyan Li , oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Paolo Abeni Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: ABBCF4000C X-Rspamd-Server: rspam01 X-Stat-Signature: 9unjq44d6z6ktop9i485z7ydm9cqrm56 X-HE-Tag: 1680625037-386848 X-HE-Meta: U2FsdGVkX185FnTKfdwA35siB1xYHp8mNjm+ZsS19m6+WVsyckf7QTm8x0cn1ZoiI3HmAGk4lDRuCuU+XZRTgmLrr94o9W4q4lySrXNi6s0PV7TAgzBoBMPmKlxM83MiPACCU3F5nE0iuDeqYgzMk5YKjHee7MKlAIjJuCmi1/aIksf1USqBxZtyDNtanyaKlFll8YRjzysTUYFxK8zjHqjyOBrNvnKfPYa63v408vChSLb43y4+s2PVsRixgjYY3g18ggtklSlsmXyViKEftMZsNH6bQdVpNR/9u+IrdjAs5oFaMsXT5Rnw/vwKjgi3OCvKXs6zPvuEs/QloZoXGi6Dcr5jM3y81SRH/3BQljrlm9y6B7vAMhsS3CQSjdYT/3Sv1YdWS02D4JgC53vjVgtkeJ7YG+kA9YFO9LZiO7ciHXx9f8LgL2Y9XWNyO0IW/7I+akpdIgHoO2gs/Ns9oH7OwylTkDA8NItbqadXUds7RSCnXOuGCKw9Hrh1eNs8WsjAwC8Xc4cxPG/ieOV7IWdsTR65lC0W0pvLAR54aYPyWmbrxAdAcZCHT9GoMaV3pK5S9s9xQ22SHxlT2/lD3cqMFPd1XgjOvGsufuYIik2ciDT1gbOMeTmse4ttnw/HPxReizEjsXEq4//IQNUWzvZqJQLGD3t20QuqGXUPQ304WnSDZjLoiwRxRQrkzVEpxZbycrGvoDSE792C3LvBeBFP77Ip5DLY9qux7lV4gYCSzSU4UK6KOgTlxkhp325y7TC+T3XvWOaORB4HIn5AI56PRTj8T5qaLBTdieHdYxz1wUEKSbk9259WZCuj/6SwlpgptigHhPIVFpkbkUS0hN36Xrr6C9wwZIUK91NgxQt4cWXJicCX15jRw7fEyDjIgWT8jB14LWGyLol/V1cvlGI+GKiK+KoOi+wCKsglE0bGJyvGWA3DmvTLI3qBreYvvgA4KyNjogvSm8ZAxZC GH+HUZZ2 WNLe7STwC/c9J6OCs2tW3yi3h4rTqJekKjWGnX3pBERtTpisbxf7NOJMM5VtXFlWTXm8uAPj9ZOTPNWxQ2LxbCwdaTnkaA9e0hOLgvlvDKsCJToCkw8ZT6T9yT+hdNVfY0sDXHM1hxIToCc7WmL7gpclayQtfObtaZ6XNg1Z/BWWyEHkclnebk7RJNJbNcAAw+ZO+PmsY1ykhKe1WNPZ7Xn8tNf4zQEdfVqV03EMeZY9gxBB4mf2tlj/cna2z+TaX8sTGwXK3B46t8NMUVnEzMvKeFlgBROFV8n1A9k5Ez71RRK9QDrgvNn67k9Szsd0B9m8WbtTSjw+EG2yqYRiVXwVXTxafyeFtQwGpfE5q3rMzzLKx5332goMn7V3KWJa+iwXZhE/I/BG0Cz8Cyy7/bbF3pTDEMD9+1rxAeVRtJIp7+78= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 4, 2023 at 4:10=E2=80=AFPM kernel test robot wr= ote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.g= it master > head: 6a53bda3aaf3de5edeea27d0b1d8781d067640b6 > commit: 5c5945dc695c54f2b55a934a10b6c4e220f9c140 [5025/9010] selftests/ne= t: Add SHA256 computation over data sent in tcp_mmap > compiler: gcc-11 (Debian 11.3.0-8) 11.3.0 > reproduce: > # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next= .git/commit/?id=3D5c5945dc695c54f2b55a934a10b6c4e220f9c140 > git remote add linux-next https://git.kernel.org/pub/scm/linux/ke= rnel/git/next/linux-next.git > git fetch --no-tags linux-next master > git checkout 5c5945dc695c54f2b55a934a10b6c4e220f9c140 > make O=3D/tmp/kselftest headers > make O=3D/tmp/kselftest -C tools/testing/selftests > > If you fix the issue, kindly add following tag where applicable > | Reported-by: kernel test robot > | Link: https://lore.kernel.org/oe-kbuild-all/202304042104.UFIuevBp-lkp@i= ntel.com/ > > Note: it may well be a FALSE warning. FWIW you are at least aware of it n= ow. > http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings > > All warnings (new ones prefixed by >>): > > tcp_mmap.c: In function 'child_thread': > >> tcp_mmap.c:211:61: warning: 'lu' may be used uninitialized in this fun= ction [-Wmaybe-uninitialized] > 211 | zc.length =3D min(chunk_size, FILE_SZ = - lu); > | ^ This is not a false warning, I will submit this fix, thanks. diff --git a/tools/testing/selftests/net/tcp_mmap.c b/tools/testing/selftests/net/tcp_mmap.c index 607cc9ad8d1b72cdcb96ca0d6fdb70900c9b9bc0..6e59b1461dcceaa658185071a75= 8e1006b48299a 100644 --- a/tools/testing/selftests/net/tcp_mmap.c +++ b/tools/testing/selftests/net/tcp_mmap.c @@ -208,7 +208,7 @@ void *child_thread(void *arg) memset(&zc, 0, sizeof(zc)); zc.address =3D (__u64)((unsigned long)addr); - zc.length =3D min(chunk_size, FILE_SZ - lu); + zc.length =3D min(chunk_size, FILE_SZ - total); res =3D getsockopt(fd, IPPROTO_TCP, TCP_ZEROCOPY_RE= CEIVE, &zc, &zc_len);