From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5164C6FD18 for ; Wed, 19 Apr 2023 08:41:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8548E8E0002; Wed, 19 Apr 2023 04:41:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 802418E0001; Wed, 19 Apr 2023 04:41:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6F4918E0002; Wed, 19 Apr 2023 04:41:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 5D78B8E0001 for ; Wed, 19 Apr 2023 04:41:15 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 2070A80280 for ; Wed, 19 Apr 2023 08:41:15 +0000 (UTC) X-FDA: 80697496110.30.D7C66DC Received: from mail-io1-f41.google.com (mail-io1-f41.google.com [209.85.166.41]) by imf01.hostedemail.com (Postfix) with ESMTP id 560CE4001E for ; Wed, 19 Apr 2023 08:41:13 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=ndg0x1pD; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf01.hostedemail.com: domain of edumazet@google.com designates 209.85.166.41 as permitted sender) smtp.mailfrom=edumazet@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681893673; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=w5zwwsv1p5D/gRlxt0eU/wzMw2WWxeFb5WeQDYnHVYU=; b=ICP529a81FP9Dn70rUmC7oqEnWefv0XE4EaIbqZA6XLsFhPa9ku/2IvwwfrxYsx57dibHi NvYoamFStvIsTQoiJoSJ0yokd+iElyz4TMPhfWk2ukscrZgAq2FFMBDFQIDzdSMhddJFbr fxdvgnb4zvN7rHbIISV6SrD/5Rt+QD4= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=ndg0x1pD; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf01.hostedemail.com: domain of edumazet@google.com designates 209.85.166.41 as permitted sender) smtp.mailfrom=edumazet@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681893673; a=rsa-sha256; cv=none; b=DfyuMu6PqSaHV2SEjmq3y+/4TEbMm/JEKg5ThyZyaVfrLWkjsqH2XBDlLclpMk/SSPHZ2S MNY916zwzuom/YXpf+I16Cgy2uDqh4g7d19uW+YFiQmBSPtWR4B7mdeX8jkh2gE41qNobi BDV/w48Q116pa0Ad5tZrk5Ym3xBSiTQ= Received: by mail-io1-f41.google.com with SMTP id ca18e2360f4ac-7606ce9b213so346679439f.0 for ; Wed, 19 Apr 2023 01:41:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1681893672; x=1684485672; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=w5zwwsv1p5D/gRlxt0eU/wzMw2WWxeFb5WeQDYnHVYU=; b=ndg0x1pDT4hSebBTYGx6yd+uiKYB07UmuUuMMHBZ2lgSYxjL8paMi9AJHCLV2aO9Hr 6bhgN5OSk5155IdRgMFSdELWjCQt+4M9hCMPUdeVZeEcdc93J+jqHn+1YtJQHp/inMfs aeuNDvZcGrX3mnI5hgStg6sgCaUDqgN6yrX6tVbgmH1msuY8AlqG0l7m9674GH/2e8a2 URWunaXK86lgNeVxGwOB/Sghuz0th0LgwG7m2Z4aX5ICauRRsryXfQjqjQz94uQBuyri KGRD7gfybFuEjWBFV5CM+1ChjrJ5scr5Bzkx43Flacm2p4QdG2gRWmi36M0znSGh8J4g N3qA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681893672; x=1684485672; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=w5zwwsv1p5D/gRlxt0eU/wzMw2WWxeFb5WeQDYnHVYU=; b=Pqm29dihu8vry/5/uaFuNUluK4eubRHEqE91pK4QWsJt0zWUdOaEAIDvENyT0mIMne Cq6ZFAi01mkkHytVJ7XNjpDuq9Rn6IJswAElwUh/ybk5QGvEVE+fiYl0X85hCe48TvDp mDOxqeFoxSrk8YS95N1UVihldLqGvTe52W+DtvDurmdNS+uGXY7LoBhNartnx5kIVhE7 3drEm1TfO94UUWEcx93RtJjpBkIbStKdFQo0C8TJE4BC7J8JOhQQR4YosW+4PDTpDjTv 6OMJrcYRIbqp/tObA7z/PZHUgyH0bQtsIfBUMdnKwBd94ySH96NqMW0Cd2yFOvrTqRpP VHUA== X-Gm-Message-State: AAQBX9eepnd8LLbSr+Vuv7u13chEmcokgzO5kNGMIYQKsbP7HrGxI2fW 3SVQRJqmV9J0FuYc3gM2RZ8gyblETn+cw82u30EBjw== X-Google-Smtp-Source: AKy350bnTfsp6ZaN6t74b/ECtx4wPwi+yVhBT4Au3SRjcvGrmJmiEAyFYeXYb03kPd6QJD26k+p1etFw3JQc422u9ZE= X-Received: by 2002:a6b:d911:0:b0:745:70d7:4962 with SMTP id r17-20020a6bd911000000b0074570d74962mr3501152ioc.0.1681893672148; Wed, 19 Apr 2023 01:41:12 -0700 (PDT) MIME-Version: 1.0 References: <202304162125.18b7bcdd-oliver.sang@intel.com> <20230418164133.GA44666@unreal> <509b08bd-d2bf-eaa8-6c49-c0860d1adbe0@kernel.org> <20230419055916.GB44666@unreal> In-Reply-To: <20230419055916.GB44666@unreal> From: Eric Dumazet Date: Wed, 19 Apr 2023 10:41:00 +0200 Message-ID: Subject: Re: [linux-next:master] [net] d288a162dd: canonical_address#:#[##] To: Leon Romanovsky Cc: David Ahern , kernel test robot , Wangyang Guo , Jakub Kicinski , oe-lkp@lists.linux.dev, lkp@intel.com, Linux Memory Management List , Arjan van de Ven , Thomas Gleixner , netdev@vger.kernel.org, steffen.klassert@secunet.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 560CE4001E X-Stat-Signature: uwnwe3pq8u4q9c79uh7p8sk1emzdysed X-HE-Tag: 1681893673-300898 X-HE-Meta: U2FsdGVkX1+oxVCzQrqC6EILcBA6XWeJzv9Yn1digQ+GqYUFJ+N4j5ijnK5x4/2Fadlo79yHk0M8OrDsIFu1mcXU93umqSgk7sOTXe9XT7Is1TIg83DFAlvFx/x0a6GJZDfwJ+g6e0zjB0rUG/00gViguX31Y17y6NbuUV9wt+HGYaSNvq/1C0iMOZxrYFYrkT9aRXSRj2dAOU55hMHhjFSdH9gRLgligS56m006s1P8H+gW6sOpKheZNepj02rOoZ32ssFMooZ46uGuKBM1sX1ED3Rv6r5KHoiR8jPxM24xyWmqgPUDFIN3Mnm4FCKlT54K35TDELIF25jauGUO4yKWM+NFo+vQgh9Pj9sXFRW65lwjm0Bbg2IudvaGlQouwMEKXCFsOAMjMpNoE/fS2VUr7IkBhJnC+A7/kRU4c0Src1zRDRY8Zhj9J5tMwE2K52hr2bvVgW0+QK+OOZbyNKtk129VAhnBBKycGMuiwUrFv7fDrOPkasiZSevROb0QjG2cqlv22qF/2m7psYIO+CewdXqtLCuoKtLdWI2C246vBaT6RIT8JF6JVojfGOS7twddO6VB1LnWt4Cz+xoPEpn7Ai8T0cNai3peMOlC88NmCE9t4j2zW+SIyzqajWsy4SEiI+6S9AtfIBbEwDEWa0Q8K0g1RFgyy2Q2xOFbBXNy3wiquHo7e2/6XxGtYF4fkeRGrw+1KY510BSiDfU5QcWvbfNmU+5SSUZWnMxem+1U5EZyM2QF6nN+mlpTkIioKgZuKhaU5gHWTs4BsKDQqE7nYpasqkTF+wZugSG+Si41xnIEvQCfShMtCMVugKQ+VTMb20qje/68A4kDEGHLU4u58BkqmEuel5yxEMqaobuxLgjmzuhm4RC6Hu7AwN3+ofn0d5Hf/ZwZJgVsxcv1RBrejftUiIMpKgC3zGfkm0vIXhzYlqrw5UoyDK4N0FyyjmLZ/bJBT4+aKIWEN4E OQp4KzCl opoODj+V9JCILgK7lyLrb1wPI13kiXxAxdcy41QyWkSZipYUiZi889YoRiLJSAVN2JQ68zwUPv95qXZPqBWcKliYVNw1s8VO3kcx9mNzgm1hA6/NiOFCC3IAQ4v1Qs6KXNhY6MyneoJFWRYS5NOTgqH3sAYHOx20NB5KaCwfXbWJmqSNx9KkQEvq4X71C0Dl3eUmeynU1M8gF9D6bWulOsnB8UcOTvyWj8HqEQUpJaYVjHO7OMibxv72dMBmnaufHLBqePn66m8RmEYMSK8lMhONKm+DH/IVBqsXtnSI+sO0zHqvYLrAqq683pjwm/z6oIkvOJcwZz3zvke/wW29N9p6I52bbU+I15v6k X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 19, 2023 at 7:59=E2=80=AFAM Leon Romanovsky w= rote: > > On Tue, Apr 18, 2023 at 02:43:02PM -0600, David Ahern wrote: > > On 4/18/23 10:41 AM, Leon Romanovsky wrote: > > > Hi, > > > > > > I came to the following diff which eliminates the kernel panics, > > > unfortunately I can explain only second hunk, but first is required > > > too. > > > > > > diff --git a/net/core/dst.c b/net/core/dst.c > > > index 3247e84045ca..750c8edfe29a 100644 > > > --- a/net/core/dst.c > > > +++ b/net/core/dst.c > > > @@ -72,6 +72,8 @@ void dst_init(struct dst_entry *dst, struct dst_ops= *ops, > > > dst->flags =3D flags; > > > if (!(flags & DST_NOCOUNT)) > > > dst_entries_add(ops, 1); > > > + > > > + INIT_LIST_HEAD(&dst->rt_uncached); > > > > d288a162dd1c73507da582966f17dd226e34a0c0 moved rt_uncached from rt6_inf= o > > and rtable to dst_entry. Only ipv4 and ipv6 usages initialize it. Since > > it is now in dst_entry, dst_init is the better place so it can be > > removed from rt_dst_alloc and rt6_info_init. > > This is why I placed it there, but the rt_uncached list is initialized > in xfrm6 right before first call to rt6_uncached_list_add(). > > 70 static int xfrm6_fill_dst(struct xfrm_dst *xdst, struct net_device = *dev, > 71 const struct flowi *fl) > 72 { > ... > 92 INIT_LIST_HEAD(&xdst->u.rt6.dst.rt_uncached); > 93 rt6_uncached_list_add(&xdst->u.rt6); > > My silly explanation is that xfrm6_dst_destroy() can be called before xfr= m6_fill_dst(). > > Thanks > > > Please take a look at the fix that was sent yesterday : https://patchwork.kernel.org/project/netdevbpf/patch/20230418165426.1869051= -1-mbizon@freebox.fr/ Thanks.