From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96B8BC001DF for ; Fri, 20 Oct 2023 19:52:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0081628000B; Fri, 20 Oct 2023 15:52:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EFB0A280009; Fri, 20 Oct 2023 15:52:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DC30428000B; Fri, 20 Oct 2023 15:52:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id C9591280009 for ; Fri, 20 Oct 2023 15:52:33 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A2AD9C0525 for ; Fri, 20 Oct 2023 19:52:33 +0000 (UTC) X-FDA: 81366886986.07.9859609 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) by imf15.hostedemail.com (Postfix) with ESMTP id CFEB6A0025 for ; Fri, 20 Oct 2023 19:52:31 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=ms1VaoYa; spf=pass (imf15.hostedemail.com: domain of edumazet@google.com designates 209.85.208.46 as permitted sender) smtp.mailfrom=edumazet@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697831551; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TSWDeA6cj4GbjOeiQsRECSOs7fXEzILOKhKiNyEQFfg=; b=0Wwq/kgWQfLbrIqOg9q4Mz6+J6UGcfscBUfBToxRRjzlqEsRwXJwKrM4eowmzPTFuks8hD EVwLEp6ne7quTMijM4Xd+EfYUHUJbTfGdJ95oF44jGGQNK5GnJx5OSyCa60tVsFk5+Q6/Y t08TgCphNefd4c5LsHodM7otEJAJoxA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697831551; a=rsa-sha256; cv=none; b=ZPg4eBX6BEhd1GF5qevP+XBA685kJpT5lVTaod1/zqknyONUku1qreDKBZOYu1dYJ2Ur3/ Rx8SHbhlw5x/Zrh53ZomE159vvOsXv0V+oo8W7ImKV+mRQpjLSt1GEDptxEHQjVw3L57ZI xYeqGUBoOrduqOd1m36adWNQ+j5t++k= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=ms1VaoYa; spf=pass (imf15.hostedemail.com: domain of edumazet@google.com designates 209.85.208.46 as permitted sender) smtp.mailfrom=edumazet@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-53f98cbcd76so384a12.1 for ; Fri, 20 Oct 2023 12:52:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1697831550; x=1698436350; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=TSWDeA6cj4GbjOeiQsRECSOs7fXEzILOKhKiNyEQFfg=; b=ms1VaoYaLN5Vy/G8b+0k5CLwYQ2sf9X3E1jEb56jlZ55yAz+oHDdaMKHxYjGeqTSYO mSaiyI8AnS2l14K/UmfTWQCMP38dEfQ8faa3wk1fwMLjYOyA9QryBAbxheENFrEZBnfy eboHkOQLknp6JeOl2Dv4WovDH8JFT6gztqcy0jRC/iYnIKrSOWAGOL+OoAsOsgqONYMd xKcXQ8txicOngtM0SfxB0KsbhOXMBcx5XKf2qvsO2NvfTw8DgnajAiQ/H2cxVyyHUE5Z DD91MbU2CnZ2q+pJnA9O25v50W0NW8750Vu4svvJDFyiUnFTIAATgxdppoonZjFYKZKf PQsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697831550; x=1698436350; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TSWDeA6cj4GbjOeiQsRECSOs7fXEzILOKhKiNyEQFfg=; b=tKEaqxVk5xh8PQKT20lajEnbStCdQD6hkULx9rVwlvVWGzoD3idKeAb2yeJ2V+sHgX woAmAIJ+QnRZFc8mKI5LiIt8kr5GK8muwbiqrGZiSnnwyDtWNy98y0L90MlQQX26VuSr ar2RPsXj5YeA2Dif+4fZ9zeVTpkljMT7K+VYQjRMbtmU58Ojbq3nPq1JLvi6fs7S5hxw oz6i5reF6+7536/9X42RE5gUwLERTeg+NgrGbD94ppwgeA/OEzlmDhj0seCPodaNNrOL sv6UVJyVHBmdQ93VX824a9hOcdYfwwXapTvW2j8ywu2pEu9zt9DFYXXh1EvHxg3UBeoY t2BA== X-Gm-Message-State: AOJu0YzPSgHc2vWUnh78SjEMoJnrXiT0Qif4TAJiawrCjZOQEzRZQc7y qbi59WGQYcLjrVT0yFz7SOuN1iyFjcBdqJ3T2+krmw== X-Google-Smtp-Source: AGHT+IHGyh2xVOVlGe60EMeCFm+QCMN2V7ofFQcGLzOeEt1UUciBn5flJkJP4ABhrqmhQ1KcSRqaYQ2AUgpN9O5g7jY= X-Received: by 2002:a50:9f41:0:b0:53f:91cb:6904 with SMTP id b59-20020a509f41000000b0053f91cb6904mr204723edf.4.1697831549963; Fri, 20 Oct 2023 12:52:29 -0700 (PDT) MIME-Version: 1.0 References: <202310201422.a22b0999-oliver.sang@intel.com> In-Reply-To: <202310201422.a22b0999-oliver.sang@intel.com> From: Eric Dumazet Date: Fri, 20 Oct 2023 21:52:16 +0200 Message-ID: Subject: Re: [linux-next:master] [net_sched] 29f834aa32: kernel-selftests.net.so_txtime.sh.fail To: kernel test robot Cc: oe-lkp@lists.linux.dev, lkp@intel.com, Linux Memory Management List , Paolo Abeni , Dave Taht , Willem de Bruijn , Soheil Hassas Yeganeh , =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= , netdev@vger.kernel.org, aubrey.li@linux.intel.com, yu.c.chen@intel.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: CFEB6A0025 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: n8q9ui9e757tuwbzizzey9biskc63nni X-HE-Tag: 1697831551-227847 X-HE-Meta: U2FsdGVkX19HwGSEam/hMQcSXXXLDYu6/+O2QEe9u9SKr0zeXHzjpJ8W3exqYZWaLW9fCN3uAJ6yJCJKOrdrO9JHSHVfbV16p0L9NW+INkQ6ZgVH5da9iY8qB6n2AEXMWZ2110Q6W6rkNSdgLa1Hnao2AFMnrhiDNkarBdJnsVptsw81vLlDXlGDnGxzQuaRZu1fPgX9460T4XnYIDZtq/X1VEmODU+IeIFRUcr/pwer4LOnjAvyZ51PyAsWVbe60x8zxKRtC4BNbbxCkA+obUlbcAPNIRkW9sMwbFIWDbYonnrHTAhE1pLHj43Gn8ZYWqV773yPdtdh73sxu6Ph2EH9TsokkK4XHpxhaY+LIn63t3h+1fvCQdwK0o5lwXPCx/DUnc1VONqdGg9bBp7+QL8FiVAo08P6XKsNiDm76zRKL8TG6SDmYS7ae3kwh+FhYMyn5tNryKSKN/VnLbFIzV2J6dW3C0WKR2pEqmxdkD1K+TWSpxVVAYLTRShlwwplKrPVDU3nM3ZcsOHwHeui/ntnFMqQx7SkElAMM1bFzbwxrIgq3VkpB4YwqPw+TE/azadRgXk6K3xtDgXoo5e/6N7pa7BuRZ+TO5sKgfzQlI2k/Y95C7QxBsjqv2QKozxZ22el2S0t2D7KrFxPkZsivYMv80yeadCM3+vMVA8bKT4H+EfINAG4GwJZ5Y7Hp6Zg7GkvQWZ5aTUmm12nRQJbXyX25RSDqXuRftZ0uOylDi/ctIYrWTPc/5dkDEj2FqQyPI1EKUevt17mXCXxnm8Xggg1v9O7ieiXTFkgyxxv5v3Z+kX23Ju/k7jRWXmxXbFll36sxXRKybcAo3YLzeFahJ0aPzYNvVuOYnkcdr43TRKXA1VPLbV6mM534lQFo3eioQ3EOcLiEUQuvXyJ0tjSAF1fVCr96/J6i7TPp/drW1LohxItZoKnyd4IyiqTPWPh34L9F6s8LnZP8xlt14z I3gvGVed xn8U89SldDFudXuQOy7YnLBBu5k9xiZMLDEDCt0gdxJKhMJgUSwYuMHyp4YfnkLEWTZ3ubBNSjk+QuYUDjZBRrTrhw+jOSGXbO97R4vdjRxrK64rvDMcNGk9nqTHlNL6fJG91FGN/CJASaX7ASun20qcSSpdEgUa0iKlrzm0SSfjAllQFjgVtZcjyujuSiew5k2SPbxx7M5PB9S1OAHi1loYj8MoRNRaeHDCGZb2nYVOg9T5yU5o6ssvlNLvhg9LDdTHTWFBrvzukehbMBzVfwuylSMfW4lFhVBnYzOsmIjGTX78LRMArQKjlto7wyRHmQG12dMldObOYdNYBqflFdvhZmmSaVvEzSD99ct/F21ECUuEscps+8vERn+Qvj4J+xz4KFK1UE+7At7WIA4U7grM8B+cVsrtaay//90+ce/dWWBhk82pz4huDnr/S/kBITBIKblG3pDn/0ZnJkdbthg/9bQIvBWHBcjgMgEfViDxkwXhPDHTxC2ZKZDskcMUChbejP438ftlSGRxlxPVOizMydAC2tuIOzf48FwdTkqPl+nyZIa+HCDxIMtBhd2Ne2ZoO X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Oct 20, 2023 at 9:18=E2=80=AFAM kernel test robot wrote: > > > > Hello, > > kernel test robot noticed "kernel-selftests.net.so_txtime.sh.fail" on: > > commit: 29f834aa326e659ed354c406056e94ea3d29706a ("net_sched: sch_fq: add= 3 bands and WRR scheduling") > https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git master > > [test failed on linux-next/master e3b18f7200f45d66f7141136c25554ac1e82009= b] > > in testcase: kernel-selftests > version: kernel-selftests-x86_64-60acb023-1_20230329 > with following parameters: > > group: net > > > > compiler: gcc-12 > test machine: 36 threads 1 sockets Intel(R) Core(TM) i9-10980XE CPU @ 3.0= 0GHz (Cascade Lake) with 32G memory > > (please refer to attached dmesg/kmsg for entire log/backtrace) > > > > If you fix the issue in a separate patch/commit (i.e. not just a new vers= ion of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-lkp/202310201422.a22b0999-oliver.san= g@intel.com > > > besides, we also noticed kernel-selftests.net.cmsg_time.sh.fail which doe= s not > happen on parent. > > 5579ee462dfe7682 29f834aa326e659ed354c406056 > ---------------- --------------------------- > fail:runs %reproduction fail:runs > | | | > :6 100% 6:6 kernel-selftests.net.cmsg_t= ime.sh.fail > :6 100% 6:6 kernel-selftests.net.so_txt= ime.sh.fail > > > > # timeout set to 1500 > # selftests: net: so_txtime.sh > # > # SO_TXTIME ipv4 clock monotonic > # payload:a delay:296 expected:0 (us) > # > # SO_TXTIME ipv6 clock monotonic > # payload:a delay:279 expected:0 (us) > # > # SO_TXTIME ipv6 clock monotonic > # ./so_txtime: recv: timeout: Resource temporarily unavailable > not ok 30 selftests: net: so_txtime.sh # exit=3D1 > > .... > > # timeout set to 1500 > # selftests: net: cmsg_time.sh > # Case UDPv4 - TXTIME abs returned '', expected 'OK' > # FAIL - 1/36 cases failed > not ok 59 selftests: net: cmsg_time.sh # exit=3D1 > > > > The kernel config and materials to reproduce are available at: > https://download.01.org/0day-ci/archive/20231020/202310201422.a22b0999-ol= iver.sang@intel.com > > > > -- > 0-DAY CI Kernel Test Service > https://github.com/intel/lkp-tests/wiki > Silly me.... I will send this fix: diff --git a/net/sched/sch_fq.c b/net/sched/sch_fq.c index 8eacdb54e72f4412af1834bfdb2c387d41516349..f6fd0de293e583ad6ba505060ce= 12c74f349a1a2 100644 --- a/net/sched/sch_fq.c +++ b/net/sched/sch_fq.c @@ -651,7 +651,7 @@ static struct sk_buff *fq_dequeue(struct Qdisc *sch) begin: head =3D fq_pband_head_select(pband); if (!head) { - while (++retry < FQ_BANDS) { + while (++retry <=3D FQ_BANDS) { if (++q->band_nr =3D=3D FQ_BANDS) q->band_nr =3D 0; pband =3D &q->band_flows[q->band_nr]; Thanks !