From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B23CEEB64D9 for ; Fri, 7 Jul 2023 15:45:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1BCA18D0001; Fri, 7 Jul 2023 11:45:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 16C6E6B0074; Fri, 7 Jul 2023 11:45:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 034A28D0001; Fri, 7 Jul 2023 11:44:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id EB3C56B0072 for ; Fri, 7 Jul 2023 11:44:59 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 92F53C0DCB for ; Fri, 7 Jul 2023 15:44:59 +0000 (UTC) X-FDA: 80985239118.23.44BC8CC Received: from mail-qt1-f174.google.com (mail-qt1-f174.google.com [209.85.160.174]) by imf16.hostedemail.com (Postfix) with ESMTP id D0EEF180019 for ; Fri, 7 Jul 2023 15:44:56 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b="NjS1x/b0"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf16.hostedemail.com: domain of edumazet@google.com designates 209.85.160.174 as permitted sender) smtp.mailfrom=edumazet@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688744696; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RlgengT9aAUSDCSQdfdVcjavg+ikjdd9vhZv6EODEuE=; b=vWOy7vVrMqoBa5UUXSKByr6qeQ/jejDrsRKcPfdUtCSdCeUvtQIDTld4qpEViP0DiAjCL5 fKhtODz9Q+vhKUnxAn6ET6tThKTUnBkF9BliPalt6ePsJd4qxsbBWCBILUWXXWGaDbbvrZ YTMG3FyDTE09qwKOpPuMCeUSjy6b0ys= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b="NjS1x/b0"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf16.hostedemail.com: domain of edumazet@google.com designates 209.85.160.174 as permitted sender) smtp.mailfrom=edumazet@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688744696; a=rsa-sha256; cv=none; b=CIP21Do9dsVsWqAoseVJkY8S+c2glGYSlbk1g97E5u2vXVmCymU0ZEn/5YzA4qFNl47lJ7 HwZLg5R/vHsUsVM7WqAfiIfV7mBEhHT+iEmdeP12hQVPW/Xyo5ubvM+7wA6HpZ43DUOyWf rpgnlgSyWK+W/JYjO1DTu9BGAVHfBxo= Received: by mail-qt1-f174.google.com with SMTP id d75a77b69052e-40371070eb7so273331cf.1 for ; Fri, 07 Jul 2023 08:44:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1688744696; x=1691336696; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=RlgengT9aAUSDCSQdfdVcjavg+ikjdd9vhZv6EODEuE=; b=NjS1x/b0fmLihlzYoavyXYbgBgclV6WvI+vCN8PpUFtK8PeAyUuQVytwUeg/vTub8z r3wqdbRgPYCAALlrh+sKsBeB0Cqp2zJDhwUvSN1Q9juTqRAKmL12WhwLVTQZqbdbae1L ePlPnnxmzM7q6UntmYjaydKQ4554HtH1YowyUn8SEFCqjTYqDsOZV06SBaqndKnGh37z H9+iV2DnoiIHPejCuDLZn/cu2ngwj4At1AFji3xDVA0C5US6Vi6/zTVli+SLJ72mzF0x 2BT7BHW4VZviqep2cXB77xOgT9KMMHvSIwMNsZXXZhOABDgJafqqgHlilNAzK7JC5CKV //Tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688744696; x=1691336696; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RlgengT9aAUSDCSQdfdVcjavg+ikjdd9vhZv6EODEuE=; b=VmxW83pQmRGiNVfAvu3ol3sC1lx7h5aHwyECcERQtvwJqMYXJ0ioohFggoU5R2HvkO HIG0cCsIYkgBpC/xxCw4vdsLm20tNYMZknWVy8jI79HE42m6mSeksaIMn/4XXJSAuhGV P4bGUWJNrZDEE3MD68SCQUQ8AJ9FbSi/S8oKxT1sQaYS1iMucxeVLZ5JF/DGSqOqmoxM hUwjellRtp69ZvRc/1XhWxjEGFQfFkdRUrPjaPiUXZT+8RSMvOvDWOqupklDXLh0+r75 Dx5XoDGKSFfMJbihc8w9ET1AWBkHuRRguULD6iNtnfDJUqHPSmMTnmS5SJ717Qj7+ZQE LZQw== X-Gm-Message-State: ABy/qLabt2ZXOE6g1bV0EXv80ZUrVviRhQHywrtJr1JCF9UvW/XOaDy9 1CK3L935YVnV3Sb6DmsUDMRi/pPETw5bo36Ury4MVQ== X-Google-Smtp-Source: APBJJlGVqhZT0XzeXUaZFLXoagNunWsFBAbhlb1W2YjWYdhXaqoASCAAa5Mkb/yUEJtYmVHGXUUym5QFA+ohkI+7zMo= X-Received: by 2002:a05:622a:89:b0:3f8:5b2:aef0 with SMTP id o9-20020a05622a008900b003f805b2aef0mr236394qtw.24.1688744695640; Fri, 07 Jul 2023 08:44:55 -0700 (PDT) MIME-Version: 1.0 References: <20230616193427.3908429-1-arjunroy.kdev@gmail.com> In-Reply-To: From: Eric Dumazet Date: Fri, 7 Jul 2023 17:44:44 +0200 Message-ID: Subject: Re: [net-next,v2] tcp: Use per-vma locking for receive zerocopy To: Matthew Wilcox Cc: Arjun Roy , netdev@vger.kernel.org, arjunroy@google.com, soheil@google.com, kuba@kernel.org, akpm@linux-foundation.org, dsahern@kernel.org, davem@davemloft.net, linux-mm@kvack.org, pabeni@redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: D0EEF180019 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: jq5oswyayzzcu4riyh8wbq4e9xm1ib5p X-HE-Tag: 1688744696-781953 X-HE-Meta: U2FsdGVkX1+06HWklMYJ3vKCms7wZreV3WDAk0SbTl0FMER0j6xiirtT/+ASeYjW8TvUN52WSmlXp8LNGN+aFcS3PTMIO3UzpCRAz0q4WBsJJ/gR57Obxx7364IrKW2vnUHjiMC5/QmzhKv1cQQ3czuFrVEvDwdThWoIHHF4ASfqPo/v6I7xKLT/sXpEGfwoCA2UFfAQVS2NRfRG7M0hvfszN4NCuKZwkwThqF4dhzzkzds8YKhrSJJJq75Xq2JYUZsu/Ohv5zsJqHU9G4sZRB5PGCQ0ogoj6VlU90uK+pmrv1o5p8TIvcK6jATBeRlN4sLdQADxEyQsiR1V6MQapbc4tV0zSKtcAs5BH8XcDNE8bGMJRWTw3P2Ts0iTq559DNR6MJ3jdvbMBY1ft8b8PSg5+U7BtdS0Emh3U2mxDwBOk8LBw1+o0+Ru45ZkDwx5tEsZiF1HFrKkXJfc9ZXybGQv7y4yDN9VjLHdfBipzhyF4FSC3M3TMVGm7DGUEK3hX90Nl8+w5u56A+e9ce62Zj12fRAAXseruHgkgLsZratj5z07GyIza9g04CSI/oq6vEiZI7snnEYLFcqHk1BWzAYJbpX97KVJpQ+/ALOVpBQbgskNEr9YvO30kOsADvUPxpDeNnIbEVsmu1SUF2B9iOAt2jEJo2Rsi+75XmbZMxE1ez9oN9abCQBKkg3duSxPFcl2fTDUffX2nQ2Cb9IcSXAsY8ATYYLYJyHmZOc9/FV3lzmaqgj7Bc6aRVgCAys5gEagq3Tyc0NyuYTsZqaHyNPeVNLij04JWwusaXUZjieJHgD2PTvGJ8UsHeBnca7hlEDXCEdbVwjMZTeDsdkR3ZshYS7wNrJ/kPeCgU5m+yzISKJ359ZIw1976bAiMlraSosZA33B7Ak7yo/YOUy9DfjrajA/u9DjTUVWbinUysygj98OCC0CL8DGpm/aBGrdvzGctd5LbI2HuSY5Bwt lH9geEv+ fsN1AMjHzN0zbogQCBYlKVu5xGj9Goy7Ek9ZWnK8AyNVOlPr+pu5U9SHc8zD7u7Q07SdgOJURRAMy8qRnfmpWQOLzfVwbL9g+gR4V1ps0yfO/lY9HNeJxEi3egvHFqjLT0N2nWnr8g7S3RRqv1vdhMrjTWn/rwkmkf3txzWC3YkyyxnxQc1YFs9ZKpTpufVsu+vg3077/keqIuNiSgxuNhzflVba3SyAi818n+FDVpxZUbBdKDH1OriL0lQAma3ix4DioqNTzQDe02Mvy7vf5i3lp+fMjMBqWG97BNPBixBlMmMLBvOxjKo+g1GykVspz5knYs1JGtrbP7HXkG3KHapo8G+GJSo2ywaeLLHgClWgA37TYnlSNgO8wqUPZJYGJJSR1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 6, 2023 at 9:43=E2=80=AFPM Matthew Wilcox = wrote: > > On Fri, Jun 16, 2023 at 12:34:27PM -0700, Arjun Roy wrote: > > However, with per-vma locking, both of these problems can be avoided. > > I appreciate your enthusiasm for this. However, applying this patch > completely wrecks my patch series to push per-vma locking down for > file-backed mappings. It would be helpful if we can back this out > for now and then apply it after that patch series. > > Would it make life hard for this patch to go through the mm tree? > No worries, can you send a formal revert then ? (With some details, because I do not see why you can not simply add the revert in front of your series ?) Thanks.