From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B87FFC433F5 for ; Wed, 15 Dec 2021 11:08:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 33E7F6B0071; Wed, 15 Dec 2021 06:08:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2EF346B0073; Wed, 15 Dec 2021 06:08:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1B6366B0074; Wed, 15 Dec 2021 06:08:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0167.hostedemail.com [216.40.44.167]) by kanga.kvack.org (Postfix) with ESMTP id 095586B0071 for ; Wed, 15 Dec 2021 06:08:39 -0500 (EST) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id C2B6E8910F for ; Wed, 15 Dec 2021 11:08:28 +0000 (UTC) X-FDA: 78919755096.08.45AA451 Received: from mail-yb1-f175.google.com (mail-yb1-f175.google.com [209.85.219.175]) by imf08.hostedemail.com (Postfix) with ESMTP id EE224160005 for ; Wed, 15 Dec 2021 11:08:24 +0000 (UTC) Received: by mail-yb1-f175.google.com with SMTP id q74so54067093ybq.11 for ; Wed, 15 Dec 2021 03:08:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=A0vP+/wf7tROPM54COWXj5vF8GszBwkxGxw5qfBgKPU=; b=AB+xftGZiEk7z+rq+DSOxL1xuqffrnZpqo3Bqtw/vwKWVCLMWBqHVjFBXWZNTN4e0Q KIRKVQt146GIvEnvUysFH+Vq2bH+uLeGfTdKaaqeChakJAa9xiS2pAEDhdWIP0ab4bj+ AWzokV3zO32QvhoNQJ8ET+K72rpmC7pCvzwMYChjLu6aXHpIYGxCdtNbFtodHd1oOmeJ Oh2iGoWDDkg5TJYKA3vv3YNJy2tPb61jGxhlaPYVJf4b7kkUgMjeMsNd7PGJHba0ScwC UkVf4H8Trn60CU0B8MEjp+JwuWjOmAd0Mi0VxxBziOfffn9lYxUYcaLPLgtVpBCsSTmS u48g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=A0vP+/wf7tROPM54COWXj5vF8GszBwkxGxw5qfBgKPU=; b=a/ts76p6Z+Wq8mFve35QTrCQfTHEGqgr4xDxYtU2vGQdZJ7uWJLgu8aQuriF7aSZas NPHLKnzc8OLnka4rkTJ6lvvEe9qICshcq7gk0s1iVa3G5vV/bJqErLP9C1wL1QRGMkBQ H2VoSqOM0EmVkyADMhSiG9FGjxRarxmA3ybcw4NQtxTUJ2tXtd7+wo+1xKuvjd8iUuHb KY+CQXPfoOn88Dn8Qt91UwazQUoazVU64AjNh4sx7pOoLuTaPSLm70MonP4LcjvF6CaG n1gH401UuGshtxwofr7/JicyVzIp8IJCfMZc3PQOveZaj4NfwGWZ9GQPws8HzG7MQJpl Jv4A== X-Gm-Message-State: AOAM5339ApUKZNlInPB9JWS1jE9oRL7fg5otiQawmk8R5IkJbXR7nJ9S blQFevoqtS5SBiOQ//DJPpSa0QJ4k3Q1E/A/7Yp5Lw== X-Google-Smtp-Source: ABdhPJy8YejpFy3uOY9TFh9jJILgF70D/7YLJk7RIDdmvk4UN8+402gWwBI9l8Qlzuv7W1GFUmhvovQK2uB44YjpZMk= X-Received: by 2002:a25:df4f:: with SMTP id w76mr5797147ybg.711.1639566507334; Wed, 15 Dec 2021 03:08:27 -0800 (PST) MIME-Version: 1.0 References: <20211205042217.982127-1-eric.dumazet@gmail.com> <20211205042217.982127-2-eric.dumazet@gmail.com> <45c1b738-1a2f-5b5f-2f6d-86fab206d01c@suse.cz> In-Reply-To: <45c1b738-1a2f-5b5f-2f6d-86fab206d01c@suse.cz> From: Eric Dumazet Date: Wed, 15 Dec 2021 03:08:15 -0800 Message-ID: Subject: Re: [PATCH v3 net-next 01/23] lib: add reference counting tracking infrastructure To: Vlastimil Babka Cc: Jiri Slaby , Andrew Morton , Eric Dumazet , "David S . Miller" , Jakub Kicinski , netdev , Dmitry Vyukov , "linux-mm@kvack.org" Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: EE224160005 X-Stat-Signature: o349gkswaymhtbzpxjr7ofhu9d63dh6e Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=AB+xftGZ; spf=pass (imf08.hostedemail.com: domain of edumazet@google.com designates 209.85.219.175 as permitted sender) smtp.mailfrom=edumazet@google.com; dmarc=pass (policy=reject) header.from=google.com X-HE-Tag: 1639566504-234588 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Dec 15, 2021 at 2:57 AM Vlastimil Babka wrote: > > > On 12/15/21 11:41, Eric Dumazet wrote: > > On Wed, Dec 15, 2021 at 2:38 AM Eric Dumazet wrote: > >> > >> On Wed, Dec 15, 2021 at 2:18 AM Jiri Slaby wrote: > >> > > >> > On 05. 12. 21, 5:21, Eric Dumazet wrote: > >> > > From: Eric Dumazet > >> > > > >> > > It can be hard to track where references are taken and released. > >> > > > >> > > In networking, we have annoying issues at device or netns dismantles, > >> > > and we had various proposals to ease root causing them. > >> > ... > >> > > --- a/lib/Kconfig > >> > > +++ b/lib/Kconfig > >> > > @@ -680,6 +680,11 @@ config STACK_HASH_ORDER > >> > > Select the hash size as a power of 2 for the stackdepot hash table. > >> > > Choose a lower value to reduce the memory impact. > >> > > > >> > > +config REF_TRACKER > >> > > + bool > >> > > + depends on STACKTRACE_SUPPORT > >> > > + select STACKDEPOT > >> > > >> > Hi, > >> > > >> > I have to: > >> > + select STACKDEPOT_ALWAYS_INIT > >> > here. Otherwise I see this during boot: > >> > > >> > >> Thanks, I am adding Vlastimil Babka to the CC > >> > >> This stuff has been added in > >> commit e88cc9f5e2e7a5d28a1adf12615840fab4cbebfd > >> Author: Vlastimil Babka > >> Date: Tue Dec 14 21:50:42 2021 +0000 > >> > >> lib/stackdepot: allow optional init and stack_table allocation by kvmalloc() > >> > >> > > > > (This is a problem because this patch is not yet in net-next, so I really do > > not know how this issue should be handled) > > Looks like multiple new users of stackdepot start appearing as soon as I > touch it :) > > The way we solved this with a new DRM user was Andrew adding a fixup to my > patch referenced above, in his "after-next" section of mm tree. > Should work here as well. > > ----8<---- > From 0fa1f25925c05f8c5c4f776913d84904fb4c03a1 Mon Sep 17 00:00:00 2001 > From: Vlastimil Babka > Date: Wed, 15 Dec 2021 11:52:10 +0100 > Subject: [PATCH] lib/stackdepot: allow optional init and stack_table > allocation by kvmalloc() - fixup4 > > Due to 4e66934eaadc ("lib: add reference counting tracking infrastructure") > landing recently to net-next adding a new stack depot user in lib/ref_tracker.c > we need to add an appropriate call to stack_depot_init() there as well. > > Signed-off-by: Vlastimil Babka > --- I guess this minimal fix will do. In the future, when net-next (or net tree) has everything in place, I will probably un-inline ref_tracker_dir_init() to avoid pulling all these includes... Reviewed-by: Eric Dumazet Reported-by: Jiri Slab