From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9130BC4332F for ; Wed, 14 Dec 2022 15:16:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AE1118E0003; Wed, 14 Dec 2022 10:16:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A42938E0002; Wed, 14 Dec 2022 10:16:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8BC178E0003; Wed, 14 Dec 2022 10:16:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 7533F8E0002 for ; Wed, 14 Dec 2022 10:16:05 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 475E8C0EB2 for ; Wed, 14 Dec 2022 15:16:05 +0000 (UTC) X-FDA: 80241262290.06.33CC175 Received: from mail-yw1-f179.google.com (mail-yw1-f179.google.com [209.85.128.179]) by imf03.hostedemail.com (Postfix) with ESMTP id 903AF20016 for ; Wed, 14 Dec 2022 15:16:02 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=BUfL3YrZ; spf=pass (imf03.hostedemail.com: domain of edumazet@google.com designates 209.85.128.179 as permitted sender) smtp.mailfrom=edumazet@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671030962; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=i8/7ompYoprPv6p5gopqt1zlXtmepYGFLCWXe2gsqzg=; b=QNmRuvmoPXGQXWhpafckeRiOqXwEP4hdK/A8gRYiFvK1XfcpH+7QXylqTCdhCdrknWLbkq xSPmcjK7HSO7IIuf0HAXYJX9+CGqIrrm3rnbCbEqnGHWbSqfAE/zQKgFuHYYOK/RpwYfLr 8KY03MEvu8aQh2SX1U2NpHWgNA2xQ5s= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=BUfL3YrZ; spf=pass (imf03.hostedemail.com: domain of edumazet@google.com designates 209.85.128.179 as permitted sender) smtp.mailfrom=edumazet@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671030962; a=rsa-sha256; cv=none; b=kgEgmIxAxp4Wf+hUmF3co5Naxefqn7F57joKqBPDs0fMfDu8u0oj6Bcf9LYugbffpDp06F 0LD+ljTEDWYZS5EHrHzO3O3aOy3TL7BtpSmhnlHmV2GfbzCwLBfRN3BaAdCP0yJNhfYRHG lFocikhoEXB4HwO5YrO/xfyzN25c8Rg= Received: by mail-yw1-f179.google.com with SMTP id 00721157ae682-3c090251d59so645307b3.4 for ; Wed, 14 Dec 2022 07:16:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=i8/7ompYoprPv6p5gopqt1zlXtmepYGFLCWXe2gsqzg=; b=BUfL3YrZ28K+1n6E2SQ9fOqgRKi2RgeotU3ckXNn8xFWPTs42cuoGfphfjNQOV0pgx 7/jp35I3w0HRIOFVcsghYPgMBrhr8AMNN8/bTKnJa17Hz49AiqnR3KxJME/VVIigK+sS o/Lm4IOiEo8w6nxX4t2A4IzKZLODEjcrKKDsdmGKLI1atzrsu3mpNZREk5A83gxmOZAt L+k/IzYKvXs7B7hnKP1erYHIobJ4iQu87BD3pnHQtG8fBQOI4ExEQ0QtE/CElufFbNCA yV0c98uSdPhEqukbLuFuzz8L6ZLLU8J5/FlBKjiGFYDWzKiB3XFMXdMwK39OTfRDW0AO GSIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=i8/7ompYoprPv6p5gopqt1zlXtmepYGFLCWXe2gsqzg=; b=Z2nX3tPbYfh6b8boBY2mUfdNanFS+YQCIL7ZB/6GvxSL2agwbzE+LAUWtcWuZZqahx 0xiysV3Qcxx89F18Dk9yxMEBQIYQKWxVkyWNJwuXkaMetXAHs3YLVW1w1F+VP+S0p89t RLGk4OfcDnv68giNlya1XQpfAdluQfMKCE4f4PVyR7tPCVe7u8Ay00ew4Uihx6sclT2M O7m+krBBi5F4oioCDiOu4TMr09USeeTUVy+ujELaDLhvj5TI1tZH4/iDcXKlG+6g9tTd Fo+wVYG16a3uvzuYJWqUvZ8QMPesmTchFN/6o5NLA7IT11nOIcWrZO33FTtmzm9X/qD+ z9Yw== X-Gm-Message-State: ANoB5pkQGeMrrgZNr08VU1A7yHN8+Nsnm7O/AMzms4G4BFjbfoJYK+Eg wKObsdEH2qb7mJZ2Bd1fANFoVgOf/1oHxFyJ1p947Q== X-Google-Smtp-Source: AA0mqf6N7NofCRVaBdlZmzX/2IFdQaSJdENS2yaazN5Bc4VEowcispQ6llOh6euNJwrBHENhxHLAYZsrXmLpw9L8cy4= X-Received: by 2002:a81:1e44:0:b0:370:7a9a:564 with SMTP id e65-20020a811e44000000b003707a9a0564mr27785992ywe.278.1671030961275; Wed, 14 Dec 2022 07:16:01 -0800 (PST) MIME-Version: 1.0 References: <20221214123358.GA1062210@linux.intel.com> In-Reply-To: <20221214123358.GA1062210@linux.intel.com> From: Eric Dumazet Date: Wed, 14 Dec 2022 16:15:49 +0100 Message-ID: Subject: Re: [PATCH 1/5] Renaming weak prng invocations - prandom_bytes_state, prandom_u32_state To: Stanislaw Gruszka Cc: "Jason A. Donenfeld" , david.keisarschm@mail.huji.ac.il, Vignesh Raghavendra , Peter Zijlstra , Dave Hansen , Rasmus Villemoes , Alexei Starovoitov , dri-devel@lists.freedesktop.org, Song Liu , linux-mtd@lists.infradead.org, Stanislav Fomichev , Miquel Raynal , Roman Gushchin , Christoph Lameter , "H. Peter Anvin" , Daniel Borkmann , Richard Weinberger , x86@kernel.org, John Fastabend , Andrii Nakryiko , ilay.bahat1@gmail.com, Ingo Molnar , Steven Rostedt , Jiri Pirko , David Rientjes , Yonghong Song , Paolo Abeni , intel-gfx@lists.freedesktop.org, Petr Mladek , Jiri Olsa , Hao Luo , "James E.J. Bottomley" , KP Singh , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Jakub Kicinski , Borislav Petkov , Hannes Reinecke , Andy Lutomirski , Rodrigo Vivi , Thomas Gleixner , Andy Shevchenko , Andrew Morton , Vlastimil Babka , Tvrtko Ursulin , linux-scsi@vger.kernel.org, "Martin K. Petersen" , linux-mm@kvack.org, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org, Pekka Enberg , Sergey Senozhatsky , aksecurity@gmail.com, Joonsoo Kim , Martin KaFai Lau , "David S. Miller" Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 903AF20016 X-Rspam-User: X-Stat-Signature: pk9r1iwi8na8qt74tqfrxofandgyheqs X-HE-Tag: 1671030962-278312 X-HE-Meta: U2FsdGVkX1/PZCzVe+3d7NXNkClYNxhjqbrbzRzYvO5emFfJQDjLP1s7tGeUSfYM+oJ4KVA/mGAJ4fLo84ds5fxZzHItUnbEsIq1zRkrURJuFq37q1sDN8YNx4p7wJh43XLcBiGcW7W0RexyMJYwt64ZFjlyAXZE/xKHf+3Bc8Ub1J4LLRj1aShIbunJDw4/uYyBmExSSUNuKgg5ZBdZjNH6D+91ATPqKQFZ5kObj2edC8OBZnluYFXXZPj+byN9ZE5JynxMCExoQOvsiYGrGEQyUpZxSMejF9ywFWThIPoMFeCDCIubYpHvEpxgwRdN2rLM1xYW9dz4juJbKhFAOKFo4Ql5ysl25lAufBPKmgQtsR+h5mMP3UYX4tRpffLH5/KPelFHKTxCQXPXfpG+pOxyW6xHmkG2zBximGHDtqs4SNiG324ZOfBTF4aa7hQKgZTBP8jxCqXSxZSwLhz9qFeTt762rY5FsuyDNByBLa/0v4gqOhA6VMYDUeIc0mcV6Lzan4Exe+3L1nNgYrjO50kbrb5keN2bcv0gJmnEgQOLoz7li6S8HP/Hy0CgqzFXFVtiBgDrWLQ9QmRNKjQj/Zdo5OJ81EneHewl+T5HcKyOJbOaZKjwFxq2kVCOmneYXf/ahho4j4hfYKA49jYcMuoT/e9+pj5ieKTLYina8l+4CcUJMRQmYNkukdbcNQRlZSsYznnLPBA2VlQ4FzwEoDg+42ckwj4GgPBw43llGjTYuzQWeWg+uPE6Mob5bNVQ187IJK2wmB3Q4B8Z4Fm91MkLAqpv6gZ4ayRwBxEzWN5SsEx4kjH2UVYPXKgVLrCBVqlTgTA8zKeg8cgEiR9jIQEuT8YmlsVc3Ne1RrMw67ehR1L2MYVp3oODh+PCXN7usT34n/kwBFWTPrWEZKCJwtkEjvfZFooAxBG6MPt2NEVxK59jIWDWvcYtS38TYCU7qzDBbDWJ0Ejyyz2kcTE 7aGiQfF+ 08peDlTttwA8Oy52nWCA6njwoQBPYzfkp9pjD4b0arNUsr558qKebMttis9pivk2c4SxwVmAF5fPBHdZQ1pXbGLImDQRKbHDzXpViNWSUqLoACqJg6S9rwisjl0UxQ49kQd/J X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Dec 14, 2022 at 1:34 PM Stanislaw Gruszka wrote: > > On Mon, Dec 12, 2022 at 03:35:20PM +0100, Jason A. Donenfeld wrote: > > Please CC me on future revisions. > > > > As of 6.2, the prandom namespace is *only* for predictable randomness. > > There's no need to rename anything. So nack on this patch 1/5. > > It is not obvious (for casual developers like me) that p in prandom > stands for predictable. Some renaming would be useful IMHO. Renaming makes backports more complicated, because stable teams will have to 'undo' name changes. Stable teams are already overwhelmed by the amount of backports, and silly merge conflicts. Take another example : u64 timecounter_read(struct timecounter *tc) You would think this function would read the timecounter, right ? Well, it _updates_ many fields from @tc, so a 'better name' would also be useful. linux kernel is not for casual readers.