From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B530C4345F for ; Tue, 30 Apr 2024 14:04:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1C8296B00C5; Tue, 30 Apr 2024 10:04:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1787D6B00C7; Tue, 30 Apr 2024 10:04:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 019126B00C8; Tue, 30 Apr 2024 10:04:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D78956B00C5 for ; Tue, 30 Apr 2024 10:04:03 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 933141607D7 for ; Tue, 30 Apr 2024 14:04:03 +0000 (UTC) X-FDA: 82066367166.29.584ACCE Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) by imf18.hostedemail.com (Postfix) with ESMTP id B2F0F1C001B for ; Tue, 30 Apr 2024 14:04:01 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=iv0N94Hu; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf18.hostedemail.com: domain of edumazet@google.com designates 209.85.208.52 as permitted sender) smtp.mailfrom=edumazet@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714485841; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=e6o6m2z1nraUEbkc5iFx1PfQfkjbyaGlyCn/YlhNo4I=; b=xZ76pPOJNSnhSCsqHDCNI1+YSuHIDfazzs7+R3b41XCgocqngUnAV7mybBpaSmqZGuh/5R beD54abA7AFb9qxQM8PTu5gL9qr7lo5ioD/MZHhKzrcrX4r4sCnb8PgUPY7UQaszMwNHAC GnJEs8T7GeGTQ2R9c40ajczaEnWv9sw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714485841; a=rsa-sha256; cv=none; b=IdtK1l+EM5O0B9gv4mBYDbxVBp2jn1YQa5dLphzN4lIuMURNLU6ZdFZ4VtWc22tUDSEGYB cyjBgHN6wgMB7gAY8o3zUf8b6WZ3/IPKo5+OxWtZqLrI1nSCsXRaVaFdILQFFabEeqXzYe xys+x6ZoXZxEHm93KBHhdHD6k8YdWyw= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=iv0N94Hu; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf18.hostedemail.com: domain of edumazet@google.com designates 209.85.208.52 as permitted sender) smtp.mailfrom=edumazet@google.com Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-5722eb4f852so11793a12.0 for ; Tue, 30 Apr 2024 07:04:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1714485840; x=1715090640; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=e6o6m2z1nraUEbkc5iFx1PfQfkjbyaGlyCn/YlhNo4I=; b=iv0N94HurFhPADTHJ8lgrG9ZNGNDDtQq0eWen9jS+n0iLaKKfArBmicwbfT2PNp3A6 ZlY85GfgqB9WEor9Fybrsf3e+XYmzr4WcIf2NkAH24LAXdS32WLSsrpz2t0TyI7xq0VV 1/UorMlECG4Le1sQvIqsT3KWzBEA//fOQykzDkYtrFuBcZzt7nI3dA3SK4x8gWjijrju rDAhn9f1tqncfa8NU5I3Lu10PeHMbYg/H9Pw8Py+Hq9fK/dcfKigMmuUezkvIH2Nrla6 ZShq95P5lKOIry8PN4d4J3//K1w7bwjEzrkThpeDty5VGEG9l9nh5jqi2BIct5wwthF0 WUpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714485840; x=1715090640; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=e6o6m2z1nraUEbkc5iFx1PfQfkjbyaGlyCn/YlhNo4I=; b=ZOa+KP8/U88t9rAEga+6bd21X+/iU/JZ8E9rEYL7+af3Oe5X/EEgYv7kqjULFLEZxh oK4XwL/5xhWx32CygAEzzOmZCWvh2/2+nHlPar5Xq28NwO5Dc8YD/mlR3jyFovuqDkvw uJzsr55qePj1wVO63EFAQLm/VuSHAzqepg6jZ9bA4W/gEtflweFzj2h2rXP2t0plr1bn xFdYiNthYiuuYYDDPg2u9fsRpapMA6Rywkumxjm2OUUDi5aKPOA9HKyknOJbzGjGBWtf 92pZzNnfdYbfqPBBk7ko5Pi4ul8581nZpJIeTxKlkuHIr6ebGZkbeqLMWhtHgAqz1ebe orjg== X-Forwarded-Encrypted: i=1; AJvYcCUk5TMMKkjumjv0kRQViN0vtDd6m9uyzrPTyvtNpIvYxMMS4/ZXjOkl9ERQTrAjJGPpXYjzGp6MRbS5cQl9gll5kdo= X-Gm-Message-State: AOJu0Yxfj32eJXlLKXSyY7eclt5iQDycOkZtfw6QU5DgM2L8zGK014Pu dRGxHt2/qFiOcuE+SQFm99DSbA29vvqjx+GGUab77iKaOFM5Zuy7VBwC8U1t0zAf8midZ+CYgge iwWAJQJ0Na+72t30o9edsyteugdYqNdDX/FsZ X-Google-Smtp-Source: AGHT+IHBhdC6bIu+OUvh2/9MUIfVZ4322MIziLWRSqqoyhN8m3aSUYdBf6eczrknAyRrGPzpddise14uOfk/VInbMs8= X-Received: by 2002:a05:6402:4304:b0:572:988f:2f38 with SMTP id m4-20020a056402430400b00572988f2f38mr106828edc.6.1714485839629; Tue, 30 Apr 2024 07:03:59 -0700 (PDT) MIME-Version: 1.0 References: <202404302139.175c602f-oliver.sang@intel.com> In-Reply-To: <202404302139.175c602f-oliver.sang@intel.com> From: Eric Dumazet Date: Tue, 30 Apr 2024 16:03:45 +0200 Message-ID: Subject: Re: [linux-next:master] [tcp] 8ee602c635: lmbench3.TCP.socket.bandwidth.10MB.MB/sec -21.8% regression To: kernel test robot Cc: oe-lkp@lists.linux.dev, lkp@intel.com, Linux Memory Management List , Jakub Kicinski , netdev@vger.kernel.org, ying.huang@intel.com, feng.tang@intel.com, fengwei.yin@intel.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: B2F0F1C001B X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: iujmijcusthnoj7tbn9m84gk3pn3wyao X-HE-Tag: 1714485841-630633 X-HE-Meta: U2FsdGVkX18PotjAWzcHCK1jgIWmztxpnGa0ocecjXE0mNRz3mpxqUqxWbLQMdKi44R4KVfBkMkLyPR+3CYrzAp+rtg3Ge+AY0Mw7JOp8xesdb3b/YVhl/RG3WBe+Rj1p83GC7uAAaxVDuWGrsZqSCWplJl3LmKZwSrXGV4xRUQHgIgBg1uIqFdJr/oGpeostqVxGHU9aKlHZpOXsaEc79HFc+CwVjtFWvzxI1i2bHBQWqzrzqFiyl/ykY8oS0tTSCrm8Xn38RVToufN+X0noQJgQ9C4eAYZyterp+fXV2DqDsGeoVU9a3OJ/uf9B6wy7BNgDJjMyj77kTDOFfyRJPZcCgcvbafMn9qGILgq8UwVHU2tqkLl/s0rNnbDTPKaJbWcLwGaNus0GE+y0y42ExUgKlLSaofnasWdODB+orNSavAXq6hMuj2JnrmVA5dPiHuAo0gdDBnZrFZHduzyQGzOUXylA0UKyJBRbUzmqsZ+RX4SHyGGC4AwLy7dmO3uMchrENf9Luk6ZjWAzOnVR8glQyLv+aP+RrVumfzFACds6HzrG1+eSPHOEbo92DqpiPU5KHre3jtOseWUe9DZDLka/tPayC+VGyoe/pvzUKL5eHGSDrKoR3AqxxT+opY3aOe3wFyhqSI49X5V4X4C8p6AtalaXLMZWIGEYl97O06O/QFekTcllwxIX98Uy5zPCZCx4Gz2yEuvIjVWSYebHGCNv0Amt7Hc7vO9qwr8qUJNr0VrhwKupBMoOomhPiB3XqTJmzR3EptACbl5fSQslcQE4voZbVLQv0dslS2l49XyCZ7zWbqCBIEH8kj8CoRNfUm7QeHNn4ESt6/Y9grIBS/axzA/xPMzKCSpSHzjVvw2VG7NkYReWXhVTGqMpMrafLHrAQ3wnQ27mkbnDr+ANJegrLiwsy9zg6FuLZr98WYvnF9r2q3eZXIC+2Xu+4GMSUl3fY9jRbWkO0S6UDl uI9LY5/M x47drQRGuIktJ80QdNnrllyMCtwheeDbDosex/H8lvOejGxDSs+wDZ8ksLLKhmfxFSnA28FfuQKfLDJp4zn2udvQWKCOk1OPd8ThdDnvi+Ni32JXt9qHfyismur4d6I7dRI/oH8G2redz1hwejBt8s1vsPac8hNq2mU49ltaDHJDa64C9kPyy9mfr6DCd+PW34FQCEMrCrpl4Z9Jv6jokM4vcT0AFbId2/Yexr+BILpfUAw1EU14bmsljtKel6yKWBp84y8oEGvXoorOT+WNRiBSHo0LSxeNmJYXJY7yH7p8JZhZQTeWbzTuAKX4OZWZ2ymRxvfUTLGMj17IxXTY40NHQmR3j8LKB2e5s9u6jT1uWRRyF/B/PxhkNCFUJOe9csQY8S/PtCfVxn50= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 30, 2024 at 3:45=E2=80=AFPM kernel test robot wrote: > > > > Hello, > > kernel test robot noticed a -21.8% regression of lmbench3.TCP.socket.band= width.10MB.MB/sec on: > > > commit: 8ee602c635206ed012f979370094015857c02359 ("tcp: try to send bigge= r TSO packets") > https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git master > > [still regression on linux-next/master bb7a2467e6beef44a80a17d45ebf2931e7= 631083] > > > testcase: lmbench3 > test machine: 48 threads 2 sockets Intel(R) Xeon(R) CPU E5-2697 v2 @ 2.70= GHz (Ivy Bridge-EP) with 64G memory > parameters: I do not think I can spend time on this regression. TCP performance is very sensitive to various factors, like packet sizes, cache sizes, sysctl settings (/proc/sys/net/ipv4/*), application design. Making TSO packets bigger can increase p99 latencies, that is for sure. > > test_memory_size: 50% > nr_threads: 100% > mode: development > test: TCP > cpufreq_governor: performance > > > > > If you fix the issue in a separate patch/commit (i.e. not just a new vers= ion of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-lkp/202404302139.175c602f-oliver.san= g@intel.com > > > Details are as below: > -------------------------------------------------------------------------= -------------------------> > > > The kernel config and materials to reproduce are available at: > https://download.01.org/0day-ci/archive/20240430/202404302139.175c602f-ol= iver.sang@intel.com > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > compiler/cpufreq_governor/kconfig/mode/nr_threads/rootfs/tbox_group/test/= test_memory_size/testcase: > gcc-13/performance/x86_64-rhel-8.3/development/100%/debian-12-x86_64-20= 240206.cgz/lkp-ivb-2ep2/TCP/50%/lmbench3 > > commit: > d5b38a71d3 ("tcp: call tcp_set_skb_tso_segs() from tcp_write_xmit()") > 8ee602c635 ("tcp: try to send bigger TSO packets") > > d5b38a71d3334bc8 8ee602c635206ed012f97937009 > ---------------- --------------------------- > %stddev %change %stddev > \ | \ > 50684 -21.8% 39620 lmbench3.TCP.socket.bandwid= th.10MB.MB/sec > 10.17 =C4=85 41% +83.6% 18.67 =C4=85 15% perf-c2c.HIT.remo= te > 0.10 =C4=85 71% +0.1 0.22 =C4=85 16% perf-profile.self= .cycles-pp.__tcp_push_pending_frames > 0.66 =C4=85 72% +0.6 1.24 =C4=85 14% perf-profile.self= .cycles-pp.tcp_write_xmit > 965580 =C4=85 83% +150.9% 2422689 =C4=85 51% numa-meminfo.node= 1.FilePages > 1617434 =C4=85 52% +91.0% 3089919 =C4=85 40% numa-meminfo.node= 1.MemUsed > 3863 =C4=85 14% +24.5% 4810 =C4=85 11% numa-meminfo.node= 1.PageTables > 612236 =C4=85149% +218.4% 1949210 =C4=85 61% numa-meminfo.node= 1.Unevictable > 241348 =C4=85 83% +150.9% 605612 =C4=85 51% numa-vmstat.node1= .nr_file_pages > 964.36 =C4=85 14% +24.7% 1202 =C4=85 10% numa-vmstat.node1= .nr_page_table_pages > 153059 =C4=85149% +218.4% 487302 =C4=85 61% numa-vmstat.node1= .nr_unevictable > 153059 =C4=85149% +218.4% 487302 =C4=85 61% numa-vmstat.node1= .nr_zone_unevictable > 51738871 =C4=85 15% +27.3% 65841641 perf-stat.i.cache-miss= es > 0.45 =C4=85 7% -7.5% 0.41 perf-stat.i.ipc > 1.29 =C4=85 2% +17.0% 1.51 perf-stat.overall.MPKI > 9.45 +1.9 11.39 perf-stat.overall.cache-mis= s-rate% > 2.67 +3.2% 2.75 perf-stat.overall.cpi > 2064 =C4=85 2% -11.8% 1820 perf-stat.overall.cycl= es-between-cache-misses > 0.37 -3.1% 0.36 perf-stat.overall.ipc > 51471548 =C4=85 15% +27.5% 65638078 perf-stat.ps.cache-mis= ses > > > > > Disclaimer: > Results have been estimated based on internal Intel analysis and are prov= ided > for informational purposes only. Any difference in system hardware or sof= tware > design or configuration may affect actual performance. > > > -- > 0-DAY CI Kernel Test Service > https://github.com/intel/lkp-tests/wiki >