From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63BABE95A91 for ; Mon, 9 Oct 2023 07:54:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CDD748D001A; Mon, 9 Oct 2023 03:54:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C8DEE8D0001; Mon, 9 Oct 2023 03:54:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B54F28D001A; Mon, 9 Oct 2023 03:54:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A3AC08D0001 for ; Mon, 9 Oct 2023 03:54:08 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 64E82A0175 for ; Mon, 9 Oct 2023 07:54:08 +0000 (UTC) X-FDA: 81325159776.19.DDCF2AD Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) by imf09.hostedemail.com (Postfix) with ESMTP id 97BDC140015 for ; Mon, 9 Oct 2023 07:54:06 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=XObHbLQk; spf=pass (imf09.hostedemail.com: domain of edumazet@google.com designates 209.85.208.44 as permitted sender) smtp.mailfrom=edumazet@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696838046; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=h352FGx59vcioNapcninHN6AK5Dc534x0lC4Q9q6E4Q=; b=ONDYr/WYMOlI/l9O8+9JfNTsWeNWfpcE0QR/Y+mC7EWNIv4IxX5yQRKkDbfS4qtdj1RuMa Bk32LxNOoa1StJr27jrGe2OwL0h777R7+FEHeMqOmc+rk3/AjNegUImNdZ6wENjuAM8tfF 4WvMtGF/XgLrPZHmXhQKMigz8zn9qrw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696838046; a=rsa-sha256; cv=none; b=JYwPF9jbopo0tDFyJ/9ykIgdHhVJvK4Nwap8GT9Q4qvLdfz5ZqcMluhzIenmh3CXxn/ySL D3aNnTNhgyrNprQXVhDwmECNuvXiz7Bajs/I+lEp33Ly/7XA7nTUtv+NMbCc/rwqzrune3 GOxwOSIKEAMtqtkgxqK4AtjOIm/ZI6A= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=XObHbLQk; spf=pass (imf09.hostedemail.com: domain of edumazet@google.com designates 209.85.208.44 as permitted sender) smtp.mailfrom=edumazet@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-51e24210395so11986a12.0 for ; Mon, 09 Oct 2023 00:54:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1696838045; x=1697442845; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=h352FGx59vcioNapcninHN6AK5Dc534x0lC4Q9q6E4Q=; b=XObHbLQkKAFpNBZfentV4PjnzzKb2kudYgQszwV9m4BG3W0RPzsuxth1EOMgxj5RuD QeBYguswJRRS87KXhGhm6O5MK30DG7T2BBYeRvV463udC96u6aAIEnfdeybcP3BTdwBp A1wGg+y7CRg9tpKyAoRblfivQsoBIRS8xgBLUoYjp91m85buA6vLi/l5jEFmVbLuvvJX ksJvul7kngqYYSKNRF2GA2x5CXLoihUm9hbRHQ4MJzUAVhgVdJMx5bq3LjN4hm+CfdGJ DAM/DcbSh+fa58ahSsVbSuxyRNnDSpsnEoJ6hSC7VNmI44K90I8JZytSi9OqrPrSn2z9 Ka3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696838045; x=1697442845; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=h352FGx59vcioNapcninHN6AK5Dc534x0lC4Q9q6E4Q=; b=DjPdLDT3zgjHuPd/vh7ld+RcgTLxXka7p9g8YYVx0gSyjv3pp5t16MTjGOGf5eXiF9 OqUtBOBUBozbbWKv0+n+o4QPqc0qGGYB//y/CwxPsoHTeqoTFUozdh6kwGzSynQG/DmR n24SzMuXnFTdlvml2cohEl9x7oB21SB77I79NUdZt9s76vPD68Lv21wKJuF/IldptlCJ 8RZWUbiQFTIub07YXF8D7iQB6NiKdDjA9GJuB3T9QsGma7z4UKZgAFJ2ffaA8NNRKS3r ozxUoVAP9V0JYPIXlqfl8xwZ1GMFSPFPGqkwmLN2Fwyw3dR8/ITM8e7Bt7AKEpRlh02I qAJA== X-Gm-Message-State: AOJu0Yz4wbLQOKGlZzviD530lN/XVRSToi7VF8UzZOFrdrr/gLHEBeke TrS08hxNPukHs1G8D4XVY/C0tpXRbiEqLgN40ldeIg== X-Google-Smtp-Source: AGHT+IHsQHtiO+HFnDwGdTsCR/yEkTk+9iKWYFkj3SIWhzqIW+ImmjZj3Dee+Bbo+8oUayPw878DHRaxoahjxKWxo2k= X-Received: by 2002:a05:6402:d4b:b0:53a:ff83:6123 with SMTP id ec11-20020a0564020d4b00b0053aff836123mr195876edb.3.1696838044799; Mon, 09 Oct 2023 00:54:04 -0700 (PDT) MIME-Version: 1.0 References: <20231007050621.1706331-1-yajun.deng@linux.dev> <917708b5-cb86-f233-e878-9233c4e6c707@linux.dev> <9f4fb613-d63f-9b86-fe92-11bf4dfb7275@linux.dev> <4a747fda-2bb9-4231-66d6-31306184eec2@linux.dev> <814b5598-5284-9558-8f56-12a6f7a67187@linux.dev> In-Reply-To: <814b5598-5284-9558-8f56-12a6f7a67187@linux.dev> From: Eric Dumazet Date: Mon, 9 Oct 2023 09:53:51 +0200 Message-ID: Subject: Re: [PATCH net-next v7] net/core: Introduce netdev_core_stats_inc() To: Yajun Deng Cc: rostedt@goodmis.org, mhiramat@kernel.org, dennis@kernel.org, tj@kernel.org, cl@linux.com, mark.rutland@arm.com, davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Alexander Lobakin , linux-trace-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 97BDC140015 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 7c4kzowar4mhktfp81kymqraeuout815 X-HE-Tag: 1696838046-941157 X-HE-Meta: U2FsdGVkX1+jqnwyCaDDvY4qJnqHSWPNhj28ai0wsVhYMnj4JIAbF1Xb9ardNokNsgeTCf3zWVQNbNg/C+aIKAeY++pmXzHYuaFYbw1vQmFVrx2rD2kgTlSA7gJ8MhzoxHURfRYpTob1xk+h6RnFgExxtdxhEXdo4QqbUF4xqRlgp8CfVZG8giFvAtxIYH43eQSz7JiJFEdRgWS1LIWNItv8284+kZV5LcvLQdsMWxqy0EnssjcQ1KXQWtOjmRYnBGAhCqQPXB2tz2HurzEgV2SuH6/MMt3sHBRMQppq9Zn/o7nHdt55EJ3YdklNpbWq7olncw4lVFcQnYDfBR3XRq8faKcGclfwsZ41KYtwvn5FEAU64KvXzPd9XJdHw9morKkMG2QAk5rW7OkGeOEMHFmT/wgPpgS5KzIEJ9+ep1emzXZi8owNQyQc/0VCgE5b39JtemrBgsa/F4UXnV6kh//qCnvBmtUnIpDpW/xNF4eli3CSPV2pe14ccn3RfDyAmLz7e46wyVR45qKfqTgMG+MCPkDG76cQwIOrWKW1MLA3Ca/X9RUS6jFF8J9ctGDICaFrac6o+hC2ppPadEsp39Dqjk4si+WJ//aJXOEjDB76grEKsGKTk/nVwJ7urFHUjsukOlywJFXgvUWRgWovFCcnoHokCdkKzj6ywcMDlt9C++2gbT6efhcyYWOCUWEk1hzm59osVHs5POTfz9O+f9xP8k/0rB08E3ZZwJRz159/6ibaXIYcMLBAH60b7biaIaT4CpONhqjsynPybtb/ixsGxCzCnDA5Xij0Jhn5rTFXiBJ9ILkwe6Kmy80eN7R8qNtDVOqOpa4ro1ixdVcBbCL56gbre8odlcdWzoMiTjI8ZRrUYi2X7hsCyaFY57PWl0BSObTUCFtmcWHOgHhZJ13SEV446bG7258QXTVv5itwh+E0uu5sIxmrpEDHT6gkvDAVUstiJpd/4OwEH4R k/lZV66E pWrxSQKzaTlwHoWySZ/LBSGNNkzORHYy5K73aui7s6r9hqqGvy/F4DkqEDlpZ65GV9wmxrPq3o6gstX6sZba96oy5lrg/7C1VWTZ+JO3R4zH+UcrYvBcH326GVNJ+R/9OGzDKySSIGhrZgs0FcGqMGJxCIHghvZMXyaaBtpGrELTRA5AMqS98ZyWMnuMn/QqhF5LYOE3ZHyAcijFWgOUpqP3yGw30oD73CUnExqH8RnJ2j5BsgQteVbw83nt9ra1VrsdcPpIzDSMU1cLwqXP/5V4cjA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.054370, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 9, 2023 at 5:07=E2=80=AFAM Yajun Deng wr= ote: > 'this_cpu_read + this_cpu_write' and 'pr_info + this_cpu_inc' will make > the trace work well. > > They all have 'pop' instructions in them. This may be the key to making > the trace work well. > > Hi all, > > I need your help on percpu and ftrace. > I do not think you made sure netdev_core_stats_inc() was never inlined. Adding more code in it is simply changing how the compiler decides to inline or not.