From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA9A9E95A91 for ; Mon, 9 Oct 2023 08:20:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 59EEB8D001C; Mon, 9 Oct 2023 04:20:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 54EE58D0001; Mon, 9 Oct 2023 04:20:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 43D4C8D001C; Mon, 9 Oct 2023 04:20:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 31C2F8D0001 for ; Mon, 9 Oct 2023 04:20:41 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 6F5FBC0186 for ; Mon, 9 Oct 2023 08:20:40 +0000 (UTC) X-FDA: 81325226640.24.4BA7B1F Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) by imf29.hostedemail.com (Postfix) with ESMTP id 9FB42120003 for ; Mon, 9 Oct 2023 08:20:38 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Q1R6W+pW; spf=pass (imf29.hostedemail.com: domain of edumazet@google.com designates 209.85.208.54 as permitted sender) smtp.mailfrom=edumazet@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696839638; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vWViv6BOk41de86zHjPam8Zdgu0i96xG1qhT5iaH3Ps=; b=k+uAhqjVW6uyl+9AAXTRWHErnTEE4Hvgw8RsluMC+gIuMp7QDNZxZSxVJH7dbsxKS9hzjZ HbRe9IgX/weXBTlr2LyA9m8I//JeYOqufeTB5FGx+IFl9pSGa7SrBNRgqVf5i7iDTzfUw+ Du7/NBCaF62liIi95Di8oquPXvaQMho= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Q1R6W+pW; spf=pass (imf29.hostedemail.com: domain of edumazet@google.com designates 209.85.208.54 as permitted sender) smtp.mailfrom=edumazet@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696839638; a=rsa-sha256; cv=none; b=5R7nGp1SitfkMJxd2rS4KkxTbuD/fjN9ETcqmdpoyen3iQbmGxm7T5tZrkDxh3VqaQjxyG jIZz8qOzMABDdenEa5cmG8845DYEeZGZdlYaHp6ijiNrlsoZRAV6hupX2LgM1T50eudLVA Vr7xk0hy+29eJDq5Q6t+4BWUNMqkaLM= Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-534694a9f26so9614a12.1 for ; Mon, 09 Oct 2023 01:20:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1696839637; x=1697444437; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=vWViv6BOk41de86zHjPam8Zdgu0i96xG1qhT5iaH3Ps=; b=Q1R6W+pWNWpZwIl5HTvKh7EbUj3ZAsQT01ZYkgfhCp/Q6kGmztO2OsacwxLDbyBt7A /76S8n3SAO+blE2rEdoHH7xBqQrDn8SBbisRCR1OycMwhzcAADeexdQWcDNjh5KR8XIQ LyT6pDLCOowr240Xx9qtQ5HP61uINWrpfiOT8+wIIf95k9QkxSbmmu2cvSjrhs0TVHYv SlslEtNDOt0wuNuhUZCD4bPj9kfm5Y4kMfdq/lzQl3s7n65cBYZUh/1rrbu+qrTJ65bb K70tP7xIAo71oGJmRtEJWu4vNUDhyKZHlG86Ss3VfF6woMy10je7Vyh2e8fKKo/dCnKX ncIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696839637; x=1697444437; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vWViv6BOk41de86zHjPam8Zdgu0i96xG1qhT5iaH3Ps=; b=Gtv5I8KX1fd8J6FjBtuQdyH5UMzS/A3P3RaUCL0ola8eW98uivBf5Lk2iwDzMwr0SV 71MYq8PTyOh8Fgl1p1tc9e6iGkKl3+bsA7bzS6nmT7K03Os3GLYcHMdGJX9+ZNlQpKqg e0WacVIuav3TZC+PcX5aDzJJGc+BNVXFixvYPlPvtwBbtrnuWNKL+MDQIXYH8r6yBYEW yYAfpwiU85XL08TvcYuILgB0h0UkXi6tN+e1mFcsoKi8UKohvybN20u9eFVzEW4Xss7O e3IxOQRo74mX9snMQe7JGV06mbhMnxFF2VnlNomCQqY1nej9i5AiJQiVopA5elfTVXCX AIRg== X-Gm-Message-State: AOJu0Yyub5/GgDVagaZS2mhjwyd56/dw8bLdhjmSHoXEgN7QBTdxvjD+ Yj9UR8Gtj/y6Cn72EB5Dob16czY5yh0FV4PN/CmpYg== X-Google-Smtp-Source: AGHT+IH0V8NS2cVB9NZEj3VMCocK2gICCvlMXNwBh20rtBdFEA7r8dCh0cjFM+eUOw8TJ+GaIC5YbUP3Z5a6HMdEiVA= X-Received: by 2002:a05:6402:d4b:b0:53a:ff83:6123 with SMTP id ec11-20020a0564020d4b00b0053aff836123mr198316edb.3.1696839636925; Mon, 09 Oct 2023 01:20:36 -0700 (PDT) MIME-Version: 1.0 References: <20231007050621.1706331-1-yajun.deng@linux.dev> <917708b5-cb86-f233-e878-9233c4e6c707@linux.dev> <9f4fb613-d63f-9b86-fe92-11bf4dfb7275@linux.dev> <4a747fda-2bb9-4231-66d6-31306184eec2@linux.dev> <814b5598-5284-9558-8f56-12a6f7a67187@linux.dev> <508b33f7-3dc0-4536-21f6-4a5e7ade2b5c@linux.dev> In-Reply-To: <508b33f7-3dc0-4536-21f6-4a5e7ade2b5c@linux.dev> From: Eric Dumazet Date: Mon, 9 Oct 2023 10:20:25 +0200 Message-ID: Subject: Re: [PATCH net-next v7] net/core: Introduce netdev_core_stats_inc() To: Yajun Deng Cc: rostedt@goodmis.org, mhiramat@kernel.org, dennis@kernel.org, tj@kernel.org, cl@linux.com, mark.rutland@arm.com, davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Alexander Lobakin , linux-trace-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 9FB42120003 X-Rspam-User: X-Stat-Signature: hmjfadycfie16hjxxurm7fqenp84zikg X-Rspamd-Server: rspam01 X-HE-Tag: 1696839638-91875 X-HE-Meta: U2FsdGVkX1+xCvPIAcmFyuE/FPORaP9vXjiLLg+QGxgsIvRUE63/1jZDm+idEWrty5qn80mDJY0vCWklUtXfSE73+jpClliBDPDsmPiE0rFGPgB6vFQUwFSdh5sbcM4MHHBZODGILEO3snyC3jmzl7Not1QUeFb4H83R3qG6IsOGxgHfqFeWzqWaHr20XNHrBeV4S20eIHk3RkTxHMpsh+Y1rxBbOSjyoohDd1cYfhBNGyrrO4j+L3KGOAPsOzSsihY6fVEiAUePeAVMvHVwlTO2Bjp1vEhoDk7d85SMt5rA9XrB/tnlP8I8mMWsYQS2T2SfaBucRxZHYDdHs8qIepGH/mg6n7V0kK28xVtuD3Hd7ykgwHwNJNBVKSBvpVHNRDnOXTZEvIWz6a1dudURITeW3nBrt21ZdrqqrUvPiJSiIC4aAPztSt5agMayBzk40/g0OaC/heX4jiN9dcqRmLLf7XFDrqaO4MOHvBVPm/MzbqqRVPlJ8j6SJFKr+3/f8YobDaks12tht7zTPp+PDjwo/WK0INXLWzDoOb2d0rqJcnfI8r0+95PGaRmte9JOxkfpuqIQs1O8CimR8cgE1SuvyE6IJW5iRmpUWvA9RrJZMzsmczCt82zPm1JyEmrDQygOtRftA8dPMSPkCJk3W3O44RXvjbbOkqsdZPFJck9hhGJb8vHP1fgiTzqY7DosNXzOM2aPg8CaP0Lu2IVqOq0VQswnmkUYvOjhiJXJk5v6pwsUnCMl04wbH68GYdpPvBAq4TZyPdZWUoNe4zMAOMZvTGggE8YRpXglUe0xxEUbDt2JxfKAdm7DEwjA7RrbCagz5PtLwWVI57AOqlVknV+FxVtI5eGG0UlK155VpbncEN+aJFYFow5X0BV8cu5oR+0kA6nWuiqhnfFFi1ROQxXt8L9spf6P/oPu6uDZKVXsgEEPqcSBlVn+fdH5oJF1DNLSui/2O/N7yl/hJNZ NU5yEsnz +aWDAuph/OUxIdhTUPd1EMVohGIk/pQ0aH+1DcD2nBskfltryi4fuN4MSQVJOrpuUdqefs+dTnlYae8yOv75ZfL0BV/GQEQUqCzhmI6xL9IhcCR4zBcaLenl0jF+0VSemIqNrn/LUJeRmNB3zbrPPWClFBOomw9O9QY69mTDgcmA5JWLmQTFDhoXy2vTsexysgZlFsCWFfPvykhyScr5rTF9/ugf0jThE6YgEs1w/4IuEoMmOZmyIuXlrcRTfyd0F5S3KTSXp3LLJxeYWaHom0rkd3Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.084562, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 9, 2023 at 10:14=E2=80=AFAM Yajun Deng w= rote: > > > On 2023/10/9 15:53, Eric Dumazet wrote: > > On Mon, Oct 9, 2023 at 5:07=E2=80=AFAM Yajun Deng wrote: > > > >> 'this_cpu_read + this_cpu_write' and 'pr_info + this_cpu_inc' will mak= e > >> the trace work well. > >> > >> They all have 'pop' instructions in them. This may be the key to makin= g > >> the trace work well. > >> > >> Hi all, > >> > >> I need your help on percpu and ftrace. > >> > > I do not think you made sure netdev_core_stats_inc() was never inlined. > > > > Adding more code in it is simply changing how the compiler decides to > > inline or not. > > > Yes, you are right. It needs to add the 'noinline' prefix. The > disassembly code will have 'pop' > > instruction. > The function was fine, you do not need anything like push or pop. The only needed stuff was the call __fentry__. The fact that the function was inlined for some invocations was the issue, because the trace point is only planted in the out of line function.