From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 845ACC04A94 for ; Sun, 30 Jul 2023 20:43:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E349E280008; Sun, 30 Jul 2023 16:43:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DE4C1280006; Sun, 30 Jul 2023 16:43:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C85D3280008; Sun, 30 Jul 2023 16:43:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B43FC280006 for ; Sun, 30 Jul 2023 16:43:57 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 805A5A0462 for ; Sun, 30 Jul 2023 20:43:57 +0000 (UTC) X-FDA: 81069454914.06.0DC2E57 Received: from mail-yw1-f179.google.com (mail-yw1-f179.google.com [209.85.128.179]) by imf22.hostedemail.com (Postfix) with ESMTP id BAD15C0004 for ; Sun, 30 Jul 2023 20:43:55 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=J0LH5189; spf=pass (imf22.hostedemail.com: domain of miguel.ojeda.sandonis@gmail.com designates 209.85.128.179 as permitted sender) smtp.mailfrom=miguel.ojeda.sandonis@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690749835; a=rsa-sha256; cv=none; b=Ri3rUZTFH1rnO09xlnyXrXY9/4sjrcFx8tLahTcswM9TXqRVttQzM1UqJFPbgT4EK59Omx a3yqkY6HhrY3KZ0O9i/vntxjTgMiwEpUQ2W9I6s4Rhnl960QIpmcwvaS75QM0j3cltYmUK tgvk8SOlslFBLhzNEd+A4PrBgexEzeQ= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=J0LH5189; spf=pass (imf22.hostedemail.com: domain of miguel.ojeda.sandonis@gmail.com designates 209.85.128.179 as permitted sender) smtp.mailfrom=miguel.ojeda.sandonis@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690749835; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2aodzXpRHI/bS7yWyn8V5jZfavldcj/3Y/at9dgvqKc=; b=o+qr54Bx4TG5xvlwAkzM9emR7SUvY5jFsBjR2jDRMK4DJr7GV9pHBy5riG/hFYt4AvwMeu eVmtf+6Bb8FwbwMWfWyzkiHI2csXTyBfkks0EDZ0AJ66Jr4uuEU/vQSMtlix+OOPmw0Bz1 hQCGBWWLLC3RkLdeO5WWblkFDDSYj1I= Received: by mail-yw1-f179.google.com with SMTP id 00721157ae682-58411e24eefso44174917b3.1 for ; Sun, 30 Jul 2023 13:43:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690749835; x=1691354635; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=2aodzXpRHI/bS7yWyn8V5jZfavldcj/3Y/at9dgvqKc=; b=J0LH5189v+VQoh18mnc1fiUc4rgF3UC6iplLI7kl85Ep1TIvOuD8TVtXOmXVe0VUS8 UKPga1SzVaptjyTJodO7qq9ePk2R22cHp2uu13Mrdn8qmQUnklFyYDNsbsKp2uDmbGCa Bbd9j8i6NkNgjZ7OqxNNn0UiGOXUNc+rdnxAiAPsVOh22/QFjr0ry45jQUTUG5KBhFl0 jXzEMPLUDPwzIJWic5rV/7x6hHXz1gZWn2k/9souI5qwNwY3K+BxsFaPN2FeYkqHIn2B 4kj5qr5xRvkhRMHkWe+WUeZt3O0Qb2U2oaH5VVPZNYUF6K3RfiVgF/HHogbao7KP1td6 AZJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690749835; x=1691354635; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2aodzXpRHI/bS7yWyn8V5jZfavldcj/3Y/at9dgvqKc=; b=IGnUo7GoI3XPvd9kWt4BhFno85E08Ed7PZ+KSi/ulHQLpPRwT0t0lB3wVEyynOiC3i lfzM/gouZ2DPyPwvbPl0/N5/E3Cy86DpUyGT21TSQexb/4ilnPBc9RGTqkWzaCcpRCHx 00oLa3Pv1zoqIfWQeF6/fKQOUBiZ8cOb//uER6W1dh1WqjbGl0P7znNBHdUR8YjxcAMd 4bEv8DevsiqdhNsCSLDG+JtDgzmzabrRQqjrhUmpPv70g3zjsAv3v//1MYQoeHdlDQbI MVW/9NGTxxUIldw6r0lHrmPJ0sC+wf1LRdYKRzgyGj1Gfsbi608c0ZuPGAXEzfbvcUy+ 9SEA== X-Gm-Message-State: ABy/qLbt+DXvD5oeiuytDth33iRxg91/M+yflMPqUWVR68xE3goQs0N8 YoKzwKvqMk0AJBoBEo+Q1qenK+XTBoFFpdqNWQY= X-Google-Smtp-Source: APBJJlELqz4rIk0ONTX57WRyZ97exjjOdhECXSwlxGUOjsg0MFwyo9pJsPd/rsR+fvXfy3CbhtN65ylorV061oqVAXA= X-Received: by 2002:a0d:e6c5:0:b0:583:af0a:267 with SMTP id p188-20020a0de6c5000000b00583af0a0267mr8900253ywe.5.1690749834884; Sun, 30 Jul 2023 13:43:54 -0700 (PDT) MIME-Version: 1.0 References: <20230730012905.643822-1-boqun.feng@gmail.com> <20230730012905.643822-2-boqun.feng@gmail.com> In-Reply-To: <20230730012905.643822-2-boqun.feng@gmail.com> From: Miguel Ojeda Date: Sun, 30 Jul 2023 22:43:44 +0200 Message-ID: Subject: Re: [PATCH 1/3] rust: allocator: Prevent mis-aligned allocation To: Boqun Feng , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= Cc: rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Miguel Ojeda , Alex Gaynor , Wedson Almeida Filho , Gary Guo , Benno Lossin , Martin Rodriguez Reboredo , Alice Ryhl , Dariusz Sosnowski , Geoffrey Thomas , Fox Chen , John Baublitz , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Kees Cook , stable@vger.kernel.org, Andreas Hindborg Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: BAD15C0004 X-Stat-Signature: pbwbcp9rrce58w8agezu9sycjin4j9nc X-Rspam-User: X-HE-Tag: 1690749835-361312 X-HE-Meta: U2FsdGVkX18PgQYowQey+fOzQqmiSARXxQB4vjMyaEvq4APUxf975cspfxdtpqGmK1TvRxQ7itCyxTYcpKIknlUpH/h39+TpNgo8TEXXbWE9cKlm226TpP1j6zTQbyY2dSPJhJKX18dfr5pDiUPfz2Vh2BYey8iYhFJ4HOpgooeI40/Zamr3qTvuFteAbPPJTcByjsynzXbY0R4gmu1cNJPNJui2Ow8qmFA14TGGFoOW/mXXd2xMnO6BNqkYr4sMXeJrVyuEYeVRwngaN5/uFYgVi1OxtkL+UObVpl4HYe1/OOLJ0lJWOu0uxXnnSgb82uMQbBOFdJCCfHJfo50YnRfSFKOIzdG1LIPFRZZtvJpdQ1rj+M2RU1A/X8jh0z3U0gzpdYwwcybJA81+UbcCUrfN0rzFMRZcz6yzbid0OPGWIZtf4Bf1o0VgRxUAnWC9LZCjcKHi7YLKdASoIlGrBBVHIP9Nm0qD/6HTHwAkAL3h4tZe4i7inVU7QgV8uRIhbcqmF4DLKbgaqOjUblWp1+NuSO0wNfSbr9r3ghI+P8PPmDtQp0HAr5pNs5evke2kaD/rzd/ES/aeJT9w6udk5MJMckQLSzoa8acW9R+9p/iYZBJJsyBujOyXiRu1iN+i62XRb2CkShsvYn/Vu/dxgsQ9EE5YjnIjJxe8Sg//gdT682AqCd0B6ZJ18gDKVruXmrTgxi5yGe0YzMPSploLNDrOwR4/7CRGWHtHkmKN8pbxZNoReS+cj820j1vDP6axW0+LjJCdVvccaNWMVcA2wKUWbfg5PpRf09kggK3cEeiWx1h2WQDcVknip8cuBOL2ifZRC+sIcin7zyi4s1fF39eiDxBodww7lkZr08oHR9ddp7xvoJL6J3Ag0Ivd1eISFxxlUjEh7mm3CA0OIl5nl79un6EtKrdipooaY4TXamUD7uZBAyVac0bXqSYg2wEK5WMMlXHw3qiUyMSnhIq xKTNMGJk 84ApiPD4BuW9+1sqFoToK5zrWSPmDG24/6wo+XYC2oe/vwhiMoncV+3nDHWsuK+Y7u3GDIVI/bTZaC5Y2EYzswiGXO6GfSX/z1nvVEpkLpX2zZLMjBglgmL5KOFb19/LfyStpLHX1Puu5R09VaUkERZzz6yDGrQGNi7Ii3uBphiUEBFGbgYKT4IcflJ8p66AoJvRgsqwkdpdNE4enuAsMKetrSZjh0eR6u754ttML+JR+p3tna0AcGUIPnx8brKk1xXUxe9x2T2r95GzP7eOxJR9CxO2Bua3DuaHaE5hotIB2f61nW5k8MTSR5kvMQf9Iew5DEyfrBkkt3mk2owSd+Ouedhy2hm+RS9QP2p1NfPslCL/6XhHIhATgNQByF9n+/2eQ+sYJzHwtshRnar6hwoe+fzncgUCxcmiFPnZwpCpZGTQO98chDa4UPLC5DK57zilvnK+J6HoCPThQmRWBSpVDNftcfE0VD/Ta X-Bogosity: Ham, tests=bogofilter, spamicity=0.000030, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Jul 30, 2023 at 3:29=E2=80=AFAM Boqun Feng w= rote: > > +// Note: Although these are *safe* functions, but they are only generate= d at > +// `GlobalAlloc` callsites, hence we assume the parameters obey the same > +// `GlobalAlloc` function safety requirements: size and align should for= m a > +// valid layout, and size is greater than 0. Thanks for adding all the `// SAFETY` comments here Boqun! Bj=C3=B6rn, do they look good to you? (since you fixed the issue in the com= piler) On this comment in particular, "generated at `GlobalAlloc` callsites" sounds a bit confusing to me. Would "... called by the compiler with parameters that obey ..." make sense? Or does the sentence refer to the normal case (i.e. when the functions are generated)? Anyway, it is not a big deal. Cheers, Miguel