From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A321C7EE30 for ; Tue, 1 Jul 2025 16:56:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DBA476B00AA; Tue, 1 Jul 2025 12:56:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D44016B00AC; Tue, 1 Jul 2025 12:56:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C32BA6B00AD; Tue, 1 Jul 2025 12:56:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id AC9926B00AA for ; Tue, 1 Jul 2025 12:56:33 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id B257A140580 for ; Tue, 1 Jul 2025 16:56:32 +0000 (UTC) X-FDA: 83616299424.08.36FAC3A Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) by imf12.hostedemail.com (Postfix) with ESMTP id C803440002 for ; Tue, 1 Jul 2025 16:56:30 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=mbMFITqi; spf=pass (imf12.hostedemail.com: domain of miguel.ojeda.sandonis@gmail.com designates 209.85.216.54 as permitted sender) smtp.mailfrom=miguel.ojeda.sandonis@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751388990; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KdOA3lpTZpeFzYmOyWPv0Y1QoQj1TrHSWxUR8VixR+Y=; b=Xby5sUl4hrPaAdPR9dR98OvwLMLzbeO30sJR0dCAYzskS040iviNE9RgtVpwqr6wG2wc64 CJi21KLgd46a7Eptw/+di8mSv2p+WR7y/yF7bKxC55jy00ynZRCD1Xwpm115z/WJGMBlyc EYzGeqp/8xJmJQwglCNQGGFr0EX3FZk= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=mbMFITqi; spf=pass (imf12.hostedemail.com: domain of miguel.ojeda.sandonis@gmail.com designates 209.85.216.54 as permitted sender) smtp.mailfrom=miguel.ojeda.sandonis@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751388990; a=rsa-sha256; cv=none; b=GqxGM+XzR7gqMP7Y8h9u22lKtVb0hNXLcXb5uGdSneimMoIDkconRwI4pJlajElHTZ9/b+ TtLhN9WTmeHCCvBjol1aYKicoJI5cOGHmOc6MhF4etlk9c8unqmES03wH86C93ivaaiIfq PZuhlAECeaz0wjPfplSsJuqn0O3J/DU= Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-313336f8438so1337355a91.0 for ; Tue, 01 Jul 2025 09:56:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751388990; x=1751993790; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=KdOA3lpTZpeFzYmOyWPv0Y1QoQj1TrHSWxUR8VixR+Y=; b=mbMFITqiwxA7sY81IGaaTYfBc6NQda2yzdu3qLnyTnJZ4APDih2UT9a+6sm9M96EDQ fHq6mJLrKrbb4LPUvp8LqkQwX/l1tu4GaKZbGbf1yVqYkB0MeARKu1yZ72oAJjVrYl0z Sw0OEXSOf/K7xTFPCZYPUutvwIRQM343unYWlDKsQMcUFUcgZoVid9T7auzn4KtTvQhG Pix8Aoj+D3AcfissmFrDw7poZbt6G6Pgc2+SGCwQj8bK1lrWQNDKPLaIVJ3mz4e56zwv 5ep73SVngewAl9C+VjdOX+WX1LAwHBbXSkqfPrD3/EEBKaSBFWX7Cbi/o5sgbh8zKqh/ nbtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751388990; x=1751993790; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KdOA3lpTZpeFzYmOyWPv0Y1QoQj1TrHSWxUR8VixR+Y=; b=R5X+Cl8MiBRz7BN+iJDMo8pEFmctPfb5zgxutlbda9aObmvUWcZMSVue4SDtQLvcRJ x7dRNR6QugK+BidQrZlxNXynfBTqKvZhX/qkYEvMtRC9paY+C3hxxb6UtlNaHAiwNwsy MwjdZkF8dQdF/pxPNd8gv5uHUqPLDcP3cR2a1QAVohBL5APIRWInQpttsmrxx5PJBgbC s/z3FKqDVGrMtcvh0Z0AQ6x2MQEYRbjA/XgfKaWRtjcWxNob0o9bfSvao4qpLPoatOqM qxt0pyvRv6/ES372uYbTHl8My7Lm+RciFC9NZ3svyHxjhsuAceuKa9yd5lfpoBfSvGmi tNGw== X-Forwarded-Encrypted: i=1; AJvYcCViiNEdyXHtC4IHs4DLjLqhsPdgoMk9dt8iX56/pEXx/7MoXafr0huCrejLpe01c/1KFbjhFrowZg==@kvack.org X-Gm-Message-State: AOJu0Ywe0mXzJRs7Cz88i1QmvcR1qg0efwZXx8OwWUN8I69plpSs3SWO xsfNPMd1oAR3O4cUzY/d8Z3Yg691+B/Zywc4c5BrfLXusl1mV1KECfC9CJX51UvUNmhRtZ+YISh XZBuY675V5WQPHereekX7+Kji0wgBf2U= X-Gm-Gg: ASbGncs2v5PZtwkYZJc6j4wTwSdWK/TqvXfX8DvtAQIpYXL8UEW1aVuOCe1q9jAfpwz TlPcjIdLF46Y9DzLE7EI5RptcI0uFq8SLEhg26tzR4d9japlNIOtkgSs2pWUzCZOdDZOIHUb7d1 33apnvT/ZNN2DwU0oUVVyaC29YKFjpS834dURHYp6LYkCkY6SBpfW4oQ== X-Google-Smtp-Source: AGHT+IHbBSasC4FVI3lzENfix/hTaP0fBUH0mKDnnKo6XoONgyd/DDi5zgE6Flmur2I1ueeEbVilDJzopPJpcZD480A= X-Received: by 2002:a17:90b:2ecb:b0:311:c5d9:2c8b with SMTP id 98e67ed59e1d1-31951a12a78mr2098121a91.5.1751388989619; Tue, 01 Jul 2025 09:56:29 -0700 (PDT) MIME-Version: 1.0 References: <20250701-xarray-insert-reserve-v1-0-25df2b0d706a@gmail.com> <20250701-xarray-insert-reserve-v1-3-25df2b0d706a@gmail.com> In-Reply-To: <20250701-xarray-insert-reserve-v1-3-25df2b0d706a@gmail.com> From: Miguel Ojeda Date: Tue, 1 Jul 2025 18:56:17 +0200 X-Gm-Features: Ac12FXzVE-UNW0TA4Ex_sS0i850xaRXXSEsIJ4SwFR7UgdwzUfddQlSdSNp4frE Message-ID: Subject: Re: [PATCH 3/3] rust: xarray: add `insert` and `reserve` To: Tamir Duberstein Cc: Andreas Hindborg , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Alice Ryhl , Trevor Gross , Danilo Krummrich , Matthew Wilcox , Andrew Morton , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Daniel Almeida Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: iqn7m5uz4agpiyidcmmzjryhwn1ggtuw X-Rspamd-Queue-Id: C803440002 X-Rspamd-Server: rspam11 X-Rspam-User: X-HE-Tag: 1751388990-541583 X-HE-Meta: U2FsdGVkX1+Takr5OqoZ56SUuv3IQ+GXGRbj24aGcQFOCk1sLxm7Yfo7eAlIqEhY+Xb27qYqhyi7Ls5PNDRvHZ6Epnu3hP15NRVgJvJ9CJ76/udCVflNJ0iW1Mt37HyLJrht66AopOB9vz5v+oZrDsOL8oqd1VrYsjsMMcxXPBHTbtXGMNC4wk2IXYOEndtRb92fI/7gw5zdpCvf6rO1I2uGNui3Ya8aXFhqvr27rS3j6ihj1sQgMnld31qD1ro4kAd5oY8O/pETzPn/XVxL6iHU/vbK/XwvQ23HXFdn/C5kBHq3QCaF2YVneHTkZxLhz3T30tzznXySjb2niCiHQoZ15ve+NfEjjAM6ePBDt5rnAmdtbPTrZ/wh1UilvGxFQ1nLKpjBkpVDI1V8/hzD1SOj7f2PNcASYNRq9lFZ7E+zReAGhPRCW8RhL2YhYLDtilWPsKymzZbbSwUfY/AhtnRDR24s+RgjkYkHq92m90X4GbiYtoohqXYYGRjjYDezij6w4tZfHns+jeHfg9Bni9YYjZASgv0g7QSQ9XDSGJJ4+airwNTnGn46/q7i3tehPTOC6h61qWcMynGW99KpX64IlSdVFu7GriT117NJkEUSjmM0xa/QhglcbEEO9w/ny/u+Ihsl2rCWYqhuGQW0Rb4Fmm6cq00DyO+ZLSGB9xJZCfXRcxUrjZYHyjjky8auG/SmhCNb0RMvracuzFSpZvtX6ye96LSBUnuceezmJojzAIDYjymLMxsNDOPjedM1Pq2ba5cCxs2zAW2uh51YZbQ+CsXINuMHVtpZyuWrwycWdvDApWtGnrKD5FDaRMIyHqxd1js77JCKpWMtONBEY5nOIHCfukjEgXabacajVitdjf+xaGQ4iPf5ShzuzTOF9jdL802/Gzf2KDmJz+fE4k8/mDO6f2FPFz2BObfCiJ6QoFuEYBhcHSYU3s4NEkoCEBX+aWcQzw0e8NbBq7I ZTMW4nlH lK8kW0pYxU2rS9XywsWeHwgn549KXo0VWfpElo/byX/RPaFts2s+Czzg1sWf1gDzwOMeMWgWTrLu8oUsr4ZYjCe78EI1I4gkks63lnLLJuZHtOIhCSHO1lOTxo78GW+Z1qS6e4oUJO2VdxgC1JKDn+8GVg3Kz7/lQAnaMUMdUF48XAusZnLupe1TnVfwdJSL6LvRS8S3pyCyMoJR8lUoMk0/hZQFHa7+yA96sPDqhi1LTKRwzxyUnYSWd1J357+bKIzEqHmPRkSYss0bBtuFmzH5GKVHFnCBGdCY5S2i4qCxjrSHxYSWrbjKudM7feT+UaOKYkRxCDFtS9nLixS1LLCMpGib7yphMnA8i6X2aj7AMdmLKGh24Afe558sabtGAmWItTlgTpx1AavgHrX4QzmBhDkDVrQplQt/8MUEAWaiXVmlyYVcIvufIYYN6haqZP6bdRWV086S7vva8FMYkLb/YG4Q0iXWkoFUGCfKHeDoWGLQRxer4l/09GedPXOMmpAzfQZXpxBruxwLpnwDXrM+BQQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jul 1, 2025 at 6:27=E2=80=AFPM Tamir Duberstein = wrote: > > Add `Guard::{insert,reserve}` and `Guard::{insert,reserve}_limit`, which > are akin to `__xa_{alloc,insert}` in C. Who will be using this? i.e. we need to justify adding code, typically by mentioning the users. By the way, it may help splitting the C parts into its own patch, so that Matthew can focus on that (but maybe you all already discussed this). Also, unit tests are great, thanks for adding those. Can we add examples as well? Maybe on the module-level docs, given the rest are there. > + /// Wrapper around `__xa_alloc`. We try to mention what something does in the title at least, even if it is just copied from the C docs -- you can reference those docs too for more context, e.g. [`__xa_alloc`] to: https://docs.kernel.org/core-api/xarray.html#c.__xa_alloc Cheers, Miguel