From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
To: ming.lei@redhat.com
Cc: axboe@kernel.dk, linux-block@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>,
Linux-MM <linux-mm@kvack.org>, Ted Ts'o <tytso@mit.edu>,
osandov@fb.com, sagi@grimberg.me, dchinner@redhat.com,
kent.overstreet@gmail.com, snitzer@redhat.com,
dm-devel@redhat.com, Al Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, shli@kernel.org,
linux-raid@vger.kernel.org, David Sterba <dsterba@suse.com>,
Linux Btrfs <linux-btrfs@vger.kernel.org>,
darrick.wong@oracle.com, linux-xfs@vger.kernel.org,
gaoxiang25@huawei.com, hch@lst.de,
Ext4 Developers List <linux-ext4@vger.kernel.org>,
colyli@suse.de, linux-bcache@vger.kernel.org,
ooo@electrozaur.com, rpeterso@redhat.com,
cluster-devel@redhat.com
Subject: Re: [PATCH V12 06/20] block: rename bvec helpers
Date: Mon, 26 Nov 2018 09:17:16 +0100 [thread overview]
Message-ID: <CANiq72nSa-=n2WUvmQOieDRtf+gC1wg2YuRvKDniSAtDn8=U8g@mail.gmail.com> (raw)
In-Reply-To: <20181126021720.19471-7-ming.lei@redhat.com>
On Mon, Nov 26, 2018 at 3:20 AM Ming Lei <ming.lei@redhat.com> wrote:
>
> We will support multi-page bvec soon, and have to deal with
> single-page vs multi-page bvec. This patch follows Christoph's
> suggestion to rename all the following helpers:
>
> for_each_bvec
> bvec_iter_bvec
> bvec_iter_len
> bvec_iter_page
> bvec_iter_offset
>
> into:
> for_each_segment
> segment_iter_bvec
> segment_iter_len
> segment_iter_page
> segment_iter_offset
>
> so that these helpers named with 'segment' only deal with single-page
> bvec, or called segment. We will introduce helpers named with 'bvec'
> for multi-page bvec.
>
> bvec_iter_advance() isn't renamed becasue this helper is always operated
> on real bvec even though multi-page bvec is supported.
>
> Suggested-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Ming Lei <ming.lei@redhat.com>
> ---
> .clang-format | 2 +-
Acked-by: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cheers,
Miguel
next prev parent reply other threads:[~2018-11-26 8:17 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-26 2:17 [PATCH V12 00/20] block: support multi-page bvec Ming Lei
2018-11-26 2:17 ` [PATCH V12 01/20] btrfs: remove various bio_offset arguments Ming Lei
2018-11-26 22:28 ` Omar Sandoval
2018-11-26 2:17 ` [PATCH V12 02/20] btrfs: look at bi_size for repair decisions Ming Lei
2018-11-26 22:46 ` Omar Sandoval
2018-11-26 2:17 ` [PATCH V12 03/20] block: remove the "cluster" flag Ming Lei
2018-11-26 22:12 ` Omar Sandoval
2018-11-26 2:17 ` [PATCH V12 04/20] block: don't use bio->bi_vcnt to figure out segment number Ming Lei
2018-11-26 22:14 ` Omar Sandoval
2018-11-26 2:17 ` [PATCH V12 05/20] block: remove bvec_iter_rewind() Ming Lei
2018-11-26 12:53 ` Christoph Hellwig
2018-11-26 22:16 ` Omar Sandoval
2018-11-26 2:17 ` [PATCH V12 06/20] block: rename bvec helpers Ming Lei
2018-11-26 8:17 ` Miguel Ojeda [this message]
2018-11-26 12:54 ` Christoph Hellwig
2018-11-26 22:18 ` Omar Sandoval
2018-11-26 2:17 ` [PATCH V12 07/20] block: introduce multi-page " Ming Lei
2018-11-26 12:55 ` Christoph Hellwig
2018-11-26 2:17 ` [PATCH V12 08/20] block: introduce bio_for_each_bvec() and rq_for_each_bvec() Ming Lei
2018-11-26 12:55 ` Christoph Hellwig
2018-11-26 2:17 ` [PATCH V12 09/20] block: use bio_for_each_bvec() to compute multi-page bvec count Ming Lei
2018-11-26 13:11 ` Christoph Hellwig
2018-11-26 22:37 ` Omar Sandoval
2018-11-26 2:17 ` [PATCH V12 10/20] block: use bio_for_each_bvec() to map sg Ming Lei
2018-11-26 13:11 ` Christoph Hellwig
2018-11-26 2:17 ` [PATCH V12 11/20] block: introduce bvec_last_segment() Ming Lei
2018-11-26 2:17 ` [PATCH V12 12/20] fs/buffer.c: use bvec iterator to truncate the bio Ming Lei
2018-11-26 2:17 ` [PATCH V12 13/20] block: loop: pass multi-page bvec to iov_iter Ming Lei
2018-11-26 22:39 ` Omar Sandoval
2018-11-26 2:17 ` [PATCH V12 14/20] bcache: avoid to use bio_for_each_segment_all() in bch_bio_alloc_pages() Ming Lei
2018-11-26 22:40 ` Omar Sandoval
2018-11-26 2:17 ` [PATCH V12 15/20] block: allow bio_for_each_segment_all() to iterate over multi-page bvec Ming Lei
2018-11-26 22:42 ` Omar Sandoval
2018-11-26 2:17 ` [PATCH V12 16/20] block: enable multipage bvecs Ming Lei
2018-11-26 12:58 ` Christoph Hellwig
2018-11-27 2:25 ` Ming Lei
2018-11-26 22:56 ` Omar Sandoval
2018-11-26 2:17 ` [PATCH V12 17/20] block: always define BIO_MAX_PAGES as 256 Ming Lei
2018-11-26 22:44 ` Omar Sandoval
2018-11-26 2:17 ` [PATCH V12 18/20] block: document usage of bio iterator helpers Ming Lei
2018-11-26 12:59 ` Christoph Hellwig
2018-11-26 22:43 ` Omar Sandoval
2018-11-26 2:17 ` [PATCH V12 19/20] block: kill QUEUE_FLAG_NO_SG_MERGE Ming Lei
2018-11-26 2:17 ` [PATCH V12 20/20] block: kill BLK_MQ_F_SG_MERGE Ming Lei
2018-11-28 13:44 ` [PATCH V12 00/20] block: support multi-page bvec Jens Axboe
2018-11-29 1:30 ` Ming Lei
2018-11-29 2:20 ` Jens Axboe
2018-11-29 3:30 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANiq72nSa-=n2WUvmQOieDRtf+gC1wg2YuRvKDniSAtDn8=U8g@mail.gmail.com' \
--to=miguel.ojeda.sandonis@gmail.com \
--cc=axboe@kernel.dk \
--cc=cluster-devel@redhat.com \
--cc=colyli@suse.de \
--cc=darrick.wong@oracle.com \
--cc=dchinner@redhat.com \
--cc=dm-devel@redhat.com \
--cc=dsterba@suse.com \
--cc=gaoxiang25@huawei.com \
--cc=hch@lst.de \
--cc=kent.overstreet@gmail.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-raid@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=ooo@electrozaur.com \
--cc=osandov@fb.com \
--cc=rpeterso@redhat.com \
--cc=sagi@grimberg.me \
--cc=shli@kernel.org \
--cc=snitzer@redhat.com \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox