From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CF13CF2591 for ; Mon, 14 Oct 2024 10:47:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9204C6B0082; Mon, 14 Oct 2024 06:47:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8D00F6B0083; Mon, 14 Oct 2024 06:47:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 798116B0085; Mon, 14 Oct 2024 06:47:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 5D3B56B0082 for ; Mon, 14 Oct 2024 06:47:00 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E75B3120D6C for ; Mon, 14 Oct 2024 10:46:52 +0000 (UTC) X-FDA: 82671879990.25.11B205C Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) by imf10.hostedemail.com (Postfix) with ESMTP id 20C5DC001C for ; Mon, 14 Oct 2024 10:46:54 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=fy7GLA2Q; spf=pass (imf10.hostedemail.com: domain of miguel.ojeda.sandonis@gmail.com designates 209.85.216.44 as permitted sender) smtp.mailfrom=miguel.ojeda.sandonis@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728902676; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=46HkK5QbXKink9cFKdDs28XgpJ3tA0weU6y+j41fq5Q=; b=vKUQoglJK9rucoYaM3V11vnUfKtrMzeyDTnEt98a/ugbaBx7TL9jweOd0gV3zuAaSuYUMM TPhA6kwGlenMLf2g+pkrj/MOD3NStJ1EUrjSeKOnSz/JQpeuIb2Fb2PbV2QT/w/nsNOils vPfZFUECCUJ8afRMAFh/vq3OYh3W8RI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728902676; a=rsa-sha256; cv=none; b=kt+12wMEtS+ELkOtXPAA6ZtbLLjFUkKDGxk3Rn9ZkeYSAKKKZDzcFEgg++2LZPCti2cB9M KLGrSZHM5rLDrsnueTof5CZrtIw6qM0WYTPuWbUnP2cg5O5TtHZID6SpSNyTTpnu5dPJij aSB3blxUPTvIkrwzi3aZZOlu1rPjfWc= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=fy7GLA2Q; spf=pass (imf10.hostedemail.com: domain of miguel.ojeda.sandonis@gmail.com designates 209.85.216.44 as permitted sender) smtp.mailfrom=miguel.ojeda.sandonis@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-2e2ee0a47fdso658162a91.2 for ; Mon, 14 Oct 2024 03:46:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728902816; x=1729507616; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=46HkK5QbXKink9cFKdDs28XgpJ3tA0weU6y+j41fq5Q=; b=fy7GLA2Qmb/kOwUMEWbsYp9pirmX/tFeqUimzMTx5r54+YdDUbRqRen0k5RffhfTEx 2u0N2d18tUV/jgbdd4X+lf5Zpj2K94GCIZlwHmDs6PCu1Ggwyuudyi0UQ2/cs8nBnO/X ky5f2Q6x/2Eki5J53RKGz9NjwBxnkLIrCaEq2WYXovnYJTmGdBSRvwbCuB6G1kotJf11 LjurGx9rtkQeuZxzBVf/xwE0ab9+cd7uXTwaSqih9rnSF9VgZgp9asA8x8cuEJOuP/aM 4Xq0b+5MGY8IytKVh78g/0vgb5JjBzjeoEzoyZORwky+fkke5cWCs37S/bxmj8YwzCOs v9hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728902816; x=1729507616; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=46HkK5QbXKink9cFKdDs28XgpJ3tA0weU6y+j41fq5Q=; b=jKntvTA5JZIT7Gd3sYV9LfLtzA/auol6OqUYmlx5nTuC3Kr2SJsVPpXyOTi3T3SoR1 nzGOFY8sdBo1AJKTbvtP6IyIl2XBKiGL0Kkm06+XjcdIThJnMwbwJ2I93ul48EHVW0AZ yinOIoqqRR1EQNwzCqjtbviuoSbllnBHD2YfY4Kx66LSh14O4n/ZT/FYj3t7CQvzw6KU B7cMcN3Sl/psZxnjYdRiJMS+h2DyV02KKb3Hz/ADxOItmHCs2p8QBXXbUvdx7Kf7DjY+ 8UglJsOpBDR8jNgv6Uch9KfMHQT6fV+LeYzJy+zDK30nHH3l42CQv8E1CrC19eEy3Itg keEg== X-Forwarded-Encrypted: i=1; AJvYcCX+xK2ifQdHyeVZ8PdoRrIZDyVCvbqVJdnC7g7U0bAWjFmof7+AOpzFqutVKy400SdWQ3M+leDJtw==@kvack.org X-Gm-Message-State: AOJu0YzJKF4gZCXex3jJnNFauaCjooUJA1Wo8sdr3WukysmZrZZGgyyB lO5CMhQdN5RY3D42Qn85Alho1Ehq1tdvCmKISf8qWQqNcKamcvE/QqtfB3bMyqYavWavLbhMZ2Y 8K64sn41dgcPItRBW15m+PzoK+uo= X-Google-Smtp-Source: AGHT+IEB/3sBumZ4RFHSZgvSjlHuw3kP78qj5138y8lCPsRQdrBstDKHwCAH9lqgwnJ0Wj1xRlNTTtwIe2wau3XXdyk= X-Received: by 2002:a17:90a:db41:b0:2e2:d881:5936 with SMTP id 98e67ed59e1d1-2e2f0d96389mr5719048a91.7.1728902816424; Mon, 14 Oct 2024 03:46:56 -0700 (PDT) MIME-Version: 1.0 References: <20241014-vma-v7-0-01e32f861195@google.com> <20241014-vma-v7-1-01e32f861195@google.com> In-Reply-To: <20241014-vma-v7-1-01e32f861195@google.com> From: Miguel Ojeda Date: Mon, 14 Oct 2024 12:46:44 +0200 Message-ID: Subject: Re: [PATCH v7 1/2] rust: mm: add abstractions for mm_struct and vm_area_struct To: Alice Ryhl Cc: Miguel Ojeda , Matthew Wilcox , Lorenzo Stoakes , Vlastimil Babka , John Hubbard , "Liam R. Howlett" , Andrew Morton , Greg Kroah-Hartman , Arnd Bergmann , Alex Gaynor , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , linux-kernel@vger.kernel.org, linux-mm@kvack.org, rust-for-linux@vger.kernel.org, Andreas Hindborg , Wedson Almeida Filho Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 20C5DC001C X-Stat-Signature: hgt1iuz51m6gdp4cbfunxggoosdcz5y3 X-HE-Tag: 1728902814-361524 X-HE-Meta: U2FsdGVkX1/B9YbgU1oNua6wvVzzCfJscYUAz95rjq+4ch8zPj4bI1/b5s4ZVNGnj5VfWQlQb/HTilWz/YDHhlpgMJBHzpGnGjneH8xnlf++a/JB9LEcGBGwzqXZeAyg5StT33c7PfTn1XKgJQilBM63LtswlLeSemVP32ixujghXDZCR/bZjkcY7UkDSyrYXnRfaO1bdLLOYJEvTb8ecnBqs3YYjUrm6c7QTKbJfuMbt88vAnK1HP53iZc+VX11SnLqDWmJFzZaIkpwWVgRDAKc7TsaFvoZ2YvEOBjN35X01iMDGtqAm38kZNMb3dPBXBzTTjlGuDYzLGqzXcPrjYsDImbk9rU9/p7ywYWoJihzBWiJnK2ifSl/YuIBjpr8JgpmmbUpSQ6kIkssa4TPAMitP6aB9Wg6ubAUi3U5r7Fd1nPAlXeuPn349XYPX6tYNnDRIz6K9lbNXIeP5v874lYIVxVjyqfwZqwtVLWhRRTzbJVRCQ5iBkIF18Tqiasb9symhaCGvOgCOKSMUxjgIkLPZIAN/EWaG70xaM04Lse30UuE4cCb46CGF59JELsisZ4vnnXymu+PpHcTAR3NPQJpScDostrXgpZ+jeMR2qZhqZ+uLZyI0eRdexfRSgA2v3zp4DKniWiPRzIUH0HPM1D1pKHoqNrASdfX/s8WbwzlK6G6s8+edIGA/uV7CoD1VESzqQEPRV/DCF6H1DdBtkgtROooWOyb4+CSggZIiYbiBcEMIJb8GjNcQW6RYWnw8ISu3RNQO1vgTVb9Hu2mPenuLR3CdKz+4JiTat7Bw9CYhTbGNwqADYVuwqzVvzKJbUFv8cBTlICwk9e6q+0fJo8Mc44ArCHqElC0XoMeVGHdMcZ1z0rmErIOBqyvpu1rFhy2dlvUvaJGe4Mk6It3dgLb93XlHsSfbxcH5HIMJqo1BsOn96UryXG2mkYH2GptO1nkTmpgrgwjrFUDl0W 9J4W5Wlz PnLAresQUkJCFuUr6NGEkzxwDqKbelO8sRXQn5UnVPJzVxHjCwc2nKSdZzbYCI/5f6sG6PqaCWlWju1LilKq4EEAP3xDSR9qElI6jc6cz8d621l8ixcqJ6HZhWH8B1nh/KPwGsBV5cbA/DX4Om1OsZD9OLqiQvvkbRcoXJxILCsaNjcd9dK1BreQLwpd8ZPhGwXl7z7iT4/cujItCQLjxtRLqCArsOkjVQZpOiLQmN6ww1bDcCzYKSTcOtVwOHVPD6+D8+phzdIUGI93JySzm+gcHLFCtQk3sfUjuGf0RmHUM92wc1MXbfDBo+YHuIFLmNuQCGanL9H5yUeVmGoSwNmAIspumwKFZqeX+757AuIE7XLFXSgmIRfFnLmRc+yvq4Nij9tC5thsnxI8Uffhseni2FckKkovdttskSODTo1HbnvJxbqEn2+mCgJUpR1QwFt7TzxPynKFidFWHsCCPZBYhH9JTAjnqxqfW4cUeLOpLBXc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000581, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Oct 14, 2024 at 11:30=E2=80=AFAM Alice Ryhl = wrote: > > +/// #[repr(transparent)] Line in docs. > +/// #[repr(transparent)] > +#[repr(transparent)] Ditto here, but in this case also outside the docs. Some trivial nits I noticed below since I am here. > + /// during the lifetime 'a. Backticks (some other instances on lifetimes too). > + /// Calls `mmget_not_zero` and returns a handle if it succeeds. I would add `bindings::` since otherwise it may be confusing to say the C name without qualifying, since this function is also called the same way. > + // SAFETY: The pointer is valid since self is a reference. `self`. > +// Make all VmAreaRef methods available on VmAreaMut. > +// Make all VmAreaMut methods available on VmAreaNew. Backticks. > + /// Can contain "struct page" and pure PFN pages. > + /// MADV_HUGEPAGE marked this vma. These are copied from C, so it is fine, but we may want to take the chance to format them. Cheers, Miguel